From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: virtio-dev@lists.oasis-open.org, cohuck@redhat.com,
sgarzare@redhat.com, pasic@linux.ibm.com,
virtio-comment@lists.oasis-open.org, shahafs@nvidia.com
Subject: [virtio-comment] Re: [PATCH v12 01/10] content: Add vq index text
Date: Wed, 5 Apr 2023 01:26:12 -0400 [thread overview]
Message-ID: <20230405012352-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230405010657.612529-2-parav@nvidia.com>
On Wed, Apr 05, 2023 at 04:06:48AM +0300, Parav Pandit wrote:
> Introduce vq index and its range so that subsequent patches can refer
> to it.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> ---
> changelog:
> v11->v12:
> - renamed 'number' to 'index'
> v9->v10:
> - added braces around vq number wording
> - added vqn as another term for vq number
> v8->v9:
> - added inclusive when describing the vq number range
> - skipped comment to put virtqueue number wording first because we
> prefer to use shorter vq number as much as possible
> v5->v6:
> - moved description close to introduction, it was in middle of
> queue data transfer description
> v2->v3:
> - new patch
> ---
> content.tex | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/content.tex b/content.tex
> index cff548a..e64115c 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -298,6 +298,10 @@ \section{Virtqueues}\label{sec:Basic Facilities of a Virtio Device / Virtqueues}
> virtqueues\footnote{For example, the simplest network device has one virtqueue for
> transmit and one for receive.}.
>
> +Each virtqueue is identified by a vq index (also referred
> +to as a virtqueue index); vq index range is from 0 to 65535
> +inclusive.
> +
It's the other way around: start with full name, then abbreviation.
Each virtqueue is identified by virtqueue
index (sometimes abbreviated to vq index). A virtqueue index range ...
are there more abbreviations we want to mention here? vq_idx?
> Driver makes requests available to device by adding
> an available buffer to the queue, i.e., adding a buffer
> describing the request to a virtqueue, and optionally triggering
> --
> 2.26.2
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: virtio-dev@lists.oasis-open.org, cohuck@redhat.com,
sgarzare@redhat.com, pasic@linux.ibm.com,
virtio-comment@lists.oasis-open.org, shahafs@nvidia.com
Subject: [virtio-dev] Re: [PATCH v12 01/10] content: Add vq index text
Date: Wed, 5 Apr 2023 01:26:12 -0400 [thread overview]
Message-ID: <20230405012352-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230405010657.612529-2-parav@nvidia.com>
On Wed, Apr 05, 2023 at 04:06:48AM +0300, Parav Pandit wrote:
> Introduce vq index and its range so that subsequent patches can refer
> to it.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> ---
> changelog:
> v11->v12:
> - renamed 'number' to 'index'
> v9->v10:
> - added braces around vq number wording
> - added vqn as another term for vq number
> v8->v9:
> - added inclusive when describing the vq number range
> - skipped comment to put virtqueue number wording first because we
> prefer to use shorter vq number as much as possible
> v5->v6:
> - moved description close to introduction, it was in middle of
> queue data transfer description
> v2->v3:
> - new patch
> ---
> content.tex | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/content.tex b/content.tex
> index cff548a..e64115c 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -298,6 +298,10 @@ \section{Virtqueues}\label{sec:Basic Facilities of a Virtio Device / Virtqueues}
> virtqueues\footnote{For example, the simplest network device has one virtqueue for
> transmit and one for receive.}.
>
> +Each virtqueue is identified by a vq index (also referred
> +to as a virtqueue index); vq index range is from 0 to 65535
> +inclusive.
> +
It's the other way around: start with full name, then abbreviation.
Each virtqueue is identified by virtqueue
index (sometimes abbreviated to vq index). A virtqueue index range ...
are there more abbreviations we want to mention here? vq_idx?
> Driver makes requests available to device by adding
> an available buffer to the queue, i.e., adding a buffer
> describing the request to a virtqueue, and optionally triggering
> --
> 2.26.2
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-04-05 5:26 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 1:06 [virtio-comment] [PATCH v12 00/10] Rename queue number to queue index Parav Pandit
2023-04-05 1:06 ` [virtio-dev] " Parav Pandit
2023-04-05 1:06 ` [virtio-comment] [PATCH v12 01/10] content: Add vq index text Parav Pandit
2023-04-05 1:06 ` [virtio-dev] " Parav Pandit
2023-04-05 5:26 ` Michael S. Tsirkin [this message]
2023-04-05 5:26 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:00 ` [virtio-comment] " Parav Pandit
2023-04-05 13:00 ` [virtio-dev] " Parav Pandit
2023-04-05 9:18 ` [virtio-comment] " Michael S. Tsirkin
2023-04-05 9:18 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:03 ` [virtio-comment] " Parav Pandit
2023-04-05 13:03 ` [virtio-dev] " Parav Pandit
2023-04-07 11:30 ` [virtio-comment] " Michael S. Tsirkin
2023-04-07 11:30 ` Michael S. Tsirkin
2023-04-07 15:34 ` [virtio-comment] " Parav Pandit
2023-04-07 15:34 ` Parav Pandit
2023-04-07 15:54 ` [virtio-comment] " Michael S. Tsirkin
2023-04-07 15:54 ` Michael S. Tsirkin
2023-04-05 1:06 ` [virtio-comment] [PATCH v12 02/10] content.tex Replace virtqueue number with index Parav Pandit
2023-04-05 1:06 ` [virtio-dev] " Parav Pandit
2023-04-05 9:46 ` [virtio-comment] " Cornelia Huck
2023-04-05 9:46 ` [virtio-dev] " Cornelia Huck
2023-04-05 1:06 ` [virtio-comment] [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names Parav Pandit
2023-04-05 1:06 ` [virtio-dev] " Parav Pandit
2023-04-05 5:22 ` [virtio-comment] " Michael S. Tsirkin
2023-04-05 5:22 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:20 ` [virtio-comment] " Parav Pandit
2023-04-05 13:20 ` [virtio-dev] " Parav Pandit
2023-04-10 13:25 ` [virtio-comment] " Michael S. Tsirkin
2023-04-10 13:25 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 5:30 ` [virtio-comment] " Michael S. Tsirkin
2023-04-05 5:30 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 9:57 ` [virtio-comment] " Cornelia Huck
2023-04-05 9:57 ` [virtio-dev] " Cornelia Huck
2023-04-05 13:21 ` [virtio-comment] " Parav Pandit
2023-04-05 13:21 ` [virtio-dev] " Parav Pandit
2023-04-05 15:27 ` [virtio-comment] " Halil Pasic
2023-04-05 15:27 ` Halil Pasic
2023-04-05 15:58 ` [virtio-comment] " Parav Pandit
2023-04-05 15:58 ` Parav Pandit
2023-04-07 11:43 ` [virtio-comment] " Michael S. Tsirkin
2023-04-07 11:43 ` [virtio-dev] " Michael S. Tsirkin
2023-04-11 8:56 ` Cornelia Huck
2023-04-11 8:56 ` [virtio-dev] " Cornelia Huck
2023-04-11 13:35 ` Parav Pandit
2023-04-11 13:35 ` [virtio-dev] " Parav Pandit
2023-04-17 3:18 ` Halil Pasic
2023-04-17 3:18 ` [virtio-dev] " Halil Pasic
2023-04-17 7:04 ` Michael S. Tsirkin
2023-04-17 7:04 ` [virtio-dev] " Michael S. Tsirkin
2023-04-17 8:47 ` [virtio-comment] Participation (was: Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names) Cornelia Huck
2023-04-17 8:47 ` [virtio-dev] " Cornelia Huck
2023-04-17 11:45 ` [virtio-comment] " Michael S. Tsirkin
2023-04-17 11:45 ` [virtio-dev] " Michael S. Tsirkin
2023-04-17 16:13 ` [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names Halil Pasic
2023-04-17 16:13 ` Halil Pasic
2023-04-07 11:44 ` [virtio-comment] " Michael S. Tsirkin
2023-04-07 11:44 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 1:06 ` [virtio-comment] [PATCH v12 04/10] transport-pci: Avoid first vq index reference Parav Pandit
2023-04-05 1:06 ` [virtio-dev] " Parav Pandit
2023-04-05 1:06 ` [virtio-comment] [PATCH v12 05/10] transport-mmio: Rename QueueNum register Parav Pandit
2023-04-05 1:06 ` [virtio-dev] " Parav Pandit
2023-04-05 1:06 ` [virtio-comment] [PATCH v12 06/10] transport-mmio: Avoid referring to zero based index Parav Pandit
2023-04-05 1:06 ` [virtio-dev] " Parav Pandit
2023-04-05 1:06 ` [virtio-comment] [PATCH v12 07/10] transport-ccw: Rename queue depth/size to other transports Parav Pandit
2023-04-05 1:06 ` [virtio-dev] " Parav Pandit
2023-04-05 1:06 ` [virtio-comment] [PATCH v12 08/10] transport-ccw: Refer to the vq by its index Parav Pandit
2023-04-05 1:06 ` [virtio-dev] " Parav Pandit
2023-04-05 1:06 ` [virtio-comment] [PATCH v12 09/10] virtio-net: Avoid duplicate receive queue example Parav Pandit
2023-04-05 1:06 ` [virtio-dev] " Parav Pandit
2023-04-05 1:06 ` [virtio-comment] [PATCH v12 10/10] virtio-net: Describe RSS using rss rq id Parav Pandit
2023-04-05 1:06 ` [virtio-dev] " Parav Pandit
2023-04-05 9:17 ` [virtio-comment] " Michael S. Tsirkin
2023-04-05 9:17 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:02 ` [virtio-comment] " Parav Pandit
2023-04-05 13:02 ` [virtio-dev] " Parav Pandit
2023-04-07 11:32 ` [virtio-comment] " Michael S. Tsirkin
2023-04-07 11:32 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 5:32 ` [virtio-comment] Re: [PATCH v12 00/10] Rename queue number to queue index Michael S. Tsirkin
2023-04-05 5:32 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:11 ` [virtio-comment] " Parav Pandit
2023-04-05 13:11 ` [virtio-dev] " Parav Pandit
2023-04-05 9:20 ` [virtio-comment] " Michael S. Tsirkin
2023-04-05 9:20 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:05 ` [virtio-comment] " Parav Pandit
2023-04-05 13:05 ` [virtio-dev] " Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405012352-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=parav@nvidia.com \
--cc=pasic@linux.ibm.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.