* [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Mario Limonciello, Shashank Sharma, Michal Simek, amd-gfx,
Jonathan Hunter, Luben Tuikov, Danilo Krummrich, Ben Skeggs,
linux-media, Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
Maxime Ripard, linaro-mm-sig, linux-tegra, NXP Linux Team,
linux-arm-kernel, Hyun Kwon, Thomas Zimmermann, Pan, Xinhui,
linux-kernel, Jerome Glisse, Alex Deucher, Gourav Samaiya,
Shawn Guo, Christian König, Hawking Zhang
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Danilo Krummrich <dakr@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Gourav Samaiya <gsamaiya@nvidia.com>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: Hyun Kwon <hyun.kwon@xilinx.com>
Cc: Jerome Glisse <glisse@freedesktop.org>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-media@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Cc: Luben Tuikov <luben.tuikov@amd.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: "Maíra Canal" <mairacanal@riseup.net>
Cc: Mario Limonciello <mario.limonciello@amd.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Mikko Perttunen <mperttunen@nvidia.com>
Cc: nouveau@lists.freedesktop.org
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shashank Sharma <shashank.sharma@amd.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Stanley Yang <Stanley.Yang@amd.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Lee Jones (20):
drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp
drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc'
drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses
drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses
drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse
drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses
drm/radeon/radeon_ttm: Remove unused variable 'rbo' from
radeon_bo_move()
drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function
headers
drm/tests/drm_kunit_helpers: Place correct function name in the
comment header
drm/scheduler/sched_main: Provide short description of missing param
'result'
drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param
'doorbell_index'
drm/amd/amdgpu/amdgpu_device: Provide suitable description for param
'xcc_id'
drm/tests/drm_kunit_helpers: Correct possible double-entry typo in
'ddrm_kunit_helper_acquire_ctx_alloc'
drm/imx/ipuv3/imx-ldb: Increase buffer size to ensure all possible
values can be stored
drm/tegra/hub: Increase buffer size to ensure all possible values can
be stored
drm/drm_connector: Provide short description of param
'supported_colorspaces'
drm/amd/amdgpu/amdgpu_ras: Increase buffer size to account for all
possible values
drm/drm_gpuva_mgr: Remove set but unused variable 'prev'
drm/amd/amdgpu/amdgpu_sdma: Increase buffer size to account for all
possible values
drm/amd/amdgpu/imu_v11_0: Increase buffer size to ensure all possible
values can be stored
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
.../gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 2 +-
drivers/gpu/drm/amd/amdgpu/imu_v11_0.c | 2 +-
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 8 +-
drivers/gpu/drm/drm_connector.c | 2 +
drivers/gpu/drm/drm_gpuva_mgr.c | 10 +-
drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 2 +-
drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 +-
.../gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +-
.../gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +-
.../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++---------
.../gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c | 4 +-
drivers/gpu/drm/radeon/radeon_ttm.c | 2 -
drivers/gpu/drm/scheduler/sched_main.c | 1 +
drivers/gpu/drm/tegra/hub.c | 2 +-
drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +-
drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +-
19 files changed, 96 insertions(+), 97 deletions(-)
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply [flat|nested] 159+ messages in thread* [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Alex Deucher, amd-gfx, Ben Skeggs,
Christian König, Daniel Vetter, Danilo Krummrich,
David Airlie, dri-devel, Fabio Estevam, Gourav Samaiya,
Hawking Zhang, Hyun Kwon, Jerome Glisse, Jonathan Hunter,
Karol Herbst, Laurent Pinchart, linaro-mm-sig, linux-arm-kernel,
linux-media, linux-tegra, Luben Tuikov, Lyude Paul,
Maarten Lankhorst, Maíra Canal, Mario Limonciello,
Maxime Ripard, Michal Simek, Mikko Perttunen, nouveau,
NXP Linux Team, Pan, Xinhui, Pengutronix Kernel Team,
Philipp Zabel, Sascha Hauer, Shashank Sharma, Shawn Guo,
Stanley Yang, Sumit Semwal, Thierry Reding, Thomas Zimmermann
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Danilo Krummrich <dakr@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Gourav Samaiya <gsamaiya@nvidia.com>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: Hyun Kwon <hyun.kwon@xilinx.com>
Cc: Jerome Glisse <glisse@freedesktop.org>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-media@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Cc: Luben Tuikov <luben.tuikov@amd.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: "Maíra Canal" <mairacanal@riseup.net>
Cc: Mario Limonciello <mario.limonciello@amd.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Mikko Perttunen <mperttunen@nvidia.com>
Cc: nouveau@lists.freedesktop.org
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shashank Sharma <shashank.sharma@amd.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Stanley Yang <Stanley.Yang@amd.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Lee Jones (20):
drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp
drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc'
drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses
drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses
drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse
drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses
drm/radeon/radeon_ttm: Remove unused variable 'rbo' from
radeon_bo_move()
drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function
headers
drm/tests/drm_kunit_helpers: Place correct function name in the
comment header
drm/scheduler/sched_main: Provide short description of missing param
'result'
drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param
'doorbell_index'
drm/amd/amdgpu/amdgpu_device: Provide suitable description for param
'xcc_id'
drm/tests/drm_kunit_helpers: Correct possible double-entry typo in
'ddrm_kunit_helper_acquire_ctx_alloc'
drm/imx/ipuv3/imx-ldb: Increase buffer size to ensure all possible
values can be stored
drm/tegra/hub: Increase buffer size to ensure all possible values can
be stored
drm/drm_connector: Provide short description of param
'supported_colorspaces'
drm/amd/amdgpu/amdgpu_ras: Increase buffer size to account for all
possible values
drm/drm_gpuva_mgr: Remove set but unused variable 'prev'
drm/amd/amdgpu/amdgpu_sdma: Increase buffer size to account for all
possible values
drm/amd/amdgpu/imu_v11_0: Increase buffer size to ensure all possible
values can be stored
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
.../gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 2 +-
drivers/gpu/drm/amd/amdgpu/imu_v11_0.c | 2 +-
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 8 +-
drivers/gpu/drm/drm_connector.c | 2 +
drivers/gpu/drm/drm_gpuva_mgr.c | 10 +-
drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 2 +-
drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 +-
.../gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +-
.../gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +-
.../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++---------
.../gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c | 4 +-
drivers/gpu/drm/radeon/radeon_ttm.c | 2 -
drivers/gpu/drm/scheduler/sched_main.c | 1 +
drivers/gpu/drm/tegra/hub.c | 2 +-
drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +-
drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +-
19 files changed, 96 insertions(+), 97 deletions(-)
--
2.42.0.rc1.204.g551eb34607-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 159+ messages in thread* [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: nouveau, dri-devel, Mikko Perttunen, Maíra Canal,
Thierry Reding, Laurent Pinchart, Fabio Estevam, Sumit Semwal,
Mario Limonciello, Shashank Sharma, Michal Simek, amd-gfx,
Luben Tuikov, Ben Skeggs, Philipp Zabel, linux-media,
Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
Maarten Lankhorst, Maxime Ripard, linaro-mm-sig, linux-tegra,
NXP Linux Team, linux-arm-kernel, Hyun Kwon, Pan, Xinhui,
linux-kernel, Jerome Glisse, Daniel Vetter, Alex Deucher,
Gourav Samaiya, Shawn Guo, Christian König, Hawking Zhang
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Danilo Krummrich <dakr@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Gourav Samaiya <gsamaiya@nvidia.com>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: Hyun Kwon <hyun.kwon@xilinx.com>
Cc: Jerome Glisse <glisse@freedesktop.org>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-media@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Cc: Luben Tuikov <luben.tuikov@amd.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: "Maíra Canal" <mairacanal@riseup.net>
Cc: Mario Limonciello <mario.limonciello@amd.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Mikko Perttunen <mperttunen@nvidia.com>
Cc: nouveau@lists.freedesktop.org
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shashank Sharma <shashank.sharma@amd.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Stanley Yang <Stanley.Yang@amd.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Lee Jones (20):
drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp
drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc'
drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses
drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses
drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse
drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses
drm/radeon/radeon_ttm: Remove unused variable 'rbo' from
radeon_bo_move()
drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function
headers
drm/tests/drm_kunit_helpers: Place correct function name in the
comment header
drm/scheduler/sched_main: Provide short description of missing param
'result'
drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param
'doorbell_index'
drm/amd/amdgpu/amdgpu_device: Provide suitable description for param
'xcc_id'
drm/tests/drm_kunit_helpers: Correct possible double-entry typo in
'ddrm_kunit_helper_acquire_ctx_alloc'
drm/imx/ipuv3/imx-ldb: Increase buffer size to ensure all possible
values can be stored
drm/tegra/hub: Increase buffer size to ensure all possible values can
be stored
drm/drm_connector: Provide short description of param
'supported_colorspaces'
drm/amd/amdgpu/amdgpu_ras: Increase buffer size to account for all
possible values
drm/drm_gpuva_mgr: Remove set but unused variable 'prev'
drm/amd/amdgpu/amdgpu_sdma: Increase buffer size to account for all
possible values
drm/amd/amdgpu/imu_v11_0: Increase buffer size to ensure all possible
values can be stored
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
.../gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 2 +-
drivers/gpu/drm/amd/amdgpu/imu_v11_0.c | 2 +-
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 8 +-
drivers/gpu/drm/drm_connector.c | 2 +
drivers/gpu/drm/drm_gpuva_mgr.c | 10 +-
drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 2 +-
drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 +-
.../gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +-
.../gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +-
.../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++---------
.../gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c | 4 +-
drivers/gpu/drm/radeon/radeon_ttm.c | 2 -
drivers/gpu/drm/scheduler/sched_main.c | 1 +
drivers/gpu/drm/tegra/hub.c | 2 +-
drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +-
drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +-
19 files changed, 96 insertions(+), 97 deletions(-)
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply [flat|nested] 159+ messages in thread* [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Alex Deucher, amd-gfx, Ben Skeggs,
Christian König, Daniel Vetter, Danilo Krummrich,
David Airlie, dri-devel, Fabio Estevam, Gourav Samaiya,
Hawking Zhang, Hyun Kwon, Jerome Glisse, Jonathan Hunter,
Karol Herbst, Laurent Pinchart, linaro-mm-sig, linux-arm-kernel,
linux-media, linux-tegra, Luben Tuikov, Lyude Paul,
Maarten Lankhorst, Maíra Canal, Mario Limonciello,
Maxime Ripard, Michal Simek, Mikko Perttunen, nouveau,
NXP Linux Team, Pan, Xinhui, Pengutronix Kernel Team,
Philipp Zabel, Sascha Hauer, Shashank Sharma, Shawn Guo,
Stanley Yang, Sumit Semwal, Thierry Reding, Thomas Zimmermann
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Danilo Krummrich <dakr@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Gourav Samaiya <gsamaiya@nvidia.com>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: Hyun Kwon <hyun.kwon@xilinx.com>
Cc: Jerome Glisse <glisse@freedesktop.org>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-media@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Cc: Luben Tuikov <luben.tuikov@amd.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: "Maíra Canal" <mairacanal@riseup.net>
Cc: Mario Limonciello <mario.limonciello@amd.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Mikko Perttunen <mperttunen@nvidia.com>
Cc: nouveau@lists.freedesktop.org
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shashank Sharma <shashank.sharma@amd.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Stanley Yang <Stanley.Yang@amd.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Lee Jones (20):
drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp
drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc'
drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses
drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses
drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse
drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses
drm/radeon/radeon_ttm: Remove unused variable 'rbo' from
radeon_bo_move()
drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function
headers
drm/tests/drm_kunit_helpers: Place correct function name in the
comment header
drm/scheduler/sched_main: Provide short description of missing param
'result'
drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param
'doorbell_index'
drm/amd/amdgpu/amdgpu_device: Provide suitable description for param
'xcc_id'
drm/tests/drm_kunit_helpers: Correct possible double-entry typo in
'ddrm_kunit_helper_acquire_ctx_alloc'
drm/imx/ipuv3/imx-ldb: Increase buffer size to ensure all possible
values can be stored
drm/tegra/hub: Increase buffer size to ensure all possible values can
be stored
drm/drm_connector: Provide short description of param
'supported_colorspaces'
drm/amd/amdgpu/amdgpu_ras: Increase buffer size to account for all
possible values
drm/drm_gpuva_mgr: Remove set but unused variable 'prev'
drm/amd/amdgpu/amdgpu_sdma: Increase buffer size to account for all
possible values
drm/amd/amdgpu/imu_v11_0: Increase buffer size to ensure all possible
values can be stored
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
.../gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 2 +-
drivers/gpu/drm/amd/amdgpu/imu_v11_0.c | 2 +-
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 8 +-
drivers/gpu/drm/drm_connector.c | 2 +
drivers/gpu/drm/drm_gpuva_mgr.c | 10 +-
drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 2 +-
drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 +-
.../gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +-
.../gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +-
.../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++---------
.../gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c | 4 +-
drivers/gpu/drm/radeon/radeon_ttm.c | 2 -
drivers/gpu/drm/scheduler/sched_main.c | 1 +
drivers/gpu/drm/tegra/hub.c | 2 +-
drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +-
drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +-
19 files changed, 96 insertions(+), 97 deletions(-)
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply [flat|nested] 159+ messages in thread* [PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 7:36 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Hyun Kwon, Laurent Pinchart, David Airlie,
Daniel Vetter, Michal Simek, dri-devel, linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'blend' not described in 'zynqmp_disp'
drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'avbuf' not described in 'zynqmp_disp'
drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'audio' not described in 'zynqmp_disp'
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Hyun Kwon <hyun.kwon@xilinx.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
index 407bc07cec69a..7c64ab11fe2b0 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
@@ -128,9 +128,9 @@ struct zynqmp_disp_layer {
* struct zynqmp_disp - Display controller
* @dev: Device structure
* @dpsub: Display subsystem
- * @blend.base: Register I/O base address for the blender
- * @avbuf.base: Register I/O base address for the audio/video buffer manager
- * @audio.base: Registers I/O base address for the audio mixer
+ * @blend: .base: Register I/O base address for the blender
+ * @avbuf: .base: Register I/O base address for the audio/video buffer manager
+ * @audio: .base: Registers I/O base address for the audio mixer
* @layers: Layers (planes)
*/
struct zynqmp_disp {
--
2.42.0.rc1.204.g551eb34607-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 159+ messages in thread* [PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Hyun Kwon, Laurent Pinchart, David Airlie,
Daniel Vetter, Michal Simek, dri-devel, linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'blend' not described in 'zynqmp_disp'
drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'avbuf' not described in 'zynqmp_disp'
drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'audio' not described in 'zynqmp_disp'
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Hyun Kwon <hyun.kwon@xilinx.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
index 407bc07cec69a..7c64ab11fe2b0 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
@@ -128,9 +128,9 @@ struct zynqmp_disp_layer {
* struct zynqmp_disp - Display controller
* @dev: Device structure
* @dpsub: Display subsystem
- * @blend.base: Register I/O base address for the blender
- * @avbuf.base: Register I/O base address for the audio/video buffer manager
- * @audio.base: Registers I/O base address for the audio mixer
+ * @blend: .base: Register I/O base address for the blender
+ * @avbuf: .base: Register I/O base address for the audio/video buffer manager
+ * @audio: .base: Registers I/O base address for the audio mixer
* @layers: Layers (planes)
*/
struct zynqmp_disp {
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* [PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: Hyun Kwon, Michal Simek, dri-devel, linux-kernel,
Laurent Pinchart, linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'blend' not described in 'zynqmp_disp'
drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'avbuf' not described in 'zynqmp_disp'
drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'audio' not described in 'zynqmp_disp'
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Hyun Kwon <hyun.kwon@xilinx.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
index 407bc07cec69a..7c64ab11fe2b0 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
@@ -128,9 +128,9 @@ struct zynqmp_disp_layer {
* struct zynqmp_disp - Display controller
* @dev: Device structure
* @dpsub: Display subsystem
- * @blend.base: Register I/O base address for the blender
- * @avbuf.base: Register I/O base address for the audio/video buffer manager
- * @audio.base: Registers I/O base address for the audio mixer
+ * @blend: .base: Register I/O base address for the blender
+ * @avbuf: .base: Register I/O base address for the audio/video buffer manager
+ * @audio: .base: Registers I/O base address for the audio mixer
* @layers: Layers (planes)
*/
struct zynqmp_disp {
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* Re: [PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-28 16:39 ` Laurent Pinchart
-1 siblings, 0 replies; 159+ messages in thread
From: Laurent Pinchart @ 2023-08-28 16:39 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Hyun Kwon, David Airlie, Daniel Vetter,
Michal Simek, dri-devel, linux-arm-kernel
Hi Lee,
Thank you for the patch.
On Thu, Aug 24, 2023 at 08:36:46AM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'blend' not described in 'zynqmp_disp'
> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'avbuf' not described in 'zynqmp_disp'
> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'audio' not described in 'zynqmp_disp'
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> index 407bc07cec69a..7c64ab11fe2b0 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> @@ -128,9 +128,9 @@ struct zynqmp_disp_layer {
> * struct zynqmp_disp - Display controller
> * @dev: Device structure
> * @dpsub: Display subsystem
> - * @blend.base: Register I/O base address for the blender
> - * @avbuf.base: Register I/O base address for the audio/video buffer manager
> - * @audio.base: Registers I/O base address for the audio mixer
> + * @blend: .base: Register I/O base address for the blender
> + * @avbuf: .base: Register I/O base address for the audio/video buffer manager
> + * @audio: .base: Registers I/O base address for the audio mixer
This is really a hack to work around the warning, and not a clean fix.
kerneldoc is still today unable, as far as I understand, to document
nested structures. That's annoying, and the warning is a good way to
remind us that it needs to be fixed. I'd be tempted to keep the warning
for that reason.
> * @layers: Layers (planes)
> */
> struct zynqmp_disp {
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp
@ 2023-08-28 16:39 ` Laurent Pinchart
0 siblings, 0 replies; 159+ messages in thread
From: Laurent Pinchart @ 2023-08-28 16:39 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Hyun Kwon, David Airlie, Daniel Vetter,
Michal Simek, dri-devel, linux-arm-kernel
Hi Lee,
Thank you for the patch.
On Thu, Aug 24, 2023 at 08:36:46AM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'blend' not described in 'zynqmp_disp'
> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'avbuf' not described in 'zynqmp_disp'
> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'audio' not described in 'zynqmp_disp'
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> index 407bc07cec69a..7c64ab11fe2b0 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> @@ -128,9 +128,9 @@ struct zynqmp_disp_layer {
> * struct zynqmp_disp - Display controller
> * @dev: Device structure
> * @dpsub: Display subsystem
> - * @blend.base: Register I/O base address for the blender
> - * @avbuf.base: Register I/O base address for the audio/video buffer manager
> - * @audio.base: Registers I/O base address for the audio mixer
> + * @blend: .base: Register I/O base address for the blender
> + * @avbuf: .base: Register I/O base address for the audio/video buffer manager
> + * @audio: .base: Registers I/O base address for the audio mixer
This is really a hack to work around the warning, and not a clean fix.
kerneldoc is still today unable, as far as I understand, to document
nested structures. That's annoying, and the warning is a good way to
remind us that it needs to be fixed. I'd be tempted to keep the warning
for that reason.
> * @layers: Layers (planes)
> */
> struct zynqmp_disp {
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp
@ 2023-08-28 16:39 ` Laurent Pinchart
0 siblings, 0 replies; 159+ messages in thread
From: Laurent Pinchart @ 2023-08-28 16:39 UTC (permalink / raw)
To: Lee Jones
Cc: Hyun Kwon, linux-kernel, dri-devel, Michal Simek,
linux-arm-kernel
Hi Lee,
Thank you for the patch.
On Thu, Aug 24, 2023 at 08:36:46AM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'blend' not described in 'zynqmp_disp'
> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'avbuf' not described in 'zynqmp_disp'
> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'audio' not described in 'zynqmp_disp'
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> index 407bc07cec69a..7c64ab11fe2b0 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> @@ -128,9 +128,9 @@ struct zynqmp_disp_layer {
> * struct zynqmp_disp - Display controller
> * @dev: Device structure
> * @dpsub: Display subsystem
> - * @blend.base: Register I/O base address for the blender
> - * @avbuf.base: Register I/O base address for the audio/video buffer manager
> - * @audio.base: Registers I/O base address for the audio mixer
> + * @blend: .base: Register I/O base address for the blender
> + * @avbuf: .base: Register I/O base address for the audio/video buffer manager
> + * @audio: .base: Registers I/O base address for the audio mixer
This is really a hack to work around the warning, and not a clean fix.
kerneldoc is still today unable, as far as I understand, to document
nested structures. That's annoying, and the warning is a good way to
remind us that it needs to be fixed. I'd be tempted to keep the warning
for that reason.
> * @layers: Layers (planes)
> */
> struct zynqmp_disp {
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp
2023-08-28 16:39 ` Laurent Pinchart
(?)
@ 2023-08-28 19:33 ` Randy Dunlap
-1 siblings, 0 replies; 159+ messages in thread
From: Randy Dunlap @ 2023-08-28 19:33 UTC (permalink / raw)
To: Laurent Pinchart, Lee Jones
Cc: linux-kernel, Hyun Kwon, David Airlie, Daniel Vetter,
Michal Simek, dri-devel, linux-arm-kernel
Hi--
On 8/28/23 09:39, Laurent Pinchart wrote:
> Hi Lee,
>
> Thank you for the patch.
>
> On Thu, Aug 24, 2023 at 08:36:46AM +0100, Lee Jones wrote:
>> Fixes the following W=1 kernel build warning(s):
>>
>> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'blend' not described in 'zynqmp_disp'
>> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'avbuf' not described in 'zynqmp_disp'
>> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'audio' not described in 'zynqmp_disp'
>>
>> Signed-off-by: Lee Jones <lee@kernel.org>
>> ---
>> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Cc: David Airlie <airlied@gmail.com>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-arm-kernel@lists.infradead.org
>> ---
>> drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
>> index 407bc07cec69a..7c64ab11fe2b0 100644
>> --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
>> +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
>> @@ -128,9 +128,9 @@ struct zynqmp_disp_layer {
>> * struct zynqmp_disp - Display controller
>> * @dev: Device structure
>> * @dpsub: Display subsystem
>> - * @blend.base: Register I/O base address for the blender
>> - * @avbuf.base: Register I/O base address for the audio/video buffer manager
>> - * @audio.base: Registers I/O base address for the audio mixer
>> + * @blend: .base: Register I/O base address for the blender
>> + * @avbuf: .base: Register I/O base address for the audio/video buffer manager
>> + * @audio: .base: Registers I/O base address for the audio mixer
>
> This is really a hack to work around the warning, and not a clean fix.
> kerneldoc is still today unable, as far as I understand, to document
> nested structures. That's annoying, and the warning is a good way to
kernel-doc for nested structs/unions is documented in Documentation/doc-guide/kernel-doc.rst.
This isn't pretty, but this fixes the warnings for me: (massage the
descriptions as you see fit)
---
drivers/gpu/drm/xlnx/zynqmp_disp.c | 3 +++
1 file changed, 3 insertions(+)
diff -- a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
--- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
@@ -128,8 +128,11 @@ struct zynqmp_disp_layer {
* struct zynqmp_disp - Display controller
* @dev: Device structure
* @dpsub: Display subsystem
+ * @blend: blender struct
* @blend.base: Register I/O base address for the blender
+ * @avbuf: audio/video buffer manager struct
* @avbuf.base: Register I/O base address for the audio/video buffer manager
+ * @audio: audio mixer struct
* @audio.base: Registers I/O base address for the audio mixer
* @layers: Layers (planes)
*/
> remind us that it needs to be fixed. I'd be tempted to keep the warning
> for that reason.
>
>> * @layers: Layers (planes)
>> */
>> struct zynqmp_disp {
>
--
~Randy
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp
@ 2023-08-28 19:33 ` Randy Dunlap
0 siblings, 0 replies; 159+ messages in thread
From: Randy Dunlap @ 2023-08-28 19:33 UTC (permalink / raw)
To: Laurent Pinchart, Lee Jones
Cc: linux-kernel, Hyun Kwon, David Airlie, Daniel Vetter,
Michal Simek, dri-devel, linux-arm-kernel
Hi--
On 8/28/23 09:39, Laurent Pinchart wrote:
> Hi Lee,
>
> Thank you for the patch.
>
> On Thu, Aug 24, 2023 at 08:36:46AM +0100, Lee Jones wrote:
>> Fixes the following W=1 kernel build warning(s):
>>
>> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'blend' not described in 'zynqmp_disp'
>> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'avbuf' not described in 'zynqmp_disp'
>> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'audio' not described in 'zynqmp_disp'
>>
>> Signed-off-by: Lee Jones <lee@kernel.org>
>> ---
>> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Cc: David Airlie <airlied@gmail.com>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-arm-kernel@lists.infradead.org
>> ---
>> drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
>> index 407bc07cec69a..7c64ab11fe2b0 100644
>> --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
>> +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
>> @@ -128,9 +128,9 @@ struct zynqmp_disp_layer {
>> * struct zynqmp_disp - Display controller
>> * @dev: Device structure
>> * @dpsub: Display subsystem
>> - * @blend.base: Register I/O base address for the blender
>> - * @avbuf.base: Register I/O base address for the audio/video buffer manager
>> - * @audio.base: Registers I/O base address for the audio mixer
>> + * @blend: .base: Register I/O base address for the blender
>> + * @avbuf: .base: Register I/O base address for the audio/video buffer manager
>> + * @audio: .base: Registers I/O base address for the audio mixer
>
> This is really a hack to work around the warning, and not a clean fix.
> kerneldoc is still today unable, as far as I understand, to document
> nested structures. That's annoying, and the warning is a good way to
kernel-doc for nested structs/unions is documented in Documentation/doc-guide/kernel-doc.rst.
This isn't pretty, but this fixes the warnings for me: (massage the
descriptions as you see fit)
---
drivers/gpu/drm/xlnx/zynqmp_disp.c | 3 +++
1 file changed, 3 insertions(+)
diff -- a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
--- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
@@ -128,8 +128,11 @@ struct zynqmp_disp_layer {
* struct zynqmp_disp - Display controller
* @dev: Device structure
* @dpsub: Display subsystem
+ * @blend: blender struct
* @blend.base: Register I/O base address for the blender
+ * @avbuf: audio/video buffer manager struct
* @avbuf.base: Register I/O base address for the audio/video buffer manager
+ * @audio: audio mixer struct
* @audio.base: Registers I/O base address for the audio mixer
* @layers: Layers (planes)
*/
> remind us that it needs to be fixed. I'd be tempted to keep the warning
> for that reason.
>
>> * @layers: Layers (planes)
>> */
>> struct zynqmp_disp {
>
--
~Randy
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp
@ 2023-08-28 19:33 ` Randy Dunlap
0 siblings, 0 replies; 159+ messages in thread
From: Randy Dunlap @ 2023-08-28 19:33 UTC (permalink / raw)
To: Laurent Pinchart, Lee Jones
Cc: Hyun Kwon, linux-kernel, dri-devel, Michal Simek,
linux-arm-kernel
Hi--
On 8/28/23 09:39, Laurent Pinchart wrote:
> Hi Lee,
>
> Thank you for the patch.
>
> On Thu, Aug 24, 2023 at 08:36:46AM +0100, Lee Jones wrote:
>> Fixes the following W=1 kernel build warning(s):
>>
>> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'blend' not described in 'zynqmp_disp'
>> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'avbuf' not described in 'zynqmp_disp'
>> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'audio' not described in 'zynqmp_disp'
>>
>> Signed-off-by: Lee Jones <lee@kernel.org>
>> ---
>> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Cc: David Airlie <airlied@gmail.com>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-arm-kernel@lists.infradead.org
>> ---
>> drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
>> index 407bc07cec69a..7c64ab11fe2b0 100644
>> --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
>> +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
>> @@ -128,9 +128,9 @@ struct zynqmp_disp_layer {
>> * struct zynqmp_disp - Display controller
>> * @dev: Device structure
>> * @dpsub: Display subsystem
>> - * @blend.base: Register I/O base address for the blender
>> - * @avbuf.base: Register I/O base address for the audio/video buffer manager
>> - * @audio.base: Registers I/O base address for the audio mixer
>> + * @blend: .base: Register I/O base address for the blender
>> + * @avbuf: .base: Register I/O base address for the audio/video buffer manager
>> + * @audio: .base: Registers I/O base address for the audio mixer
>
> This is really a hack to work around the warning, and not a clean fix.
> kerneldoc is still today unable, as far as I understand, to document
> nested structures. That's annoying, and the warning is a good way to
kernel-doc for nested structs/unions is documented in Documentation/doc-guide/kernel-doc.rst.
This isn't pretty, but this fixes the warnings for me: (massage the
descriptions as you see fit)
---
drivers/gpu/drm/xlnx/zynqmp_disp.c | 3 +++
1 file changed, 3 insertions(+)
diff -- a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
--- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
@@ -128,8 +128,11 @@ struct zynqmp_disp_layer {
* struct zynqmp_disp - Display controller
* @dev: Device structure
* @dpsub: Display subsystem
+ * @blend: blender struct
* @blend.base: Register I/O base address for the blender
+ * @avbuf: audio/video buffer manager struct
* @avbuf.base: Register I/O base address for the audio/video buffer manager
+ * @audio: audio mixer struct
* @audio.base: Registers I/O base address for the audio mixer
* @layers: Layers (planes)
*/
> remind us that it needs to be fixed. I'd be tempted to keep the warning
> for that reason.
>
>> * @layers: Layers (planes)
>> */
>> struct zynqmp_disp {
>
--
~Randy
^ permalink raw reply [flat|nested] 159+ messages in thread
* [Nouveau] [PATCH 02/20] drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc'
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 7:36 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: nouveau, linux-kernel, dri-devel, Ben Skeggs, Daniel Vetter,
Gourav Samaiya
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c: In function ‘nvkm_acr_lsfw_load_sig_image_desc_v2’:
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:21: warning: variable ‘loc’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Gourav Samaiya <gsamaiya@nvidia.com>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
---
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
index f36a359d4531c..bd104a030243a 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
@@ -218,7 +218,7 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev,
const struct firmware *hsbl;
const struct nvfw_ls_hsbl_bin_hdr *hdr;
const struct nvfw_ls_hsbl_hdr *hshdr;
- u32 loc, sig, cnt, *meta;
+ u32 sig, cnt, *meta;
ret = nvkm_firmware_load_name(subdev, path, "hs_bl_sig", ver, &hsbl);
if (ret)
@@ -227,7 +227,6 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev,
hdr = nvfw_ls_hsbl_bin_hdr(subdev, hsbl->data);
hshdr = nvfw_ls_hsbl_hdr(subdev, hsbl->data + hdr->header_offset);
meta = (u32 *)(hsbl->data + hshdr->meta_data_offset);
- loc = *(u32 *)(hsbl->data + hshdr->patch_loc);
sig = *(u32 *)(hsbl->data + hshdr->patch_sig);
cnt = *(u32 *)(hsbl->data + hshdr->num_sig);
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 02/20] drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc'
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Ben Skeggs, Karol Herbst, Lyude Paul, David Airlie,
Daniel Vetter, Gourav Samaiya, dri-devel, nouveau
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c: In function ‘nvkm_acr_lsfw_load_sig_image_desc_v2’:
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:21: warning: variable ‘loc’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Gourav Samaiya <gsamaiya@nvidia.com>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
---
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
index f36a359d4531c..bd104a030243a 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
@@ -218,7 +218,7 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev,
const struct firmware *hsbl;
const struct nvfw_ls_hsbl_bin_hdr *hdr;
const struct nvfw_ls_hsbl_hdr *hshdr;
- u32 loc, sig, cnt, *meta;
+ u32 sig, cnt, *meta;
ret = nvkm_firmware_load_name(subdev, path, "hs_bl_sig", ver, &hsbl);
if (ret)
@@ -227,7 +227,6 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev,
hdr = nvfw_ls_hsbl_bin_hdr(subdev, hsbl->data);
hshdr = nvfw_ls_hsbl_hdr(subdev, hsbl->data + hdr->header_offset);
meta = (u32 *)(hsbl->data + hshdr->meta_data_offset);
- loc = *(u32 *)(hsbl->data + hshdr->patch_loc);
sig = *(u32 *)(hsbl->data + hshdr->patch_sig);
cnt = *(u32 *)(hsbl->data + hshdr->num_sig);
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 02/20] drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc'
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: Karol Herbst, nouveau, linux-kernel, dri-devel, Ben Skeggs,
Gourav Samaiya
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c: In function ‘nvkm_acr_lsfw_load_sig_image_desc_v2’:
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:21: warning: variable ‘loc’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Gourav Samaiya <gsamaiya@nvidia.com>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
---
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
index f36a359d4531c..bd104a030243a 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
@@ -218,7 +218,7 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev,
const struct firmware *hsbl;
const struct nvfw_ls_hsbl_bin_hdr *hdr;
const struct nvfw_ls_hsbl_hdr *hshdr;
- u32 loc, sig, cnt, *meta;
+ u32 sig, cnt, *meta;
ret = nvkm_firmware_load_name(subdev, path, "hs_bl_sig", ver, &hsbl);
if (ret)
@@ -227,7 +227,6 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev,
hdr = nvfw_ls_hsbl_bin_hdr(subdev, hsbl->data);
hshdr = nvfw_ls_hsbl_hdr(subdev, hsbl->data + hdr->header_offset);
meta = (u32 *)(hsbl->data + hshdr->meta_data_offset);
- loc = *(u32 *)(hsbl->data + hshdr->patch_loc);
sig = *(u32 *)(hsbl->data + hshdr->patch_sig);
cnt = *(u32 *)(hsbl->data + hshdr->num_sig);
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [Nouveau] [PATCH 03/20] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 7:36 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee; +Cc: nouveau, linux-kernel, dri-devel, Ben Skeggs, Daniel Vetter
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function parameter or member 'init' not described in 'init_reserved'
drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: warning: expecting prototype for INIT_DONE(). Prototype was for init_done() instead
[Snipped ~140 lines for brevity]
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
---
.../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++---------
1 file changed, 68 insertions(+), 68 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
index 1420794038642..b54f044c4483b 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
@@ -575,7 +575,7 @@ init_tmds_reg(struct nvbios_init *init, u8 tmds)
* init opcode handlers
*****************************************************************************/
-/**
+/*
* init_reserved - stub for various unknown/unused single-byte opcodes
*
*/
@@ -602,7 +602,7 @@ init_reserved(struct nvbios_init *init)
init->offset += length;
}
-/**
+/*
* INIT_DONE - opcode 0x71
*
*/
@@ -613,7 +613,7 @@ init_done(struct nvbios_init *init)
init->offset = 0x0000;
}
-/**
+/*
* INIT_IO_RESTRICT_PROG - opcode 0x32
*
*/
@@ -650,7 +650,7 @@ init_io_restrict_prog(struct nvbios_init *init)
trace("}]\n");
}
-/**
+/*
* INIT_REPEAT - opcode 0x33
*
*/
@@ -676,7 +676,7 @@ init_repeat(struct nvbios_init *init)
init->repeat = repeat;
}
-/**
+/*
* INIT_IO_RESTRICT_PLL - opcode 0x34
*
*/
@@ -716,7 +716,7 @@ init_io_restrict_pll(struct nvbios_init *init)
trace("}]\n");
}
-/**
+/*
* INIT_END_REPEAT - opcode 0x36
*
*/
@@ -732,7 +732,7 @@ init_end_repeat(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_COPY - opcode 0x37
*
*/
@@ -759,7 +759,7 @@ init_copy(struct nvbios_init *init)
init_wrvgai(init, port, index, data);
}
-/**
+/*
* INIT_NOT - opcode 0x38
*
*/
@@ -771,7 +771,7 @@ init_not(struct nvbios_init *init)
init_exec_inv(init);
}
-/**
+/*
* INIT_IO_FLAG_CONDITION - opcode 0x39
*
*/
@@ -788,7 +788,7 @@ init_io_flag_condition(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_GENERIC_CONDITION - opcode 0x3a
*
*/
@@ -840,7 +840,7 @@ init_generic_condition(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_IO_MASK_OR - opcode 0x3b
*
*/
@@ -859,7 +859,7 @@ init_io_mask_or(struct nvbios_init *init)
init_wrvgai(init, 0x03d4, index, data &= ~(1 << or));
}
-/**
+/*
* INIT_IO_OR - opcode 0x3c
*
*/
@@ -878,7 +878,7 @@ init_io_or(struct nvbios_init *init)
init_wrvgai(init, 0x03d4, index, data | (1 << or));
}
-/**
+/*
* INIT_ANDN_REG - opcode 0x47
*
*/
@@ -895,7 +895,7 @@ init_andn_reg(struct nvbios_init *init)
init_mask(init, reg, mask, 0);
}
-/**
+/*
* INIT_OR_REG - opcode 0x48
*
*/
@@ -912,7 +912,7 @@ init_or_reg(struct nvbios_init *init)
init_mask(init, reg, 0, mask);
}
-/**
+/*
* INIT_INDEX_ADDRESS_LATCHED - opcode 0x49
*
*/
@@ -942,7 +942,7 @@ init_idx_addr_latched(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_IO_RESTRICT_PLL2 - opcode 0x4a
*
*/
@@ -977,7 +977,7 @@ init_io_restrict_pll2(struct nvbios_init *init)
trace("}]\n");
}
-/**
+/*
* INIT_PLL2 - opcode 0x4b
*
*/
@@ -994,7 +994,7 @@ init_pll2(struct nvbios_init *init)
init_prog_pll(init, reg, freq);
}
-/**
+/*
* INIT_I2C_BYTE - opcode 0x4c
*
*/
@@ -1025,7 +1025,7 @@ init_i2c_byte(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_ZM_I2C_BYTE - opcode 0x4d
*
*/
@@ -1051,7 +1051,7 @@ init_zm_i2c_byte(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_ZM_I2C - opcode 0x4e
*
*/
@@ -1085,7 +1085,7 @@ init_zm_i2c(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_TMDS - opcode 0x4f
*
*/
@@ -1111,7 +1111,7 @@ init_tmds(struct nvbios_init *init)
init_wr32(init, reg + 0, addr);
}
-/**
+/*
* INIT_ZM_TMDS_GROUP - opcode 0x50
*
*/
@@ -1138,7 +1138,7 @@ init_zm_tmds_group(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_CR_INDEX_ADDRESS_LATCHED - opcode 0x51
*
*/
@@ -1168,7 +1168,7 @@ init_cr_idx_adr_latch(struct nvbios_init *init)
init_wrvgai(init, 0x03d4, addr0, save0);
}
-/**
+/*
* INIT_CR - opcode 0x52
*
*/
@@ -1188,7 +1188,7 @@ init_cr(struct nvbios_init *init)
init_wrvgai(init, 0x03d4, addr, val | data);
}
-/**
+/*
* INIT_ZM_CR - opcode 0x53
*
*/
@@ -1205,7 +1205,7 @@ init_zm_cr(struct nvbios_init *init)
init_wrvgai(init, 0x03d4, addr, data);
}
-/**
+/*
* INIT_ZM_CR_GROUP - opcode 0x54
*
*/
@@ -1229,7 +1229,7 @@ init_zm_cr_group(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_CONDITION_TIME - opcode 0x56
*
*/
@@ -1256,7 +1256,7 @@ init_condition_time(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_LTIME - opcode 0x57
*
*/
@@ -1273,7 +1273,7 @@ init_ltime(struct nvbios_init *init)
mdelay(msec);
}
-/**
+/*
* INIT_ZM_REG_SEQUENCE - opcode 0x58
*
*/
@@ -1298,7 +1298,7 @@ init_zm_reg_sequence(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_PLL_INDIRECT - opcode 0x59
*
*/
@@ -1317,7 +1317,7 @@ init_pll_indirect(struct nvbios_init *init)
init_prog_pll(init, reg, freq);
}
-/**
+/*
* INIT_ZM_REG_INDIRECT - opcode 0x5a
*
*/
@@ -1336,7 +1336,7 @@ init_zm_reg_indirect(struct nvbios_init *init)
init_wr32(init, addr, data);
}
-/**
+/*
* INIT_SUB_DIRECT - opcode 0x5b
*
*/
@@ -1362,7 +1362,7 @@ init_sub_direct(struct nvbios_init *init)
init->offset += 3;
}
-/**
+/*
* INIT_JUMP - opcode 0x5c
*
*/
@@ -1380,7 +1380,7 @@ init_jump(struct nvbios_init *init)
init->offset += 3;
}
-/**
+/*
* INIT_I2C_IF - opcode 0x5e
*
*/
@@ -1407,7 +1407,7 @@ init_i2c_if(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_COPY_NV_REG - opcode 0x5f
*
*/
@@ -1433,7 +1433,7 @@ init_copy_nv_reg(struct nvbios_init *init)
init_mask(init, dreg, ~dmask, (data & smask) ^ sxor);
}
-/**
+/*
* INIT_ZM_INDEX_IO - opcode 0x62
*
*/
@@ -1451,7 +1451,7 @@ init_zm_index_io(struct nvbios_init *init)
init_wrvgai(init, port, index, data);
}
-/**
+/*
* INIT_COMPUTE_MEM - opcode 0x63
*
*/
@@ -1469,7 +1469,7 @@ init_compute_mem(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_RESET - opcode 0x65
*
*/
@@ -1496,7 +1496,7 @@ init_reset(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_CONFIGURE_MEM - opcode 0x66
*
*/
@@ -1555,7 +1555,7 @@ init_configure_mem(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_CONFIGURE_CLK - opcode 0x67
*
*/
@@ -1589,7 +1589,7 @@ init_configure_clk(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_CONFIGURE_PREINIT - opcode 0x68
*
*/
@@ -1615,7 +1615,7 @@ init_configure_preinit(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_IO - opcode 0x69
*
*/
@@ -1655,7 +1655,7 @@ init_io(struct nvbios_init *init)
init_wrport(init, port, data | value);
}
-/**
+/*
* INIT_SUB - opcode 0x6b
*
*/
@@ -1682,7 +1682,7 @@ init_sub(struct nvbios_init *init)
init->offset += 2;
}
-/**
+/*
* INIT_RAM_CONDITION - opcode 0x6d
*
*/
@@ -1701,7 +1701,7 @@ init_ram_condition(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_NV_REG - opcode 0x6e
*
*/
@@ -1719,7 +1719,7 @@ init_nv_reg(struct nvbios_init *init)
init_mask(init, reg, ~mask, data);
}
-/**
+/*
* INIT_MACRO - opcode 0x6f
*
*/
@@ -1743,7 +1743,7 @@ init_macro(struct nvbios_init *init)
init->offset += 2;
}
-/**
+/*
* INIT_RESUME - opcode 0x72
*
*/
@@ -1755,7 +1755,7 @@ init_resume(struct nvbios_init *init)
init_exec_set(init, true);
}
-/**
+/*
* INIT_STRAP_CONDITION - opcode 0x73
*
*/
@@ -1773,7 +1773,7 @@ init_strap_condition(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_TIME - opcode 0x74
*
*/
@@ -1794,7 +1794,7 @@ init_time(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_CONDITION - opcode 0x75
*
*/
@@ -1811,7 +1811,7 @@ init_condition(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_IO_CONDITION - opcode 0x76
*
*/
@@ -1828,7 +1828,7 @@ init_io_condition(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_ZM_REG16 - opcode 0x77
*
*/
@@ -1845,7 +1845,7 @@ init_zm_reg16(struct nvbios_init *init)
init_wr32(init, addr, data);
}
-/**
+/*
* INIT_INDEX_IO - opcode 0x78
*
*/
@@ -1867,7 +1867,7 @@ init_index_io(struct nvbios_init *init)
init_wrvgai(init, port, index, data | value);
}
-/**
+/*
* INIT_PLL - opcode 0x79
*
*/
@@ -1884,7 +1884,7 @@ init_pll(struct nvbios_init *init)
init_prog_pll(init, reg, freq);
}
-/**
+/*
* INIT_ZM_REG - opcode 0x7a
*
*/
@@ -1904,7 +1904,7 @@ init_zm_reg(struct nvbios_init *init)
init_wr32(init, addr, data);
}
-/**
+/*
* INIT_RAM_RESTRICT_PLL - opcde 0x87
*
*/
@@ -1934,7 +1934,7 @@ init_ram_restrict_pll(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_RESET_BEGUN - opcode 0x8c
*
*/
@@ -1945,7 +1945,7 @@ init_reset_begun(struct nvbios_init *init)
init->offset += 1;
}
-/**
+/*
* INIT_RESET_END - opcode 0x8d
*
*/
@@ -1956,7 +1956,7 @@ init_reset_end(struct nvbios_init *init)
init->offset += 1;
}
-/**
+/*
* INIT_GPIO - opcode 0x8e
*
*/
@@ -1972,7 +1972,7 @@ init_gpio(struct nvbios_init *init)
nvkm_gpio_reset(gpio, DCB_GPIO_UNUSED);
}
-/**
+/*
* INIT_RAM_RESTRICT_ZM_GROUP - opcode 0x8f
*
*/
@@ -2010,7 +2010,7 @@ init_ram_restrict_zm_reg_group(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_COPY_ZM_REG - opcode 0x90
*
*/
@@ -2027,7 +2027,7 @@ init_copy_zm_reg(struct nvbios_init *init)
init_wr32(init, dreg, init_rd32(init, sreg));
}
-/**
+/*
* INIT_ZM_REG_GROUP - opcode 0x91
*
*/
@@ -2049,7 +2049,7 @@ init_zm_reg_group(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_XLAT - opcode 0x96
*
*/
@@ -2077,7 +2077,7 @@ init_xlat(struct nvbios_init *init)
init_mask(init, daddr, ~dmask, data);
}
-/**
+/*
* INIT_ZM_MASK_ADD - opcode 0x97
*
*/
@@ -2098,7 +2098,7 @@ init_zm_mask_add(struct nvbios_init *init)
init_wr32(init, addr, data);
}
-/**
+/*
* INIT_AUXCH - opcode 0x98
*
*/
@@ -2122,7 +2122,7 @@ init_auxch(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_AUXCH - opcode 0x99
*
*/
@@ -2144,7 +2144,7 @@ init_zm_auxch(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_I2C_LONG_IF - opcode 0x9a
*
*/
@@ -2183,7 +2183,7 @@ init_i2c_long_if(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_GPIO_NE - opcode 0xa9
*
*/
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* [PATCH 03/20] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Ben Skeggs, Karol Herbst, Lyude Paul, David Airlie,
Daniel Vetter, dri-devel, nouveau
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function parameter or member 'init' not described in 'init_reserved'
drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: warning: expecting prototype for INIT_DONE(). Prototype was for init_done() instead
[Snipped ~140 lines for brevity]
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
---
.../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++---------
1 file changed, 68 insertions(+), 68 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
index 1420794038642..b54f044c4483b 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
@@ -575,7 +575,7 @@ init_tmds_reg(struct nvbios_init *init, u8 tmds)
* init opcode handlers
*****************************************************************************/
-/**
+/*
* init_reserved - stub for various unknown/unused single-byte opcodes
*
*/
@@ -602,7 +602,7 @@ init_reserved(struct nvbios_init *init)
init->offset += length;
}
-/**
+/*
* INIT_DONE - opcode 0x71
*
*/
@@ -613,7 +613,7 @@ init_done(struct nvbios_init *init)
init->offset = 0x0000;
}
-/**
+/*
* INIT_IO_RESTRICT_PROG - opcode 0x32
*
*/
@@ -650,7 +650,7 @@ init_io_restrict_prog(struct nvbios_init *init)
trace("}]\n");
}
-/**
+/*
* INIT_REPEAT - opcode 0x33
*
*/
@@ -676,7 +676,7 @@ init_repeat(struct nvbios_init *init)
init->repeat = repeat;
}
-/**
+/*
* INIT_IO_RESTRICT_PLL - opcode 0x34
*
*/
@@ -716,7 +716,7 @@ init_io_restrict_pll(struct nvbios_init *init)
trace("}]\n");
}
-/**
+/*
* INIT_END_REPEAT - opcode 0x36
*
*/
@@ -732,7 +732,7 @@ init_end_repeat(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_COPY - opcode 0x37
*
*/
@@ -759,7 +759,7 @@ init_copy(struct nvbios_init *init)
init_wrvgai(init, port, index, data);
}
-/**
+/*
* INIT_NOT - opcode 0x38
*
*/
@@ -771,7 +771,7 @@ init_not(struct nvbios_init *init)
init_exec_inv(init);
}
-/**
+/*
* INIT_IO_FLAG_CONDITION - opcode 0x39
*
*/
@@ -788,7 +788,7 @@ init_io_flag_condition(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_GENERIC_CONDITION - opcode 0x3a
*
*/
@@ -840,7 +840,7 @@ init_generic_condition(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_IO_MASK_OR - opcode 0x3b
*
*/
@@ -859,7 +859,7 @@ init_io_mask_or(struct nvbios_init *init)
init_wrvgai(init, 0x03d4, index, data &= ~(1 << or));
}
-/**
+/*
* INIT_IO_OR - opcode 0x3c
*
*/
@@ -878,7 +878,7 @@ init_io_or(struct nvbios_init *init)
init_wrvgai(init, 0x03d4, index, data | (1 << or));
}
-/**
+/*
* INIT_ANDN_REG - opcode 0x47
*
*/
@@ -895,7 +895,7 @@ init_andn_reg(struct nvbios_init *init)
init_mask(init, reg, mask, 0);
}
-/**
+/*
* INIT_OR_REG - opcode 0x48
*
*/
@@ -912,7 +912,7 @@ init_or_reg(struct nvbios_init *init)
init_mask(init, reg, 0, mask);
}
-/**
+/*
* INIT_INDEX_ADDRESS_LATCHED - opcode 0x49
*
*/
@@ -942,7 +942,7 @@ init_idx_addr_latched(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_IO_RESTRICT_PLL2 - opcode 0x4a
*
*/
@@ -977,7 +977,7 @@ init_io_restrict_pll2(struct nvbios_init *init)
trace("}]\n");
}
-/**
+/*
* INIT_PLL2 - opcode 0x4b
*
*/
@@ -994,7 +994,7 @@ init_pll2(struct nvbios_init *init)
init_prog_pll(init, reg, freq);
}
-/**
+/*
* INIT_I2C_BYTE - opcode 0x4c
*
*/
@@ -1025,7 +1025,7 @@ init_i2c_byte(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_ZM_I2C_BYTE - opcode 0x4d
*
*/
@@ -1051,7 +1051,7 @@ init_zm_i2c_byte(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_ZM_I2C - opcode 0x4e
*
*/
@@ -1085,7 +1085,7 @@ init_zm_i2c(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_TMDS - opcode 0x4f
*
*/
@@ -1111,7 +1111,7 @@ init_tmds(struct nvbios_init *init)
init_wr32(init, reg + 0, addr);
}
-/**
+/*
* INIT_ZM_TMDS_GROUP - opcode 0x50
*
*/
@@ -1138,7 +1138,7 @@ init_zm_tmds_group(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_CR_INDEX_ADDRESS_LATCHED - opcode 0x51
*
*/
@@ -1168,7 +1168,7 @@ init_cr_idx_adr_latch(struct nvbios_init *init)
init_wrvgai(init, 0x03d4, addr0, save0);
}
-/**
+/*
* INIT_CR - opcode 0x52
*
*/
@@ -1188,7 +1188,7 @@ init_cr(struct nvbios_init *init)
init_wrvgai(init, 0x03d4, addr, val | data);
}
-/**
+/*
* INIT_ZM_CR - opcode 0x53
*
*/
@@ -1205,7 +1205,7 @@ init_zm_cr(struct nvbios_init *init)
init_wrvgai(init, 0x03d4, addr, data);
}
-/**
+/*
* INIT_ZM_CR_GROUP - opcode 0x54
*
*/
@@ -1229,7 +1229,7 @@ init_zm_cr_group(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_CONDITION_TIME - opcode 0x56
*
*/
@@ -1256,7 +1256,7 @@ init_condition_time(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_LTIME - opcode 0x57
*
*/
@@ -1273,7 +1273,7 @@ init_ltime(struct nvbios_init *init)
mdelay(msec);
}
-/**
+/*
* INIT_ZM_REG_SEQUENCE - opcode 0x58
*
*/
@@ -1298,7 +1298,7 @@ init_zm_reg_sequence(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_PLL_INDIRECT - opcode 0x59
*
*/
@@ -1317,7 +1317,7 @@ init_pll_indirect(struct nvbios_init *init)
init_prog_pll(init, reg, freq);
}
-/**
+/*
* INIT_ZM_REG_INDIRECT - opcode 0x5a
*
*/
@@ -1336,7 +1336,7 @@ init_zm_reg_indirect(struct nvbios_init *init)
init_wr32(init, addr, data);
}
-/**
+/*
* INIT_SUB_DIRECT - opcode 0x5b
*
*/
@@ -1362,7 +1362,7 @@ init_sub_direct(struct nvbios_init *init)
init->offset += 3;
}
-/**
+/*
* INIT_JUMP - opcode 0x5c
*
*/
@@ -1380,7 +1380,7 @@ init_jump(struct nvbios_init *init)
init->offset += 3;
}
-/**
+/*
* INIT_I2C_IF - opcode 0x5e
*
*/
@@ -1407,7 +1407,7 @@ init_i2c_if(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_COPY_NV_REG - opcode 0x5f
*
*/
@@ -1433,7 +1433,7 @@ init_copy_nv_reg(struct nvbios_init *init)
init_mask(init, dreg, ~dmask, (data & smask) ^ sxor);
}
-/**
+/*
* INIT_ZM_INDEX_IO - opcode 0x62
*
*/
@@ -1451,7 +1451,7 @@ init_zm_index_io(struct nvbios_init *init)
init_wrvgai(init, port, index, data);
}
-/**
+/*
* INIT_COMPUTE_MEM - opcode 0x63
*
*/
@@ -1469,7 +1469,7 @@ init_compute_mem(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_RESET - opcode 0x65
*
*/
@@ -1496,7 +1496,7 @@ init_reset(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_CONFIGURE_MEM - opcode 0x66
*
*/
@@ -1555,7 +1555,7 @@ init_configure_mem(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_CONFIGURE_CLK - opcode 0x67
*
*/
@@ -1589,7 +1589,7 @@ init_configure_clk(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_CONFIGURE_PREINIT - opcode 0x68
*
*/
@@ -1615,7 +1615,7 @@ init_configure_preinit(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_IO - opcode 0x69
*
*/
@@ -1655,7 +1655,7 @@ init_io(struct nvbios_init *init)
init_wrport(init, port, data | value);
}
-/**
+/*
* INIT_SUB - opcode 0x6b
*
*/
@@ -1682,7 +1682,7 @@ init_sub(struct nvbios_init *init)
init->offset += 2;
}
-/**
+/*
* INIT_RAM_CONDITION - opcode 0x6d
*
*/
@@ -1701,7 +1701,7 @@ init_ram_condition(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_NV_REG - opcode 0x6e
*
*/
@@ -1719,7 +1719,7 @@ init_nv_reg(struct nvbios_init *init)
init_mask(init, reg, ~mask, data);
}
-/**
+/*
* INIT_MACRO - opcode 0x6f
*
*/
@@ -1743,7 +1743,7 @@ init_macro(struct nvbios_init *init)
init->offset += 2;
}
-/**
+/*
* INIT_RESUME - opcode 0x72
*
*/
@@ -1755,7 +1755,7 @@ init_resume(struct nvbios_init *init)
init_exec_set(init, true);
}
-/**
+/*
* INIT_STRAP_CONDITION - opcode 0x73
*
*/
@@ -1773,7 +1773,7 @@ init_strap_condition(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_TIME - opcode 0x74
*
*/
@@ -1794,7 +1794,7 @@ init_time(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_CONDITION - opcode 0x75
*
*/
@@ -1811,7 +1811,7 @@ init_condition(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_IO_CONDITION - opcode 0x76
*
*/
@@ -1828,7 +1828,7 @@ init_io_condition(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_ZM_REG16 - opcode 0x77
*
*/
@@ -1845,7 +1845,7 @@ init_zm_reg16(struct nvbios_init *init)
init_wr32(init, addr, data);
}
-/**
+/*
* INIT_INDEX_IO - opcode 0x78
*
*/
@@ -1867,7 +1867,7 @@ init_index_io(struct nvbios_init *init)
init_wrvgai(init, port, index, data | value);
}
-/**
+/*
* INIT_PLL - opcode 0x79
*
*/
@@ -1884,7 +1884,7 @@ init_pll(struct nvbios_init *init)
init_prog_pll(init, reg, freq);
}
-/**
+/*
* INIT_ZM_REG - opcode 0x7a
*
*/
@@ -1904,7 +1904,7 @@ init_zm_reg(struct nvbios_init *init)
init_wr32(init, addr, data);
}
-/**
+/*
* INIT_RAM_RESTRICT_PLL - opcde 0x87
*
*/
@@ -1934,7 +1934,7 @@ init_ram_restrict_pll(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_RESET_BEGUN - opcode 0x8c
*
*/
@@ -1945,7 +1945,7 @@ init_reset_begun(struct nvbios_init *init)
init->offset += 1;
}
-/**
+/*
* INIT_RESET_END - opcode 0x8d
*
*/
@@ -1956,7 +1956,7 @@ init_reset_end(struct nvbios_init *init)
init->offset += 1;
}
-/**
+/*
* INIT_GPIO - opcode 0x8e
*
*/
@@ -1972,7 +1972,7 @@ init_gpio(struct nvbios_init *init)
nvkm_gpio_reset(gpio, DCB_GPIO_UNUSED);
}
-/**
+/*
* INIT_RAM_RESTRICT_ZM_GROUP - opcode 0x8f
*
*/
@@ -2010,7 +2010,7 @@ init_ram_restrict_zm_reg_group(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_COPY_ZM_REG - opcode 0x90
*
*/
@@ -2027,7 +2027,7 @@ init_copy_zm_reg(struct nvbios_init *init)
init_wr32(init, dreg, init_rd32(init, sreg));
}
-/**
+/*
* INIT_ZM_REG_GROUP - opcode 0x91
*
*/
@@ -2049,7 +2049,7 @@ init_zm_reg_group(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_XLAT - opcode 0x96
*
*/
@@ -2077,7 +2077,7 @@ init_xlat(struct nvbios_init *init)
init_mask(init, daddr, ~dmask, data);
}
-/**
+/*
* INIT_ZM_MASK_ADD - opcode 0x97
*
*/
@@ -2098,7 +2098,7 @@ init_zm_mask_add(struct nvbios_init *init)
init_wr32(init, addr, data);
}
-/**
+/*
* INIT_AUXCH - opcode 0x98
*
*/
@@ -2122,7 +2122,7 @@ init_auxch(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_AUXCH - opcode 0x99
*
*/
@@ -2144,7 +2144,7 @@ init_zm_auxch(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_I2C_LONG_IF - opcode 0x9a
*
*/
@@ -2183,7 +2183,7 @@ init_i2c_long_if(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_GPIO_NE - opcode 0xa9
*
*/
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* [PATCH 03/20] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee; +Cc: Karol Herbst, nouveau, linux-kernel, dri-devel, Ben Skeggs
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function parameter or member 'init' not described in 'init_reserved'
drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: warning: expecting prototype for INIT_DONE(). Prototype was for init_done() instead
[Snipped ~140 lines for brevity]
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
---
.../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++---------
1 file changed, 68 insertions(+), 68 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
index 1420794038642..b54f044c4483b 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
@@ -575,7 +575,7 @@ init_tmds_reg(struct nvbios_init *init, u8 tmds)
* init opcode handlers
*****************************************************************************/
-/**
+/*
* init_reserved - stub for various unknown/unused single-byte opcodes
*
*/
@@ -602,7 +602,7 @@ init_reserved(struct nvbios_init *init)
init->offset += length;
}
-/**
+/*
* INIT_DONE - opcode 0x71
*
*/
@@ -613,7 +613,7 @@ init_done(struct nvbios_init *init)
init->offset = 0x0000;
}
-/**
+/*
* INIT_IO_RESTRICT_PROG - opcode 0x32
*
*/
@@ -650,7 +650,7 @@ init_io_restrict_prog(struct nvbios_init *init)
trace("}]\n");
}
-/**
+/*
* INIT_REPEAT - opcode 0x33
*
*/
@@ -676,7 +676,7 @@ init_repeat(struct nvbios_init *init)
init->repeat = repeat;
}
-/**
+/*
* INIT_IO_RESTRICT_PLL - opcode 0x34
*
*/
@@ -716,7 +716,7 @@ init_io_restrict_pll(struct nvbios_init *init)
trace("}]\n");
}
-/**
+/*
* INIT_END_REPEAT - opcode 0x36
*
*/
@@ -732,7 +732,7 @@ init_end_repeat(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_COPY - opcode 0x37
*
*/
@@ -759,7 +759,7 @@ init_copy(struct nvbios_init *init)
init_wrvgai(init, port, index, data);
}
-/**
+/*
* INIT_NOT - opcode 0x38
*
*/
@@ -771,7 +771,7 @@ init_not(struct nvbios_init *init)
init_exec_inv(init);
}
-/**
+/*
* INIT_IO_FLAG_CONDITION - opcode 0x39
*
*/
@@ -788,7 +788,7 @@ init_io_flag_condition(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_GENERIC_CONDITION - opcode 0x3a
*
*/
@@ -840,7 +840,7 @@ init_generic_condition(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_IO_MASK_OR - opcode 0x3b
*
*/
@@ -859,7 +859,7 @@ init_io_mask_or(struct nvbios_init *init)
init_wrvgai(init, 0x03d4, index, data &= ~(1 << or));
}
-/**
+/*
* INIT_IO_OR - opcode 0x3c
*
*/
@@ -878,7 +878,7 @@ init_io_or(struct nvbios_init *init)
init_wrvgai(init, 0x03d4, index, data | (1 << or));
}
-/**
+/*
* INIT_ANDN_REG - opcode 0x47
*
*/
@@ -895,7 +895,7 @@ init_andn_reg(struct nvbios_init *init)
init_mask(init, reg, mask, 0);
}
-/**
+/*
* INIT_OR_REG - opcode 0x48
*
*/
@@ -912,7 +912,7 @@ init_or_reg(struct nvbios_init *init)
init_mask(init, reg, 0, mask);
}
-/**
+/*
* INIT_INDEX_ADDRESS_LATCHED - opcode 0x49
*
*/
@@ -942,7 +942,7 @@ init_idx_addr_latched(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_IO_RESTRICT_PLL2 - opcode 0x4a
*
*/
@@ -977,7 +977,7 @@ init_io_restrict_pll2(struct nvbios_init *init)
trace("}]\n");
}
-/**
+/*
* INIT_PLL2 - opcode 0x4b
*
*/
@@ -994,7 +994,7 @@ init_pll2(struct nvbios_init *init)
init_prog_pll(init, reg, freq);
}
-/**
+/*
* INIT_I2C_BYTE - opcode 0x4c
*
*/
@@ -1025,7 +1025,7 @@ init_i2c_byte(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_ZM_I2C_BYTE - opcode 0x4d
*
*/
@@ -1051,7 +1051,7 @@ init_zm_i2c_byte(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_ZM_I2C - opcode 0x4e
*
*/
@@ -1085,7 +1085,7 @@ init_zm_i2c(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_TMDS - opcode 0x4f
*
*/
@@ -1111,7 +1111,7 @@ init_tmds(struct nvbios_init *init)
init_wr32(init, reg + 0, addr);
}
-/**
+/*
* INIT_ZM_TMDS_GROUP - opcode 0x50
*
*/
@@ -1138,7 +1138,7 @@ init_zm_tmds_group(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_CR_INDEX_ADDRESS_LATCHED - opcode 0x51
*
*/
@@ -1168,7 +1168,7 @@ init_cr_idx_adr_latch(struct nvbios_init *init)
init_wrvgai(init, 0x03d4, addr0, save0);
}
-/**
+/*
* INIT_CR - opcode 0x52
*
*/
@@ -1188,7 +1188,7 @@ init_cr(struct nvbios_init *init)
init_wrvgai(init, 0x03d4, addr, val | data);
}
-/**
+/*
* INIT_ZM_CR - opcode 0x53
*
*/
@@ -1205,7 +1205,7 @@ init_zm_cr(struct nvbios_init *init)
init_wrvgai(init, 0x03d4, addr, data);
}
-/**
+/*
* INIT_ZM_CR_GROUP - opcode 0x54
*
*/
@@ -1229,7 +1229,7 @@ init_zm_cr_group(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_CONDITION_TIME - opcode 0x56
*
*/
@@ -1256,7 +1256,7 @@ init_condition_time(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_LTIME - opcode 0x57
*
*/
@@ -1273,7 +1273,7 @@ init_ltime(struct nvbios_init *init)
mdelay(msec);
}
-/**
+/*
* INIT_ZM_REG_SEQUENCE - opcode 0x58
*
*/
@@ -1298,7 +1298,7 @@ init_zm_reg_sequence(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_PLL_INDIRECT - opcode 0x59
*
*/
@@ -1317,7 +1317,7 @@ init_pll_indirect(struct nvbios_init *init)
init_prog_pll(init, reg, freq);
}
-/**
+/*
* INIT_ZM_REG_INDIRECT - opcode 0x5a
*
*/
@@ -1336,7 +1336,7 @@ init_zm_reg_indirect(struct nvbios_init *init)
init_wr32(init, addr, data);
}
-/**
+/*
* INIT_SUB_DIRECT - opcode 0x5b
*
*/
@@ -1362,7 +1362,7 @@ init_sub_direct(struct nvbios_init *init)
init->offset += 3;
}
-/**
+/*
* INIT_JUMP - opcode 0x5c
*
*/
@@ -1380,7 +1380,7 @@ init_jump(struct nvbios_init *init)
init->offset += 3;
}
-/**
+/*
* INIT_I2C_IF - opcode 0x5e
*
*/
@@ -1407,7 +1407,7 @@ init_i2c_if(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_COPY_NV_REG - opcode 0x5f
*
*/
@@ -1433,7 +1433,7 @@ init_copy_nv_reg(struct nvbios_init *init)
init_mask(init, dreg, ~dmask, (data & smask) ^ sxor);
}
-/**
+/*
* INIT_ZM_INDEX_IO - opcode 0x62
*
*/
@@ -1451,7 +1451,7 @@ init_zm_index_io(struct nvbios_init *init)
init_wrvgai(init, port, index, data);
}
-/**
+/*
* INIT_COMPUTE_MEM - opcode 0x63
*
*/
@@ -1469,7 +1469,7 @@ init_compute_mem(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_RESET - opcode 0x65
*
*/
@@ -1496,7 +1496,7 @@ init_reset(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_CONFIGURE_MEM - opcode 0x66
*
*/
@@ -1555,7 +1555,7 @@ init_configure_mem(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_CONFIGURE_CLK - opcode 0x67
*
*/
@@ -1589,7 +1589,7 @@ init_configure_clk(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_CONFIGURE_PREINIT - opcode 0x68
*
*/
@@ -1615,7 +1615,7 @@ init_configure_preinit(struct nvbios_init *init)
init_exec_force(init, false);
}
-/**
+/*
* INIT_IO - opcode 0x69
*
*/
@@ -1655,7 +1655,7 @@ init_io(struct nvbios_init *init)
init_wrport(init, port, data | value);
}
-/**
+/*
* INIT_SUB - opcode 0x6b
*
*/
@@ -1682,7 +1682,7 @@ init_sub(struct nvbios_init *init)
init->offset += 2;
}
-/**
+/*
* INIT_RAM_CONDITION - opcode 0x6d
*
*/
@@ -1701,7 +1701,7 @@ init_ram_condition(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_NV_REG - opcode 0x6e
*
*/
@@ -1719,7 +1719,7 @@ init_nv_reg(struct nvbios_init *init)
init_mask(init, reg, ~mask, data);
}
-/**
+/*
* INIT_MACRO - opcode 0x6f
*
*/
@@ -1743,7 +1743,7 @@ init_macro(struct nvbios_init *init)
init->offset += 2;
}
-/**
+/*
* INIT_RESUME - opcode 0x72
*
*/
@@ -1755,7 +1755,7 @@ init_resume(struct nvbios_init *init)
init_exec_set(init, true);
}
-/**
+/*
* INIT_STRAP_CONDITION - opcode 0x73
*
*/
@@ -1773,7 +1773,7 @@ init_strap_condition(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_TIME - opcode 0x74
*
*/
@@ -1794,7 +1794,7 @@ init_time(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_CONDITION - opcode 0x75
*
*/
@@ -1811,7 +1811,7 @@ init_condition(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_IO_CONDITION - opcode 0x76
*
*/
@@ -1828,7 +1828,7 @@ init_io_condition(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_ZM_REG16 - opcode 0x77
*
*/
@@ -1845,7 +1845,7 @@ init_zm_reg16(struct nvbios_init *init)
init_wr32(init, addr, data);
}
-/**
+/*
* INIT_INDEX_IO - opcode 0x78
*
*/
@@ -1867,7 +1867,7 @@ init_index_io(struct nvbios_init *init)
init_wrvgai(init, port, index, data | value);
}
-/**
+/*
* INIT_PLL - opcode 0x79
*
*/
@@ -1884,7 +1884,7 @@ init_pll(struct nvbios_init *init)
init_prog_pll(init, reg, freq);
}
-/**
+/*
* INIT_ZM_REG - opcode 0x7a
*
*/
@@ -1904,7 +1904,7 @@ init_zm_reg(struct nvbios_init *init)
init_wr32(init, addr, data);
}
-/**
+/*
* INIT_RAM_RESTRICT_PLL - opcde 0x87
*
*/
@@ -1934,7 +1934,7 @@ init_ram_restrict_pll(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_RESET_BEGUN - opcode 0x8c
*
*/
@@ -1945,7 +1945,7 @@ init_reset_begun(struct nvbios_init *init)
init->offset += 1;
}
-/**
+/*
* INIT_RESET_END - opcode 0x8d
*
*/
@@ -1956,7 +1956,7 @@ init_reset_end(struct nvbios_init *init)
init->offset += 1;
}
-/**
+/*
* INIT_GPIO - opcode 0x8e
*
*/
@@ -1972,7 +1972,7 @@ init_gpio(struct nvbios_init *init)
nvkm_gpio_reset(gpio, DCB_GPIO_UNUSED);
}
-/**
+/*
* INIT_RAM_RESTRICT_ZM_GROUP - opcode 0x8f
*
*/
@@ -2010,7 +2010,7 @@ init_ram_restrict_zm_reg_group(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_COPY_ZM_REG - opcode 0x90
*
*/
@@ -2027,7 +2027,7 @@ init_copy_zm_reg(struct nvbios_init *init)
init_wr32(init, dreg, init_rd32(init, sreg));
}
-/**
+/*
* INIT_ZM_REG_GROUP - opcode 0x91
*
*/
@@ -2049,7 +2049,7 @@ init_zm_reg_group(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_XLAT - opcode 0x96
*
*/
@@ -2077,7 +2077,7 @@ init_xlat(struct nvbios_init *init)
init_mask(init, daddr, ~dmask, data);
}
-/**
+/*
* INIT_ZM_MASK_ADD - opcode 0x97
*
*/
@@ -2098,7 +2098,7 @@ init_zm_mask_add(struct nvbios_init *init)
init_wr32(init, addr, data);
}
-/**
+/*
* INIT_AUXCH - opcode 0x98
*
*/
@@ -2122,7 +2122,7 @@ init_auxch(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_AUXCH - opcode 0x99
*
*/
@@ -2144,7 +2144,7 @@ init_zm_auxch(struct nvbios_init *init)
}
}
-/**
+/*
* INIT_I2C_LONG_IF - opcode 0x9a
*
*/
@@ -2183,7 +2183,7 @@ init_i2c_long_if(struct nvbios_init *init)
init_exec_set(init, false);
}
-/**
+/*
* INIT_GPIO_NE - opcode 0xa9
*
*/
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* Re: [Nouveau] [PATCH 03/20] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 8:41 ` Karol Herbst
-1 siblings, 0 replies; 159+ messages in thread
From: Karol Herbst @ 2023-08-24 8:41 UTC (permalink / raw)
To: Lee Jones; +Cc: nouveau, linux-kernel, dri-devel, Ben Skeggs, Daniel Vetter
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function parameter or member 'init' not described in 'init_reserved'
> drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: warning: expecting prototype for INIT_DONE(). Prototype was for init_done() instead
> [Snipped ~140 lines for brevity]
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> ---
> .../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++---------
> 1 file changed, 68 insertions(+), 68 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
> index 1420794038642..b54f044c4483b 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
> @@ -575,7 +575,7 @@ init_tmds_reg(struct nvbios_init *init, u8 tmds)
> * init opcode handlers
> *****************************************************************************/
>
> -/**
> +/*
> * init_reserved - stub for various unknown/unused single-byte opcodes
> *
> */
> @@ -602,7 +602,7 @@ init_reserved(struct nvbios_init *init)
> init->offset += length;
> }
>
> -/**
> +/*
> * INIT_DONE - opcode 0x71
> *
> */
> @@ -613,7 +613,7 @@ init_done(struct nvbios_init *init)
> init->offset = 0x0000;
> }
>
> -/**
> +/*
> * INIT_IO_RESTRICT_PROG - opcode 0x32
> *
> */
> @@ -650,7 +650,7 @@ init_io_restrict_prog(struct nvbios_init *init)
> trace("}]\n");
> }
>
> -/**
> +/*
> * INIT_REPEAT - opcode 0x33
> *
> */
> @@ -676,7 +676,7 @@ init_repeat(struct nvbios_init *init)
> init->repeat = repeat;
> }
>
> -/**
> +/*
> * INIT_IO_RESTRICT_PLL - opcode 0x34
> *
> */
> @@ -716,7 +716,7 @@ init_io_restrict_pll(struct nvbios_init *init)
> trace("}]\n");
> }
>
> -/**
> +/*
> * INIT_END_REPEAT - opcode 0x36
> *
> */
> @@ -732,7 +732,7 @@ init_end_repeat(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_COPY - opcode 0x37
> *
> */
> @@ -759,7 +759,7 @@ init_copy(struct nvbios_init *init)
> init_wrvgai(init, port, index, data);
> }
>
> -/**
> +/*
> * INIT_NOT - opcode 0x38
> *
> */
> @@ -771,7 +771,7 @@ init_not(struct nvbios_init *init)
> init_exec_inv(init);
> }
>
> -/**
> +/*
> * INIT_IO_FLAG_CONDITION - opcode 0x39
> *
> */
> @@ -788,7 +788,7 @@ init_io_flag_condition(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_GENERIC_CONDITION - opcode 0x3a
> *
> */
> @@ -840,7 +840,7 @@ init_generic_condition(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_IO_MASK_OR - opcode 0x3b
> *
> */
> @@ -859,7 +859,7 @@ init_io_mask_or(struct nvbios_init *init)
> init_wrvgai(init, 0x03d4, index, data &= ~(1 << or));
> }
>
> -/**
> +/*
> * INIT_IO_OR - opcode 0x3c
> *
> */
> @@ -878,7 +878,7 @@ init_io_or(struct nvbios_init *init)
> init_wrvgai(init, 0x03d4, index, data | (1 << or));
> }
>
> -/**
> +/*
> * INIT_ANDN_REG - opcode 0x47
> *
> */
> @@ -895,7 +895,7 @@ init_andn_reg(struct nvbios_init *init)
> init_mask(init, reg, mask, 0);
> }
>
> -/**
> +/*
> * INIT_OR_REG - opcode 0x48
> *
> */
> @@ -912,7 +912,7 @@ init_or_reg(struct nvbios_init *init)
> init_mask(init, reg, 0, mask);
> }
>
> -/**
> +/*
> * INIT_INDEX_ADDRESS_LATCHED - opcode 0x49
> *
> */
> @@ -942,7 +942,7 @@ init_idx_addr_latched(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_IO_RESTRICT_PLL2 - opcode 0x4a
> *
> */
> @@ -977,7 +977,7 @@ init_io_restrict_pll2(struct nvbios_init *init)
> trace("}]\n");
> }
>
> -/**
> +/*
> * INIT_PLL2 - opcode 0x4b
> *
> */
> @@ -994,7 +994,7 @@ init_pll2(struct nvbios_init *init)
> init_prog_pll(init, reg, freq);
> }
>
> -/**
> +/*
> * INIT_I2C_BYTE - opcode 0x4c
> *
> */
> @@ -1025,7 +1025,7 @@ init_i2c_byte(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_ZM_I2C_BYTE - opcode 0x4d
> *
> */
> @@ -1051,7 +1051,7 @@ init_zm_i2c_byte(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_ZM_I2C - opcode 0x4e
> *
> */
> @@ -1085,7 +1085,7 @@ init_zm_i2c(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_TMDS - opcode 0x4f
> *
> */
> @@ -1111,7 +1111,7 @@ init_tmds(struct nvbios_init *init)
> init_wr32(init, reg + 0, addr);
> }
>
> -/**
> +/*
> * INIT_ZM_TMDS_GROUP - opcode 0x50
> *
> */
> @@ -1138,7 +1138,7 @@ init_zm_tmds_group(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_CR_INDEX_ADDRESS_LATCHED - opcode 0x51
> *
> */
> @@ -1168,7 +1168,7 @@ init_cr_idx_adr_latch(struct nvbios_init *init)
> init_wrvgai(init, 0x03d4, addr0, save0);
> }
>
> -/**
> +/*
> * INIT_CR - opcode 0x52
> *
> */
> @@ -1188,7 +1188,7 @@ init_cr(struct nvbios_init *init)
> init_wrvgai(init, 0x03d4, addr, val | data);
> }
>
> -/**
> +/*
> * INIT_ZM_CR - opcode 0x53
> *
> */
> @@ -1205,7 +1205,7 @@ init_zm_cr(struct nvbios_init *init)
> init_wrvgai(init, 0x03d4, addr, data);
> }
>
> -/**
> +/*
> * INIT_ZM_CR_GROUP - opcode 0x54
> *
> */
> @@ -1229,7 +1229,7 @@ init_zm_cr_group(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_CONDITION_TIME - opcode 0x56
> *
> */
> @@ -1256,7 +1256,7 @@ init_condition_time(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_LTIME - opcode 0x57
> *
> */
> @@ -1273,7 +1273,7 @@ init_ltime(struct nvbios_init *init)
> mdelay(msec);
> }
>
> -/**
> +/*
> * INIT_ZM_REG_SEQUENCE - opcode 0x58
> *
> */
> @@ -1298,7 +1298,7 @@ init_zm_reg_sequence(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_PLL_INDIRECT - opcode 0x59
> *
> */
> @@ -1317,7 +1317,7 @@ init_pll_indirect(struct nvbios_init *init)
> init_prog_pll(init, reg, freq);
> }
>
> -/**
> +/*
> * INIT_ZM_REG_INDIRECT - opcode 0x5a
> *
> */
> @@ -1336,7 +1336,7 @@ init_zm_reg_indirect(struct nvbios_init *init)
> init_wr32(init, addr, data);
> }
>
> -/**
> +/*
> * INIT_SUB_DIRECT - opcode 0x5b
> *
> */
> @@ -1362,7 +1362,7 @@ init_sub_direct(struct nvbios_init *init)
> init->offset += 3;
> }
>
> -/**
> +/*
> * INIT_JUMP - opcode 0x5c
> *
> */
> @@ -1380,7 +1380,7 @@ init_jump(struct nvbios_init *init)
> init->offset += 3;
> }
>
> -/**
> +/*
> * INIT_I2C_IF - opcode 0x5e
> *
> */
> @@ -1407,7 +1407,7 @@ init_i2c_if(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_COPY_NV_REG - opcode 0x5f
> *
> */
> @@ -1433,7 +1433,7 @@ init_copy_nv_reg(struct nvbios_init *init)
> init_mask(init, dreg, ~dmask, (data & smask) ^ sxor);
> }
>
> -/**
> +/*
> * INIT_ZM_INDEX_IO - opcode 0x62
> *
> */
> @@ -1451,7 +1451,7 @@ init_zm_index_io(struct nvbios_init *init)
> init_wrvgai(init, port, index, data);
> }
>
> -/**
> +/*
> * INIT_COMPUTE_MEM - opcode 0x63
> *
> */
> @@ -1469,7 +1469,7 @@ init_compute_mem(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_RESET - opcode 0x65
> *
> */
> @@ -1496,7 +1496,7 @@ init_reset(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_CONFIGURE_MEM - opcode 0x66
> *
> */
> @@ -1555,7 +1555,7 @@ init_configure_mem(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_CONFIGURE_CLK - opcode 0x67
> *
> */
> @@ -1589,7 +1589,7 @@ init_configure_clk(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_CONFIGURE_PREINIT - opcode 0x68
> *
> */
> @@ -1615,7 +1615,7 @@ init_configure_preinit(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_IO - opcode 0x69
> *
> */
> @@ -1655,7 +1655,7 @@ init_io(struct nvbios_init *init)
> init_wrport(init, port, data | value);
> }
>
> -/**
> +/*
> * INIT_SUB - opcode 0x6b
> *
> */
> @@ -1682,7 +1682,7 @@ init_sub(struct nvbios_init *init)
> init->offset += 2;
> }
>
> -/**
> +/*
> * INIT_RAM_CONDITION - opcode 0x6d
> *
> */
> @@ -1701,7 +1701,7 @@ init_ram_condition(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_NV_REG - opcode 0x6e
> *
> */
> @@ -1719,7 +1719,7 @@ init_nv_reg(struct nvbios_init *init)
> init_mask(init, reg, ~mask, data);
> }
>
> -/**
> +/*
> * INIT_MACRO - opcode 0x6f
> *
> */
> @@ -1743,7 +1743,7 @@ init_macro(struct nvbios_init *init)
> init->offset += 2;
> }
>
> -/**
> +/*
> * INIT_RESUME - opcode 0x72
> *
> */
> @@ -1755,7 +1755,7 @@ init_resume(struct nvbios_init *init)
> init_exec_set(init, true);
> }
>
> -/**
> +/*
> * INIT_STRAP_CONDITION - opcode 0x73
> *
> */
> @@ -1773,7 +1773,7 @@ init_strap_condition(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_TIME - opcode 0x74
> *
> */
> @@ -1794,7 +1794,7 @@ init_time(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_CONDITION - opcode 0x75
> *
> */
> @@ -1811,7 +1811,7 @@ init_condition(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_IO_CONDITION - opcode 0x76
> *
> */
> @@ -1828,7 +1828,7 @@ init_io_condition(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_ZM_REG16 - opcode 0x77
> *
> */
> @@ -1845,7 +1845,7 @@ init_zm_reg16(struct nvbios_init *init)
> init_wr32(init, addr, data);
> }
>
> -/**
> +/*
> * INIT_INDEX_IO - opcode 0x78
> *
> */
> @@ -1867,7 +1867,7 @@ init_index_io(struct nvbios_init *init)
> init_wrvgai(init, port, index, data | value);
> }
>
> -/**
> +/*
> * INIT_PLL - opcode 0x79
> *
> */
> @@ -1884,7 +1884,7 @@ init_pll(struct nvbios_init *init)
> init_prog_pll(init, reg, freq);
> }
>
> -/**
> +/*
> * INIT_ZM_REG - opcode 0x7a
> *
> */
> @@ -1904,7 +1904,7 @@ init_zm_reg(struct nvbios_init *init)
> init_wr32(init, addr, data);
> }
>
> -/**
> +/*
> * INIT_RAM_RESTRICT_PLL - opcde 0x87
> *
> */
> @@ -1934,7 +1934,7 @@ init_ram_restrict_pll(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_RESET_BEGUN - opcode 0x8c
> *
> */
> @@ -1945,7 +1945,7 @@ init_reset_begun(struct nvbios_init *init)
> init->offset += 1;
> }
>
> -/**
> +/*
> * INIT_RESET_END - opcode 0x8d
> *
> */
> @@ -1956,7 +1956,7 @@ init_reset_end(struct nvbios_init *init)
> init->offset += 1;
> }
>
> -/**
> +/*
> * INIT_GPIO - opcode 0x8e
> *
> */
> @@ -1972,7 +1972,7 @@ init_gpio(struct nvbios_init *init)
> nvkm_gpio_reset(gpio, DCB_GPIO_UNUSED);
> }
>
> -/**
> +/*
> * INIT_RAM_RESTRICT_ZM_GROUP - opcode 0x8f
> *
> */
> @@ -2010,7 +2010,7 @@ init_ram_restrict_zm_reg_group(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_COPY_ZM_REG - opcode 0x90
> *
> */
> @@ -2027,7 +2027,7 @@ init_copy_zm_reg(struct nvbios_init *init)
> init_wr32(init, dreg, init_rd32(init, sreg));
> }
>
> -/**
> +/*
> * INIT_ZM_REG_GROUP - opcode 0x91
> *
> */
> @@ -2049,7 +2049,7 @@ init_zm_reg_group(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_XLAT - opcode 0x96
> *
> */
> @@ -2077,7 +2077,7 @@ init_xlat(struct nvbios_init *init)
> init_mask(init, daddr, ~dmask, data);
> }
>
> -/**
> +/*
> * INIT_ZM_MASK_ADD - opcode 0x97
> *
> */
> @@ -2098,7 +2098,7 @@ init_zm_mask_add(struct nvbios_init *init)
> init_wr32(init, addr, data);
> }
>
> -/**
> +/*
> * INIT_AUXCH - opcode 0x98
> *
> */
> @@ -2122,7 +2122,7 @@ init_auxch(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_AUXCH - opcode 0x99
> *
> */
> @@ -2144,7 +2144,7 @@ init_zm_auxch(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_I2C_LONG_IF - opcode 0x9a
> *
> */
> @@ -2183,7 +2183,7 @@ init_i2c_long_if(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_GPIO_NE - opcode 0xa9
> *
> */
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 03/20] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses
@ 2023-08-24 8:41 ` Karol Herbst
0 siblings, 0 replies; 159+ messages in thread
From: Karol Herbst @ 2023-08-24 8:41 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Ben Skeggs, Lyude Paul, David Airlie, Daniel Vetter,
dri-devel, nouveau
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function parameter or member 'init' not described in 'init_reserved'
> drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: warning: expecting prototype for INIT_DONE(). Prototype was for init_done() instead
> [Snipped ~140 lines for brevity]
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> ---
> .../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++---------
> 1 file changed, 68 insertions(+), 68 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
> index 1420794038642..b54f044c4483b 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
> @@ -575,7 +575,7 @@ init_tmds_reg(struct nvbios_init *init, u8 tmds)
> * init opcode handlers
> *****************************************************************************/
>
> -/**
> +/*
> * init_reserved - stub for various unknown/unused single-byte opcodes
> *
> */
> @@ -602,7 +602,7 @@ init_reserved(struct nvbios_init *init)
> init->offset += length;
> }
>
> -/**
> +/*
> * INIT_DONE - opcode 0x71
> *
> */
> @@ -613,7 +613,7 @@ init_done(struct nvbios_init *init)
> init->offset = 0x0000;
> }
>
> -/**
> +/*
> * INIT_IO_RESTRICT_PROG - opcode 0x32
> *
> */
> @@ -650,7 +650,7 @@ init_io_restrict_prog(struct nvbios_init *init)
> trace("}]\n");
> }
>
> -/**
> +/*
> * INIT_REPEAT - opcode 0x33
> *
> */
> @@ -676,7 +676,7 @@ init_repeat(struct nvbios_init *init)
> init->repeat = repeat;
> }
>
> -/**
> +/*
> * INIT_IO_RESTRICT_PLL - opcode 0x34
> *
> */
> @@ -716,7 +716,7 @@ init_io_restrict_pll(struct nvbios_init *init)
> trace("}]\n");
> }
>
> -/**
> +/*
> * INIT_END_REPEAT - opcode 0x36
> *
> */
> @@ -732,7 +732,7 @@ init_end_repeat(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_COPY - opcode 0x37
> *
> */
> @@ -759,7 +759,7 @@ init_copy(struct nvbios_init *init)
> init_wrvgai(init, port, index, data);
> }
>
> -/**
> +/*
> * INIT_NOT - opcode 0x38
> *
> */
> @@ -771,7 +771,7 @@ init_not(struct nvbios_init *init)
> init_exec_inv(init);
> }
>
> -/**
> +/*
> * INIT_IO_FLAG_CONDITION - opcode 0x39
> *
> */
> @@ -788,7 +788,7 @@ init_io_flag_condition(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_GENERIC_CONDITION - opcode 0x3a
> *
> */
> @@ -840,7 +840,7 @@ init_generic_condition(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_IO_MASK_OR - opcode 0x3b
> *
> */
> @@ -859,7 +859,7 @@ init_io_mask_or(struct nvbios_init *init)
> init_wrvgai(init, 0x03d4, index, data &= ~(1 << or));
> }
>
> -/**
> +/*
> * INIT_IO_OR - opcode 0x3c
> *
> */
> @@ -878,7 +878,7 @@ init_io_or(struct nvbios_init *init)
> init_wrvgai(init, 0x03d4, index, data | (1 << or));
> }
>
> -/**
> +/*
> * INIT_ANDN_REG - opcode 0x47
> *
> */
> @@ -895,7 +895,7 @@ init_andn_reg(struct nvbios_init *init)
> init_mask(init, reg, mask, 0);
> }
>
> -/**
> +/*
> * INIT_OR_REG - opcode 0x48
> *
> */
> @@ -912,7 +912,7 @@ init_or_reg(struct nvbios_init *init)
> init_mask(init, reg, 0, mask);
> }
>
> -/**
> +/*
> * INIT_INDEX_ADDRESS_LATCHED - opcode 0x49
> *
> */
> @@ -942,7 +942,7 @@ init_idx_addr_latched(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_IO_RESTRICT_PLL2 - opcode 0x4a
> *
> */
> @@ -977,7 +977,7 @@ init_io_restrict_pll2(struct nvbios_init *init)
> trace("}]\n");
> }
>
> -/**
> +/*
> * INIT_PLL2 - opcode 0x4b
> *
> */
> @@ -994,7 +994,7 @@ init_pll2(struct nvbios_init *init)
> init_prog_pll(init, reg, freq);
> }
>
> -/**
> +/*
> * INIT_I2C_BYTE - opcode 0x4c
> *
> */
> @@ -1025,7 +1025,7 @@ init_i2c_byte(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_ZM_I2C_BYTE - opcode 0x4d
> *
> */
> @@ -1051,7 +1051,7 @@ init_zm_i2c_byte(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_ZM_I2C - opcode 0x4e
> *
> */
> @@ -1085,7 +1085,7 @@ init_zm_i2c(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_TMDS - opcode 0x4f
> *
> */
> @@ -1111,7 +1111,7 @@ init_tmds(struct nvbios_init *init)
> init_wr32(init, reg + 0, addr);
> }
>
> -/**
> +/*
> * INIT_ZM_TMDS_GROUP - opcode 0x50
> *
> */
> @@ -1138,7 +1138,7 @@ init_zm_tmds_group(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_CR_INDEX_ADDRESS_LATCHED - opcode 0x51
> *
> */
> @@ -1168,7 +1168,7 @@ init_cr_idx_adr_latch(struct nvbios_init *init)
> init_wrvgai(init, 0x03d4, addr0, save0);
> }
>
> -/**
> +/*
> * INIT_CR - opcode 0x52
> *
> */
> @@ -1188,7 +1188,7 @@ init_cr(struct nvbios_init *init)
> init_wrvgai(init, 0x03d4, addr, val | data);
> }
>
> -/**
> +/*
> * INIT_ZM_CR - opcode 0x53
> *
> */
> @@ -1205,7 +1205,7 @@ init_zm_cr(struct nvbios_init *init)
> init_wrvgai(init, 0x03d4, addr, data);
> }
>
> -/**
> +/*
> * INIT_ZM_CR_GROUP - opcode 0x54
> *
> */
> @@ -1229,7 +1229,7 @@ init_zm_cr_group(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_CONDITION_TIME - opcode 0x56
> *
> */
> @@ -1256,7 +1256,7 @@ init_condition_time(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_LTIME - opcode 0x57
> *
> */
> @@ -1273,7 +1273,7 @@ init_ltime(struct nvbios_init *init)
> mdelay(msec);
> }
>
> -/**
> +/*
> * INIT_ZM_REG_SEQUENCE - opcode 0x58
> *
> */
> @@ -1298,7 +1298,7 @@ init_zm_reg_sequence(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_PLL_INDIRECT - opcode 0x59
> *
> */
> @@ -1317,7 +1317,7 @@ init_pll_indirect(struct nvbios_init *init)
> init_prog_pll(init, reg, freq);
> }
>
> -/**
> +/*
> * INIT_ZM_REG_INDIRECT - opcode 0x5a
> *
> */
> @@ -1336,7 +1336,7 @@ init_zm_reg_indirect(struct nvbios_init *init)
> init_wr32(init, addr, data);
> }
>
> -/**
> +/*
> * INIT_SUB_DIRECT - opcode 0x5b
> *
> */
> @@ -1362,7 +1362,7 @@ init_sub_direct(struct nvbios_init *init)
> init->offset += 3;
> }
>
> -/**
> +/*
> * INIT_JUMP - opcode 0x5c
> *
> */
> @@ -1380,7 +1380,7 @@ init_jump(struct nvbios_init *init)
> init->offset += 3;
> }
>
> -/**
> +/*
> * INIT_I2C_IF - opcode 0x5e
> *
> */
> @@ -1407,7 +1407,7 @@ init_i2c_if(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_COPY_NV_REG - opcode 0x5f
> *
> */
> @@ -1433,7 +1433,7 @@ init_copy_nv_reg(struct nvbios_init *init)
> init_mask(init, dreg, ~dmask, (data & smask) ^ sxor);
> }
>
> -/**
> +/*
> * INIT_ZM_INDEX_IO - opcode 0x62
> *
> */
> @@ -1451,7 +1451,7 @@ init_zm_index_io(struct nvbios_init *init)
> init_wrvgai(init, port, index, data);
> }
>
> -/**
> +/*
> * INIT_COMPUTE_MEM - opcode 0x63
> *
> */
> @@ -1469,7 +1469,7 @@ init_compute_mem(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_RESET - opcode 0x65
> *
> */
> @@ -1496,7 +1496,7 @@ init_reset(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_CONFIGURE_MEM - opcode 0x66
> *
> */
> @@ -1555,7 +1555,7 @@ init_configure_mem(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_CONFIGURE_CLK - opcode 0x67
> *
> */
> @@ -1589,7 +1589,7 @@ init_configure_clk(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_CONFIGURE_PREINIT - opcode 0x68
> *
> */
> @@ -1615,7 +1615,7 @@ init_configure_preinit(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_IO - opcode 0x69
> *
> */
> @@ -1655,7 +1655,7 @@ init_io(struct nvbios_init *init)
> init_wrport(init, port, data | value);
> }
>
> -/**
> +/*
> * INIT_SUB - opcode 0x6b
> *
> */
> @@ -1682,7 +1682,7 @@ init_sub(struct nvbios_init *init)
> init->offset += 2;
> }
>
> -/**
> +/*
> * INIT_RAM_CONDITION - opcode 0x6d
> *
> */
> @@ -1701,7 +1701,7 @@ init_ram_condition(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_NV_REG - opcode 0x6e
> *
> */
> @@ -1719,7 +1719,7 @@ init_nv_reg(struct nvbios_init *init)
> init_mask(init, reg, ~mask, data);
> }
>
> -/**
> +/*
> * INIT_MACRO - opcode 0x6f
> *
> */
> @@ -1743,7 +1743,7 @@ init_macro(struct nvbios_init *init)
> init->offset += 2;
> }
>
> -/**
> +/*
> * INIT_RESUME - opcode 0x72
> *
> */
> @@ -1755,7 +1755,7 @@ init_resume(struct nvbios_init *init)
> init_exec_set(init, true);
> }
>
> -/**
> +/*
> * INIT_STRAP_CONDITION - opcode 0x73
> *
> */
> @@ -1773,7 +1773,7 @@ init_strap_condition(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_TIME - opcode 0x74
> *
> */
> @@ -1794,7 +1794,7 @@ init_time(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_CONDITION - opcode 0x75
> *
> */
> @@ -1811,7 +1811,7 @@ init_condition(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_IO_CONDITION - opcode 0x76
> *
> */
> @@ -1828,7 +1828,7 @@ init_io_condition(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_ZM_REG16 - opcode 0x77
> *
> */
> @@ -1845,7 +1845,7 @@ init_zm_reg16(struct nvbios_init *init)
> init_wr32(init, addr, data);
> }
>
> -/**
> +/*
> * INIT_INDEX_IO - opcode 0x78
> *
> */
> @@ -1867,7 +1867,7 @@ init_index_io(struct nvbios_init *init)
> init_wrvgai(init, port, index, data | value);
> }
>
> -/**
> +/*
> * INIT_PLL - opcode 0x79
> *
> */
> @@ -1884,7 +1884,7 @@ init_pll(struct nvbios_init *init)
> init_prog_pll(init, reg, freq);
> }
>
> -/**
> +/*
> * INIT_ZM_REG - opcode 0x7a
> *
> */
> @@ -1904,7 +1904,7 @@ init_zm_reg(struct nvbios_init *init)
> init_wr32(init, addr, data);
> }
>
> -/**
> +/*
> * INIT_RAM_RESTRICT_PLL - opcde 0x87
> *
> */
> @@ -1934,7 +1934,7 @@ init_ram_restrict_pll(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_RESET_BEGUN - opcode 0x8c
> *
> */
> @@ -1945,7 +1945,7 @@ init_reset_begun(struct nvbios_init *init)
> init->offset += 1;
> }
>
> -/**
> +/*
> * INIT_RESET_END - opcode 0x8d
> *
> */
> @@ -1956,7 +1956,7 @@ init_reset_end(struct nvbios_init *init)
> init->offset += 1;
> }
>
> -/**
> +/*
> * INIT_GPIO - opcode 0x8e
> *
> */
> @@ -1972,7 +1972,7 @@ init_gpio(struct nvbios_init *init)
> nvkm_gpio_reset(gpio, DCB_GPIO_UNUSED);
> }
>
> -/**
> +/*
> * INIT_RAM_RESTRICT_ZM_GROUP - opcode 0x8f
> *
> */
> @@ -2010,7 +2010,7 @@ init_ram_restrict_zm_reg_group(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_COPY_ZM_REG - opcode 0x90
> *
> */
> @@ -2027,7 +2027,7 @@ init_copy_zm_reg(struct nvbios_init *init)
> init_wr32(init, dreg, init_rd32(init, sreg));
> }
>
> -/**
> +/*
> * INIT_ZM_REG_GROUP - opcode 0x91
> *
> */
> @@ -2049,7 +2049,7 @@ init_zm_reg_group(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_XLAT - opcode 0x96
> *
> */
> @@ -2077,7 +2077,7 @@ init_xlat(struct nvbios_init *init)
> init_mask(init, daddr, ~dmask, data);
> }
>
> -/**
> +/*
> * INIT_ZM_MASK_ADD - opcode 0x97
> *
> */
> @@ -2098,7 +2098,7 @@ init_zm_mask_add(struct nvbios_init *init)
> init_wr32(init, addr, data);
> }
>
> -/**
> +/*
> * INIT_AUXCH - opcode 0x98
> *
> */
> @@ -2122,7 +2122,7 @@ init_auxch(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_AUXCH - opcode 0x99
> *
> */
> @@ -2144,7 +2144,7 @@ init_zm_auxch(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_I2C_LONG_IF - opcode 0x9a
> *
> */
> @@ -2183,7 +2183,7 @@ init_i2c_long_if(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_GPIO_NE - opcode 0xa9
> *
> */
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 03/20] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses
@ 2023-08-24 8:41 ` Karol Herbst
0 siblings, 0 replies; 159+ messages in thread
From: Karol Herbst @ 2023-08-24 8:41 UTC (permalink / raw)
To: Lee Jones; +Cc: nouveau, linux-kernel, dri-devel, Ben Skeggs
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function parameter or member 'init' not described in 'init_reserved'
> drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: warning: expecting prototype for INIT_DONE(). Prototype was for init_done() instead
> [Snipped ~140 lines for brevity]
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> ---
> .../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++---------
> 1 file changed, 68 insertions(+), 68 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
> index 1420794038642..b54f044c4483b 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
> @@ -575,7 +575,7 @@ init_tmds_reg(struct nvbios_init *init, u8 tmds)
> * init opcode handlers
> *****************************************************************************/
>
> -/**
> +/*
> * init_reserved - stub for various unknown/unused single-byte opcodes
> *
> */
> @@ -602,7 +602,7 @@ init_reserved(struct nvbios_init *init)
> init->offset += length;
> }
>
> -/**
> +/*
> * INIT_DONE - opcode 0x71
> *
> */
> @@ -613,7 +613,7 @@ init_done(struct nvbios_init *init)
> init->offset = 0x0000;
> }
>
> -/**
> +/*
> * INIT_IO_RESTRICT_PROG - opcode 0x32
> *
> */
> @@ -650,7 +650,7 @@ init_io_restrict_prog(struct nvbios_init *init)
> trace("}]\n");
> }
>
> -/**
> +/*
> * INIT_REPEAT - opcode 0x33
> *
> */
> @@ -676,7 +676,7 @@ init_repeat(struct nvbios_init *init)
> init->repeat = repeat;
> }
>
> -/**
> +/*
> * INIT_IO_RESTRICT_PLL - opcode 0x34
> *
> */
> @@ -716,7 +716,7 @@ init_io_restrict_pll(struct nvbios_init *init)
> trace("}]\n");
> }
>
> -/**
> +/*
> * INIT_END_REPEAT - opcode 0x36
> *
> */
> @@ -732,7 +732,7 @@ init_end_repeat(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_COPY - opcode 0x37
> *
> */
> @@ -759,7 +759,7 @@ init_copy(struct nvbios_init *init)
> init_wrvgai(init, port, index, data);
> }
>
> -/**
> +/*
> * INIT_NOT - opcode 0x38
> *
> */
> @@ -771,7 +771,7 @@ init_not(struct nvbios_init *init)
> init_exec_inv(init);
> }
>
> -/**
> +/*
> * INIT_IO_FLAG_CONDITION - opcode 0x39
> *
> */
> @@ -788,7 +788,7 @@ init_io_flag_condition(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_GENERIC_CONDITION - opcode 0x3a
> *
> */
> @@ -840,7 +840,7 @@ init_generic_condition(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_IO_MASK_OR - opcode 0x3b
> *
> */
> @@ -859,7 +859,7 @@ init_io_mask_or(struct nvbios_init *init)
> init_wrvgai(init, 0x03d4, index, data &= ~(1 << or));
> }
>
> -/**
> +/*
> * INIT_IO_OR - opcode 0x3c
> *
> */
> @@ -878,7 +878,7 @@ init_io_or(struct nvbios_init *init)
> init_wrvgai(init, 0x03d4, index, data | (1 << or));
> }
>
> -/**
> +/*
> * INIT_ANDN_REG - opcode 0x47
> *
> */
> @@ -895,7 +895,7 @@ init_andn_reg(struct nvbios_init *init)
> init_mask(init, reg, mask, 0);
> }
>
> -/**
> +/*
> * INIT_OR_REG - opcode 0x48
> *
> */
> @@ -912,7 +912,7 @@ init_or_reg(struct nvbios_init *init)
> init_mask(init, reg, 0, mask);
> }
>
> -/**
> +/*
> * INIT_INDEX_ADDRESS_LATCHED - opcode 0x49
> *
> */
> @@ -942,7 +942,7 @@ init_idx_addr_latched(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_IO_RESTRICT_PLL2 - opcode 0x4a
> *
> */
> @@ -977,7 +977,7 @@ init_io_restrict_pll2(struct nvbios_init *init)
> trace("}]\n");
> }
>
> -/**
> +/*
> * INIT_PLL2 - opcode 0x4b
> *
> */
> @@ -994,7 +994,7 @@ init_pll2(struct nvbios_init *init)
> init_prog_pll(init, reg, freq);
> }
>
> -/**
> +/*
> * INIT_I2C_BYTE - opcode 0x4c
> *
> */
> @@ -1025,7 +1025,7 @@ init_i2c_byte(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_ZM_I2C_BYTE - opcode 0x4d
> *
> */
> @@ -1051,7 +1051,7 @@ init_zm_i2c_byte(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_ZM_I2C - opcode 0x4e
> *
> */
> @@ -1085,7 +1085,7 @@ init_zm_i2c(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_TMDS - opcode 0x4f
> *
> */
> @@ -1111,7 +1111,7 @@ init_tmds(struct nvbios_init *init)
> init_wr32(init, reg + 0, addr);
> }
>
> -/**
> +/*
> * INIT_ZM_TMDS_GROUP - opcode 0x50
> *
> */
> @@ -1138,7 +1138,7 @@ init_zm_tmds_group(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_CR_INDEX_ADDRESS_LATCHED - opcode 0x51
> *
> */
> @@ -1168,7 +1168,7 @@ init_cr_idx_adr_latch(struct nvbios_init *init)
> init_wrvgai(init, 0x03d4, addr0, save0);
> }
>
> -/**
> +/*
> * INIT_CR - opcode 0x52
> *
> */
> @@ -1188,7 +1188,7 @@ init_cr(struct nvbios_init *init)
> init_wrvgai(init, 0x03d4, addr, val | data);
> }
>
> -/**
> +/*
> * INIT_ZM_CR - opcode 0x53
> *
> */
> @@ -1205,7 +1205,7 @@ init_zm_cr(struct nvbios_init *init)
> init_wrvgai(init, 0x03d4, addr, data);
> }
>
> -/**
> +/*
> * INIT_ZM_CR_GROUP - opcode 0x54
> *
> */
> @@ -1229,7 +1229,7 @@ init_zm_cr_group(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_CONDITION_TIME - opcode 0x56
> *
> */
> @@ -1256,7 +1256,7 @@ init_condition_time(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_LTIME - opcode 0x57
> *
> */
> @@ -1273,7 +1273,7 @@ init_ltime(struct nvbios_init *init)
> mdelay(msec);
> }
>
> -/**
> +/*
> * INIT_ZM_REG_SEQUENCE - opcode 0x58
> *
> */
> @@ -1298,7 +1298,7 @@ init_zm_reg_sequence(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_PLL_INDIRECT - opcode 0x59
> *
> */
> @@ -1317,7 +1317,7 @@ init_pll_indirect(struct nvbios_init *init)
> init_prog_pll(init, reg, freq);
> }
>
> -/**
> +/*
> * INIT_ZM_REG_INDIRECT - opcode 0x5a
> *
> */
> @@ -1336,7 +1336,7 @@ init_zm_reg_indirect(struct nvbios_init *init)
> init_wr32(init, addr, data);
> }
>
> -/**
> +/*
> * INIT_SUB_DIRECT - opcode 0x5b
> *
> */
> @@ -1362,7 +1362,7 @@ init_sub_direct(struct nvbios_init *init)
> init->offset += 3;
> }
>
> -/**
> +/*
> * INIT_JUMP - opcode 0x5c
> *
> */
> @@ -1380,7 +1380,7 @@ init_jump(struct nvbios_init *init)
> init->offset += 3;
> }
>
> -/**
> +/*
> * INIT_I2C_IF - opcode 0x5e
> *
> */
> @@ -1407,7 +1407,7 @@ init_i2c_if(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_COPY_NV_REG - opcode 0x5f
> *
> */
> @@ -1433,7 +1433,7 @@ init_copy_nv_reg(struct nvbios_init *init)
> init_mask(init, dreg, ~dmask, (data & smask) ^ sxor);
> }
>
> -/**
> +/*
> * INIT_ZM_INDEX_IO - opcode 0x62
> *
> */
> @@ -1451,7 +1451,7 @@ init_zm_index_io(struct nvbios_init *init)
> init_wrvgai(init, port, index, data);
> }
>
> -/**
> +/*
> * INIT_COMPUTE_MEM - opcode 0x63
> *
> */
> @@ -1469,7 +1469,7 @@ init_compute_mem(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_RESET - opcode 0x65
> *
> */
> @@ -1496,7 +1496,7 @@ init_reset(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_CONFIGURE_MEM - opcode 0x66
> *
> */
> @@ -1555,7 +1555,7 @@ init_configure_mem(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_CONFIGURE_CLK - opcode 0x67
> *
> */
> @@ -1589,7 +1589,7 @@ init_configure_clk(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_CONFIGURE_PREINIT - opcode 0x68
> *
> */
> @@ -1615,7 +1615,7 @@ init_configure_preinit(struct nvbios_init *init)
> init_exec_force(init, false);
> }
>
> -/**
> +/*
> * INIT_IO - opcode 0x69
> *
> */
> @@ -1655,7 +1655,7 @@ init_io(struct nvbios_init *init)
> init_wrport(init, port, data | value);
> }
>
> -/**
> +/*
> * INIT_SUB - opcode 0x6b
> *
> */
> @@ -1682,7 +1682,7 @@ init_sub(struct nvbios_init *init)
> init->offset += 2;
> }
>
> -/**
> +/*
> * INIT_RAM_CONDITION - opcode 0x6d
> *
> */
> @@ -1701,7 +1701,7 @@ init_ram_condition(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_NV_REG - opcode 0x6e
> *
> */
> @@ -1719,7 +1719,7 @@ init_nv_reg(struct nvbios_init *init)
> init_mask(init, reg, ~mask, data);
> }
>
> -/**
> +/*
> * INIT_MACRO - opcode 0x6f
> *
> */
> @@ -1743,7 +1743,7 @@ init_macro(struct nvbios_init *init)
> init->offset += 2;
> }
>
> -/**
> +/*
> * INIT_RESUME - opcode 0x72
> *
> */
> @@ -1755,7 +1755,7 @@ init_resume(struct nvbios_init *init)
> init_exec_set(init, true);
> }
>
> -/**
> +/*
> * INIT_STRAP_CONDITION - opcode 0x73
> *
> */
> @@ -1773,7 +1773,7 @@ init_strap_condition(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_TIME - opcode 0x74
> *
> */
> @@ -1794,7 +1794,7 @@ init_time(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_CONDITION - opcode 0x75
> *
> */
> @@ -1811,7 +1811,7 @@ init_condition(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_IO_CONDITION - opcode 0x76
> *
> */
> @@ -1828,7 +1828,7 @@ init_io_condition(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_ZM_REG16 - opcode 0x77
> *
> */
> @@ -1845,7 +1845,7 @@ init_zm_reg16(struct nvbios_init *init)
> init_wr32(init, addr, data);
> }
>
> -/**
> +/*
> * INIT_INDEX_IO - opcode 0x78
> *
> */
> @@ -1867,7 +1867,7 @@ init_index_io(struct nvbios_init *init)
> init_wrvgai(init, port, index, data | value);
> }
>
> -/**
> +/*
> * INIT_PLL - opcode 0x79
> *
> */
> @@ -1884,7 +1884,7 @@ init_pll(struct nvbios_init *init)
> init_prog_pll(init, reg, freq);
> }
>
> -/**
> +/*
> * INIT_ZM_REG - opcode 0x7a
> *
> */
> @@ -1904,7 +1904,7 @@ init_zm_reg(struct nvbios_init *init)
> init_wr32(init, addr, data);
> }
>
> -/**
> +/*
> * INIT_RAM_RESTRICT_PLL - opcde 0x87
> *
> */
> @@ -1934,7 +1934,7 @@ init_ram_restrict_pll(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_RESET_BEGUN - opcode 0x8c
> *
> */
> @@ -1945,7 +1945,7 @@ init_reset_begun(struct nvbios_init *init)
> init->offset += 1;
> }
>
> -/**
> +/*
> * INIT_RESET_END - opcode 0x8d
> *
> */
> @@ -1956,7 +1956,7 @@ init_reset_end(struct nvbios_init *init)
> init->offset += 1;
> }
>
> -/**
> +/*
> * INIT_GPIO - opcode 0x8e
> *
> */
> @@ -1972,7 +1972,7 @@ init_gpio(struct nvbios_init *init)
> nvkm_gpio_reset(gpio, DCB_GPIO_UNUSED);
> }
>
> -/**
> +/*
> * INIT_RAM_RESTRICT_ZM_GROUP - opcode 0x8f
> *
> */
> @@ -2010,7 +2010,7 @@ init_ram_restrict_zm_reg_group(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_COPY_ZM_REG - opcode 0x90
> *
> */
> @@ -2027,7 +2027,7 @@ init_copy_zm_reg(struct nvbios_init *init)
> init_wr32(init, dreg, init_rd32(init, sreg));
> }
>
> -/**
> +/*
> * INIT_ZM_REG_GROUP - opcode 0x91
> *
> */
> @@ -2049,7 +2049,7 @@ init_zm_reg_group(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_XLAT - opcode 0x96
> *
> */
> @@ -2077,7 +2077,7 @@ init_xlat(struct nvbios_init *init)
> init_mask(init, daddr, ~dmask, data);
> }
>
> -/**
> +/*
> * INIT_ZM_MASK_ADD - opcode 0x97
> *
> */
> @@ -2098,7 +2098,7 @@ init_zm_mask_add(struct nvbios_init *init)
> init_wr32(init, addr, data);
> }
>
> -/**
> +/*
> * INIT_AUXCH - opcode 0x98
> *
> */
> @@ -2122,7 +2122,7 @@ init_auxch(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_AUXCH - opcode 0x99
> *
> */
> @@ -2144,7 +2144,7 @@ init_zm_auxch(struct nvbios_init *init)
> }
> }
>
> -/**
> +/*
> * INIT_I2C_LONG_IF - opcode 0x9a
> *
> */
> @@ -2183,7 +2183,7 @@ init_i2c_long_if(struct nvbios_init *init)
> init_exec_set(init, false);
> }
>
> -/**
> +/*
> * INIT_GPIO_NE - opcode 0xa9
> *
> */
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
^ permalink raw reply [flat|nested] 159+ messages in thread
* [Nouveau] [PATCH 04/20] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 7:36 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee; +Cc: nouveau, linux-kernel, dri-devel, Ben Skeggs, Daniel Vetter
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:49: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:62: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
---
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
index 8c2faa9645111..ccac88da88648 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
@@ -45,7 +45,7 @@ static const struct cvb_coef gk20a_cvb_coef[] = {
/* 852 */ { 1608418, -21643, -269, 0, 763, -48},
};
-/**
+/*
* cvb_mv = ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0)
*/
static inline int
@@ -58,7 +58,7 @@ gk20a_volt_get_cvb_voltage(int speedo, int s_scale, const struct cvb_coef *coef)
return mv;
}
-/**
+/*
* cvb_t_mv =
* ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0) +
* ((c3 * speedo / s_scale + c4 + c5 * T / t_scale) * T / t_scale)
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* [PATCH 04/20] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Ben Skeggs, Karol Herbst, Lyude Paul, David Airlie,
Daniel Vetter, dri-devel, nouveau
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:49: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:62: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
---
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
index 8c2faa9645111..ccac88da88648 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
@@ -45,7 +45,7 @@ static const struct cvb_coef gk20a_cvb_coef[] = {
/* 852 */ { 1608418, -21643, -269, 0, 763, -48},
};
-/**
+/*
* cvb_mv = ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0)
*/
static inline int
@@ -58,7 +58,7 @@ gk20a_volt_get_cvb_voltage(int speedo, int s_scale, const struct cvb_coef *coef)
return mv;
}
-/**
+/*
* cvb_t_mv =
* ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0) +
* ((c3 * speedo / s_scale + c4 + c5 * T / t_scale) * T / t_scale)
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* [PATCH 04/20] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee; +Cc: Karol Herbst, nouveau, linux-kernel, dri-devel, Ben Skeggs
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:49: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:62: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
---
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
index 8c2faa9645111..ccac88da88648 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
@@ -45,7 +45,7 @@ static const struct cvb_coef gk20a_cvb_coef[] = {
/* 852 */ { 1608418, -21643, -269, 0, 763, -48},
};
-/**
+/*
* cvb_mv = ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0)
*/
static inline int
@@ -58,7 +58,7 @@ gk20a_volt_get_cvb_voltage(int speedo, int s_scale, const struct cvb_coef *coef)
return mv;
}
-/**
+/*
* cvb_t_mv =
* ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0) +
* ((c3 * speedo / s_scale + c4 + c5 * T / t_scale) * T / t_scale)
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* Re: [Nouveau] [PATCH 04/20] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 8:41 ` Karol Herbst
-1 siblings, 0 replies; 159+ messages in thread
From: Karol Herbst @ 2023-08-24 8:41 UTC (permalink / raw)
To: Lee Jones; +Cc: nouveau, linux-kernel, dri-devel, Ben Skeggs, Daniel Vetter
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:49: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:62: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> ---
> drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
> index 8c2faa9645111..ccac88da88648 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
> @@ -45,7 +45,7 @@ static const struct cvb_coef gk20a_cvb_coef[] = {
> /* 852 */ { 1608418, -21643, -269, 0, 763, -48},
> };
>
> -/**
> +/*
> * cvb_mv = ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0)
> */
> static inline int
> @@ -58,7 +58,7 @@ gk20a_volt_get_cvb_voltage(int speedo, int s_scale, const struct cvb_coef *coef)
> return mv;
> }
>
> -/**
> +/*
> * cvb_t_mv =
> * ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0) +
> * ((c3 * speedo / s_scale + c4 + c5 * T / t_scale) * T / t_scale)
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 04/20] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses
@ 2023-08-24 8:41 ` Karol Herbst
0 siblings, 0 replies; 159+ messages in thread
From: Karol Herbst @ 2023-08-24 8:41 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Ben Skeggs, Lyude Paul, David Airlie, Daniel Vetter,
dri-devel, nouveau
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:49: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:62: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> ---
> drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
> index 8c2faa9645111..ccac88da88648 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
> @@ -45,7 +45,7 @@ static const struct cvb_coef gk20a_cvb_coef[] = {
> /* 852 */ { 1608418, -21643, -269, 0, 763, -48},
> };
>
> -/**
> +/*
> * cvb_mv = ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0)
> */
> static inline int
> @@ -58,7 +58,7 @@ gk20a_volt_get_cvb_voltage(int speedo, int s_scale, const struct cvb_coef *coef)
> return mv;
> }
>
> -/**
> +/*
> * cvb_t_mv =
> * ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0) +
> * ((c3 * speedo / s_scale + c4 + c5 * T / t_scale) * T / t_scale)
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 04/20] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses
@ 2023-08-24 8:41 ` Karol Herbst
0 siblings, 0 replies; 159+ messages in thread
From: Karol Herbst @ 2023-08-24 8:41 UTC (permalink / raw)
To: Lee Jones; +Cc: nouveau, linux-kernel, dri-devel, Ben Skeggs
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:49: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:62: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> ---
> drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
> index 8c2faa9645111..ccac88da88648 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c
> @@ -45,7 +45,7 @@ static const struct cvb_coef gk20a_cvb_coef[] = {
> /* 852 */ { 1608418, -21643, -269, 0, 763, -48},
> };
>
> -/**
> +/*
> * cvb_mv = ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0)
> */
> static inline int
> @@ -58,7 +58,7 @@ gk20a_volt_get_cvb_voltage(int speedo, int s_scale, const struct cvb_coef *coef)
> return mv;
> }
>
> -/**
> +/*
> * cvb_t_mv =
> * ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0) +
> * ((c3 * speedo / s_scale + c4 + c5 * T / t_scale) * T / t_scale)
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
^ permalink raw reply [flat|nested] 159+ messages in thread
* [Nouveau] [PATCH 05/20] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 7:36 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee; +Cc: nouveau, linux-kernel, dri-devel, Ben Skeggs, Daniel Vetter
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1044: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
index 3648868bb9fc5..788b1773c46a7 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
@@ -1040,7 +1040,7 @@ gf100_gr_zbc_init(struct gf100_gr *gr)
}
}
-/**
+/*
* Wait until GR goes idle. GR is considered idle if it is disabled by the
* MC (0x200) register, or GR is not busy and a context switch is not in
* progress.
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 05/20] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Ben Skeggs, Karol Herbst, Lyude Paul, David Airlie,
Daniel Vetter, dri-devel, nouveau
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1044: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
index 3648868bb9fc5..788b1773c46a7 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
@@ -1040,7 +1040,7 @@ gf100_gr_zbc_init(struct gf100_gr *gr)
}
}
-/**
+/*
* Wait until GR goes idle. GR is considered idle if it is disabled by the
* MC (0x200) register, or GR is not busy and a context switch is not in
* progress.
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 05/20] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee; +Cc: Karol Herbst, nouveau, linux-kernel, dri-devel, Ben Skeggs
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1044: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
index 3648868bb9fc5..788b1773c46a7 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
@@ -1040,7 +1040,7 @@ gf100_gr_zbc_init(struct gf100_gr *gr)
}
}
-/**
+/*
* Wait until GR goes idle. GR is considered idle if it is disabled by the
* MC (0x200) register, or GR is not busy and a context switch is not in
* progress.
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* Re: [Nouveau] [PATCH 05/20] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 8:41 ` Karol Herbst
-1 siblings, 0 replies; 159+ messages in thread
From: Karol Herbst @ 2023-08-24 8:41 UTC (permalink / raw)
To: Lee Jones; +Cc: nouveau, linux-kernel, dri-devel, Ben Skeggs, Daniel Vetter
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1044: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
> index 3648868bb9fc5..788b1773c46a7 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
> @@ -1040,7 +1040,7 @@ gf100_gr_zbc_init(struct gf100_gr *gr)
> }
> }
>
> -/**
> +/*
> * Wait until GR goes idle. GR is considered idle if it is disabled by the
> * MC (0x200) register, or GR is not busy and a context switch is not in
> * progress.
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH 05/20] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse
@ 2023-08-24 8:41 ` Karol Herbst
0 siblings, 0 replies; 159+ messages in thread
From: Karol Herbst @ 2023-08-24 8:41 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Ben Skeggs, Lyude Paul, David Airlie, Daniel Vetter,
dri-devel, nouveau
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1044: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
> index 3648868bb9fc5..788b1773c46a7 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
> @@ -1040,7 +1040,7 @@ gf100_gr_zbc_init(struct gf100_gr *gr)
> }
> }
>
> -/**
> +/*
> * Wait until GR goes idle. GR is considered idle if it is disabled by the
> * MC (0x200) register, or GR is not busy and a context switch is not in
> * progress.
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH 05/20] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse
@ 2023-08-24 8:41 ` Karol Herbst
0 siblings, 0 replies; 159+ messages in thread
From: Karol Herbst @ 2023-08-24 8:41 UTC (permalink / raw)
To: Lee Jones; +Cc: nouveau, linux-kernel, dri-devel, Ben Skeggs
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1044: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
> index 3648868bb9fc5..788b1773c46a7 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
> @@ -1040,7 +1040,7 @@ gf100_gr_zbc_init(struct gf100_gr *gr)
> }
> }
>
> -/**
> +/*
> * Wait until GR goes idle. GR is considered idle if it is disabled by the
> * MC (0x200) register, or GR is not busy and a context switch is not in
> * progress.
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
^ permalink raw reply [flat|nested] 159+ messages in thread
* [Nouveau] [PATCH 06/20] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 7:36 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee; +Cc: nouveau, linux-kernel, dri-devel, Ben Skeggs, Daniel Vetter
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
---
drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/crtc.c b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
index a34924523133c..5454dbb669566 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/crtc.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
@@ -449,7 +449,7 @@ nv_crtc_mode_set_vga(struct drm_crtc *crtc, struct drm_display_mode *mode)
regp->Attribute[NV_CIO_AR_CSEL_INDEX] = 0x00;
}
-/**
+/*
* Sets up registers for the given mode/adjusted_mode pair.
*
* The clocks, CRTCs and outputs attached to this CRTC must be off.
@@ -625,7 +625,7 @@ nv_crtc_swap_fbs(struct drm_crtc *crtc, struct drm_framebuffer *old_fb)
return ret;
}
-/**
+/*
* Sets up registers for the given mode/adjusted_mode pair.
*
* The clocks, CRTCs and outputs attached to this CRTC must be off.
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 06/20] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Ben Skeggs, Karol Herbst, Lyude Paul, David Airlie,
Daniel Vetter, dri-devel, nouveau
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
---
drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/crtc.c b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
index a34924523133c..5454dbb669566 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/crtc.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
@@ -449,7 +449,7 @@ nv_crtc_mode_set_vga(struct drm_crtc *crtc, struct drm_display_mode *mode)
regp->Attribute[NV_CIO_AR_CSEL_INDEX] = 0x00;
}
-/**
+/*
* Sets up registers for the given mode/adjusted_mode pair.
*
* The clocks, CRTCs and outputs attached to this CRTC must be off.
@@ -625,7 +625,7 @@ nv_crtc_swap_fbs(struct drm_crtc *crtc, struct drm_framebuffer *old_fb)
return ret;
}
-/**
+/*
* Sets up registers for the given mode/adjusted_mode pair.
*
* The clocks, CRTCs and outputs attached to this CRTC must be off.
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 06/20] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee; +Cc: Karol Herbst, nouveau, linux-kernel, dri-devel, Ben Skeggs
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
---
drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/crtc.c b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
index a34924523133c..5454dbb669566 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/crtc.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
@@ -449,7 +449,7 @@ nv_crtc_mode_set_vga(struct drm_crtc *crtc, struct drm_display_mode *mode)
regp->Attribute[NV_CIO_AR_CSEL_INDEX] = 0x00;
}
-/**
+/*
* Sets up registers for the given mode/adjusted_mode pair.
*
* The clocks, CRTCs and outputs attached to this CRTC must be off.
@@ -625,7 +625,7 @@ nv_crtc_swap_fbs(struct drm_crtc *crtc, struct drm_framebuffer *old_fb)
return ret;
}
-/**
+/*
* Sets up registers for the given mode/adjusted_mode pair.
*
* The clocks, CRTCs and outputs attached to this CRTC must be off.
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* Re: [Nouveau] [PATCH 06/20] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 8:42 ` Karol Herbst
-1 siblings, 0 replies; 159+ messages in thread
From: Karol Herbst @ 2023-08-24 8:42 UTC (permalink / raw)
To: Lee Jones; +Cc: nouveau, linux-kernel, dri-devel, Ben Skeggs, Daniel Vetter
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> drivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> ---
> drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv04/crtc.c b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
> index a34924523133c..5454dbb669566 100644
> --- a/drivers/gpu/drm/nouveau/dispnv04/crtc.c
> +++ b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
> @@ -449,7 +449,7 @@ nv_crtc_mode_set_vga(struct drm_crtc *crtc, struct drm_display_mode *mode)
> regp->Attribute[NV_CIO_AR_CSEL_INDEX] = 0x00;
> }
>
> -/**
> +/*
> * Sets up registers for the given mode/adjusted_mode pair.
> *
> * The clocks, CRTCs and outputs attached to this CRTC must be off.
> @@ -625,7 +625,7 @@ nv_crtc_swap_fbs(struct drm_crtc *crtc, struct drm_framebuffer *old_fb)
> return ret;
> }
>
> -/**
> +/*
> * Sets up registers for the given mode/adjusted_mode pair.
> *
> * The clocks, CRTCs and outputs attached to this CRTC must be off.
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH 06/20] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses
@ 2023-08-24 8:42 ` Karol Herbst
0 siblings, 0 replies; 159+ messages in thread
From: Karol Herbst @ 2023-08-24 8:42 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Ben Skeggs, Lyude Paul, David Airlie, Daniel Vetter,
dri-devel, nouveau
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> drivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> ---
> drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv04/crtc.c b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
> index a34924523133c..5454dbb669566 100644
> --- a/drivers/gpu/drm/nouveau/dispnv04/crtc.c
> +++ b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
> @@ -449,7 +449,7 @@ nv_crtc_mode_set_vga(struct drm_crtc *crtc, struct drm_display_mode *mode)
> regp->Attribute[NV_CIO_AR_CSEL_INDEX] = 0x00;
> }
>
> -/**
> +/*
> * Sets up registers for the given mode/adjusted_mode pair.
> *
> * The clocks, CRTCs and outputs attached to this CRTC must be off.
> @@ -625,7 +625,7 @@ nv_crtc_swap_fbs(struct drm_crtc *crtc, struct drm_framebuffer *old_fb)
> return ret;
> }
>
> -/**
> +/*
> * Sets up registers for the given mode/adjusted_mode pair.
> *
> * The clocks, CRTCs and outputs attached to this CRTC must be off.
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH 06/20] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses
@ 2023-08-24 8:42 ` Karol Herbst
0 siblings, 0 replies; 159+ messages in thread
From: Karol Herbst @ 2023-08-24 8:42 UTC (permalink / raw)
To: Lee Jones; +Cc: nouveau, linux-kernel, dri-devel, Ben Skeggs
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> drivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> ---
> drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv04/crtc.c b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
> index a34924523133c..5454dbb669566 100644
> --- a/drivers/gpu/drm/nouveau/dispnv04/crtc.c
> +++ b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
> @@ -449,7 +449,7 @@ nv_crtc_mode_set_vga(struct drm_crtc *crtc, struct drm_display_mode *mode)
> regp->Attribute[NV_CIO_AR_CSEL_INDEX] = 0x00;
> }
>
> -/**
> +/*
> * Sets up registers for the given mode/adjusted_mode pair.
> *
> * The clocks, CRTCs and outputs attached to this CRTC must be off.
> @@ -625,7 +625,7 @@ nv_crtc_swap_fbs(struct drm_crtc *crtc, struct drm_framebuffer *old_fb)
> return ret;
> }
>
> -/**
> +/*
> * Sets up registers for the given mode/adjusted_mode pair.
> *
> * The clocks, CRTCs and outputs attached to this CRTC must be off.
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
^ permalink raw reply [flat|nested] 159+ messages in thread
* [PATCH 07/20] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move()
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 7:36 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: Pan, Xinhui, linux-kernel, amd-gfx, Jerome Glisse, dri-devel,
Daniel Vetter, Alex Deucher, David Airlie, Christian König
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_bo_move’:
drivers/gpu/drm/radeon/radeon_ttm.c:201:27: warning: variable ‘rbo’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Jerome Glisse <glisse@freedesktop.org>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/radeon/radeon_ttm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
index 4eb83ccc4906a..de4e6d78f1e12 100644
--- a/drivers/gpu/drm/radeon/radeon_ttm.c
+++ b/drivers/gpu/drm/radeon/radeon_ttm.c
@@ -197,7 +197,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,
{
struct ttm_resource *old_mem = bo->resource;
struct radeon_device *rdev;
- struct radeon_bo *rbo;
int r;
if (new_mem->mem_type == TTM_PL_TT) {
@@ -210,7 +209,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,
if (r)
return r;
- rbo = container_of(bo, struct radeon_bo, tbo);
rdev = radeon_get_rdev(bo->bdev);
if (!old_mem || (old_mem->mem_type == TTM_PL_SYSTEM &&
bo->ttm == NULL)) {
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* [PATCH 07/20] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move()
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter, Jerome Glisse, amd-gfx, dri-devel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_bo_move’:
drivers/gpu/drm/radeon/radeon_ttm.c:201:27: warning: variable ‘rbo’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Jerome Glisse <glisse@freedesktop.org>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/radeon/radeon_ttm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
index 4eb83ccc4906a..de4e6d78f1e12 100644
--- a/drivers/gpu/drm/radeon/radeon_ttm.c
+++ b/drivers/gpu/drm/radeon/radeon_ttm.c
@@ -197,7 +197,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,
{
struct ttm_resource *old_mem = bo->resource;
struct radeon_device *rdev;
- struct radeon_bo *rbo;
int r;
if (new_mem->mem_type == TTM_PL_TT) {
@@ -210,7 +209,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,
if (r)
return r;
- rbo = container_of(bo, struct radeon_bo, tbo);
rdev = radeon_get_rdev(bo->bdev);
if (!old_mem || (old_mem->mem_type == TTM_PL_SYSTEM &&
bo->ttm == NULL)) {
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* [PATCH 07/20] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move()
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: Pan, Xinhui, linux-kernel, amd-gfx, Jerome Glisse, dri-devel,
Alex Deucher, Christian König
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_bo_move’:
drivers/gpu/drm/radeon/radeon_ttm.c:201:27: warning: variable ‘rbo’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Jerome Glisse <glisse@freedesktop.org>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/radeon/radeon_ttm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
index 4eb83ccc4906a..de4e6d78f1e12 100644
--- a/drivers/gpu/drm/radeon/radeon_ttm.c
+++ b/drivers/gpu/drm/radeon/radeon_ttm.c
@@ -197,7 +197,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,
{
struct ttm_resource *old_mem = bo->resource;
struct radeon_device *rdev;
- struct radeon_bo *rbo;
int r;
if (new_mem->mem_type == TTM_PL_TT) {
@@ -210,7 +209,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,
if (r)
return r;
- rbo = container_of(bo, struct radeon_bo, tbo);
rdev = radeon_get_rdev(bo->bdev);
if (!old_mem || (old_mem->mem_type == TTM_PL_SYSTEM &&
bo->ttm == NULL)) {
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* Re: [PATCH 07/20] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move()
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 14:53 ` Alex Deucher
-1 siblings, 0 replies; 159+ messages in thread
From: Alex Deucher @ 2023-08-24 14:53 UTC (permalink / raw)
To: Lee Jones
Cc: Pan, Xinhui, linux-kernel, dri-devel, Jerome Glisse, amd-gfx,
Daniel Vetter, Alex Deucher, David Airlie, Christian König
Applied. Thanks!
On Thu, Aug 24, 2023 at 3:37 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_bo_move’:
> drivers/gpu/drm/radeon/radeon_ttm.c:201:27: warning: variable ‘rbo’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Jerome Glisse <glisse@freedesktop.org>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/radeon/radeon_ttm.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 4eb83ccc4906a..de4e6d78f1e12 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -197,7 +197,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,
> {
> struct ttm_resource *old_mem = bo->resource;
> struct radeon_device *rdev;
> - struct radeon_bo *rbo;
> int r;
>
> if (new_mem->mem_type == TTM_PL_TT) {
> @@ -210,7 +209,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,
> if (r)
> return r;
>
> - rbo = container_of(bo, struct radeon_bo, tbo);
> rdev = radeon_get_rdev(bo->bdev);
> if (!old_mem || (old_mem->mem_type == TTM_PL_SYSTEM &&
> bo->ttm == NULL)) {
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 07/20] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move()
@ 2023-08-24 14:53 ` Alex Deucher
0 siblings, 0 replies; 159+ messages in thread
From: Alex Deucher @ 2023-08-24 14:53 UTC (permalink / raw)
To: Lee Jones
Cc: Pan, Xinhui, linux-kernel, amd-gfx, Jerome Glisse, dri-devel,
Daniel Vetter, Alex Deucher, David Airlie, Christian König
Applied. Thanks!
On Thu, Aug 24, 2023 at 3:37 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_bo_move’:
> drivers/gpu/drm/radeon/radeon_ttm.c:201:27: warning: variable ‘rbo’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Jerome Glisse <glisse@freedesktop.org>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/radeon/radeon_ttm.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 4eb83ccc4906a..de4e6d78f1e12 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -197,7 +197,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,
> {
> struct ttm_resource *old_mem = bo->resource;
> struct radeon_device *rdev;
> - struct radeon_bo *rbo;
> int r;
>
> if (new_mem->mem_type == TTM_PL_TT) {
> @@ -210,7 +209,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,
> if (r)
> return r;
>
> - rbo = container_of(bo, struct radeon_bo, tbo);
> rdev = radeon_get_rdev(bo->bdev);
> if (!old_mem || (old_mem->mem_type == TTM_PL_SYSTEM &&
> bo->ttm == NULL)) {
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 07/20] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move()
@ 2023-08-24 14:53 ` Alex Deucher
0 siblings, 0 replies; 159+ messages in thread
From: Alex Deucher @ 2023-08-24 14:53 UTC (permalink / raw)
To: Lee Jones
Cc: Pan, Xinhui, linux-kernel, dri-devel, Jerome Glisse, amd-gfx,
Alex Deucher, Christian König
Applied. Thanks!
On Thu, Aug 24, 2023 at 3:37 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_bo_move’:
> drivers/gpu/drm/radeon/radeon_ttm.c:201:27: warning: variable ‘rbo’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Jerome Glisse <glisse@freedesktop.org>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/radeon/radeon_ttm.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 4eb83ccc4906a..de4e6d78f1e12 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -197,7 +197,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,
> {
> struct ttm_resource *old_mem = bo->resource;
> struct radeon_device *rdev;
> - struct radeon_bo *rbo;
> int r;
>
> if (new_mem->mem_type == TTM_PL_TT) {
> @@ -210,7 +209,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,
> if (r)
> return r;
>
> - rbo = container_of(bo, struct radeon_bo, tbo);
> rdev = radeon_get_rdev(bo->bdev);
> if (!old_mem || (old_mem->mem_type == TTM_PL_SYSTEM &&
> bo->ttm == NULL)) {
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
^ permalink raw reply [flat|nested] 159+ messages in thread
* [PATCH 08/20] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 7:36 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: Pan, Xinhui, linux-kernel, amd-gfx, Sumit Semwal, linaro-mm-sig,
Stanley Yang, dri-devel, Daniel Vetter, Alex Deucher,
David Airlie, Christian König, linux-media
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'job' not described in 'sdma_v6_0_ring_emit_ib'
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'flags' not described in 'sdma_v6_0_ring_emit_ib'
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:945: warning: Function parameter or member 'timeout' not described in 'sdma_v6_0_ring_test_ib'
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1124: warning: Function parameter or member 'ring' not described in 'sdma_v6_0_ring_pad_ib'
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'vmid' not described in 'sdma_v6_0_ring_emit_vm_flush'
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'pd_addr' not described in 'sdma_v6_0_ring_emit_vm_flush'
Cc: linaro-mm-sig@lists.linaro.org
---
Signed-off-by: Lee Jones <lee@kernel.org>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Stanley Yang <Stanley.Yang@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
---
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
index 45be0af2570b2..0e25b6fb13404 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
@@ -234,7 +234,7 @@ static void sdma_v6_0_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count)
amdgpu_ring_write(ring, ring->funcs->nop);
}
-/**
+/*
* sdma_v6_0_ring_emit_ib - Schedule an IB on the DMA engine
*
* @ring: amdgpu ring pointer
@@ -937,7 +937,7 @@ static int sdma_v6_0_ring_test_ring(struct amdgpu_ring *ring)
return r;
}
-/**
+/*
* sdma_v6_0_ring_test_ib - test an IB on the DMA engine
*
* @ring: amdgpu_ring structure holding ring information
@@ -1119,7 +1119,7 @@ static void sdma_v6_0_vm_set_pte_pde(struct amdgpu_ib *ib,
ib->ptr[ib->length_dw++] = count - 1; /* number of entries */
}
-/**
+/*
* sdma_v6_0_ring_pad_ib - pad the IB
* @ib: indirect buffer to fill with padding
* @ring: amdgpu ring pointer
@@ -1168,7 +1168,7 @@ static void sdma_v6_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring)
SDMA_PKT_POLL_REGMEM_DW5_INTERVAL(4)); /* retry count, poll interval */
}
-/**
+/*
* sdma_v6_0_ring_emit_vm_flush - vm flush using sDMA
*
* @ring: amdgpu_ring pointer
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 08/20] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, linaro-mm-sig, Alex Deucher, Christian König,
Pan, Xinhui, David Airlie, Daniel Vetter, Sumit Semwal,
Stanley Yang, amd-gfx, dri-devel, linux-media
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'job' not described in 'sdma_v6_0_ring_emit_ib'
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'flags' not described in 'sdma_v6_0_ring_emit_ib'
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:945: warning: Function parameter or member 'timeout' not described in 'sdma_v6_0_ring_test_ib'
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1124: warning: Function parameter or member 'ring' not described in 'sdma_v6_0_ring_pad_ib'
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'vmid' not described in 'sdma_v6_0_ring_emit_vm_flush'
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'pd_addr' not described in 'sdma_v6_0_ring_emit_vm_flush'
Cc: linaro-mm-sig@lists.linaro.org
---
Signed-off-by: Lee Jones <lee@kernel.org>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Stanley Yang <Stanley.Yang@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
---
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
index 45be0af2570b2..0e25b6fb13404 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
@@ -234,7 +234,7 @@ static void sdma_v6_0_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count)
amdgpu_ring_write(ring, ring->funcs->nop);
}
-/**
+/*
* sdma_v6_0_ring_emit_ib - Schedule an IB on the DMA engine
*
* @ring: amdgpu ring pointer
@@ -937,7 +937,7 @@ static int sdma_v6_0_ring_test_ring(struct amdgpu_ring *ring)
return r;
}
-/**
+/*
* sdma_v6_0_ring_test_ib - test an IB on the DMA engine
*
* @ring: amdgpu_ring structure holding ring information
@@ -1119,7 +1119,7 @@ static void sdma_v6_0_vm_set_pte_pde(struct amdgpu_ib *ib,
ib->ptr[ib->length_dw++] = count - 1; /* number of entries */
}
-/**
+/*
* sdma_v6_0_ring_pad_ib - pad the IB
* @ib: indirect buffer to fill with padding
* @ring: amdgpu ring pointer
@@ -1168,7 +1168,7 @@ static void sdma_v6_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring)
SDMA_PKT_POLL_REGMEM_DW5_INTERVAL(4)); /* retry count, poll interval */
}
-/**
+/*
* sdma_v6_0_ring_emit_vm_flush - vm flush using sDMA
*
* @ring: amdgpu_ring pointer
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 08/20] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: Pan, Xinhui, linux-kernel, amd-gfx, Sumit Semwal, linaro-mm-sig,
Stanley Yang, dri-devel, Alex Deucher, Christian König,
linux-media
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'job' not described in 'sdma_v6_0_ring_emit_ib'
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'flags' not described in 'sdma_v6_0_ring_emit_ib'
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:945: warning: Function parameter or member 'timeout' not described in 'sdma_v6_0_ring_test_ib'
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1124: warning: Function parameter or member 'ring' not described in 'sdma_v6_0_ring_pad_ib'
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'vmid' not described in 'sdma_v6_0_ring_emit_vm_flush'
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'pd_addr' not described in 'sdma_v6_0_ring_emit_vm_flush'
Cc: linaro-mm-sig@lists.linaro.org
---
Signed-off-by: Lee Jones <lee@kernel.org>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Stanley Yang <Stanley.Yang@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
---
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
index 45be0af2570b2..0e25b6fb13404 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
@@ -234,7 +234,7 @@ static void sdma_v6_0_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count)
amdgpu_ring_write(ring, ring->funcs->nop);
}
-/**
+/*
* sdma_v6_0_ring_emit_ib - Schedule an IB on the DMA engine
*
* @ring: amdgpu ring pointer
@@ -937,7 +937,7 @@ static int sdma_v6_0_ring_test_ring(struct amdgpu_ring *ring)
return r;
}
-/**
+/*
* sdma_v6_0_ring_test_ib - test an IB on the DMA engine
*
* @ring: amdgpu_ring structure holding ring information
@@ -1119,7 +1119,7 @@ static void sdma_v6_0_vm_set_pte_pde(struct amdgpu_ib *ib,
ib->ptr[ib->length_dw++] = count - 1; /* number of entries */
}
-/**
+/*
* sdma_v6_0_ring_pad_ib - pad the IB
* @ib: indirect buffer to fill with padding
* @ring: amdgpu ring pointer
@@ -1168,7 +1168,7 @@ static void sdma_v6_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring)
SDMA_PKT_POLL_REGMEM_DW5_INTERVAL(4)); /* retry count, poll interval */
}
-/**
+/*
* sdma_v6_0_ring_emit_vm_flush - vm flush using sDMA
*
* @ring: amdgpu_ring pointer
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 09/20] drm/tests/drm_kunit_helpers: Place correct function name in the comment header
2023-08-24 7:36 ` Lee Jones
@ 2023-08-24 7:36 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee; +Cc: linux-kernel, Maxime Ripard, Maíra Canal, dri-devel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/tests/drm_kunit_helpers.c:172: warning: expecting prototype for drm_kunit_helper_context_alloc(). Prototype was for drm_kunit_helper_acquire_ctx_alloc() instead
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: "Maíra Canal" <mairacanal@riseup.net>
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
index 3d624ff2f6517..f102c23eee1dd 100644
--- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
+++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
@@ -156,7 +156,7 @@ static void action_drm_release_context(void *ptr)
}
/**
- * drm_kunit_helper_context_alloc - Allocates an acquire context
+ * ddrm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context
* @test: The test context object
*
* Allocates and initializes a modeset acquire context.
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 09/20] drm/tests/drm_kunit_helpers: Place correct function name in the comment header
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, David Airlie, Daniel Vetter, Maxime Ripard,
Maíra Canal, dri-devel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/tests/drm_kunit_helpers.c:172: warning: expecting prototype for drm_kunit_helper_context_alloc(). Prototype was for drm_kunit_helper_acquire_ctx_alloc() instead
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: "Maíra Canal" <mairacanal@riseup.net>
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
index 3d624ff2f6517..f102c23eee1dd 100644
--- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
+++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
@@ -156,7 +156,7 @@ static void action_drm_release_context(void *ptr)
}
/**
- * drm_kunit_helper_context_alloc - Allocates an acquire context
+ * ddrm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context
* @test: The test context object
*
* Allocates and initializes a modeset acquire context.
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 10/20] drm/scheduler/sched_main: Provide short description of missing param 'result'
2023-08-24 7:36 ` Lee Jones
@ 2023-08-24 7:36 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, dri-devel, Sumit Semwal, linaro-mm-sig,
Luben Tuikov, Christian König, linux-media
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/scheduler/sched_main.c:266: warning: Function parameter or member 'result' not described in 'drm_sched_job_done'
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Luben Tuikov <luben.tuikov@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
---
drivers/gpu/drm/scheduler/sched_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index 506371c427451..1ef558cda60ce 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -259,6 +259,7 @@ drm_sched_rq_select_entity_fifo(struct drm_sched_rq *rq)
/**
* drm_sched_job_done - complete a job
* @s_job: pointer to the job which is done
+ * @result: fence error to forward and set
*
* Finish the job's fence and wake up the worker thread.
*/
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 10/20] drm/scheduler/sched_main: Provide short description of missing param 'result'
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Luben Tuikov, David Airlie, Daniel Vetter,
Sumit Semwal, Christian König, dri-devel, linux-media,
linaro-mm-sig
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/scheduler/sched_main.c:266: warning: Function parameter or member 'result' not described in 'drm_sched_job_done'
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Luben Tuikov <luben.tuikov@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
---
drivers/gpu/drm/scheduler/sched_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index 506371c427451..1ef558cda60ce 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -259,6 +259,7 @@ drm_sched_rq_select_entity_fifo(struct drm_sched_rq *rq)
/**
* drm_sched_job_done - complete a job
* @s_job: pointer to the job which is done
+ * @result: fence error to forward and set
*
* Finish the job's fence and wake up the worker thread.
*/
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* Re: [Linaro-mm-sig] [PATCH 10/20] drm/scheduler/sched_main: Provide short description of missing param 'result'
2023-08-24 7:36 ` Lee Jones
@ 2023-08-24 9:42 ` Christian König
-1 siblings, 0 replies; 159+ messages in thread
From: Christian König @ 2023-08-24 9:42 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, dri-devel, Sumit Semwal, linaro-mm-sig,
Luben Tuikov, Christian König, linux-media
Am 24.08.23 um 09:36 schrieb Lee Jones:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/scheduler/sched_main.c:266: warning: Function parameter or member 'result' not described in 'drm_sched_job_done'
>
> Signed-off-by: Lee Jones <lee@kernel.org>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> Cc: Luben Tuikov <luben.tuikov@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-media@vger.kernel.org
> Cc: linaro-mm-sig@lists.linaro.org
> ---
> drivers/gpu/drm/scheduler/sched_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 506371c427451..1ef558cda60ce 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -259,6 +259,7 @@ drm_sched_rq_select_entity_fifo(struct drm_sched_rq *rq)
> /**
> * drm_sched_job_done - complete a job
> * @s_job: pointer to the job which is done
> + * @result: fence error to forward and set
> *
> * Finish the job's fence and wake up the worker thread.
> */
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [Linaro-mm-sig] [PATCH 10/20] drm/scheduler/sched_main: Provide short description of missing param 'result'
@ 2023-08-24 9:42 ` Christian König
0 siblings, 0 replies; 159+ messages in thread
From: Christian König @ 2023-08-24 9:42 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Luben Tuikov, Daniel Vetter, Sumit Semwal,
Christian König, dri-devel, linux-media, linaro-mm-sig
Am 24.08.23 um 09:36 schrieb Lee Jones:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/scheduler/sched_main.c:266: warning: Function parameter or member 'result' not described in 'drm_sched_job_done'
>
> Signed-off-by: Lee Jones <lee@kernel.org>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> Cc: Luben Tuikov <luben.tuikov@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-media@vger.kernel.org
> Cc: linaro-mm-sig@lists.linaro.org
> ---
> drivers/gpu/drm/scheduler/sched_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 506371c427451..1ef558cda60ce 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -259,6 +259,7 @@ drm_sched_rq_select_entity_fifo(struct drm_sched_rq *rq)
> /**
> * drm_sched_job_done - complete a job
> * @s_job: pointer to the job which is done
> + * @result: fence error to forward and set
> *
> * Finish the job's fence and wake up the worker thread.
> */
^ permalink raw reply [flat|nested] 159+ messages in thread
* [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 7:36 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: Shashank Sharma, Pan, Xinhui, linux-kernel, amd-gfx, dri-devel,
Daniel Vetter, Alex Deucher, David Airlie, Christian König
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Function parameter or member 'doorbell_index' not described in 'amdgpu_doorbell_index_on_bar'
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Excess function parameter 'db_index' description in 'amdgpu_doorbell_index_on_bar'
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Shashank Sharma <shashank.sharma@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
index da4be0bbb4466..d0249ada91d30 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
@@ -113,7 +113,7 @@ void amdgpu_mm_wdoorbell64(struct amdgpu_device *adev, u32 index, u64 v)
*
* @adev: amdgpu_device pointer
* @db_bo: doorbell object's bo
- * @db_index: doorbell relative index in this doorbell object
+ * @doorbell_index: doorbell relative index in this doorbell object
*
* returns doorbell's absolute index in BAR
*/
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter, Shashank Sharma, amd-gfx, dri-devel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Function parameter or member 'doorbell_index' not described in 'amdgpu_doorbell_index_on_bar'
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Excess function parameter 'db_index' description in 'amdgpu_doorbell_index_on_bar'
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Shashank Sharma <shashank.sharma@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
index da4be0bbb4466..d0249ada91d30 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
@@ -113,7 +113,7 @@ void amdgpu_mm_wdoorbell64(struct amdgpu_device *adev, u32 index, u64 v)
*
* @adev: amdgpu_device pointer
* @db_bo: doorbell object's bo
- * @db_index: doorbell relative index in this doorbell object
+ * @doorbell_index: doorbell relative index in this doorbell object
*
* returns doorbell's absolute index in BAR
*/
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: Shashank Sharma, Pan, Xinhui, linux-kernel, amd-gfx, dri-devel,
Alex Deucher, Christian König
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Function parameter or member 'doorbell_index' not described in 'amdgpu_doorbell_index_on_bar'
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Excess function parameter 'db_index' description in 'amdgpu_doorbell_index_on_bar'
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Shashank Sharma <shashank.sharma@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
index da4be0bbb4466..d0249ada91d30 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
@@ -113,7 +113,7 @@ void amdgpu_mm_wdoorbell64(struct amdgpu_device *adev, u32 index, u64 v)
*
* @adev: amdgpu_device pointer
* @db_bo: doorbell object's bo
- * @db_index: doorbell relative index in this doorbell object
+ * @doorbell_index: doorbell relative index in this doorbell object
*
* returns doorbell's absolute index in BAR
*/
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* RE: [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 8:25 ` Sharma, Shashank
-1 siblings, 0 replies; 159+ messages in thread
From: Sharma, Shashank @ 2023-08-24 8:25 UTC (permalink / raw)
To: Lee Jones
Cc: Pan, Xinhui, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Daniel Vetter, Deucher, Alexander, David Airlie,
Koenig, Christian
[AMD Official Use Only - General]
Reviewed-by: : Shashank Sharma <shashank.sharma@amd.com>
Regards
Shashank
-----Original Message-----
From: Lee Jones <lee@kernel.org>
Sent: Thursday, August 24, 2023 9:37 AM
To: lee@kernel.org
Cc: linux-kernel@vger.kernel.org; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; David Airlie <airlied@gmail.com>; Daniel Vetter <daniel@ffwll.ch>; Sharma, Shashank <Shashank.Sharma@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Subject: [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Function parameter or member 'doorbell_index' not described in 'amdgpu_doorbell_index_on_bar'
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Excess function parameter 'db_index' description in 'amdgpu_doorbell_index_on_bar'
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Shashank Sharma <shashank.sharma@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
index da4be0bbb4466..d0249ada91d30 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
@@ -113,7 +113,7 @@ void amdgpu_mm_wdoorbell64(struct amdgpu_device *adev, u32 index, u64 v)
*
* @adev: amdgpu_device pointer
* @db_bo: doorbell object's bo
- * @db_index: doorbell relative index in this doorbell object
+ * @doorbell_index: doorbell relative index in this doorbell object
*
* returns doorbell's absolute index in BAR
*/
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* RE: [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'
@ 2023-08-24 8:25 ` Sharma, Shashank
0 siblings, 0 replies; 159+ messages in thread
From: Sharma, Shashank @ 2023-08-24 8:25 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel@vger.kernel.org, Deucher, Alexander,
Koenig, Christian, Pan, Xinhui, David Airlie, Daniel Vetter,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
[AMD Official Use Only - General]
Reviewed-by: : Shashank Sharma <shashank.sharma@amd.com>
Regards
Shashank
-----Original Message-----
From: Lee Jones <lee@kernel.org>
Sent: Thursday, August 24, 2023 9:37 AM
To: lee@kernel.org
Cc: linux-kernel@vger.kernel.org; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; David Airlie <airlied@gmail.com>; Daniel Vetter <daniel@ffwll.ch>; Sharma, Shashank <Shashank.Sharma@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Subject: [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Function parameter or member 'doorbell_index' not described in 'amdgpu_doorbell_index_on_bar'
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Excess function parameter 'db_index' description in 'amdgpu_doorbell_index_on_bar'
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Shashank Sharma <shashank.sharma@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
index da4be0bbb4466..d0249ada91d30 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
@@ -113,7 +113,7 @@ void amdgpu_mm_wdoorbell64(struct amdgpu_device *adev, u32 index, u64 v)
*
* @adev: amdgpu_device pointer
* @db_bo: doorbell object's bo
- * @db_index: doorbell relative index in this doorbell object
+ * @doorbell_index: doorbell relative index in this doorbell object
*
* returns doorbell's absolute index in BAR
*/
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* RE: [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'
@ 2023-08-24 8:25 ` Sharma, Shashank
0 siblings, 0 replies; 159+ messages in thread
From: Sharma, Shashank @ 2023-08-24 8:25 UTC (permalink / raw)
To: Lee Jones
Cc: Pan, Xinhui, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Deucher, Alexander, Koenig, Christian
[AMD Official Use Only - General]
Reviewed-by: : Shashank Sharma <shashank.sharma@amd.com>
Regards
Shashank
-----Original Message-----
From: Lee Jones <lee@kernel.org>
Sent: Thursday, August 24, 2023 9:37 AM
To: lee@kernel.org
Cc: linux-kernel@vger.kernel.org; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; David Airlie <airlied@gmail.com>; Daniel Vetter <daniel@ffwll.ch>; Sharma, Shashank <Shashank.Sharma@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Subject: [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Function parameter or member 'doorbell_index' not described in 'amdgpu_doorbell_index_on_bar'
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Excess function parameter 'db_index' description in 'amdgpu_doorbell_index_on_bar'
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Shashank Sharma <shashank.sharma@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
index da4be0bbb4466..d0249ada91d30 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
@@ -113,7 +113,7 @@ void amdgpu_mm_wdoorbell64(struct amdgpu_device *adev, u32 index, u64 v)
*
* @adev: amdgpu_device pointer
* @db_bo: doorbell object's bo
- * @db_index: doorbell relative index in this doorbell object
+ * @doorbell_index: doorbell relative index in this doorbell object
*
* returns doorbell's absolute index in BAR
*/
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* Re: [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'
2023-08-24 8:25 ` Sharma, Shashank
@ 2023-08-24 14:59 ` Alex Deucher
-1 siblings, 0 replies; 159+ messages in thread
From: Alex Deucher @ 2023-08-24 14:59 UTC (permalink / raw)
To: Sharma, Shashank
Cc: Lee Jones, Pan, Xinhui, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
Deucher, Alexander, Koenig, Christian
Applied. Thanks!
On Thu, Aug 24, 2023 at 4:35 AM Sharma, Shashank
<Shashank.Sharma@amd.com> wrote:
>
> [AMD Official Use Only - General]
>
> Reviewed-by: : Shashank Sharma <shashank.sharma@amd.com>
>
> Regards
> Shashank
> -----Original Message-----
> From: Lee Jones <lee@kernel.org>
> Sent: Thursday, August 24, 2023 9:37 AM
> To: lee@kernel.org
> Cc: linux-kernel@vger.kernel.org; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; David Airlie <airlied@gmail.com>; Daniel Vetter <daniel@ffwll.ch>; Sharma, Shashank <Shashank.Sharma@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> Subject: [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Function parameter or member 'doorbell_index' not described in 'amdgpu_doorbell_index_on_bar'
> drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Excess function parameter 'db_index' description in 'amdgpu_doorbell_index_on_bar'
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Shashank Sharma <shashank.sharma@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
> index da4be0bbb4466..d0249ada91d30 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
> @@ -113,7 +113,7 @@ void amdgpu_mm_wdoorbell64(struct amdgpu_device *adev, u32 index, u64 v)
> *
> * @adev: amdgpu_device pointer
> * @db_bo: doorbell object's bo
> - * @db_index: doorbell relative index in this doorbell object
> + * @doorbell_index: doorbell relative index in this doorbell object
> *
> * returns doorbell's absolute index in BAR
> */
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'
@ 2023-08-24 14:59 ` Alex Deucher
0 siblings, 0 replies; 159+ messages in thread
From: Alex Deucher @ 2023-08-24 14:59 UTC (permalink / raw)
To: Sharma, Shashank
Cc: Lee Jones, Pan, Xinhui, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Deucher, Alexander, Koenig, Christian
Applied. Thanks!
On Thu, Aug 24, 2023 at 4:35 AM Sharma, Shashank
<Shashank.Sharma@amd.com> wrote:
>
> [AMD Official Use Only - General]
>
> Reviewed-by: : Shashank Sharma <shashank.sharma@amd.com>
>
> Regards
> Shashank
> -----Original Message-----
> From: Lee Jones <lee@kernel.org>
> Sent: Thursday, August 24, 2023 9:37 AM
> To: lee@kernel.org
> Cc: linux-kernel@vger.kernel.org; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; David Airlie <airlied@gmail.com>; Daniel Vetter <daniel@ffwll.ch>; Sharma, Shashank <Shashank.Sharma@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> Subject: [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Function parameter or member 'doorbell_index' not described in 'amdgpu_doorbell_index_on_bar'
> drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Excess function parameter 'db_index' description in 'amdgpu_doorbell_index_on_bar'
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Shashank Sharma <shashank.sharma@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
> index da4be0bbb4466..d0249ada91d30 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
> @@ -113,7 +113,7 @@ void amdgpu_mm_wdoorbell64(struct amdgpu_device *adev, u32 index, u64 v)
> *
> * @adev: amdgpu_device pointer
> * @db_bo: doorbell object's bo
> - * @db_index: doorbell relative index in this doorbell object
> + * @doorbell_index: doorbell relative index in this doorbell object
> *
> * returns doorbell's absolute index in BAR
> */
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
^ permalink raw reply [flat|nested] 159+ messages in thread
* [PATCH 12/20] drm/amd/amdgpu/amdgpu_device: Provide suitable description for param 'xcc_id'
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 7:36 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: Pan, Xinhui, linux-kernel, amd-gfx, Sumit Semwal, linaro-mm-sig,
dri-devel, Daniel Vetter, Alex Deucher, David Airlie,
Christian König, linux-media
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:516: warning: Function parameter or member 'xcc_id' not described in 'amdgpu_mm_wreg_mmio_rlc'
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index e77f048c99d85..d4f0e4327dd3f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -507,6 +507,7 @@ void amdgpu_device_wreg(struct amdgpu_device *adev,
* @adev: amdgpu_device pointer
* @reg: mmio/rlc register
* @v: value to write
+ * @xcc_id: xcc accelerated compute core id
*
* this function is invoked only for the debugfs register access
*/
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 12/20] drm/amd/amdgpu/amdgpu_device: Provide suitable description for param 'xcc_id'
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter, Sumit Semwal, amd-gfx, dri-devel,
linux-media, linaro-mm-sig
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:516: warning: Function parameter or member 'xcc_id' not described in 'amdgpu_mm_wreg_mmio_rlc'
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index e77f048c99d85..d4f0e4327dd3f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -507,6 +507,7 @@ void amdgpu_device_wreg(struct amdgpu_device *adev,
* @adev: amdgpu_device pointer
* @reg: mmio/rlc register
* @v: value to write
+ * @xcc_id: xcc accelerated compute core id
*
* this function is invoked only for the debugfs register access
*/
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 12/20] drm/amd/amdgpu/amdgpu_device: Provide suitable description for param 'xcc_id'
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: Pan, Xinhui, linux-kernel, amd-gfx, Sumit Semwal, linaro-mm-sig,
dri-devel, Alex Deucher, Christian König, linux-media
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:516: warning: Function parameter or member 'xcc_id' not described in 'amdgpu_mm_wreg_mmio_rlc'
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index e77f048c99d85..d4f0e4327dd3f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -507,6 +507,7 @@ void amdgpu_device_wreg(struct amdgpu_device *adev,
* @adev: amdgpu_device pointer
* @reg: mmio/rlc register
* @v: value to write
+ * @xcc_id: xcc accelerated compute core id
*
* this function is invoked only for the debugfs register access
*/
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* Re: [PATCH 12/20] drm/amd/amdgpu/amdgpu_device: Provide suitable description for param 'xcc_id'
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 14:54 ` Alex Deucher
-1 siblings, 0 replies; 159+ messages in thread
From: Alex Deucher @ 2023-08-24 14:54 UTC (permalink / raw)
To: Lee Jones
Cc: Pan, Xinhui, linux-kernel, dri-devel, Christian König,
linaro-mm-sig, amd-gfx, Daniel Vetter, Alex Deucher, David Airlie,
Sumit Semwal, linux-media
Applied. Thanks!
On Thu, Aug 24, 2023 at 3:38 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:516: warning: Function parameter or member 'xcc_id' not described in 'amdgpu_mm_wreg_mmio_rlc'
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-media@vger.kernel.org
> Cc: linaro-mm-sig@lists.linaro.org
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index e77f048c99d85..d4f0e4327dd3f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -507,6 +507,7 @@ void amdgpu_device_wreg(struct amdgpu_device *adev,
> * @adev: amdgpu_device pointer
> * @reg: mmio/rlc register
> * @v: value to write
> + * @xcc_id: xcc accelerated compute core id
> *
> * this function is invoked only for the debugfs register access
> */
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH 12/20] drm/amd/amdgpu/amdgpu_device: Provide suitable description for param 'xcc_id'
@ 2023-08-24 14:54 ` Alex Deucher
0 siblings, 0 replies; 159+ messages in thread
From: Alex Deucher @ 2023-08-24 14:54 UTC (permalink / raw)
To: Lee Jones
Cc: Pan, Xinhui, linux-kernel, amd-gfx, Sumit Semwal, linaro-mm-sig,
dri-devel, Daniel Vetter, Alex Deucher, David Airlie,
Christian König, linux-media
Applied. Thanks!
On Thu, Aug 24, 2023 at 3:38 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:516: warning: Function parameter or member 'xcc_id' not described in 'amdgpu_mm_wreg_mmio_rlc'
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-media@vger.kernel.org
> Cc: linaro-mm-sig@lists.linaro.org
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index e77f048c99d85..d4f0e4327dd3f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -507,6 +507,7 @@ void amdgpu_device_wreg(struct amdgpu_device *adev,
> * @adev: amdgpu_device pointer
> * @reg: mmio/rlc register
> * @v: value to write
> + * @xcc_id: xcc accelerated compute core id
> *
> * this function is invoked only for the debugfs register access
> */
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH 12/20] drm/amd/amdgpu/amdgpu_device: Provide suitable description for param 'xcc_id'
@ 2023-08-24 14:54 ` Alex Deucher
0 siblings, 0 replies; 159+ messages in thread
From: Alex Deucher @ 2023-08-24 14:54 UTC (permalink / raw)
To: Lee Jones
Cc: Pan, Xinhui, linux-kernel, dri-devel, Christian König,
linaro-mm-sig, amd-gfx, Alex Deucher, Sumit Semwal, linux-media
Applied. Thanks!
On Thu, Aug 24, 2023 at 3:38 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:516: warning: Function parameter or member 'xcc_id' not described in 'amdgpu_mm_wreg_mmio_rlc'
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-media@vger.kernel.org
> Cc: linaro-mm-sig@lists.linaro.org
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index e77f048c99d85..d4f0e4327dd3f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -507,6 +507,7 @@ void amdgpu_device_wreg(struct amdgpu_device *adev,
> * @adev: amdgpu_device pointer
> * @reg: mmio/rlc register
> * @v: value to write
> + * @xcc_id: xcc accelerated compute core id
> *
> * this function is invoked only for the debugfs register access
> */
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
^ permalink raw reply [flat|nested] 159+ messages in thread
* [PATCH 13/20] drm/tests/drm_kunit_helpers: Correct possible double-entry typo in 'ddrm_kunit_helper_acquire_ctx_alloc'
2023-08-24 7:36 ` Lee Jones
@ 2023-08-24 7:36 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee; +Cc: linux-kernel, Maxime Ripard, Maíra Canal, dri-devel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/tests/drm_kunit_helpers.c:172: warning: expecting prototype for ddrm_kunit_helper_acquire_ctx_alloc(). Prototype was for drm_kunit_helper_acquire_ctx_alloc() instead
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: "Maíra Canal" <mairacanal@riseup.net>
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
index f102c23eee1dd..c1dfbfcaa0001 100644
--- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
+++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
@@ -156,7 +156,7 @@ static void action_drm_release_context(void *ptr)
}
/**
- * ddrm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context
+ * drm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context
* @test: The test context object
*
* Allocates and initializes a modeset acquire context.
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 13/20] drm/tests/drm_kunit_helpers: Correct possible double-entry typo in 'ddrm_kunit_helper_acquire_ctx_alloc'
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, David Airlie, Daniel Vetter, Maxime Ripard,
Maíra Canal, dri-devel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/tests/drm_kunit_helpers.c:172: warning: expecting prototype for ddrm_kunit_helper_acquire_ctx_alloc(). Prototype was for drm_kunit_helper_acquire_ctx_alloc() instead
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: "Maíra Canal" <mairacanal@riseup.net>
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
index f102c23eee1dd..c1dfbfcaa0001 100644
--- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
+++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
@@ -156,7 +156,7 @@ static void action_drm_release_context(void *ptr)
}
/**
- * ddrm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context
+ * drm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context
* @test: The test context object
*
* Allocates and initializes a modeset acquire context.
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* Re: [PATCH 13/20] drm/tests/drm_kunit_helpers: Correct possible double-entry typo in 'ddrm_kunit_helper_acquire_ctx_alloc'
2023-08-24 7:36 ` Lee Jones
@ 2023-08-24 8:53 ` Maxime Ripard
-1 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 8:53 UTC (permalink / raw)
To: Lee Jones; +Cc: Maíra Canal, dri-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]
Hi,
On Thu, Aug 24, 2023 at 08:36:58AM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/tests/drm_kunit_helpers.c:172: warning: expecting prototype for ddrm_kunit_helper_acquire_ctx_alloc(). Prototype was for drm_kunit_helper_acquire_ctx_alloc() instead
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: "Maíra Canal" <mairacanal@riseup.net>
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> index f102c23eee1dd..c1dfbfcaa0001 100644
> --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
> +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> @@ -156,7 +156,7 @@ static void action_drm_release_context(void *ptr)
> }
>
> /**
> - * ddrm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context
> + * drm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context
> * @test: The test context object
> *
> * Allocates and initializes a modeset acquire context.
The typo was added by your patch 9.
I've applied and squashed them both
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH 13/20] drm/tests/drm_kunit_helpers: Correct possible double-entry typo in 'ddrm_kunit_helper_acquire_ctx_alloc'
@ 2023-08-24 8:53 ` Maxime Ripard
0 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 8:53 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, David Airlie, Daniel Vetter, Maíra Canal,
dri-devel
[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]
Hi,
On Thu, Aug 24, 2023 at 08:36:58AM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/tests/drm_kunit_helpers.c:172: warning: expecting prototype for ddrm_kunit_helper_acquire_ctx_alloc(). Prototype was for drm_kunit_helper_acquire_ctx_alloc() instead
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: "Maíra Canal" <mairacanal@riseup.net>
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> index f102c23eee1dd..c1dfbfcaa0001 100644
> --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
> +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> @@ -156,7 +156,7 @@ static void action_drm_release_context(void *ptr)
> }
>
> /**
> - * ddrm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context
> + * drm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context
> * @test: The test context object
> *
> * Allocates and initializes a modeset acquire context.
The typo was added by your patch 9.
I've applied and squashed them both
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH 13/20] drm/tests/drm_kunit_helpers: Correct possible double-entry typo in 'ddrm_kunit_helper_acquire_ctx_alloc'
2023-08-24 8:53 ` Maxime Ripard
@ 2023-08-24 12:11 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:11 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Maíra Canal, dri-devel, linux-kernel
On Thu, 24 Aug 2023, Maxime Ripard wrote:
> Hi,
>
> On Thu, Aug 24, 2023 at 08:36:58AM +0100, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/gpu/drm/tests/drm_kunit_helpers.c:172: warning: expecting prototype for ddrm_kunit_helper_acquire_ctx_alloc(). Prototype was for drm_kunit_helper_acquire_ctx_alloc() instead
> >
> > Signed-off-by: Lee Jones <lee@kernel.org>
> > ---
> > Cc: David Airlie <airlied@gmail.com>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: "Maíra Canal" <mairacanal@riseup.net>
> > Cc: dri-devel@lists.freedesktop.org
> > ---
> > drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> > index f102c23eee1dd..c1dfbfcaa0001 100644
> > --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
> > +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> > @@ -156,7 +156,7 @@ static void action_drm_release_context(void *ptr)
> > }
> >
> > /**
> > - * ddrm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context
> > + * drm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context
> > * @test: The test context object
> > *
> > * Allocates and initializes a modeset acquire context.
>
> The typo was added by your patch 9.
Whoops! Good catch.
>
> I've applied and squashed them both
Perfect, thank you.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH 13/20] drm/tests/drm_kunit_helpers: Correct possible double-entry typo in 'ddrm_kunit_helper_acquire_ctx_alloc'
@ 2023-08-24 12:11 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:11 UTC (permalink / raw)
To: Maxime Ripard
Cc: linux-kernel, David Airlie, Daniel Vetter, Maíra Canal,
dri-devel
On Thu, 24 Aug 2023, Maxime Ripard wrote:
> Hi,
>
> On Thu, Aug 24, 2023 at 08:36:58AM +0100, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/gpu/drm/tests/drm_kunit_helpers.c:172: warning: expecting prototype for ddrm_kunit_helper_acquire_ctx_alloc(). Prototype was for drm_kunit_helper_acquire_ctx_alloc() instead
> >
> > Signed-off-by: Lee Jones <lee@kernel.org>
> > ---
> > Cc: David Airlie <airlied@gmail.com>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: "Maíra Canal" <mairacanal@riseup.net>
> > Cc: dri-devel@lists.freedesktop.org
> > ---
> > drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> > index f102c23eee1dd..c1dfbfcaa0001 100644
> > --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
> > +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> > @@ -156,7 +156,7 @@ static void action_drm_release_context(void *ptr)
> > }
> >
> > /**
> > - * ddrm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context
> > + * drm_kunit_helper_acquire_ctx_alloc - Allocates an acquire context
> > * @test: The test context object
> > *
> > * Allocates and initializes a modeset acquire context.
>
> The typo was added by your patch 9.
Whoops! Good catch.
>
> I've applied and squashed them both
Perfect, thank you.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread
* [PATCH 14/20] drm/imx/ipuv3/imx-ldb: Increase buffer size to ensure all possible values can be stored
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 7:36 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Philipp Zabel, David Airlie, Daniel Vetter,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, dri-devel, linux-arm-kernel
When converting from int to string, we must allow for up to 10-chars (2147483647).
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/imx/ipuv3/imx-ldb.c: In function ‘imx_ldb_probe’:
drivers/gpu/drm/imx/ipuv3/imx-ldb.c:659:39: warning: ‘_sel’ directive writing 4 bytes into a region of size between 3 and 13 [-Wformat-overflow=]
drivers/gpu/drm/imx/ipuv3/imx-ldb.c:659:17: note: ‘sprintf’ output between 8 and 18 bytes into a destination of size 16
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/ipuv3/imx-ldb.c b/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
index c45fc8f4744d0..0404781dcd176 100644
--- a/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
+++ b/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
@@ -654,7 +654,7 @@ static int imx_ldb_probe(struct platform_device *pdev)
* Map them all to di0_sel...di3_sel.
*/
for (i = 0; i < 4; i++) {
- char clkname[16];
+ char clkname[18];
sprintf(clkname, "di%d_sel", i);
imx_ldb->clk_sel[i] = devm_clk_get(imx_ldb->dev, clkname);
--
2.42.0.rc1.204.g551eb34607-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 159+ messages in thread* [PATCH 14/20] drm/imx/ipuv3/imx-ldb: Increase buffer size to ensure all possible values can be stored
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Philipp Zabel, David Airlie, Daniel Vetter,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, dri-devel, linux-arm-kernel
When converting from int to string, we must allow for up to 10-chars (2147483647).
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/imx/ipuv3/imx-ldb.c: In function ‘imx_ldb_probe’:
drivers/gpu/drm/imx/ipuv3/imx-ldb.c:659:39: warning: ‘_sel’ directive writing 4 bytes into a region of size between 3 and 13 [-Wformat-overflow=]
drivers/gpu/drm/imx/ipuv3/imx-ldb.c:659:17: note: ‘sprintf’ output between 8 and 18 bytes into a destination of size 16
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/ipuv3/imx-ldb.c b/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
index c45fc8f4744d0..0404781dcd176 100644
--- a/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
+++ b/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
@@ -654,7 +654,7 @@ static int imx_ldb_probe(struct platform_device *pdev)
* Map them all to di0_sel...di3_sel.
*/
for (i = 0; i < 4; i++) {
- char clkname[16];
+ char clkname[18];
sprintf(clkname, "di%d_sel", i);
imx_ldb->clk_sel[i] = devm_clk_get(imx_ldb->dev, clkname);
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* [PATCH 14/20] drm/imx/ipuv3/imx-ldb: Increase buffer size to ensure all possible values can be stored
@ 2023-08-24 7:36 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:36 UTC (permalink / raw)
To: lee
Cc: Sascha Hauer, linux-kernel, dri-devel, NXP Linux Team, Shawn Guo,
Pengutronix Kernel Team, linux-arm-kernel
When converting from int to string, we must allow for up to 10-chars (2147483647).
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/imx/ipuv3/imx-ldb.c: In function ‘imx_ldb_probe’:
drivers/gpu/drm/imx/ipuv3/imx-ldb.c:659:39: warning: ‘_sel’ directive writing 4 bytes into a region of size between 3 and 13 [-Wformat-overflow=]
drivers/gpu/drm/imx/ipuv3/imx-ldb.c:659:17: note: ‘sprintf’ output between 8 and 18 bytes into a destination of size 16
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/ipuv3/imx-ldb.c b/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
index c45fc8f4744d0..0404781dcd176 100644
--- a/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
+++ b/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
@@ -654,7 +654,7 @@ static int imx_ldb_probe(struct platform_device *pdev)
* Map them all to di0_sel...di3_sel.
*/
for (i = 0; i < 4; i++) {
- char clkname[16];
+ char clkname[18];
sprintf(clkname, "di%d_sel", i);
imx_ldb->clk_sel[i] = devm_clk_get(imx_ldb->dev, clkname);
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored
2023-08-24 7:36 ` Lee Jones
@ 2023-08-24 7:37 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:37 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Thierry Reding, Mikko Perttunen, David Airlie,
Daniel Vetter, Jonathan Hunter, Philipp Zabel, dri-devel,
linux-tegra
When converting from int to string, we must allow for up to 10-chars (2147483647).
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/tegra/hub.c: In function ‘tegra_display_hub_probe’:
drivers/gpu/drm/tegra/hub.c:1106:47: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
drivers/gpu/drm/tegra/hub.c:1106:42: note: directive argument in the range [0, 4294967294]
drivers/gpu/drm/tegra/hub.c:1106:17: note: ‘snprintf’ output between 6 and 15 bytes into a destination of size 8
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Mikko Perttunen <mperttunen@nvidia.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-tegra@vger.kernel.org
---
drivers/gpu/drm/tegra/hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c
index 1af5f8318d914..f21e57e8599ee 100644
--- a/drivers/gpu/drm/tegra/hub.c
+++ b/drivers/gpu/drm/tegra/hub.c
@@ -1101,7 +1101,7 @@ static int tegra_display_hub_probe(struct platform_device *pdev)
for (i = 0; i < hub->soc->num_wgrps; i++) {
struct tegra_windowgroup *wgrp = &hub->wgrps[i];
- char id[8];
+ char id[16];
snprintf(id, sizeof(id), "wgrp%u", i);
mutex_init(&wgrp->lock);
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored
@ 2023-08-24 7:37 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:37 UTC (permalink / raw)
To: lee
Cc: linux-kernel, dri-devel, Jonathan Hunter, Thierry Reding,
linux-tegra, Mikko Perttunen
When converting from int to string, we must allow for up to 10-chars (2147483647).
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/tegra/hub.c: In function ‘tegra_display_hub_probe’:
drivers/gpu/drm/tegra/hub.c:1106:47: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
drivers/gpu/drm/tegra/hub.c:1106:42: note: directive argument in the range [0, 4294967294]
drivers/gpu/drm/tegra/hub.c:1106:17: note: ‘snprintf’ output between 6 and 15 bytes into a destination of size 8
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Mikko Perttunen <mperttunen@nvidia.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-tegra@vger.kernel.org
---
drivers/gpu/drm/tegra/hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c
index 1af5f8318d914..f21e57e8599ee 100644
--- a/drivers/gpu/drm/tegra/hub.c
+++ b/drivers/gpu/drm/tegra/hub.c
@@ -1101,7 +1101,7 @@ static int tegra_display_hub_probe(struct platform_device *pdev)
for (i = 0; i < hub->soc->num_wgrps; i++) {
struct tegra_windowgroup *wgrp = &hub->wgrps[i];
- char id[8];
+ char id[16];
snprintf(id, sizeof(id), "wgrp%u", i);
mutex_init(&wgrp->lock);
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* Re: [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored
2023-08-24 7:37 ` Lee Jones
@ 2023-08-24 9:25 ` Thierry Reding
-1 siblings, 0 replies; 159+ messages in thread
From: Thierry Reding @ 2023-08-24 9:25 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Mikko Perttunen, David Airlie, Daniel Vetter,
Jonathan Hunter, Philipp Zabel, dri-devel, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 2029 bytes --]
On Thu, Aug 24, 2023 at 08:37:00AM +0100, Lee Jones wrote:
> When converting from int to string, we must allow for up to 10-chars (2147483647).
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/tegra/hub.c: In function ‘tegra_display_hub_probe’:
> drivers/gpu/drm/tegra/hub.c:1106:47: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
> drivers/gpu/drm/tegra/hub.c:1106:42: note: directive argument in the range [0, 4294967294]
> drivers/gpu/drm/tegra/hub.c:1106:17: note: ‘snprintf’ output between 6 and 15 bytes into a destination of size 8
I wish there was (perhaps there is?) a better way to annotate that i
will always be within a given range. In practice this is always going to
be smaller than 10 and even in future hardware I wouldn't expect this to
ever exceed anything like 32 or 64, so 8 characters is already generous.
Thierry
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Mikko Perttunen <mperttunen@nvidia.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-tegra@vger.kernel.org
> ---
> drivers/gpu/drm/tegra/hub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c
> index 1af5f8318d914..f21e57e8599ee 100644
> --- a/drivers/gpu/drm/tegra/hub.c
> +++ b/drivers/gpu/drm/tegra/hub.c
> @@ -1101,7 +1101,7 @@ static int tegra_display_hub_probe(struct platform_device *pdev)
>
> for (i = 0; i < hub->soc->num_wgrps; i++) {
> struct tegra_windowgroup *wgrp = &hub->wgrps[i];
> - char id[8];
> + char id[16];
>
> snprintf(id, sizeof(id), "wgrp%u", i);
> mutex_init(&wgrp->lock);
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored
@ 2023-08-24 9:25 ` Thierry Reding
0 siblings, 0 replies; 159+ messages in thread
From: Thierry Reding @ 2023-08-24 9:25 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, dri-devel, Jonathan Hunter, linux-tegra,
Mikko Perttunen
[-- Attachment #1: Type: text/plain, Size: 2029 bytes --]
On Thu, Aug 24, 2023 at 08:37:00AM +0100, Lee Jones wrote:
> When converting from int to string, we must allow for up to 10-chars (2147483647).
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/tegra/hub.c: In function ‘tegra_display_hub_probe’:
> drivers/gpu/drm/tegra/hub.c:1106:47: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
> drivers/gpu/drm/tegra/hub.c:1106:42: note: directive argument in the range [0, 4294967294]
> drivers/gpu/drm/tegra/hub.c:1106:17: note: ‘snprintf’ output between 6 and 15 bytes into a destination of size 8
I wish there was (perhaps there is?) a better way to annotate that i
will always be within a given range. In practice this is always going to
be smaller than 10 and even in future hardware I wouldn't expect this to
ever exceed anything like 32 or 64, so 8 characters is already generous.
Thierry
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Mikko Perttunen <mperttunen@nvidia.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-tegra@vger.kernel.org
> ---
> drivers/gpu/drm/tegra/hub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c
> index 1af5f8318d914..f21e57e8599ee 100644
> --- a/drivers/gpu/drm/tegra/hub.c
> +++ b/drivers/gpu/drm/tegra/hub.c
> @@ -1101,7 +1101,7 @@ static int tegra_display_hub_probe(struct platform_device *pdev)
>
> for (i = 0; i < hub->soc->num_wgrps; i++) {
> struct tegra_windowgroup *wgrp = &hub->wgrps[i];
> - char id[8];
> + char id[16];
>
> snprintf(id, sizeof(id), "wgrp%u", i);
> mutex_init(&wgrp->lock);
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored
2023-08-24 9:25 ` Thierry Reding
@ 2023-08-24 9:33 ` Jani Nikula
-1 siblings, 0 replies; 159+ messages in thread
From: Jani Nikula @ 2023-08-24 9:33 UTC (permalink / raw)
To: Thierry Reding, Lee Jones
Cc: linux-kernel, dri-devel, Jonathan Hunter, linux-tegra,
Mikko Perttunen
On Thu, 24 Aug 2023, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Thu, Aug 24, 2023 at 08:37:00AM +0100, Lee Jones wrote:
>> When converting from int to string, we must allow for up to 10-chars (2147483647).
>>
>> Fixes the following W=1 kernel build warning(s):
>>
>> drivers/gpu/drm/tegra/hub.c: In function ‘tegra_display_hub_probe’:
>> drivers/gpu/drm/tegra/hub.c:1106:47: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
>> drivers/gpu/drm/tegra/hub.c:1106:42: note: directive argument in the range [0, 4294967294]
>> drivers/gpu/drm/tegra/hub.c:1106:17: note: ‘snprintf’ output between 6 and 15 bytes into a destination of size 8
>
> I wish there was (perhaps there is?) a better way to annotate that i
> will always be within a given range. In practice this is always going to
> be smaller than 10 and even in future hardware I wouldn't expect this to
> ever exceed anything like 32 or 64, so 8 characters is already generous.
I assume you could do
snprintf(id, sizeof(id), "wgrp%u", (unsigned char)i);
but it's perhaps less obvious than just increasing the size of the
buffer.
BR,
Jani.
>
> Thierry
>
>>
>> Signed-off-by: Lee Jones <lee@kernel.org>
>> ---
>> Cc: Thierry Reding <thierry.reding@gmail.com>
>> Cc: Mikko Perttunen <mperttunen@nvidia.com>
>> Cc: David Airlie <airlied@gmail.com>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Cc: Jonathan Hunter <jonathanh@nvidia.com>
>> Cc: Philipp Zabel <p.zabel@pengutronix.de>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-tegra@vger.kernel.org
>> ---
>> drivers/gpu/drm/tegra/hub.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c
>> index 1af5f8318d914..f21e57e8599ee 100644
>> --- a/drivers/gpu/drm/tegra/hub.c
>> +++ b/drivers/gpu/drm/tegra/hub.c
>> @@ -1101,7 +1101,7 @@ static int tegra_display_hub_probe(struct platform_device *pdev)
>>
>> for (i = 0; i < hub->soc->num_wgrps; i++) {
>> struct tegra_windowgroup *wgrp = &hub->wgrps[i];
>> - char id[8];
>> + char id[16];
>>
>> snprintf(id, sizeof(id), "wgrp%u", i);
>> mutex_init(&wgrp->lock);
>> --
>> 2.42.0.rc1.204.g551eb34607-goog
>>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored
@ 2023-08-24 9:33 ` Jani Nikula
0 siblings, 0 replies; 159+ messages in thread
From: Jani Nikula @ 2023-08-24 9:33 UTC (permalink / raw)
To: Thierry Reding, Lee Jones
Cc: linux-tegra, Mikko Perttunen, linux-kernel, dri-devel,
Jonathan Hunter
On Thu, 24 Aug 2023, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Thu, Aug 24, 2023 at 08:37:00AM +0100, Lee Jones wrote:
>> When converting from int to string, we must allow for up to 10-chars (2147483647).
>>
>> Fixes the following W=1 kernel build warning(s):
>>
>> drivers/gpu/drm/tegra/hub.c: In function ‘tegra_display_hub_probe’:
>> drivers/gpu/drm/tegra/hub.c:1106:47: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
>> drivers/gpu/drm/tegra/hub.c:1106:42: note: directive argument in the range [0, 4294967294]
>> drivers/gpu/drm/tegra/hub.c:1106:17: note: ‘snprintf’ output between 6 and 15 bytes into a destination of size 8
>
> I wish there was (perhaps there is?) a better way to annotate that i
> will always be within a given range. In practice this is always going to
> be smaller than 10 and even in future hardware I wouldn't expect this to
> ever exceed anything like 32 or 64, so 8 characters is already generous.
I assume you could do
snprintf(id, sizeof(id), "wgrp%u", (unsigned char)i);
but it's perhaps less obvious than just increasing the size of the
buffer.
BR,
Jani.
>
> Thierry
>
>>
>> Signed-off-by: Lee Jones <lee@kernel.org>
>> ---
>> Cc: Thierry Reding <thierry.reding@gmail.com>
>> Cc: Mikko Perttunen <mperttunen@nvidia.com>
>> Cc: David Airlie <airlied@gmail.com>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Cc: Jonathan Hunter <jonathanh@nvidia.com>
>> Cc: Philipp Zabel <p.zabel@pengutronix.de>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-tegra@vger.kernel.org
>> ---
>> drivers/gpu/drm/tegra/hub.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c
>> index 1af5f8318d914..f21e57e8599ee 100644
>> --- a/drivers/gpu/drm/tegra/hub.c
>> +++ b/drivers/gpu/drm/tegra/hub.c
>> @@ -1101,7 +1101,7 @@ static int tegra_display_hub_probe(struct platform_device *pdev)
>>
>> for (i = 0; i < hub->soc->num_wgrps; i++) {
>> struct tegra_windowgroup *wgrp = &hub->wgrps[i];
>> - char id[8];
>> + char id[16];
>>
>> snprintf(id, sizeof(id), "wgrp%u", i);
>> mutex_init(&wgrp->lock);
>> --
>> 2.42.0.rc1.204.g551eb34607-goog
>>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored
2023-08-24 9:33 ` Jani Nikula
@ 2023-08-24 12:01 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:01 UTC (permalink / raw)
To: Jani Nikula
Cc: Thierry Reding, linux-kernel, dri-devel, Jonathan Hunter,
linux-tegra, Mikko Perttunen
On Thu, 24 Aug 2023, Jani Nikula wrote:
> On Thu, 24 Aug 2023, Thierry Reding <thierry.reding@gmail.com> wrote:
> > On Thu, Aug 24, 2023 at 08:37:00AM +0100, Lee Jones wrote:
> >> When converting from int to string, we must allow for up to 10-chars (2147483647).
> >>
> >> Fixes the following W=1 kernel build warning(s):
> >>
> >> drivers/gpu/drm/tegra/hub.c: In function ‘tegra_display_hub_probe’:
> >> drivers/gpu/drm/tegra/hub.c:1106:47: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
> >> drivers/gpu/drm/tegra/hub.c:1106:42: note: directive argument in the range [0, 4294967294]
> >> drivers/gpu/drm/tegra/hub.c:1106:17: note: ‘snprintf’ output between 6 and 15 bytes into a destination of size 8
> >
> > I wish there was (perhaps there is?) a better way to annotate that i
> > will always be within a given range. In practice this is always going to
> > be smaller than 10 and even in future hardware I wouldn't expect this to
> > ever exceed anything like 32 or 64, so 8 characters is already generous.
>
> I assume you could do
>
> snprintf(id, sizeof(id), "wgrp%u", (unsigned char)i);
>
> but it's perhaps less obvious than just increasing the size of the
> buffer.
I had the very same thought process.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored
@ 2023-08-24 12:01 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:01 UTC (permalink / raw)
To: Jani Nikula
Cc: linux-kernel, dri-devel, Mikko Perttunen, Thierry Reding,
linux-tegra, Jonathan Hunter
On Thu, 24 Aug 2023, Jani Nikula wrote:
> On Thu, 24 Aug 2023, Thierry Reding <thierry.reding@gmail.com> wrote:
> > On Thu, Aug 24, 2023 at 08:37:00AM +0100, Lee Jones wrote:
> >> When converting from int to string, we must allow for up to 10-chars (2147483647).
> >>
> >> Fixes the following W=1 kernel build warning(s):
> >>
> >> drivers/gpu/drm/tegra/hub.c: In function ‘tegra_display_hub_probe’:
> >> drivers/gpu/drm/tegra/hub.c:1106:47: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
> >> drivers/gpu/drm/tegra/hub.c:1106:42: note: directive argument in the range [0, 4294967294]
> >> drivers/gpu/drm/tegra/hub.c:1106:17: note: ‘snprintf’ output between 6 and 15 bytes into a destination of size 8
> >
> > I wish there was (perhaps there is?) a better way to annotate that i
> > will always be within a given range. In practice this is always going to
> > be smaller than 10 and even in future hardware I wouldn't expect this to
> > ever exceed anything like 32 or 64, so 8 characters is already generous.
>
> I assume you could do
>
> snprintf(id, sizeof(id), "wgrp%u", (unsigned char)i);
>
> but it's perhaps less obvious than just increasing the size of the
> buffer.
I had the very same thought process.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored
2023-08-24 12:01 ` Lee Jones
@ 2023-08-24 13:45 ` Thierry Reding
-1 siblings, 0 replies; 159+ messages in thread
From: Thierry Reding @ 2023-08-24 13:45 UTC (permalink / raw)
To: Lee Jones
Cc: Jani Nikula, linux-kernel, dri-devel, Jonathan Hunter,
linux-tegra, Mikko Perttunen
[-- Attachment #1: Type: text/plain, Size: 1912 bytes --]
On Thu, Aug 24, 2023 at 01:01:24PM +0100, Lee Jones wrote:
> On Thu, 24 Aug 2023, Jani Nikula wrote:
>
> > On Thu, 24 Aug 2023, Thierry Reding <thierry.reding@gmail.com> wrote:
> > > On Thu, Aug 24, 2023 at 08:37:00AM +0100, Lee Jones wrote:
> > >> When converting from int to string, we must allow for up to 10-chars (2147483647).
> > >>
> > >> Fixes the following W=1 kernel build warning(s):
> > >>
> > >> drivers/gpu/drm/tegra/hub.c: In function ‘tegra_display_hub_probe’:
> > >> drivers/gpu/drm/tegra/hub.c:1106:47: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
> > >> drivers/gpu/drm/tegra/hub.c:1106:42: note: directive argument in the range [0, 4294967294]
> > >> drivers/gpu/drm/tegra/hub.c:1106:17: note: ‘snprintf’ output between 6 and 15 bytes into a destination of size 8
> > >
> > > I wish there was (perhaps there is?) a better way to annotate that i
> > > will always be within a given range. In practice this is always going to
> > > be smaller than 10 and even in future hardware I wouldn't expect this to
> > > ever exceed anything like 32 or 64, so 8 characters is already generous.
> >
> > I assume you could do
> >
> > snprintf(id, sizeof(id), "wgrp%u", (unsigned char)i);
> >
> > but it's perhaps less obvious than just increasing the size of the
> > buffer.
>
> I had the very same thought process.
It's not a big deal, this happens all on the stack, so adding a couple
of bytes isn't going to hurt very much. Still with all the tooling that
we have it'd be nice if something could be added. Perhaps an alternative
would be to reject values for num_wgrp that are bigger than 32. With
that the compiler might have enough information not to warn about this.
Anyway, no need to spend any more time on this, I'm fine with the patch
as-is.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored
@ 2023-08-24 13:45 ` Thierry Reding
0 siblings, 0 replies; 159+ messages in thread
From: Thierry Reding @ 2023-08-24 13:45 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, dri-devel, Mikko Perttunen, linux-tegra,
Jonathan Hunter
[-- Attachment #1: Type: text/plain, Size: 1912 bytes --]
On Thu, Aug 24, 2023 at 01:01:24PM +0100, Lee Jones wrote:
> On Thu, 24 Aug 2023, Jani Nikula wrote:
>
> > On Thu, 24 Aug 2023, Thierry Reding <thierry.reding@gmail.com> wrote:
> > > On Thu, Aug 24, 2023 at 08:37:00AM +0100, Lee Jones wrote:
> > >> When converting from int to string, we must allow for up to 10-chars (2147483647).
> > >>
> > >> Fixes the following W=1 kernel build warning(s):
> > >>
> > >> drivers/gpu/drm/tegra/hub.c: In function ‘tegra_display_hub_probe’:
> > >> drivers/gpu/drm/tegra/hub.c:1106:47: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
> > >> drivers/gpu/drm/tegra/hub.c:1106:42: note: directive argument in the range [0, 4294967294]
> > >> drivers/gpu/drm/tegra/hub.c:1106:17: note: ‘snprintf’ output between 6 and 15 bytes into a destination of size 8
> > >
> > > I wish there was (perhaps there is?) a better way to annotate that i
> > > will always be within a given range. In practice this is always going to
> > > be smaller than 10 and even in future hardware I wouldn't expect this to
> > > ever exceed anything like 32 or 64, so 8 characters is already generous.
> >
> > I assume you could do
> >
> > snprintf(id, sizeof(id), "wgrp%u", (unsigned char)i);
> >
> > but it's perhaps less obvious than just increasing the size of the
> > buffer.
>
> I had the very same thought process.
It's not a big deal, this happens all on the stack, so adding a couple
of bytes isn't going to hurt very much. Still with all the tooling that
we have it'd be nice if something could be added. Perhaps an alternative
would be to reject values for num_wgrp that are bigger than 32. With
that the compiler might have enough information not to warn about this.
Anyway, no need to spend any more time on this, I'm fine with the patch
as-is.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 159+ messages in thread
* [PATCH 16/20] drm/drm_connector: Provide short description of param 'supported_colorspaces'
2023-08-24 7:36 ` Lee Jones
@ 2023-08-24 7:37 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:37 UTC (permalink / raw)
To: lee; +Cc: Thomas Zimmermann, linux-kernel, Maxime Ripard, dri-devel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/drm_connector.c:2215: warning: Function parameter or member 'supported_colorspaces' not described in 'drm_mode_create_hdmi_colorspace_property'
drivers/gpu/drm/drm_connector.c:2239: warning: Function parameter or member 'supported_colorspaces' not described in 'drm_mode_create_dp_colorspace_property'
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/drm_connector.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index bf8371dc2a612..c44d5bcf12847 100644
--- a/drivers/gpu/drm/drm_connector.c
+++ b/drivers/gpu/drm/drm_connector.c
@@ -2203,6 +2203,7 @@ static int drm_mode_create_colorspace_property(struct drm_connector *connector,
/**
* drm_mode_create_hdmi_colorspace_property - create hdmi colorspace property
* @connector: connector to create the Colorspace property on.
+ * @supported_colorspaces: bitmap of supported color spaces
*
* Called by a driver the first time it's needed, must be attached to desired
* HDMI connectors.
@@ -2227,6 +2228,7 @@ EXPORT_SYMBOL(drm_mode_create_hdmi_colorspace_property);
/**
* drm_mode_create_dp_colorspace_property - create dp colorspace property
* @connector: connector to create the Colorspace property on.
+ * @supported_colorspaces: bitmap of supported color spaces
*
* Called by a driver the first time it's needed, must be attached to desired
* DP connectors.
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 16/20] drm/drm_connector: Provide short description of param 'supported_colorspaces'
@ 2023-08-24 7:37 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:37 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, dri-devel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/drm_connector.c:2215: warning: Function parameter or member 'supported_colorspaces' not described in 'drm_mode_create_hdmi_colorspace_property'
drivers/gpu/drm/drm_connector.c:2239: warning: Function parameter or member 'supported_colorspaces' not described in 'drm_mode_create_dp_colorspace_property'
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/drm_connector.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index bf8371dc2a612..c44d5bcf12847 100644
--- a/drivers/gpu/drm/drm_connector.c
+++ b/drivers/gpu/drm/drm_connector.c
@@ -2203,6 +2203,7 @@ static int drm_mode_create_colorspace_property(struct drm_connector *connector,
/**
* drm_mode_create_hdmi_colorspace_property - create hdmi colorspace property
* @connector: connector to create the Colorspace property on.
+ * @supported_colorspaces: bitmap of supported color spaces
*
* Called by a driver the first time it's needed, must be attached to desired
* HDMI connectors.
@@ -2227,6 +2228,7 @@ EXPORT_SYMBOL(drm_mode_create_hdmi_colorspace_property);
/**
* drm_mode_create_dp_colorspace_property - create dp colorspace property
* @connector: connector to create the Colorspace property on.
+ * @supported_colorspaces: bitmap of supported color spaces
*
* Called by a driver the first time it's needed, must be attached to desired
* DP connectors.
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* Re: (subset) [PATCH 16/20] drm/drm_connector: Provide short description of param 'supported_colorspaces'
2023-08-24 7:37 ` Lee Jones
@ 2023-08-24 9:00 ` Maxime Ripard
-1 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 9:00 UTC (permalink / raw)
To: Lee Jones; +Cc: Thomas Zimmermann, linux-kernel, dri-devel
On Thu, 24 Aug 2023 08:37:01 +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/drm_connector.c:2215: warning: Function parameter or member 'supported_colorspaces' not described in 'drm_mode_create_hdmi_colorspace_property'
> drivers/gpu/drm/drm_connector.c:2239: warning: Function parameter or member 'supported_colorspaces' not described in 'drm_mode_create_dp_colorspace_property'
>
>
Applied to drm/drm-misc (drm-misc-fixes).
Thanks!
Maxime
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: (subset) [PATCH 16/20] drm/drm_connector: Provide short description of param 'supported_colorspaces'
@ 2023-08-24 9:00 ` Maxime Ripard
0 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 9:00 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Maarten Lankhorst, Thomas Zimmermann, David Airlie,
Daniel Vetter, dri-devel
On Thu, 24 Aug 2023 08:37:01 +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/drm_connector.c:2215: warning: Function parameter or member 'supported_colorspaces' not described in 'drm_mode_create_hdmi_colorspace_property'
> drivers/gpu/drm/drm_connector.c:2239: warning: Function parameter or member 'supported_colorspaces' not described in 'drm_mode_create_dp_colorspace_property'
>
>
Applied to drm/drm-misc (drm-misc-fixes).
Thanks!
Maxime
^ permalink raw reply [flat|nested] 159+ messages in thread
* [PATCH 17/20] drm/amd/amdgpu/amdgpu_ras: Increase buffer size to account for all possible values
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 7:37 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:37 UTC (permalink / raw)
To: lee
Cc: Pan, Xinhui, linux-kernel, amd-gfx, dri-devel, Daniel Vetter,
Alex Deucher, David Airlie, Christian König, Hawking Zhang
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_sysfs_create’:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1406:20: warning: ‘_err_count’ directive output may be truncated writing 10 bytes into a region of size between 1 and 32 [-Wformat-truncation=]
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1405:9: note: ‘snprintf’ output between 11 and 42 bytes into a destination of size 32
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
index ffb49b2d533ad..7999d202c9bc5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
@@ -436,7 +436,7 @@ struct amdgpu_ras {
};
struct ras_fs_data {
- char sysfs_name[32];
+ char sysfs_name[48];
char debugfs_name[32];
};
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* [PATCH 17/20] drm/amd/amdgpu/amdgpu_ras: Increase buffer size to account for all possible values
@ 2023-08-24 7:37 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:37 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter, Hawking Zhang, amd-gfx, dri-devel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_sysfs_create’:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1406:20: warning: ‘_err_count’ directive output may be truncated writing 10 bytes into a region of size between 1 and 32 [-Wformat-truncation=]
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1405:9: note: ‘snprintf’ output between 11 and 42 bytes into a destination of size 32
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
index ffb49b2d533ad..7999d202c9bc5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
@@ -436,7 +436,7 @@ struct amdgpu_ras {
};
struct ras_fs_data {
- char sysfs_name[32];
+ char sysfs_name[48];
char debugfs_name[32];
};
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* [PATCH 17/20] drm/amd/amdgpu/amdgpu_ras: Increase buffer size to account for all possible values
@ 2023-08-24 7:37 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:37 UTC (permalink / raw)
To: lee
Cc: Pan, Xinhui, linux-kernel, amd-gfx, dri-devel, Alex Deucher,
Christian König, Hawking Zhang
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_sysfs_create’:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1406:20: warning: ‘_err_count’ directive output may be truncated writing 10 bytes into a region of size between 1 and 32 [-Wformat-truncation=]
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1405:9: note: ‘snprintf’ output between 11 and 42 bytes into a destination of size 32
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
index ffb49b2d533ad..7999d202c9bc5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
@@ -436,7 +436,7 @@ struct amdgpu_ras {
};
struct ras_fs_data {
- char sysfs_name[32];
+ char sysfs_name[48];
char debugfs_name[32];
};
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* Re: [PATCH 17/20] drm/amd/amdgpu/amdgpu_ras: Increase buffer size to account for all possible values
2023-08-24 7:37 ` Lee Jones
(?)
@ 2023-08-24 14:55 ` Alex Deucher
-1 siblings, 0 replies; 159+ messages in thread
From: Alex Deucher @ 2023-08-24 14:55 UTC (permalink / raw)
To: Lee Jones
Cc: Pan, Xinhui, linux-kernel, dri-devel, amd-gfx, Daniel Vetter,
Alex Deucher, David Airlie, Christian König, Hawking Zhang
Applied. Thanks!
On Thu, Aug 24, 2023 at 3:38 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_sysfs_create’:
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1406:20: warning: ‘_err_count’ directive output may be truncated writing 10 bytes into a region of size between 1 and 32 [-Wformat-truncation=]
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1405:9: note: ‘snprintf’ output between 11 and 42 bytes into a destination of size 32
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
> index ffb49b2d533ad..7999d202c9bc5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
> @@ -436,7 +436,7 @@ struct amdgpu_ras {
> };
>
> struct ras_fs_data {
> - char sysfs_name[32];
> + char sysfs_name[48];
> char debugfs_name[32];
> };
>
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 17/20] drm/amd/amdgpu/amdgpu_ras: Increase buffer size to account for all possible values
@ 2023-08-24 14:55 ` Alex Deucher
0 siblings, 0 replies; 159+ messages in thread
From: Alex Deucher @ 2023-08-24 14:55 UTC (permalink / raw)
To: Lee Jones
Cc: Pan, Xinhui, linux-kernel, amd-gfx, dri-devel, Daniel Vetter,
Alex Deucher, David Airlie, Christian König, Hawking Zhang
Applied. Thanks!
On Thu, Aug 24, 2023 at 3:38 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_sysfs_create’:
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1406:20: warning: ‘_err_count’ directive output may be truncated writing 10 bytes into a region of size between 1 and 32 [-Wformat-truncation=]
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1405:9: note: ‘snprintf’ output between 11 and 42 bytes into a destination of size 32
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
> index ffb49b2d533ad..7999d202c9bc5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
> @@ -436,7 +436,7 @@ struct amdgpu_ras {
> };
>
> struct ras_fs_data {
> - char sysfs_name[32];
> + char sysfs_name[48];
> char debugfs_name[32];
> };
>
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 17/20] drm/amd/amdgpu/amdgpu_ras: Increase buffer size to account for all possible values
@ 2023-08-24 14:55 ` Alex Deucher
0 siblings, 0 replies; 159+ messages in thread
From: Alex Deucher @ 2023-08-24 14:55 UTC (permalink / raw)
To: Lee Jones
Cc: Pan, Xinhui, linux-kernel, dri-devel, amd-gfx, Alex Deucher,
Christian König, Hawking Zhang
Applied. Thanks!
On Thu, Aug 24, 2023 at 3:38 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_sysfs_create’:
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1406:20: warning: ‘_err_count’ directive output may be truncated writing 10 bytes into a region of size between 1 and 32 [-Wformat-truncation=]
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1405:9: note: ‘snprintf’ output between 11 and 42 bytes into a destination of size 32
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
> index ffb49b2d533ad..7999d202c9bc5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
> @@ -436,7 +436,7 @@ struct amdgpu_ras {
> };
>
> struct ras_fs_data {
> - char sysfs_name[32];
> + char sysfs_name[48];
> char debugfs_name[32];
> };
>
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
^ permalink raw reply [flat|nested] 159+ messages in thread
* [PATCH 18/20] drm/drm_gpuva_mgr: Remove set but unused variable 'prev'
2023-08-24 7:36 ` Lee Jones
@ 2023-08-24 7:37 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:37 UTC (permalink / raw)
To: lee
Cc: Thomas Zimmermann, linux-kernel, Maxime Ripard,
Christian König, linaro-mm-sig, Danilo Krummrich, dri-devel,
Sumit Semwal, linux-media
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/drm_gpuva_mgr.c: In function ‘__drm_gpuva_sm_map’:
drivers/gpu/drm/drm_gpuva_mgr.c:1079:39: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Danilo Krummrich <dakr@redhat.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
---
drivers/gpu/drm/drm_gpuva_mgr.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_gpuva_mgr.c b/drivers/gpu/drm/drm_gpuva_mgr.c
index f86bfad74ff8a..ad99c9cfedac7 100644
--- a/drivers/gpu/drm/drm_gpuva_mgr.c
+++ b/drivers/gpu/drm/drm_gpuva_mgr.c
@@ -1076,7 +1076,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
u64 req_addr, u64 req_range,
struct drm_gem_object *req_obj, u64 req_offset)
{
- struct drm_gpuva *va, *next, *prev = NULL;
+ struct drm_gpuva *va, *next;
u64 req_end = req_addr + req_range;
int ret;
@@ -1106,7 +1106,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
ret = op_unmap_cb(ops, priv, va, merge);
if (ret)
return ret;
- goto next;
+ continue;
}
if (end > req_end) {
@@ -1151,7 +1151,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
ret = op_remap_cb(ops, priv, &p, NULL, &u);
if (ret)
return ret;
- goto next;
+ continue;
}
if (end > req_end) {
@@ -1184,7 +1184,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
ret = op_unmap_cb(ops, priv, va, merge);
if (ret)
return ret;
- goto next;
+ continue;
}
if (end > req_end) {
@@ -1205,8 +1205,6 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
break;
}
}
-next:
- prev = va;
}
return op_map_cb(ops, priv,
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* [PATCH 18/20] drm/drm_gpuva_mgr: Remove set but unused variable 'prev'
@ 2023-08-24 7:37 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:37 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Sumit Semwal, Christian König,
Danilo Krummrich, dri-devel, linux-media, linaro-mm-sig
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/drm_gpuva_mgr.c: In function ‘__drm_gpuva_sm_map’:
drivers/gpu/drm/drm_gpuva_mgr.c:1079:39: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Danilo Krummrich <dakr@redhat.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
---
drivers/gpu/drm/drm_gpuva_mgr.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_gpuva_mgr.c b/drivers/gpu/drm/drm_gpuva_mgr.c
index f86bfad74ff8a..ad99c9cfedac7 100644
--- a/drivers/gpu/drm/drm_gpuva_mgr.c
+++ b/drivers/gpu/drm/drm_gpuva_mgr.c
@@ -1076,7 +1076,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
u64 req_addr, u64 req_range,
struct drm_gem_object *req_obj, u64 req_offset)
{
- struct drm_gpuva *va, *next, *prev = NULL;
+ struct drm_gpuva *va, *next;
u64 req_end = req_addr + req_range;
int ret;
@@ -1106,7 +1106,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
ret = op_unmap_cb(ops, priv, va, merge);
if (ret)
return ret;
- goto next;
+ continue;
}
if (end > req_end) {
@@ -1151,7 +1151,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
ret = op_remap_cb(ops, priv, &p, NULL, &u);
if (ret)
return ret;
- goto next;
+ continue;
}
if (end > req_end) {
@@ -1184,7 +1184,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
ret = op_unmap_cb(ops, priv, va, merge);
if (ret)
return ret;
- goto next;
+ continue;
}
if (end > req_end) {
@@ -1205,8 +1205,6 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
break;
}
}
-next:
- prev = va;
}
return op_map_cb(ops, priv,
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* Re: [PATCH 18/20] drm/drm_gpuva_mgr: Remove set but unused variable 'prev'
2023-08-24 7:37 ` Lee Jones
@ 2023-08-24 12:53 ` Danilo Krummrich
-1 siblings, 0 replies; 159+ messages in thread
From: Danilo Krummrich @ 2023-08-24 12:53 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Maxime Ripard, Sumit Semwal, linaro-mm-sig,
dri-devel, Thomas Zimmermann, Christian König, linux-media
Hi Lee,
On 8/24/23 09:37, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/drm_gpuva_mgr.c: In function ‘__drm_gpuva_sm_map’:
> drivers/gpu/drm/drm_gpuva_mgr.c:1079:39: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable]
Thanks for fixing this up.
However, I already had a patch in the queue addressing the warning,
which I already applied to drm-misc/drm-misc-next-fixes.
- Danilo
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Danilo Krummrich <dakr@redhat.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-media@vger.kernel.org
> Cc: linaro-mm-sig@lists.linaro.org
> ---
> drivers/gpu/drm/drm_gpuva_mgr.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gpuva_mgr.c b/drivers/gpu/drm/drm_gpuva_mgr.c
> index f86bfad74ff8a..ad99c9cfedac7 100644
> --- a/drivers/gpu/drm/drm_gpuva_mgr.c
> +++ b/drivers/gpu/drm/drm_gpuva_mgr.c
> @@ -1076,7 +1076,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
> u64 req_addr, u64 req_range,
> struct drm_gem_object *req_obj, u64 req_offset)
> {
> - struct drm_gpuva *va, *next, *prev = NULL;
> + struct drm_gpuva *va, *next;
> u64 req_end = req_addr + req_range;
> int ret;
>
> @@ -1106,7 +1106,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
> ret = op_unmap_cb(ops, priv, va, merge);
> if (ret)
> return ret;
> - goto next;
> + continue;
> }
>
> if (end > req_end) {
> @@ -1151,7 +1151,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
> ret = op_remap_cb(ops, priv, &p, NULL, &u);
> if (ret)
> return ret;
> - goto next;
> + continue;
> }
>
> if (end > req_end) {
> @@ -1184,7 +1184,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
> ret = op_unmap_cb(ops, priv, va, merge);
> if (ret)
> return ret;
> - goto next;
> + continue;
> }
>
> if (end > req_end) {
> @@ -1205,8 +1205,6 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
> break;
> }
> }
> -next:
> - prev = va;
> }
>
> return op_map_cb(ops, priv,
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 18/20] drm/drm_gpuva_mgr: Remove set but unused variable 'prev'
@ 2023-08-24 12:53 ` Danilo Krummrich
0 siblings, 0 replies; 159+ messages in thread
From: Danilo Krummrich @ 2023-08-24 12:53 UTC (permalink / raw)
To: Lee Jones
Cc: Thomas Zimmermann, linux-kernel, Maxime Ripard,
Christian König, linaro-mm-sig, dri-devel, Sumit Semwal,
linux-media
Hi Lee,
On 8/24/23 09:37, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/drm_gpuva_mgr.c: In function ‘__drm_gpuva_sm_map’:
> drivers/gpu/drm/drm_gpuva_mgr.c:1079:39: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable]
Thanks for fixing this up.
However, I already had a patch in the queue addressing the warning,
which I already applied to drm-misc/drm-misc-next-fixes.
- Danilo
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Danilo Krummrich <dakr@redhat.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-media@vger.kernel.org
> Cc: linaro-mm-sig@lists.linaro.org
> ---
> drivers/gpu/drm/drm_gpuva_mgr.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gpuva_mgr.c b/drivers/gpu/drm/drm_gpuva_mgr.c
> index f86bfad74ff8a..ad99c9cfedac7 100644
> --- a/drivers/gpu/drm/drm_gpuva_mgr.c
> +++ b/drivers/gpu/drm/drm_gpuva_mgr.c
> @@ -1076,7 +1076,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
> u64 req_addr, u64 req_range,
> struct drm_gem_object *req_obj, u64 req_offset)
> {
> - struct drm_gpuva *va, *next, *prev = NULL;
> + struct drm_gpuva *va, *next;
> u64 req_end = req_addr + req_range;
> int ret;
>
> @@ -1106,7 +1106,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
> ret = op_unmap_cb(ops, priv, va, merge);
> if (ret)
> return ret;
> - goto next;
> + continue;
> }
>
> if (end > req_end) {
> @@ -1151,7 +1151,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
> ret = op_remap_cb(ops, priv, &p, NULL, &u);
> if (ret)
> return ret;
> - goto next;
> + continue;
> }
>
> if (end > req_end) {
> @@ -1184,7 +1184,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
> ret = op_unmap_cb(ops, priv, va, merge);
> if (ret)
> return ret;
> - goto next;
> + continue;
> }
>
> if (end > req_end) {
> @@ -1205,8 +1205,6 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr,
> break;
> }
> }
> -next:
> - prev = va;
> }
>
> return op_map_cb(ops, priv,
^ permalink raw reply [flat|nested] 159+ messages in thread
* [PATCH 19/20] drm/amd/amdgpu/amdgpu_sdma: Increase buffer size to account for all possible values
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 7:37 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:37 UTC (permalink / raw)
To: lee
Cc: Pan, Xinhui, linux-kernel, amd-gfx, dri-devel, Daniel Vetter,
Alex Deucher, David Airlie, Christian König
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c: In function ‘amdgpu_sdma_init_microcode’:
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:217:64: warning: ‘.bin’ directive output may be truncated writing 4 bytes into a region of size between 0 and 32 [-Wformat-truncation=]
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:217:17: note: ‘snprintf’ output between 13 and 52 bytes into a destination of size 40
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:215:66: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=]
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:215:17: note: ‘snprintf’ output between 12 and 41 bytes into a destination of size 40
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
index e2b9392d7f0de..572f861e3f706 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
@@ -208,7 +208,7 @@ int amdgpu_sdma_init_microcode(struct amdgpu_device *adev,
const struct sdma_firmware_header_v2_0 *sdma_hdr;
uint16_t version_major;
char ucode_prefix[30];
- char fw_name[40];
+ char fw_name[52];
amdgpu_ucode_ip_version_decode(adev, SDMA0_HWIP, ucode_prefix, sizeof(ucode_prefix));
if (instance == 0)
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 19/20] drm/amd/amdgpu/amdgpu_sdma: Increase buffer size to account for all possible values
@ 2023-08-24 7:37 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:37 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter, amd-gfx, dri-devel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c: In function ‘amdgpu_sdma_init_microcode’:
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:217:64: warning: ‘.bin’ directive output may be truncated writing 4 bytes into a region of size between 0 and 32 [-Wformat-truncation=]
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:217:17: note: ‘snprintf’ output between 13 and 52 bytes into a destination of size 40
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:215:66: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=]
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:215:17: note: ‘snprintf’ output between 12 and 41 bytes into a destination of size 40
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
index e2b9392d7f0de..572f861e3f706 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
@@ -208,7 +208,7 @@ int amdgpu_sdma_init_microcode(struct amdgpu_device *adev,
const struct sdma_firmware_header_v2_0 *sdma_hdr;
uint16_t version_major;
char ucode_prefix[30];
- char fw_name[40];
+ char fw_name[52];
amdgpu_ucode_ip_version_decode(adev, SDMA0_HWIP, ucode_prefix, sizeof(ucode_prefix));
if (instance == 0)
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* [PATCH 19/20] drm/amd/amdgpu/amdgpu_sdma: Increase buffer size to account for all possible values
@ 2023-08-24 7:37 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:37 UTC (permalink / raw)
To: lee
Cc: Pan, Xinhui, linux-kernel, amd-gfx, dri-devel, Alex Deucher,
Christian König
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c: In function ‘amdgpu_sdma_init_microcode’:
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:217:64: warning: ‘.bin’ directive output may be truncated writing 4 bytes into a region of size between 0 and 32 [-Wformat-truncation=]
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:217:17: note: ‘snprintf’ output between 13 and 52 bytes into a destination of size 40
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:215:66: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=]
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:215:17: note: ‘snprintf’ output between 12 and 41 bytes into a destination of size 40
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
index e2b9392d7f0de..572f861e3f706 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
@@ -208,7 +208,7 @@ int amdgpu_sdma_init_microcode(struct amdgpu_device *adev,
const struct sdma_firmware_header_v2_0 *sdma_hdr;
uint16_t version_major;
char ucode_prefix[30];
- char fw_name[40];
+ char fw_name[52];
amdgpu_ucode_ip_version_decode(adev, SDMA0_HWIP, ucode_prefix, sizeof(ucode_prefix));
if (instance == 0)
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread
* Re: [PATCH 19/20] drm/amd/amdgpu/amdgpu_sdma: Increase buffer size to account for all possible values
2023-08-24 7:37 ` Lee Jones
(?)
@ 2023-08-24 14:56 ` Alex Deucher
-1 siblings, 0 replies; 159+ messages in thread
From: Alex Deucher @ 2023-08-24 14:56 UTC (permalink / raw)
To: Lee Jones
Cc: Pan, Xinhui, linux-kernel, dri-devel, amd-gfx, Daniel Vetter,
Alex Deucher, David Airlie, Christian König
Applied. Thanks!
On Thu, Aug 24, 2023 at 3:38 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c: In function ‘amdgpu_sdma_init_microcode’:
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:217:64: warning: ‘.bin’ directive output may be truncated writing 4 bytes into a region of size between 0 and 32 [-Wformat-truncation=]
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:217:17: note: ‘snprintf’ output between 13 and 52 bytes into a destination of size 40
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:215:66: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=]
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:215:17: note: ‘snprintf’ output between 12 and 41 bytes into a destination of size 40
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
> index e2b9392d7f0de..572f861e3f706 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
> @@ -208,7 +208,7 @@ int amdgpu_sdma_init_microcode(struct amdgpu_device *adev,
> const struct sdma_firmware_header_v2_0 *sdma_hdr;
> uint16_t version_major;
> char ucode_prefix[30];
> - char fw_name[40];
> + char fw_name[52];
>
> amdgpu_ucode_ip_version_decode(adev, SDMA0_HWIP, ucode_prefix, sizeof(ucode_prefix));
> if (instance == 0)
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH 19/20] drm/amd/amdgpu/amdgpu_sdma: Increase buffer size to account for all possible values
@ 2023-08-24 14:56 ` Alex Deucher
0 siblings, 0 replies; 159+ messages in thread
From: Alex Deucher @ 2023-08-24 14:56 UTC (permalink / raw)
To: Lee Jones
Cc: Pan, Xinhui, linux-kernel, amd-gfx, dri-devel, Daniel Vetter,
Alex Deucher, David Airlie, Christian König
Applied. Thanks!
On Thu, Aug 24, 2023 at 3:38 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c: In function ‘amdgpu_sdma_init_microcode’:
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:217:64: warning: ‘.bin’ directive output may be truncated writing 4 bytes into a region of size between 0 and 32 [-Wformat-truncation=]
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:217:17: note: ‘snprintf’ output between 13 and 52 bytes into a destination of size 40
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:215:66: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=]
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:215:17: note: ‘snprintf’ output between 12 and 41 bytes into a destination of size 40
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
> index e2b9392d7f0de..572f861e3f706 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
> @@ -208,7 +208,7 @@ int amdgpu_sdma_init_microcode(struct amdgpu_device *adev,
> const struct sdma_firmware_header_v2_0 *sdma_hdr;
> uint16_t version_major;
> char ucode_prefix[30];
> - char fw_name[40];
> + char fw_name[52];
>
> amdgpu_ucode_ip_version_decode(adev, SDMA0_HWIP, ucode_prefix, sizeof(ucode_prefix));
> if (instance == 0)
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH 19/20] drm/amd/amdgpu/amdgpu_sdma: Increase buffer size to account for all possible values
@ 2023-08-24 14:56 ` Alex Deucher
0 siblings, 0 replies; 159+ messages in thread
From: Alex Deucher @ 2023-08-24 14:56 UTC (permalink / raw)
To: Lee Jones
Cc: Pan, Xinhui, linux-kernel, dri-devel, amd-gfx, Alex Deucher,
Christian König
Applied. Thanks!
On Thu, Aug 24, 2023 at 3:38 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c: In function ‘amdgpu_sdma_init_microcode’:
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:217:64: warning: ‘.bin’ directive output may be truncated writing 4 bytes into a region of size between 0 and 32 [-Wformat-truncation=]
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:217:17: note: ‘snprintf’ output between 13 and 52 bytes into a destination of size 40
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:215:66: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=]
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:215:17: note: ‘snprintf’ output between 12 and 41 bytes into a destination of size 40
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
> index e2b9392d7f0de..572f861e3f706 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
> @@ -208,7 +208,7 @@ int amdgpu_sdma_init_microcode(struct amdgpu_device *adev,
> const struct sdma_firmware_header_v2_0 *sdma_hdr;
> uint16_t version_major;
> char ucode_prefix[30];
> - char fw_name[40];
> + char fw_name[52];
>
> amdgpu_ucode_ip_version_decode(adev, SDMA0_HWIP, ucode_prefix, sizeof(ucode_prefix));
> if (instance == 0)
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
^ permalink raw reply [flat|nested] 159+ messages in thread
* [PATCH 20/20] drm/amd/amdgpu/imu_v11_0: Increase buffer size to ensure all possible values can be stored
2023-08-24 7:36 ` Lee Jones
(?)
@ 2023-08-24 7:37 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:37 UTC (permalink / raw)
To: lee
Cc: dri-devel, Pan, Xinhui, linux-kernel, amd-gfx, Mario Limonciello,
Daniel Vetter, Alex Deucher, David Airlie, Christian König
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/imu_v11_0.c: In function ‘imu_v11_0_init_microcode’:
drivers/gpu/drm/amd/amdgpu/imu_v11_0.c:52:54: warning: ‘_imu.bin’ directive output may be truncated writing 8 bytes into a region of size between 4 and 33 [-Wformat-truncation=]
drivers/gpu/drm/amd/amdgpu/imu_v11_0.c:52:9: note: ‘snprintf’ output between 16 and 45 bytes into a destination of size 40
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Mario Limonciello <mario.limonciello@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/amd/amdgpu/imu_v11_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c b/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
index 4ab90c7852c3e..ca123ff553477 100644
--- a/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
@@ -39,7 +39,7 @@ MODULE_FIRMWARE("amdgpu/gc_11_0_4_imu.bin");
static int imu_v11_0_init_microcode(struct amdgpu_device *adev)
{
- char fw_name[40];
+ char fw_name[45];
char ucode_prefix[30];
int err;
const struct imu_firmware_header_v1_0 *imu_hdr;
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* [PATCH 20/20] drm/amd/amdgpu/imu_v11_0: Increase buffer size to ensure all possible values can be stored
@ 2023-08-24 7:37 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:37 UTC (permalink / raw)
To: lee
Cc: linux-kernel, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter, Mario Limonciello, amd-gfx,
dri-devel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/imu_v11_0.c: In function ‘imu_v11_0_init_microcode’:
drivers/gpu/drm/amd/amdgpu/imu_v11_0.c:52:54: warning: ‘_imu.bin’ directive output may be truncated writing 8 bytes into a region of size between 4 and 33 [-Wformat-truncation=]
drivers/gpu/drm/amd/amdgpu/imu_v11_0.c:52:9: note: ‘snprintf’ output between 16 and 45 bytes into a destination of size 40
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Mario Limonciello <mario.limonciello@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/amd/amdgpu/imu_v11_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c b/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
index 4ab90c7852c3e..ca123ff553477 100644
--- a/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
@@ -39,7 +39,7 @@ MODULE_FIRMWARE("amdgpu/gc_11_0_4_imu.bin");
static int imu_v11_0_init_microcode(struct amdgpu_device *adev)
{
- char fw_name[40];
+ char fw_name[45];
char ucode_prefix[30];
int err;
const struct imu_firmware_header_v1_0 *imu_hdr;
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* [PATCH 20/20] drm/amd/amdgpu/imu_v11_0: Increase buffer size to ensure all possible values can be stored
@ 2023-08-24 7:37 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 7:37 UTC (permalink / raw)
To: lee
Cc: dri-devel, Pan, Xinhui, linux-kernel, amd-gfx, Mario Limonciello,
Alex Deucher, Christian König
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/imu_v11_0.c: In function ‘imu_v11_0_init_microcode’:
drivers/gpu/drm/amd/amdgpu/imu_v11_0.c:52:54: warning: ‘_imu.bin’ directive output may be truncated writing 8 bytes into a region of size between 4 and 33 [-Wformat-truncation=]
drivers/gpu/drm/amd/amdgpu/imu_v11_0.c:52:9: note: ‘snprintf’ output between 16 and 45 bytes into a destination of size 40
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Mario Limonciello <mario.limonciello@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/amd/amdgpu/imu_v11_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c b/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
index 4ab90c7852c3e..ca123ff553477 100644
--- a/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
@@ -39,7 +39,7 @@ MODULE_FIRMWARE("amdgpu/gc_11_0_4_imu.bin");
static int imu_v11_0_init_microcode(struct amdgpu_device *adev)
{
- char fw_name[40];
+ char fw_name[45];
char ucode_prefix[30];
int err;
const struct imu_firmware_header_v1_0 *imu_hdr;
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 159+ messages in thread* Re: [PATCH 20/20] drm/amd/amdgpu/imu_v11_0: Increase buffer size to ensure all possible values can be stored
2023-08-24 7:37 ` Lee Jones
(?)
@ 2023-08-24 14:57 ` Alex Deucher
-1 siblings, 0 replies; 159+ messages in thread
From: Alex Deucher @ 2023-08-24 14:57 UTC (permalink / raw)
To: Lee Jones
Cc: Pan, Xinhui, linux-kernel, amd-gfx, dri-devel, Daniel Vetter,
Alex Deucher, David Airlie, Christian König,
Mario Limonciello
Applied. Thanks!
On Thu, Aug 24, 2023 at 3:38 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/imu_v11_0.c: In function ‘imu_v11_0_init_microcode’:
> drivers/gpu/drm/amd/amdgpu/imu_v11_0.c:52:54: warning: ‘_imu.bin’ directive output may be truncated writing 8 bytes into a region of size between 4 and 33 [-Wformat-truncation=]
> drivers/gpu/drm/amd/amdgpu/imu_v11_0.c:52:9: note: ‘snprintf’ output between 16 and 45 bytes into a destination of size 40
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/amd/amdgpu/imu_v11_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c b/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
> index 4ab90c7852c3e..ca123ff553477 100644
> --- a/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
> @@ -39,7 +39,7 @@ MODULE_FIRMWARE("amdgpu/gc_11_0_4_imu.bin");
>
> static int imu_v11_0_init_microcode(struct amdgpu_device *adev)
> {
> - char fw_name[40];
> + char fw_name[45];
> char ucode_prefix[30];
> int err;
> const struct imu_firmware_header_v1_0 *imu_hdr;
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 20/20] drm/amd/amdgpu/imu_v11_0: Increase buffer size to ensure all possible values can be stored
@ 2023-08-24 14:57 ` Alex Deucher
0 siblings, 0 replies; 159+ messages in thread
From: Alex Deucher @ 2023-08-24 14:57 UTC (permalink / raw)
To: Lee Jones
Cc: dri-devel, Pan, Xinhui, linux-kernel, amd-gfx, Mario Limonciello,
Daniel Vetter, Alex Deucher, David Airlie, Christian König
Applied. Thanks!
On Thu, Aug 24, 2023 at 3:38 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/imu_v11_0.c: In function ‘imu_v11_0_init_microcode’:
> drivers/gpu/drm/amd/amdgpu/imu_v11_0.c:52:54: warning: ‘_imu.bin’ directive output may be truncated writing 8 bytes into a region of size between 4 and 33 [-Wformat-truncation=]
> drivers/gpu/drm/amd/amdgpu/imu_v11_0.c:52:9: note: ‘snprintf’ output between 16 and 45 bytes into a destination of size 40
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/amd/amdgpu/imu_v11_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c b/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
> index 4ab90c7852c3e..ca123ff553477 100644
> --- a/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
> @@ -39,7 +39,7 @@ MODULE_FIRMWARE("amdgpu/gc_11_0_4_imu.bin");
>
> static int imu_v11_0_init_microcode(struct amdgpu_device *adev)
> {
> - char fw_name[40];
> + char fw_name[45];
> char ucode_prefix[30];
> int err;
> const struct imu_firmware_header_v1_0 *imu_hdr;
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH 20/20] drm/amd/amdgpu/imu_v11_0: Increase buffer size to ensure all possible values can be stored
@ 2023-08-24 14:57 ` Alex Deucher
0 siblings, 0 replies; 159+ messages in thread
From: Alex Deucher @ 2023-08-24 14:57 UTC (permalink / raw)
To: Lee Jones
Cc: Pan, Xinhui, linux-kernel, amd-gfx, dri-devel, Alex Deucher,
Christian König, Mario Limonciello
Applied. Thanks!
On Thu, Aug 24, 2023 at 3:38 AM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/imu_v11_0.c: In function ‘imu_v11_0_init_microcode’:
> drivers/gpu/drm/amd/amdgpu/imu_v11_0.c:52:54: warning: ‘_imu.bin’ directive output may be truncated writing 8 bytes into a region of size between 4 and 33 [-Wformat-truncation=]
> drivers/gpu/drm/amd/amdgpu/imu_v11_0.c:52:9: note: ‘snprintf’ output between 16 and 45 bytes into a destination of size 40
>
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/amd/amdgpu/imu_v11_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c b/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
> index 4ab90c7852c3e..ca123ff553477 100644
> --- a/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c
> @@ -39,7 +39,7 @@ MODULE_FIRMWARE("amdgpu/gc_11_0_4_imu.bin");
>
> static int imu_v11_0_init_microcode(struct amdgpu_device *adev)
> {
> - char fw_name[40];
> + char fw_name[45];
> char ucode_prefix[30];
> int err;
> const struct imu_firmware_header_v1_0 *imu_hdr;
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
2023-08-24 7:36 ` Lee Jones
` (2 preceding siblings ...)
(?)
@ 2023-08-24 8:59 ` Maxime Ripard
-1 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 8:59 UTC (permalink / raw)
To: Lee Jones
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Fabio Estevam,
Sumit Semwal, Mario Limonciello, Shashank Sharma, David Airlie,
NXP Linux Team, amd-gfx, Jonathan Hunter, Luben Tuikov,
Danilo Krummrich, Ben Skeggs, Philipp Zabel, linux-media,
Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
Maarten Lankhorst, linaro-mm-sig, linux-tegra, Michal Simek,
linux-arm-kernel, Hyun Kwon, Thomas Zimmermann, Pan, Xinhui,
linux-kernel, Jerome Glisse, Daniel Vetter, Alex Deucher,
Gourav Samaiya, Shawn Guo, Christian König, Hawking Zhang
On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Danilo Krummrich <dakr@redhat.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Gourav Samaiya <gsamaiya@nvidia.com>
> Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> Cc: Jerome Glisse <glisse@freedesktop.org>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-media@vger.kernel.org
> Cc: linux-tegra@vger.kernel.org
> Cc: Luben Tuikov <luben.tuikov@amd.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: "Maíra Canal" <mairacanal@riseup.net>
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Mikko Perttunen <mperttunen@nvidia.com>
> Cc: nouveau@lists.freedesktop.org
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shashank Sharma <shashank.sharma@amd.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Stanley Yang <Stanley.Yang@amd.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>
> [...]
Applied to drm/drm-misc (drm-misc-fixes).
Thanks!
Maxime
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 8:59 ` Maxime Ripard
0 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 8:59 UTC (permalink / raw)
To: Lee Jones
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Mario Limonciello, Shashank Sharma, NXP Linux Team, amd-gfx,
Jonathan Hunter, Luben Tuikov, Danilo Krummrich, Ben Skeggs,
linux-media, Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
linaro-mm-sig, linux-tegra, Michal Simek, linux-arm-kernel,
Hyun Kwon, Thomas Zimmermann, Pan, Xinhui, linux-kernel,
Jerome Glisse, Alex Deucher, Gourav Samaiya, Shawn Guo,
Christian König, Hawking Zhang
On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Danilo Krummrich <dakr@redhat.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Gourav Samaiya <gsamaiya@nvidia.com>
> Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> Cc: Jerome Glisse <glisse@freedesktop.org>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-media@vger.kernel.org
> Cc: linux-tegra@vger.kernel.org
> Cc: Luben Tuikov <luben.tuikov@amd.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: "Maíra Canal" <mairacanal@riseup.net>
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Mikko Perttunen <mperttunen@nvidia.com>
> Cc: nouveau@lists.freedesktop.org
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shashank Sharma <shashank.sharma@amd.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Stanley Yang <Stanley.Yang@amd.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>
> [...]
Applied to drm/drm-misc (drm-misc-fixes).
Thanks!
Maxime
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 8:59 ` Maxime Ripard
0 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 8:59 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Alex Deucher, amd-gfx, Ben Skeggs,
Christian König, Daniel Vetter, Danilo Krummrich,
David Airlie, dri-devel, Fabio Estevam, Gourav Samaiya,
Hawking Zhang, Hyun Kwon, Jerome Glisse, Jonathan Hunter,
Karol Herbst, Laurent Pinchart, linaro-mm-sig, linux-arm-kernel,
linux-media, linux-tegra, Luben Tuikov, Lyude Paul,
Maarten Lankhorst, Maíra Canal, Mario Limonciello,
Mikko Perttunen, nouveau, NXP Linux Team, Pan, Xinhui,
Pengutronix Kernel Team, Philipp Zabel, Sascha Hauer,
Shashank Sharma, Shawn Guo, Stanley Yang, Sumit Semwal,
Thierry Reding, Thomas Zimmermann, Michal Simek
On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Danilo Krummrich <dakr@redhat.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Gourav Samaiya <gsamaiya@nvidia.com>
> Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> Cc: Jerome Glisse <glisse@freedesktop.org>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-media@vger.kernel.org
> Cc: linux-tegra@vger.kernel.org
> Cc: Luben Tuikov <luben.tuikov@amd.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: "Maíra Canal" <mairacanal@riseup.net>
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Mikko Perttunen <mperttunen@nvidia.com>
> Cc: nouveau@lists.freedesktop.org
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shashank Sharma <shashank.sharma@amd.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Stanley Yang <Stanley.Yang@amd.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>
> [...]
Applied to drm/drm-misc (drm-misc-fixes).
Thanks!
Maxime
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 8:59 ` Maxime Ripard
0 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 8:59 UTC (permalink / raw)
To: Lee Jones
Cc: nouveau, dri-devel, Mikko Perttunen, Maíra Canal,
Thierry Reding, Laurent Pinchart, Fabio Estevam, Sumit Semwal,
Mario Limonciello, Shashank Sharma, NXP Linux Team, amd-gfx,
Luben Tuikov, Ben Skeggs, Philipp Zabel, linux-media,
Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
Maarten Lankhorst, linaro-mm-sig, linux-tegra, Michal Simek,
linux-arm-kernel, Hyun Kwon, Pan, Xinhui, linux-kernel,
Jerome Glisse, Daniel Vetter, Alex Deucher, Gourav Samaiya,
Shawn Guo, Christian König, Hawking Zhang
On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Danilo Krummrich <dakr@redhat.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Gourav Samaiya <gsamaiya@nvidia.com>
> Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> Cc: Jerome Glisse <glisse@freedesktop.org>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-media@vger.kernel.org
> Cc: linux-tegra@vger.kernel.org
> Cc: Luben Tuikov <luben.tuikov@amd.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: "Maíra Canal" <mairacanal@riseup.net>
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Mikko Perttunen <mperttunen@nvidia.com>
> Cc: nouveau@lists.freedesktop.org
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shashank Sharma <shashank.sharma@amd.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Stanley Yang <Stanley.Yang@amd.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>
> [...]
Applied to drm/drm-misc (drm-misc-fixes).
Thanks!
Maxime
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 8:59 ` Maxime Ripard
0 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 8:59 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Alex Deucher, amd-gfx, Ben Skeggs,
Christian König, Daniel Vetter, Danilo Krummrich,
David Airlie, dri-devel, Fabio Estevam, Gourav Samaiya,
Hawking Zhang, Hyun Kwon, Jerome Glisse, Jonathan Hunter,
Karol Herbst, Laurent Pinchart, linaro-mm-sig, linux-arm-kernel,
linux-media, linux-tegra, Luben Tuikov, Lyude Paul,
Maarten Lankhorst, Maíra Canal, Mario Limonciello,
Mikko Perttunen, nouveau, NXP Linux Team, Pan, Xinhui,
Pengutronix Kernel Team, Philipp Zabel, Sascha Hauer,
Shashank Sharma, Shawn Guo, Stanley Yang, Sumit Semwal,
Thierry Reding, Thomas Zimmermann, Michal Simek
On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Danilo Krummrich <dakr@redhat.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Gourav Samaiya <gsamaiya@nvidia.com>
> Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> Cc: Jerome Glisse <glisse@freedesktop.org>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-media@vger.kernel.org
> Cc: linux-tegra@vger.kernel.org
> Cc: Luben Tuikov <luben.tuikov@amd.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: "Maíra Canal" <mairacanal@riseup.net>
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Mikko Perttunen <mperttunen@nvidia.com>
> Cc: nouveau@lists.freedesktop.org
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shashank Sharma <shashank.sharma@amd.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Stanley Yang <Stanley.Yang@amd.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>
> [...]
Applied to drm/drm-misc (drm-misc-fixes).
Thanks!
Maxime
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
2023-08-24 8:59 ` Maxime Ripard
` (2 preceding siblings ...)
(?)
@ 2023-08-24 9:03 ` Maxime Ripard
-1 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 9:03 UTC (permalink / raw)
To: Lee Jones
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Fabio Estevam,
Sumit Semwal, Mario Limonciello, Shashank Sharma, David Airlie,
NXP Linux Team, amd-gfx, Jonathan Hunter, Luben Tuikov,
Danilo Krummrich, Ben Skeggs, Philipp Zabel, linux-media,
Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
Maarten Lankhorst, linaro-mm-sig, linux-tegra, Michal Simek,
linux-arm-kernel, Hyun Kwon, Thomas Zimmermann, Pan, Xinhui,
linux-kernel, Jerome Glisse, Daniel Vetter, Alex Deucher,
Gourav Samaiya, Shawn Guo, Christian König, Hawking Zhang
[-- Attachment #1: Type: text/plain, Size: 2365 bytes --]
Hi,
On Thu, Aug 24, 2023 at 10:59:54AM +0200, Maxime Ripard wrote:
> On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Cc: amd-gfx@lists.freedesktop.org
> > Cc: Ben Skeggs <bskeggs@redhat.com>
> > Cc: "Christian König" <christian.koenig@amd.com>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Danilo Krummrich <dakr@redhat.com>
> > Cc: David Airlie <airlied@gmail.com>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: Fabio Estevam <festevam@gmail.com>
> > Cc: Gourav Samaiya <gsamaiya@nvidia.com>
> > Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> > Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> > Cc: Jerome Glisse <glisse@freedesktop.org>
> > Cc: Jonathan Hunter <jonathanh@nvidia.com>
> > Cc: Karol Herbst <kherbst@redhat.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: linaro-mm-sig@lists.linaro.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-media@vger.kernel.org
> > Cc: linux-tegra@vger.kernel.org
> > Cc: Luben Tuikov <luben.tuikov@amd.com>
> > Cc: Lyude Paul <lyude@redhat.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: "Maíra Canal" <mairacanal@riseup.net>
> > Cc: Mario Limonciello <mario.limonciello@amd.com>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Michal Simek <michal.simek@xilinx.com>
> > Cc: Mikko Perttunen <mperttunen@nvidia.com>
> > Cc: nouveau@lists.freedesktop.org
> > Cc: NXP Linux Team <linux-imx@nxp.com>
> > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Shashank Sharma <shashank.sharma@amd.com>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: Stanley Yang <Stanley.Yang@amd.com>
> > Cc: Sumit Semwal <sumit.semwal@linaro.org>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> >
> > [...]
>
> Applied to drm/drm-misc (drm-misc-fixes).
I got confused with b4 usage, but that wasn't actually applied. Only the
three patches I explicitly mentioned were, sorry for the confusion.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 9:03 ` Maxime Ripard
0 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 9:03 UTC (permalink / raw)
To: Lee Jones
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Mario Limonciello, Shashank Sharma, NXP Linux Team, amd-gfx,
Jonathan Hunter, Luben Tuikov, Danilo Krummrich, Ben Skeggs,
linux-media, Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
linaro-mm-sig, linux-tegra, Michal Simek, linux-arm-kernel,
Hyun Kwon, Thomas Zimmermann, Pan, Xinhui, linux-kernel,
Jerome Glisse, Alex Deucher, Gourav Samaiya, Shawn Guo,
Christian König, Hawking Zhang
[-- Attachment #1: Type: text/plain, Size: 2365 bytes --]
Hi,
On Thu, Aug 24, 2023 at 10:59:54AM +0200, Maxime Ripard wrote:
> On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Cc: amd-gfx@lists.freedesktop.org
> > Cc: Ben Skeggs <bskeggs@redhat.com>
> > Cc: "Christian König" <christian.koenig@amd.com>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Danilo Krummrich <dakr@redhat.com>
> > Cc: David Airlie <airlied@gmail.com>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: Fabio Estevam <festevam@gmail.com>
> > Cc: Gourav Samaiya <gsamaiya@nvidia.com>
> > Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> > Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> > Cc: Jerome Glisse <glisse@freedesktop.org>
> > Cc: Jonathan Hunter <jonathanh@nvidia.com>
> > Cc: Karol Herbst <kherbst@redhat.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: linaro-mm-sig@lists.linaro.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-media@vger.kernel.org
> > Cc: linux-tegra@vger.kernel.org
> > Cc: Luben Tuikov <luben.tuikov@amd.com>
> > Cc: Lyude Paul <lyude@redhat.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: "Maíra Canal" <mairacanal@riseup.net>
> > Cc: Mario Limonciello <mario.limonciello@amd.com>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Michal Simek <michal.simek@xilinx.com>
> > Cc: Mikko Perttunen <mperttunen@nvidia.com>
> > Cc: nouveau@lists.freedesktop.org
> > Cc: NXP Linux Team <linux-imx@nxp.com>
> > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Shashank Sharma <shashank.sharma@amd.com>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: Stanley Yang <Stanley.Yang@amd.com>
> > Cc: Sumit Semwal <sumit.semwal@linaro.org>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> >
> > [...]
>
> Applied to drm/drm-misc (drm-misc-fixes).
I got confused with b4 usage, but that wasn't actually applied. Only the
three patches I explicitly mentioned were, sorry for the confusion.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 9:03 ` Maxime Ripard
0 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 9:03 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Alex Deucher, amd-gfx, Ben Skeggs,
Christian König, Daniel Vetter, Danilo Krummrich,
David Airlie, dri-devel, Fabio Estevam, Gourav Samaiya,
Hawking Zhang, Hyun Kwon, Jerome Glisse, Jonathan Hunter,
Karol Herbst, Laurent Pinchart, linaro-mm-sig, linux-arm-kernel,
linux-media, linux-tegra, Luben Tuikov, Lyude Paul,
Maarten Lankhorst, Maíra Canal, Mario Limonciello,
Mikko Perttunen, nouveau, NXP Linux Team, Pan, Xinhui,
Pengutronix Kernel Team, Philipp Zabel, Sascha Hauer,
Shashank Sharma, Shawn Guo, Stanley Yang, Sumit Semwal,
Thierry Reding, Thomas Zimmermann, Michal Simek
[-- Attachment #1.1: Type: text/plain, Size: 2365 bytes --]
Hi,
On Thu, Aug 24, 2023 at 10:59:54AM +0200, Maxime Ripard wrote:
> On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Cc: amd-gfx@lists.freedesktop.org
> > Cc: Ben Skeggs <bskeggs@redhat.com>
> > Cc: "Christian König" <christian.koenig@amd.com>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Danilo Krummrich <dakr@redhat.com>
> > Cc: David Airlie <airlied@gmail.com>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: Fabio Estevam <festevam@gmail.com>
> > Cc: Gourav Samaiya <gsamaiya@nvidia.com>
> > Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> > Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> > Cc: Jerome Glisse <glisse@freedesktop.org>
> > Cc: Jonathan Hunter <jonathanh@nvidia.com>
> > Cc: Karol Herbst <kherbst@redhat.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: linaro-mm-sig@lists.linaro.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-media@vger.kernel.org
> > Cc: linux-tegra@vger.kernel.org
> > Cc: Luben Tuikov <luben.tuikov@amd.com>
> > Cc: Lyude Paul <lyude@redhat.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: "Maíra Canal" <mairacanal@riseup.net>
> > Cc: Mario Limonciello <mario.limonciello@amd.com>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Michal Simek <michal.simek@xilinx.com>
> > Cc: Mikko Perttunen <mperttunen@nvidia.com>
> > Cc: nouveau@lists.freedesktop.org
> > Cc: NXP Linux Team <linux-imx@nxp.com>
> > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Shashank Sharma <shashank.sharma@amd.com>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: Stanley Yang <Stanley.Yang@amd.com>
> > Cc: Sumit Semwal <sumit.semwal@linaro.org>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> >
> > [...]
>
> Applied to drm/drm-misc (drm-misc-fixes).
I got confused with b4 usage, but that wasn't actually applied. Only the
three patches I explicitly mentioned were, sorry for the confusion.
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 9:03 ` Maxime Ripard
0 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 9:03 UTC (permalink / raw)
To: Lee Jones
Cc: nouveau, dri-devel, Mikko Perttunen, Maíra Canal,
Thierry Reding, Laurent Pinchart, Fabio Estevam, Sumit Semwal,
Mario Limonciello, Shashank Sharma, NXP Linux Team, amd-gfx,
Luben Tuikov, Ben Skeggs, Philipp Zabel, linux-media,
Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
Maarten Lankhorst, linaro-mm-sig, linux-tegra, Michal Simek,
linux-arm-kernel, Hyun Kwon, Pan, Xinhui, linux-kernel,
Jerome Glisse, Daniel Vetter, Alex Deucher, Gourav Samaiya,
Shawn Guo, Christian König, Hawking Zhang
[-- Attachment #1: Type: text/plain, Size: 2365 bytes --]
Hi,
On Thu, Aug 24, 2023 at 10:59:54AM +0200, Maxime Ripard wrote:
> On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Cc: amd-gfx@lists.freedesktop.org
> > Cc: Ben Skeggs <bskeggs@redhat.com>
> > Cc: "Christian König" <christian.koenig@amd.com>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Danilo Krummrich <dakr@redhat.com>
> > Cc: David Airlie <airlied@gmail.com>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: Fabio Estevam <festevam@gmail.com>
> > Cc: Gourav Samaiya <gsamaiya@nvidia.com>
> > Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> > Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> > Cc: Jerome Glisse <glisse@freedesktop.org>
> > Cc: Jonathan Hunter <jonathanh@nvidia.com>
> > Cc: Karol Herbst <kherbst@redhat.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: linaro-mm-sig@lists.linaro.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-media@vger.kernel.org
> > Cc: linux-tegra@vger.kernel.org
> > Cc: Luben Tuikov <luben.tuikov@amd.com>
> > Cc: Lyude Paul <lyude@redhat.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: "Maíra Canal" <mairacanal@riseup.net>
> > Cc: Mario Limonciello <mario.limonciello@amd.com>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Michal Simek <michal.simek@xilinx.com>
> > Cc: Mikko Perttunen <mperttunen@nvidia.com>
> > Cc: nouveau@lists.freedesktop.org
> > Cc: NXP Linux Team <linux-imx@nxp.com>
> > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Shashank Sharma <shashank.sharma@amd.com>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: Stanley Yang <Stanley.Yang@amd.com>
> > Cc: Sumit Semwal <sumit.semwal@linaro.org>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> >
> > [...]
>
> Applied to drm/drm-misc (drm-misc-fixes).
I got confused with b4 usage, but that wasn't actually applied. Only the
three patches I explicitly mentioned were, sorry for the confusion.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 9:03 ` Maxime Ripard
0 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 9:03 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Alex Deucher, amd-gfx, Ben Skeggs,
Christian König, Daniel Vetter, Danilo Krummrich,
David Airlie, dri-devel, Fabio Estevam, Gourav Samaiya,
Hawking Zhang, Hyun Kwon, Jerome Glisse, Jonathan Hunter,
Karol Herbst, Laurent Pinchart, linaro-mm-sig, linux-arm-kernel,
linux-media, linux-tegra, Luben Tuikov, Lyude Paul,
Maarten Lankhorst, Maíra Canal, Mario Limonciello,
Mikko Perttunen, nouveau, NXP Linux Team, Pan, Xinhui,
Pengutronix Kernel Team, Philipp Zabel, Sascha Hauer,
Shashank Sharma, Shawn Guo, Stanley Yang, Sumit Semwal,
Thierry Reding, Thomas Zimmermann, Michal Simek
[-- Attachment #1: Type: text/plain, Size: 2365 bytes --]
Hi,
On Thu, Aug 24, 2023 at 10:59:54AM +0200, Maxime Ripard wrote:
> On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Cc: amd-gfx@lists.freedesktop.org
> > Cc: Ben Skeggs <bskeggs@redhat.com>
> > Cc: "Christian König" <christian.koenig@amd.com>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Danilo Krummrich <dakr@redhat.com>
> > Cc: David Airlie <airlied@gmail.com>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: Fabio Estevam <festevam@gmail.com>
> > Cc: Gourav Samaiya <gsamaiya@nvidia.com>
> > Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> > Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> > Cc: Jerome Glisse <glisse@freedesktop.org>
> > Cc: Jonathan Hunter <jonathanh@nvidia.com>
> > Cc: Karol Herbst <kherbst@redhat.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: linaro-mm-sig@lists.linaro.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-media@vger.kernel.org
> > Cc: linux-tegra@vger.kernel.org
> > Cc: Luben Tuikov <luben.tuikov@amd.com>
> > Cc: Lyude Paul <lyude@redhat.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: "Maíra Canal" <mairacanal@riseup.net>
> > Cc: Mario Limonciello <mario.limonciello@amd.com>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Michal Simek <michal.simek@xilinx.com>
> > Cc: Mikko Perttunen <mperttunen@nvidia.com>
> > Cc: nouveau@lists.freedesktop.org
> > Cc: NXP Linux Team <linux-imx@nxp.com>
> > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Shashank Sharma <shashank.sharma@amd.com>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: Stanley Yang <Stanley.Yang@amd.com>
> > Cc: Sumit Semwal <sumit.semwal@linaro.org>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> >
> > [...]
>
> Applied to drm/drm-misc (drm-misc-fixes).
I got confused with b4 usage, but that wasn't actually applied. Only the
three patches I explicitly mentioned were, sorry for the confusion.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
2023-08-24 9:03 ` Maxime Ripard
` (2 preceding siblings ...)
(?)
@ 2023-08-24 12:10 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:10 UTC (permalink / raw)
To: Maxime Ripard
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Fabio Estevam,
Sumit Semwal, Mario Limonciello, Shashank Sharma, David Airlie,
NXP Linux Team, amd-gfx, Jonathan Hunter, Luben Tuikov,
Danilo Krummrich, Ben Skeggs, Philipp Zabel, linux-media,
Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
Maarten Lankhorst, linaro-mm-sig, linux-tegra, Michal Simek,
linux-arm-kernel, Hyun Kwon, Thomas Zimmermann, Pan, Xinhui,
linux-kernel, Jerome Glisse, Daniel Vetter, Alex Deucher,
Gourav Samaiya, Shawn Guo, Christian König, Hawking Zhang
On Thu, 24 Aug 2023, Maxime Ripard wrote:
> Hi,
>
> On Thu, Aug 24, 2023 at 10:59:54AM +0200, Maxime Ripard wrote:
> > On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote:
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> > >
> > > Cc: Alex Deucher <alexander.deucher@amd.com>
> > > Cc: amd-gfx@lists.freedesktop.org
> > > Cc: Ben Skeggs <bskeggs@redhat.com>
> > > Cc: "Christian König" <christian.koenig@amd.com>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Cc: Danilo Krummrich <dakr@redhat.com>
> > > Cc: David Airlie <airlied@gmail.com>
> > > Cc: dri-devel@lists.freedesktop.org
> > > Cc: Fabio Estevam <festevam@gmail.com>
> > > Cc: Gourav Samaiya <gsamaiya@nvidia.com>
> > > Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> > > Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> > > Cc: Jerome Glisse <glisse@freedesktop.org>
> > > Cc: Jonathan Hunter <jonathanh@nvidia.com>
> > > Cc: Karol Herbst <kherbst@redhat.com>
> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Cc: linaro-mm-sig@lists.linaro.org
> > > Cc: linux-arm-kernel@lists.infradead.org
> > > Cc: linux-media@vger.kernel.org
> > > Cc: linux-tegra@vger.kernel.org
> > > Cc: Luben Tuikov <luben.tuikov@amd.com>
> > > Cc: Lyude Paul <lyude@redhat.com>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > Cc: "Maíra Canal" <mairacanal@riseup.net>
> > > Cc: Mario Limonciello <mario.limonciello@amd.com>
> > > Cc: Maxime Ripard <mripard@kernel.org>
> > > Cc: Michal Simek <michal.simek@xilinx.com>
> > > Cc: Mikko Perttunen <mperttunen@nvidia.com>
> > > Cc: nouveau@lists.freedesktop.org
> > > Cc: NXP Linux Team <linux-imx@nxp.com>
> > > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > Cc: Shashank Sharma <shashank.sharma@amd.com>
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Cc: Stanley Yang <Stanley.Yang@amd.com>
> > > Cc: Sumit Semwal <sumit.semwal@linaro.org>
> > > Cc: Thierry Reding <thierry.reding@gmail.com>
> > > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > >
> > > [...]
> >
> > Applied to drm/drm-misc (drm-misc-fixes).
>
> I got confused with b4 usage, but that wasn't actually applied. Only the
> three patches I explicitly mentioned were, sorry for the confusion.
:)
Thanks Maxime.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 12:10 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:10 UTC (permalink / raw)
To: Maxime Ripard
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Mario Limonciello, Shashank Sharma, NXP Linux Team, amd-gfx,
Jonathan Hunter, Luben Tuikov, Danilo Krummrich, Ben Skeggs,
linux-media, Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
linaro-mm-sig, linux-tegra, Michal Simek, linux-arm-kernel,
Hyun Kwon, Thomas Zimmermann, Pan, Xinhui, linux-kernel,
Jerome Glisse, Alex Deucher, Gourav Samaiya, Shawn Guo,
Christian König, Hawking Zhang
On Thu, 24 Aug 2023, Maxime Ripard wrote:
> Hi,
>
> On Thu, Aug 24, 2023 at 10:59:54AM +0200, Maxime Ripard wrote:
> > On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote:
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> > >
> > > Cc: Alex Deucher <alexander.deucher@amd.com>
> > > Cc: amd-gfx@lists.freedesktop.org
> > > Cc: Ben Skeggs <bskeggs@redhat.com>
> > > Cc: "Christian König" <christian.koenig@amd.com>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Cc: Danilo Krummrich <dakr@redhat.com>
> > > Cc: David Airlie <airlied@gmail.com>
> > > Cc: dri-devel@lists.freedesktop.org
> > > Cc: Fabio Estevam <festevam@gmail.com>
> > > Cc: Gourav Samaiya <gsamaiya@nvidia.com>
> > > Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> > > Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> > > Cc: Jerome Glisse <glisse@freedesktop.org>
> > > Cc: Jonathan Hunter <jonathanh@nvidia.com>
> > > Cc: Karol Herbst <kherbst@redhat.com>
> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Cc: linaro-mm-sig@lists.linaro.org
> > > Cc: linux-arm-kernel@lists.infradead.org
> > > Cc: linux-media@vger.kernel.org
> > > Cc: linux-tegra@vger.kernel.org
> > > Cc: Luben Tuikov <luben.tuikov@amd.com>
> > > Cc: Lyude Paul <lyude@redhat.com>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > Cc: "Maíra Canal" <mairacanal@riseup.net>
> > > Cc: Mario Limonciello <mario.limonciello@amd.com>
> > > Cc: Maxime Ripard <mripard@kernel.org>
> > > Cc: Michal Simek <michal.simek@xilinx.com>
> > > Cc: Mikko Perttunen <mperttunen@nvidia.com>
> > > Cc: nouveau@lists.freedesktop.org
> > > Cc: NXP Linux Team <linux-imx@nxp.com>
> > > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > Cc: Shashank Sharma <shashank.sharma@amd.com>
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Cc: Stanley Yang <Stanley.Yang@amd.com>
> > > Cc: Sumit Semwal <sumit.semwal@linaro.org>
> > > Cc: Thierry Reding <thierry.reding@gmail.com>
> > > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > >
> > > [...]
> >
> > Applied to drm/drm-misc (drm-misc-fixes).
>
> I got confused with b4 usage, but that wasn't actually applied. Only the
> three patches I explicitly mentioned were, sorry for the confusion.
:)
Thanks Maxime.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 12:10 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:10 UTC (permalink / raw)
To: Maxime Ripard
Cc: linux-kernel, Alex Deucher, amd-gfx, Ben Skeggs,
Christian König, Daniel Vetter, Danilo Krummrich,
David Airlie, dri-devel, Fabio Estevam, Gourav Samaiya,
Hawking Zhang, Hyun Kwon, Jerome Glisse, Jonathan Hunter,
Karol Herbst, Laurent Pinchart, linaro-mm-sig, linux-arm-kernel,
linux-media, linux-tegra, Luben Tuikov, Lyude Paul,
Maarten Lankhorst, Maíra Canal, Mario Limonciello,
Mikko Perttunen, nouveau, NXP Linux Team, Pan, Xinhui,
Pengutronix Kernel Team, Philipp Zabel, Sascha Hauer,
Shashank Sharma, Shawn Guo, Stanley Yang, Sumit Semwal,
Thierry Reding, Thomas Zimmermann, Michal Simek
On Thu, 24 Aug 2023, Maxime Ripard wrote:
> Hi,
>
> On Thu, Aug 24, 2023 at 10:59:54AM +0200, Maxime Ripard wrote:
> > On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote:
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> > >
> > > Cc: Alex Deucher <alexander.deucher@amd.com>
> > > Cc: amd-gfx@lists.freedesktop.org
> > > Cc: Ben Skeggs <bskeggs@redhat.com>
> > > Cc: "Christian König" <christian.koenig@amd.com>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Cc: Danilo Krummrich <dakr@redhat.com>
> > > Cc: David Airlie <airlied@gmail.com>
> > > Cc: dri-devel@lists.freedesktop.org
> > > Cc: Fabio Estevam <festevam@gmail.com>
> > > Cc: Gourav Samaiya <gsamaiya@nvidia.com>
> > > Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> > > Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> > > Cc: Jerome Glisse <glisse@freedesktop.org>
> > > Cc: Jonathan Hunter <jonathanh@nvidia.com>
> > > Cc: Karol Herbst <kherbst@redhat.com>
> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Cc: linaro-mm-sig@lists.linaro.org
> > > Cc: linux-arm-kernel@lists.infradead.org
> > > Cc: linux-media@vger.kernel.org
> > > Cc: linux-tegra@vger.kernel.org
> > > Cc: Luben Tuikov <luben.tuikov@amd.com>
> > > Cc: Lyude Paul <lyude@redhat.com>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > Cc: "Maíra Canal" <mairacanal@riseup.net>
> > > Cc: Mario Limonciello <mario.limonciello@amd.com>
> > > Cc: Maxime Ripard <mripard@kernel.org>
> > > Cc: Michal Simek <michal.simek@xilinx.com>
> > > Cc: Mikko Perttunen <mperttunen@nvidia.com>
> > > Cc: nouveau@lists.freedesktop.org
> > > Cc: NXP Linux Team <linux-imx@nxp.com>
> > > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > Cc: Shashank Sharma <shashank.sharma@amd.com>
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Cc: Stanley Yang <Stanley.Yang@amd.com>
> > > Cc: Sumit Semwal <sumit.semwal@linaro.org>
> > > Cc: Thierry Reding <thierry.reding@gmail.com>
> > > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > >
> > > [...]
> >
> > Applied to drm/drm-misc (drm-misc-fixes).
>
> I got confused with b4 usage, but that wasn't actually applied. Only the
> three patches I explicitly mentioned were, sorry for the confusion.
:)
Thanks Maxime.
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 12:10 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:10 UTC (permalink / raw)
To: Maxime Ripard
Cc: nouveau, dri-devel, Mikko Perttunen, Maíra Canal,
Thierry Reding, Laurent Pinchart, Fabio Estevam, Sumit Semwal,
Mario Limonciello, Shashank Sharma, NXP Linux Team, amd-gfx,
Luben Tuikov, Ben Skeggs, Philipp Zabel, linux-media,
Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
Maarten Lankhorst, linaro-mm-sig, linux-tegra, Michal Simek,
linux-arm-kernel, Hyun Kwon, Pan, Xinhui, linux-kernel,
Jerome Glisse, Daniel Vetter, Alex Deucher, Gourav Samaiya,
Shawn Guo, Christian König, Hawking Zhang
On Thu, 24 Aug 2023, Maxime Ripard wrote:
> Hi,
>
> On Thu, Aug 24, 2023 at 10:59:54AM +0200, Maxime Ripard wrote:
> > On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote:
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> > >
> > > Cc: Alex Deucher <alexander.deucher@amd.com>
> > > Cc: amd-gfx@lists.freedesktop.org
> > > Cc: Ben Skeggs <bskeggs@redhat.com>
> > > Cc: "Christian König" <christian.koenig@amd.com>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Cc: Danilo Krummrich <dakr@redhat.com>
> > > Cc: David Airlie <airlied@gmail.com>
> > > Cc: dri-devel@lists.freedesktop.org
> > > Cc: Fabio Estevam <festevam@gmail.com>
> > > Cc: Gourav Samaiya <gsamaiya@nvidia.com>
> > > Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> > > Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> > > Cc: Jerome Glisse <glisse@freedesktop.org>
> > > Cc: Jonathan Hunter <jonathanh@nvidia.com>
> > > Cc: Karol Herbst <kherbst@redhat.com>
> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Cc: linaro-mm-sig@lists.linaro.org
> > > Cc: linux-arm-kernel@lists.infradead.org
> > > Cc: linux-media@vger.kernel.org
> > > Cc: linux-tegra@vger.kernel.org
> > > Cc: Luben Tuikov <luben.tuikov@amd.com>
> > > Cc: Lyude Paul <lyude@redhat.com>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > Cc: "Maíra Canal" <mairacanal@riseup.net>
> > > Cc: Mario Limonciello <mario.limonciello@amd.com>
> > > Cc: Maxime Ripard <mripard@kernel.org>
> > > Cc: Michal Simek <michal.simek@xilinx.com>
> > > Cc: Mikko Perttunen <mperttunen@nvidia.com>
> > > Cc: nouveau@lists.freedesktop.org
> > > Cc: NXP Linux Team <linux-imx@nxp.com>
> > > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > Cc: Shashank Sharma <shashank.sharma@amd.com>
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Cc: Stanley Yang <Stanley.Yang@amd.com>
> > > Cc: Sumit Semwal <sumit.semwal@linaro.org>
> > > Cc: Thierry Reding <thierry.reding@gmail.com>
> > > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > >
> > > [...]
> >
> > Applied to drm/drm-misc (drm-misc-fixes).
>
> I got confused with b4 usage, but that wasn't actually applied. Only the
> three patches I explicitly mentioned were, sorry for the confusion.
:)
Thanks Maxime.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 12:10 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:10 UTC (permalink / raw)
To: Maxime Ripard
Cc: linux-kernel, Alex Deucher, amd-gfx, Ben Skeggs,
Christian König, Daniel Vetter, Danilo Krummrich,
David Airlie, dri-devel, Fabio Estevam, Gourav Samaiya,
Hawking Zhang, Hyun Kwon, Jerome Glisse, Jonathan Hunter,
Karol Herbst, Laurent Pinchart, linaro-mm-sig, linux-arm-kernel,
linux-media, linux-tegra, Luben Tuikov, Lyude Paul,
Maarten Lankhorst, Maíra Canal, Mario Limonciello,
Mikko Perttunen, nouveau, NXP Linux Team, Pan, Xinhui,
Pengutronix Kernel Team, Philipp Zabel, Sascha Hauer,
Shashank Sharma, Shawn Guo, Stanley Yang, Sumit Semwal,
Thierry Reding, Thomas Zimmermann, Michal Simek
On Thu, 24 Aug 2023, Maxime Ripard wrote:
> Hi,
>
> On Thu, Aug 24, 2023 at 10:59:54AM +0200, Maxime Ripard wrote:
> > On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote:
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> > >
> > > Cc: Alex Deucher <alexander.deucher@amd.com>
> > > Cc: amd-gfx@lists.freedesktop.org
> > > Cc: Ben Skeggs <bskeggs@redhat.com>
> > > Cc: "Christian König" <christian.koenig@amd.com>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Cc: Danilo Krummrich <dakr@redhat.com>
> > > Cc: David Airlie <airlied@gmail.com>
> > > Cc: dri-devel@lists.freedesktop.org
> > > Cc: Fabio Estevam <festevam@gmail.com>
> > > Cc: Gourav Samaiya <gsamaiya@nvidia.com>
> > > Cc: Hawking Zhang <Hawking.Zhang@amd.com>
> > > Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> > > Cc: Jerome Glisse <glisse@freedesktop.org>
> > > Cc: Jonathan Hunter <jonathanh@nvidia.com>
> > > Cc: Karol Herbst <kherbst@redhat.com>
> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Cc: linaro-mm-sig@lists.linaro.org
> > > Cc: linux-arm-kernel@lists.infradead.org
> > > Cc: linux-media@vger.kernel.org
> > > Cc: linux-tegra@vger.kernel.org
> > > Cc: Luben Tuikov <luben.tuikov@amd.com>
> > > Cc: Lyude Paul <lyude@redhat.com>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > Cc: "Maíra Canal" <mairacanal@riseup.net>
> > > Cc: Mario Limonciello <mario.limonciello@amd.com>
> > > Cc: Maxime Ripard <mripard@kernel.org>
> > > Cc: Michal Simek <michal.simek@xilinx.com>
> > > Cc: Mikko Perttunen <mperttunen@nvidia.com>
> > > Cc: nouveau@lists.freedesktop.org
> > > Cc: NXP Linux Team <linux-imx@nxp.com>
> > > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > Cc: Shashank Sharma <shashank.sharma@amd.com>
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Cc: Stanley Yang <Stanley.Yang@amd.com>
> > > Cc: Sumit Semwal <sumit.semwal@linaro.org>
> > > Cc: Thierry Reding <thierry.reding@gmail.com>
> > > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > >
> > > [...]
> >
> > Applied to drm/drm-misc (drm-misc-fixes).
>
> I got confused with b4 usage, but that wasn't actually applied. Only the
> three patches I explicitly mentioned were, sorry for the confusion.
:)
Thanks Maxime.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
2023-08-24 7:36 ` Lee Jones
(?)
(?)
@ 2023-08-24 9:03 ` Jani Nikula
-1 siblings, 0 replies; 159+ messages in thread
From: Jani Nikula @ 2023-08-24 9:03 UTC (permalink / raw)
To: Lee Jones, lee
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Shashank Sharma, Michal Simek, amd-gfx, Jonathan Hunter,
Luben Tuikov, Danilo Krummrich, Ben Skeggs, Stanley Yang,
linux-media, Thomas Zimmermann, Sascha Hauer, Maxime Ripard,
linaro-mm-sig, linux-tegra, NXP Linux Team, linux-arm-kernel,
Hyun Kwon, Pan, Xinhui, linux-kernel, Hawking Zhang,
Jerome Glisse, Pengutronix Kernel Team, Alex Deucher,
Gourav Samaiya, Shawn Guo, Christian König,
Mario Limonciello
On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
The next question is, how do we keep it W=1 clean going forward?
Most people don't use W=1 because it's too noisy, so it's a bit of a
catch-22.
In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
Makefile. For CI/developer use we also enable kernel-doc warnings by
default.
Should we start enabling some of those warning flags in drm/Makefile to
to keep the entire subsystem warning free?
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 9:03 ` Jani Nikula
0 siblings, 0 replies; 159+ messages in thread
From: Jani Nikula @ 2023-08-24 9:03 UTC (permalink / raw)
To: Lee Jones, lee
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Mario Limonciello, Shashank Sharma, Michal Simek, amd-gfx,
Jonathan Hunter, Luben Tuikov, Danilo Krummrich, Ben Skeggs,
linux-media, Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
Maxime Ripard, linaro-mm-sig, linux-tegra, NXP Linux Team,
linux-arm-kernel, Hyun Kwon, Thomas Zimmermann, Pan, Xinhui,
linux-kernel, Jerome Glisse, Alex Deucher, Gourav Samaiya,
Shawn Guo, Christian König, Hawking Zhang
On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
The next question is, how do we keep it W=1 clean going forward?
Most people don't use W=1 because it's too noisy, so it's a bit of a
catch-22.
In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
Makefile. For CI/developer use we also enable kernel-doc warnings by
default.
Should we start enabling some of those warning flags in drm/Makefile to
to keep the entire subsystem warning free?
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 9:03 ` Jani Nikula
0 siblings, 0 replies; 159+ messages in thread
From: Jani Nikula @ 2023-08-24 9:03 UTC (permalink / raw)
To: Lee Jones, lee
Cc: nouveau, dri-devel, Mikko Perttunen, Maíra Canal,
Thierry Reding, Laurent Pinchart, Sumit Semwal, Shashank Sharma,
Michal Simek, amd-gfx, Luben Tuikov, Ben Skeggs, Stanley Yang,
linux-media, Sascha Hauer, Maxime Ripard, linaro-mm-sig,
linux-tegra, NXP Linux Team, linux-arm-kernel, Hyun Kwon,
Pan, Xinhui, linux-kernel, Hawking Zhang, Jerome Glisse,
Pengutronix Kernel Team, Alex Deucher, Gourav Samaiya, Shawn Guo,
Christian König, Mario Limonciello
On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
The next question is, how do we keep it W=1 clean going forward?
Most people don't use W=1 because it's too noisy, so it's a bit of a
catch-22.
In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
Makefile. For CI/developer use we also enable kernel-doc warnings by
default.
Should we start enabling some of those warning flags in drm/Makefile to
to keep the entire subsystem warning free?
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 9:03 ` Jani Nikula
0 siblings, 0 replies; 159+ messages in thread
From: Jani Nikula @ 2023-08-24 9:03 UTC (permalink / raw)
To: Lee Jones, lee
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Mario Limonciello, Shashank Sharma, Michal Simek, amd-gfx,
Jonathan Hunter, Luben Tuikov, Danilo Krummrich, Ben Skeggs,
linux-media, Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
Maxime Ripard, linaro-mm-sig, linux-tegra, NXP Linux Team,
linux-arm-kernel, Hyun Kwon, Thomas Zimmermann, Pan, Xinhui,
linux-kernel, Jerome Glisse, Alex Deucher, Gourav Samaiya,
Shawn Guo, Christian König, Hawking Zhang
On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
The next question is, how do we keep it W=1 clean going forward?
Most people don't use W=1 because it's too noisy, so it's a bit of a
catch-22.
In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
Makefile. For CI/developer use we also enable kernel-doc warnings by
default.
Should we start enabling some of those warning flags in drm/Makefile to
to keep the entire subsystem warning free?
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
2023-08-24 9:03 ` Jani Nikula
(?)
(?)
@ 2023-08-24 9:16 ` Maxime Ripard
-1 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 9:16 UTC (permalink / raw)
To: Jani Nikula
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Shashank Sharma, Lee Jones, Michal Simek, amd-gfx,
Jonathan Hunter, Luben Tuikov, Danilo Krummrich, Ben Skeggs,
Stanley Yang, linux-media, Thomas Zimmermann, Sascha Hauer,
linaro-mm-sig, linux-tegra, NXP Linux Team, linux-arm-kernel,
Hyun Kwon, Pan, Xinhui, linux-kernel, Hawking Zhang,
Jerome Glisse, Pengutronix Kernel Team, Alex Deucher,
Gourav Samaiya, Shawn Guo, Christian König,
Mario Limonciello
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
On Thu, Aug 24, 2023 at 12:03:20PM +0300, Jani Nikula wrote:
> On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
>
> The next question is, how do we keep it W=1 clean going forward?
>
> Most people don't use W=1 because it's too noisy, so it's a bit of a
> catch-22.
>
> In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
> Makefile. For CI/developer use we also enable kernel-doc warnings by
> default.
>
> Should we start enabling some of those warning flags in drm/Makefile to
> to keep the entire subsystem warning free?
I think that's a good idea. At least the documentation fixes I just
merged could have been easily caught before submission.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 9:16 ` Maxime Ripard
0 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 9:16 UTC (permalink / raw)
To: Jani Nikula
Cc: Lee Jones, Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Mario Limonciello, Shashank Sharma, Michal Simek, amd-gfx,
Jonathan Hunter, Luben Tuikov, Danilo Krummrich, Ben Skeggs,
linux-media, Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
linaro-mm-sig, linux-tegra, NXP Linux Team, linux-arm-kernel,
Hyun Kwon, Thomas Zimmermann, Pan, Xinhui, linux-kernel,
Jerome Glisse, Alex Deucher, Gourav Samaiya, Shawn Guo,
Christian König, Hawking Zhang
[-- Attachment #1.1: Type: text/plain, Size: 871 bytes --]
On Thu, Aug 24, 2023 at 12:03:20PM +0300, Jani Nikula wrote:
> On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
>
> The next question is, how do we keep it W=1 clean going forward?
>
> Most people don't use W=1 because it's too noisy, so it's a bit of a
> catch-22.
>
> In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
> Makefile. For CI/developer use we also enable kernel-doc warnings by
> default.
>
> Should we start enabling some of those warning flags in drm/Makefile to
> to keep the entire subsystem warning free?
I think that's a good idea. At least the documentation fixes I just
merged could have been easily caught before submission.
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 9:16 ` Maxime Ripard
0 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 9:16 UTC (permalink / raw)
To: Jani Nikula
Cc: nouveau, dri-devel, Mikko Perttunen, Maíra Canal,
Thierry Reding, Laurent Pinchart, Sumit Semwal, Shashank Sharma,
Lee Jones, Michal Simek, amd-gfx, Luben Tuikov, Ben Skeggs,
Stanley Yang, linux-media, Sascha Hauer, linaro-mm-sig,
linux-tegra, NXP Linux Team, linux-arm-kernel, Hyun Kwon,
Pan, Xinhui, linux-kernel, Hawking Zhang, Jerome Glisse,
Pengutronix Kernel Team, Alex Deucher, Gourav Samaiya, Shawn Guo,
Christian König, Mario Limonciello
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
On Thu, Aug 24, 2023 at 12:03:20PM +0300, Jani Nikula wrote:
> On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
>
> The next question is, how do we keep it W=1 clean going forward?
>
> Most people don't use W=1 because it's too noisy, so it's a bit of a
> catch-22.
>
> In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
> Makefile. For CI/developer use we also enable kernel-doc warnings by
> default.
>
> Should we start enabling some of those warning flags in drm/Makefile to
> to keep the entire subsystem warning free?
I think that's a good idea. At least the documentation fixes I just
merged could have been easily caught before submission.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 9:16 ` Maxime Ripard
0 siblings, 0 replies; 159+ messages in thread
From: Maxime Ripard @ 2023-08-24 9:16 UTC (permalink / raw)
To: Jani Nikula
Cc: Lee Jones, Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Mario Limonciello, Shashank Sharma, Michal Simek, amd-gfx,
Jonathan Hunter, Luben Tuikov, Danilo Krummrich, Ben Skeggs,
linux-media, Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
linaro-mm-sig, linux-tegra, NXP Linux Team, linux-arm-kernel,
Hyun Kwon, Thomas Zimmermann, Pan, Xinhui, linux-kernel,
Jerome Glisse, Alex Deucher, Gourav Samaiya, Shawn Guo,
Christian König, Hawking Zhang
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
On Thu, Aug 24, 2023 at 12:03:20PM +0300, Jani Nikula wrote:
> On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
>
> The next question is, how do we keep it W=1 clean going forward?
>
> Most people don't use W=1 because it's too noisy, so it's a bit of a
> catch-22.
>
> In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
> Makefile. For CI/developer use we also enable kernel-doc warnings by
> default.
>
> Should we start enabling some of those warning flags in drm/Makefile to
> to keep the entire subsystem warning free?
I think that's a good idea. At least the documentation fixes I just
merged could have been easily caught before submission.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
2023-08-24 9:03 ` Jani Nikula
(?)
(?)
@ 2023-08-24 12:07 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:07 UTC (permalink / raw)
To: Jani Nikula
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Shashank Sharma, Michal Simek, amd-gfx, Jonathan Hunter,
Luben Tuikov, Danilo Krummrich, Ben Skeggs, Stanley Yang,
linux-media, Thomas Zimmermann, Sascha Hauer, Maxime Ripard,
linaro-mm-sig, linux-tegra, NXP Linux Team, linux-arm-kernel,
Hyun Kwon, Pan, Xinhui, linux-kernel, Hawking Zhang,
Jerome Glisse, Pengutronix Kernel Team, Alex Deucher,
Gourav Samaiya, Shawn Guo, Christian König,
Mario Limonciello
On Thu, 24 Aug 2023, Jani Nikula wrote:
> On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
>
> The next question is, how do we keep it W=1 clean going forward?
My plan was to fix them all, then move each warning to W=0.
Arnd recently submitted a set doing just that for a bunch of them.
https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
I like to think a bunch of this is built on top of my previous efforts.
GPU is a particularly tricky though - the warnings seem to come in faster
than I can squash them. Maybe the maintainers can find a way to test
new patches on merge?
> Most people don't use W=1 because it's too noisy, so it's a bit of a
> catch-22.
>
> In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
> Makefile. For CI/developer use we also enable kernel-doc warnings by
> default.
>
> Should we start enabling some of those warning flags in drm/Makefile to
> to keep the entire subsystem warning free?
That would we awesome! We'd just need buy-in.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 12:07 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:07 UTC (permalink / raw)
To: Jani Nikula
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Mario Limonciello, Shashank Sharma, Michal Simek, amd-gfx,
Jonathan Hunter, Luben Tuikov, Danilo Krummrich, Ben Skeggs,
linux-media, Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
Maxime Ripard, linaro-mm-sig, linux-tegra, NXP Linux Team,
linux-arm-kernel, Hyun Kwon, Thomas Zimmermann, Pan, Xinhui,
linux-kernel, Jerome Glisse, Alex Deucher, Gourav Samaiya,
Shawn Guo, Christian König, Hawking Zhang
On Thu, 24 Aug 2023, Jani Nikula wrote:
> On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
>
> The next question is, how do we keep it W=1 clean going forward?
My plan was to fix them all, then move each warning to W=0.
Arnd recently submitted a set doing just that for a bunch of them.
https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
I like to think a bunch of this is built on top of my previous efforts.
GPU is a particularly tricky though - the warnings seem to come in faster
than I can squash them. Maybe the maintainers can find a way to test
new patches on merge?
> Most people don't use W=1 because it's too noisy, so it's a bit of a
> catch-22.
>
> In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
> Makefile. For CI/developer use we also enable kernel-doc warnings by
> default.
>
> Should we start enabling some of those warning flags in drm/Makefile to
> to keep the entire subsystem warning free?
That would we awesome! We'd just need buy-in.
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 12:07 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:07 UTC (permalink / raw)
To: Jani Nikula
Cc: nouveau, dri-devel, Mikko Perttunen, Maíra Canal,
Thierry Reding, Laurent Pinchart, Sumit Semwal, Shashank Sharma,
Michal Simek, amd-gfx, Luben Tuikov, Ben Skeggs, Stanley Yang,
linux-media, Sascha Hauer, Maxime Ripard, linaro-mm-sig,
linux-tegra, NXP Linux Team, linux-arm-kernel, Hyun Kwon,
Pan, Xinhui, linux-kernel, Hawking Zhang, Jerome Glisse,
Pengutronix Kernel Team, Alex Deucher, Gourav Samaiya, Shawn Guo,
Christian König, Mario Limonciello
On Thu, 24 Aug 2023, Jani Nikula wrote:
> On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
>
> The next question is, how do we keep it W=1 clean going forward?
My plan was to fix them all, then move each warning to W=0.
Arnd recently submitted a set doing just that for a bunch of them.
https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
I like to think a bunch of this is built on top of my previous efforts.
GPU is a particularly tricky though - the warnings seem to come in faster
than I can squash them. Maybe the maintainers can find a way to test
new patches on merge?
> Most people don't use W=1 because it's too noisy, so it's a bit of a
> catch-22.
>
> In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
> Makefile. For CI/developer use we also enable kernel-doc warnings by
> default.
>
> Should we start enabling some of those warning flags in drm/Makefile to
> to keep the entire subsystem warning free?
That would we awesome! We'd just need buy-in.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 12:07 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:07 UTC (permalink / raw)
To: Jani Nikula
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Mario Limonciello, Shashank Sharma, Michal Simek, amd-gfx,
Jonathan Hunter, Luben Tuikov, Danilo Krummrich, Ben Skeggs,
linux-media, Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
Maxime Ripard, linaro-mm-sig, linux-tegra, NXP Linux Team,
linux-arm-kernel, Hyun Kwon, Thomas Zimmermann, Pan, Xinhui,
linux-kernel, Jerome Glisse, Alex Deucher, Gourav Samaiya,
Shawn Guo, Christian König, Hawking Zhang
On Thu, 24 Aug 2023, Jani Nikula wrote:
> On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
>
> The next question is, how do we keep it W=1 clean going forward?
My plan was to fix them all, then move each warning to W=0.
Arnd recently submitted a set doing just that for a bunch of them.
https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
I like to think a bunch of this is built on top of my previous efforts.
GPU is a particularly tricky though - the warnings seem to come in faster
than I can squash them. Maybe the maintainers can find a way to test
new patches on merge?
> Most people don't use W=1 because it's too noisy, so it's a bit of a
> catch-22.
>
> In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
> Makefile. For CI/developer use we also enable kernel-doc warnings by
> default.
>
> Should we start enabling some of those warning flags in drm/Makefile to
> to keep the entire subsystem warning free?
That would we awesome! We'd just need buy-in.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
2023-08-24 12:07 ` Lee Jones
(?)
(?)
@ 2023-08-24 12:08 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:08 UTC (permalink / raw)
To: Jani Nikula
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Shashank Sharma, Michal Simek, amd-gfx, Jonathan Hunter,
Luben Tuikov, Danilo Krummrich, Ben Skeggs, Stanley Yang,
linux-media, Thomas Zimmermann, Sascha Hauer, Maxime Ripard,
linaro-mm-sig, linux-tegra, NXP Linux Team, linux-arm-kernel,
Hyun Kwon, Pan, Xinhui, linux-kernel, Hawking Zhang,
Jerome Glisse, Pengutronix Kernel Team, Alex Deucher,
Gourav Samaiya, Shawn Guo, Christian König,
Mario Limonciello
On Thu, 24 Aug 2023, Lee Jones wrote:
> On Thu, 24 Aug 2023, Jani Nikula wrote:
>
> > On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> >
> > The next question is, how do we keep it W=1 clean going forward?
>
> My plan was to fix them all, then move each warning to W=0.
Some history:
- Starting with v5.8-rc1: 18867
- 2020-07-01: 18089
- 2020-07-07: 17288
- 2020-07-17: 15762
- 2020-07-20: 15724
- 2020-07-23: 15116
- 2020-08-12: 15184
- 2020-10-19: 10909
- 2020-11-04: 9385
- 2021-01-04: 5478
- 2021-01-12 4749
- 2021-01-29 4911
- 2021-04-07 3594
- 2021-05-20 2938
- 2021-07-01 2587
- 2023-02-10 2587
- 2023-08-22 1650
> Arnd recently submitted a set doing just that for a bunch of them.
>
> https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
>
> I like to think a bunch of this is built on top of my previous efforts.
>
> GPU is a particularly tricky though - the warnings seem to come in faster
> than I can squash them. Maybe the maintainers can find a way to test
> new patches on merge?
>
> > Most people don't use W=1 because it's too noisy, so it's a bit of a
> > catch-22.
> >
> > In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
> > Makefile. For CI/developer use we also enable kernel-doc warnings by
> > default.
> >
> > Should we start enabling some of those warning flags in drm/Makefile to
> > to keep the entire subsystem warning free?
>
> That would we awesome! We'd just need buy-in.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 12:08 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:08 UTC (permalink / raw)
To: Jani Nikula
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Mario Limonciello, Shashank Sharma, Michal Simek, amd-gfx,
Jonathan Hunter, Luben Tuikov, Danilo Krummrich, Ben Skeggs,
linux-media, Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
Maxime Ripard, linaro-mm-sig, linux-tegra, NXP Linux Team,
linux-arm-kernel, Hyun Kwon, Thomas Zimmermann, Pan, Xinhui,
linux-kernel, Jerome Glisse, Alex Deucher, Gourav Samaiya,
Shawn Guo, Christian König, Hawking Zhang
On Thu, 24 Aug 2023, Lee Jones wrote:
> On Thu, 24 Aug 2023, Jani Nikula wrote:
>
> > On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> >
> > The next question is, how do we keep it W=1 clean going forward?
>
> My plan was to fix them all, then move each warning to W=0.
Some history:
- Starting with v5.8-rc1: 18867
- 2020-07-01: 18089
- 2020-07-07: 17288
- 2020-07-17: 15762
- 2020-07-20: 15724
- 2020-07-23: 15116
- 2020-08-12: 15184
- 2020-10-19: 10909
- 2020-11-04: 9385
- 2021-01-04: 5478
- 2021-01-12 4749
- 2021-01-29 4911
- 2021-04-07 3594
- 2021-05-20 2938
- 2021-07-01 2587
- 2023-02-10 2587
- 2023-08-22 1650
> Arnd recently submitted a set doing just that for a bunch of them.
>
> https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
>
> I like to think a bunch of this is built on top of my previous efforts.
>
> GPU is a particularly tricky though - the warnings seem to come in faster
> than I can squash them. Maybe the maintainers can find a way to test
> new patches on merge?
>
> > Most people don't use W=1 because it's too noisy, so it's a bit of a
> > catch-22.
> >
> > In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
> > Makefile. For CI/developer use we also enable kernel-doc warnings by
> > default.
> >
> > Should we start enabling some of those warning flags in drm/Makefile to
> > to keep the entire subsystem warning free?
>
> That would we awesome! We'd just need buy-in.
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 12:08 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:08 UTC (permalink / raw)
To: Jani Nikula
Cc: nouveau, dri-devel, Mikko Perttunen, Maíra Canal,
Thierry Reding, Laurent Pinchart, Sumit Semwal, Shashank Sharma,
Michal Simek, amd-gfx, Luben Tuikov, Ben Skeggs, Stanley Yang,
linux-media, Sascha Hauer, Maxime Ripard, linaro-mm-sig,
linux-tegra, NXP Linux Team, linux-arm-kernel, Hyun Kwon,
Pan, Xinhui, linux-kernel, Hawking Zhang, Jerome Glisse,
Pengutronix Kernel Team, Alex Deucher, Gourav Samaiya, Shawn Guo,
Christian König, Mario Limonciello
On Thu, 24 Aug 2023, Lee Jones wrote:
> On Thu, 24 Aug 2023, Jani Nikula wrote:
>
> > On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> >
> > The next question is, how do we keep it W=1 clean going forward?
>
> My plan was to fix them all, then move each warning to W=0.
Some history:
- Starting with v5.8-rc1: 18867
- 2020-07-01: 18089
- 2020-07-07: 17288
- 2020-07-17: 15762
- 2020-07-20: 15724
- 2020-07-23: 15116
- 2020-08-12: 15184
- 2020-10-19: 10909
- 2020-11-04: 9385
- 2021-01-04: 5478
- 2021-01-12 4749
- 2021-01-29 4911
- 2021-04-07 3594
- 2021-05-20 2938
- 2021-07-01 2587
- 2023-02-10 2587
- 2023-08-22 1650
> Arnd recently submitted a set doing just that for a bunch of them.
>
> https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
>
> I like to think a bunch of this is built on top of my previous efforts.
>
> GPU is a particularly tricky though - the warnings seem to come in faster
> than I can squash them. Maybe the maintainers can find a way to test
> new patches on merge?
>
> > Most people don't use W=1 because it's too noisy, so it's a bit of a
> > catch-22.
> >
> > In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
> > Makefile. For CI/developer use we also enable kernel-doc warnings by
> > default.
> >
> > Should we start enabling some of those warning flags in drm/Makefile to
> > to keep the entire subsystem warning free?
>
> That would we awesome! We'd just need buy-in.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 12:08 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:08 UTC (permalink / raw)
To: Jani Nikula
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Mario Limonciello, Shashank Sharma, Michal Simek, amd-gfx,
Jonathan Hunter, Luben Tuikov, Danilo Krummrich, Ben Skeggs,
linux-media, Stanley Yang, Pengutronix Kernel Team, Sascha Hauer,
Maxime Ripard, linaro-mm-sig, linux-tegra, NXP Linux Team,
linux-arm-kernel, Hyun Kwon, Thomas Zimmermann, Pan, Xinhui,
linux-kernel, Jerome Glisse, Alex Deucher, Gourav Samaiya,
Shawn Guo, Christian König, Hawking Zhang
On Thu, 24 Aug 2023, Lee Jones wrote:
> On Thu, 24 Aug 2023, Jani Nikula wrote:
>
> > On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> >
> > The next question is, how do we keep it W=1 clean going forward?
>
> My plan was to fix them all, then move each warning to W=0.
Some history:
- Starting with v5.8-rc1: 18867
- 2020-07-01: 18089
- 2020-07-07: 17288
- 2020-07-17: 15762
- 2020-07-20: 15724
- 2020-07-23: 15116
- 2020-08-12: 15184
- 2020-10-19: 10909
- 2020-11-04: 9385
- 2021-01-04: 5478
- 2021-01-12 4749
- 2021-01-29 4911
- 2021-04-07 3594
- 2021-05-20 2938
- 2021-07-01 2587
- 2023-02-10 2587
- 2023-08-22 1650
> Arnd recently submitted a set doing just that for a bunch of them.
>
> https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
>
> I like to think a bunch of this is built on top of my previous efforts.
>
> GPU is a particularly tricky though - the warnings seem to come in faster
> than I can squash them. Maybe the maintainers can find a way to test
> new patches on merge?
>
> > Most people don't use W=1 because it's too noisy, so it's a bit of a
> > catch-22.
> >
> > In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
> > Makefile. For CI/developer use we also enable kernel-doc warnings by
> > default.
> >
> > Should we start enabling some of those warning flags in drm/Makefile to
> > to keep the entire subsystem warning free?
>
> That would we awesome! We'd just need buy-in.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
2023-08-24 12:07 ` Lee Jones
(?)
(?)
@ 2023-08-24 12:14 ` Hamza Mahfooz
-1 siblings, 0 replies; 159+ messages in thread
From: Hamza Mahfooz @ 2023-08-24 12:14 UTC (permalink / raw)
To: Lee Jones, Jani Nikula
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Mario Limonciello, Shashank Sharma, Michal Simek, amd-gfx,
Jonathan Hunter, Luben Tuikov, Danilo Krummrich, Ben Skeggs,
Stanley Yang, linux-media, Pengutronix Kernel Team, Sascha Hauer,
Maxime Ripard, linaro-mm-sig, linux-tegra, NXP Linux Team,
linux-arm-kernel, Hyun Kwon, Pan, Xinhui, linux-kernel,
Jerome Glisse, Thomas Zimmermann, Alex Deucher, Gourav Samaiya,
Shawn Guo, Christian König, Hawking Zhang
On 8/24/23 08:07, Lee Jones wrote:
> On Thu, 24 Aug 2023, Jani Nikula wrote:
>
>> On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
>>> This set is part of a larger effort attempting to clean-up W=1
>>> kernel builds, which are currently overwhelmingly riddled with
>>> niggly little warnings.
>>
>> The next question is, how do we keep it W=1 clean going forward?
>
> My plan was to fix them all, then move each warning to W=0.
>
> Arnd recently submitted a set doing just that for a bunch of them.
>
> https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
>
> I like to think a bunch of this is built on top of my previous efforts.
>
> GPU is a particularly tricky though - the warnings seem to come in faster
> than I can squash them. Maybe the maintainers can find a way to test
> new patches on merge?
I guess on that note, do you know if there is a way to run
`scripts/kernel-doc` on patches instead of whole files? That would make
much easier to block new kernel-doc issues from appearing.
>
>> Most people don't use W=1 because it's too noisy, so it's a bit of a
>> catch-22.
>>
>> In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
>> Makefile. For CI/developer use we also enable kernel-doc warnings by
>> default.
>>
>> Should we start enabling some of those warning flags in drm/Makefile to
>> to keep the entire subsystem warning free?
>
> That would we awesome! We'd just need buy-in.
>
--
Hamza
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 12:14 ` Hamza Mahfooz
0 siblings, 0 replies; 159+ messages in thread
From: Hamza Mahfooz @ 2023-08-24 12:14 UTC (permalink / raw)
To: Lee Jones, Jani Nikula
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Shashank Sharma, Michal Simek, amd-gfx, Jonathan Hunter,
Luben Tuikov, Danilo Krummrich, Ben Skeggs, Stanley Yang,
linux-media, Thomas Zimmermann, Sascha Hauer, Maxime Ripard,
linaro-mm-sig, linux-tegra, NXP Linux Team, linux-arm-kernel,
Hyun Kwon, Pan, Xinhui, linux-kernel, Hawking Zhang,
Jerome Glisse, Pengutronix Kernel Team, Alex Deucher,
Gourav Samaiya, Shawn Guo, Christian König,
Mario Limonciello
On 8/24/23 08:07, Lee Jones wrote:
> On Thu, 24 Aug 2023, Jani Nikula wrote:
>
>> On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
>>> This set is part of a larger effort attempting to clean-up W=1
>>> kernel builds, which are currently overwhelmingly riddled with
>>> niggly little warnings.
>>
>> The next question is, how do we keep it W=1 clean going forward?
>
> My plan was to fix them all, then move each warning to W=0.
>
> Arnd recently submitted a set doing just that for a bunch of them.
>
> https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
>
> I like to think a bunch of this is built on top of my previous efforts.
>
> GPU is a particularly tricky though - the warnings seem to come in faster
> than I can squash them. Maybe the maintainers can find a way to test
> new patches on merge?
I guess on that note, do you know if there is a way to run
`scripts/kernel-doc` on patches instead of whole files? That would make
much easier to block new kernel-doc issues from appearing.
>
>> Most people don't use W=1 because it's too noisy, so it's a bit of a
>> catch-22.
>>
>> In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
>> Makefile. For CI/developer use we also enable kernel-doc warnings by
>> default.
>>
>> Should we start enabling some of those warning flags in drm/Makefile to
>> to keep the entire subsystem warning free?
>
> That would we awesome! We'd just need buy-in.
>
--
Hamza
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 12:14 ` Hamza Mahfooz
0 siblings, 0 replies; 159+ messages in thread
From: Hamza Mahfooz @ 2023-08-24 12:14 UTC (permalink / raw)
To: Lee Jones, Jani Nikula
Cc: nouveau, dri-devel, Mikko Perttunen, Maíra Canal,
Thierry Reding, Laurent Pinchart, Sumit Semwal, Mario Limonciello,
Shashank Sharma, Michal Simek, amd-gfx, Luben Tuikov, Ben Skeggs,
Stanley Yang, linux-media, Pengutronix Kernel Team, Sascha Hauer,
Maxime Ripard, linaro-mm-sig, linux-tegra, NXP Linux Team,
linux-arm-kernel, Hyun Kwon, Pan, Xinhui, linux-kernel,
Jerome Glisse, Alex Deucher, Gourav Samaiya, Shawn Guo,
Christian König, Hawking Zhang
On 8/24/23 08:07, Lee Jones wrote:
> On Thu, 24 Aug 2023, Jani Nikula wrote:
>
>> On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
>>> This set is part of a larger effort attempting to clean-up W=1
>>> kernel builds, which are currently overwhelmingly riddled with
>>> niggly little warnings.
>>
>> The next question is, how do we keep it W=1 clean going forward?
>
> My plan was to fix them all, then move each warning to W=0.
>
> Arnd recently submitted a set doing just that for a bunch of them.
>
> https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
>
> I like to think a bunch of this is built on top of my previous efforts.
>
> GPU is a particularly tricky though - the warnings seem to come in faster
> than I can squash them. Maybe the maintainers can find a way to test
> new patches on merge?
I guess on that note, do you know if there is a way to run
`scripts/kernel-doc` on patches instead of whole files? That would make
much easier to block new kernel-doc issues from appearing.
>
>> Most people don't use W=1 because it's too noisy, so it's a bit of a
>> catch-22.
>>
>> In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
>> Makefile. For CI/developer use we also enable kernel-doc warnings by
>> default.
>>
>> Should we start enabling some of those warning flags in drm/Makefile to
>> to keep the entire subsystem warning free?
>
> That would we awesome! We'd just need buy-in.
>
--
Hamza
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 12:14 ` Hamza Mahfooz
0 siblings, 0 replies; 159+ messages in thread
From: Hamza Mahfooz @ 2023-08-24 12:14 UTC (permalink / raw)
To: Lee Jones, Jani Nikula
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Shashank Sharma, Michal Simek, amd-gfx, Jonathan Hunter,
Luben Tuikov, Danilo Krummrich, Ben Skeggs, Stanley Yang,
linux-media, Thomas Zimmermann, Sascha Hauer, Maxime Ripard,
linaro-mm-sig, linux-tegra, NXP Linux Team, linux-arm-kernel,
Hyun Kwon, Pan, Xinhui, linux-kernel, Hawking Zhang,
Jerome Glisse, Pengutronix Kernel Team, Alex Deucher,
Gourav Samaiya, Shawn Guo, Christian König,
Mario Limonciello
On 8/24/23 08:07, Lee Jones wrote:
> On Thu, 24 Aug 2023, Jani Nikula wrote:
>
>> On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
>>> This set is part of a larger effort attempting to clean-up W=1
>>> kernel builds, which are currently overwhelmingly riddled with
>>> niggly little warnings.
>>
>> The next question is, how do we keep it W=1 clean going forward?
>
> My plan was to fix them all, then move each warning to W=0.
>
> Arnd recently submitted a set doing just that for a bunch of them.
>
> https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
>
> I like to think a bunch of this is built on top of my previous efforts.
>
> GPU is a particularly tricky though - the warnings seem to come in faster
> than I can squash them. Maybe the maintainers can find a way to test
> new patches on merge?
I guess on that note, do you know if there is a way to run
`scripts/kernel-doc` on patches instead of whole files? That would make
much easier to block new kernel-doc issues from appearing.
>
>> Most people don't use W=1 because it's too noisy, so it's a bit of a
>> catch-22.
>>
>> In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
>> Makefile. For CI/developer use we also enable kernel-doc warnings by
>> default.
>>
>> Should we start enabling some of those warning flags in drm/Makefile to
>> to keep the entire subsystem warning free?
>
> That would we awesome! We'd just need buy-in.
>
--
Hamza
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
2023-08-24 12:14 ` Hamza Mahfooz
` (2 preceding siblings ...)
(?)
@ 2023-08-24 12:24 ` Lee Jones
-1 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:24 UTC (permalink / raw)
To: Hamza Mahfooz
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Mario Limonciello, Shashank Sharma, Michal Simek, amd-gfx,
Jonathan Hunter, Luben Tuikov, Danilo Krummrich, Ben Skeggs,
Stanley Yang, linux-media, Pengutronix Kernel Team, Sascha Hauer,
Maxime Ripard, linaro-mm-sig, Jani Nikula, linux-tegra,
NXP Linux Team, linux-arm-kernel, Hyun Kwon, Pan, Xinhui,
linux-kernel, Jerome Glisse, Thomas Zimmermann, Alex Deucher,
Gourav Samaiya, Shawn Guo, Christian König, Hawking Zhang
On Thu, 24 Aug 2023, Hamza Mahfooz wrote:
>
> On 8/24/23 08:07, Lee Jones wrote:
> > On Thu, 24 Aug 2023, Jani Nikula wrote:
> >
> > > On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> > > > This set is part of a larger effort attempting to clean-up W=1
> > > > kernel builds, which are currently overwhelmingly riddled with
> > > > niggly little warnings.
> > >
> > > The next question is, how do we keep it W=1 clean going forward?
> >
> > My plan was to fix them all, then move each warning to W=0.
> >
> > Arnd recently submitted a set doing just that for a bunch of them.
> >
> > https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
> >
> > I like to think a bunch of this is built on top of my previous efforts.
> >
> > GPU is a particularly tricky though - the warnings seem to come in faster
> > than I can squash them. Maybe the maintainers can find a way to test
> > new patches on merge?
>
> I guess on that note, do you know if there is a way to run
> `scripts/kernel-doc` on patches instead of whole files? That would make
> much easier to block new kernel-doc issues from appearing.
Not off hand.
When I run builds on patches I author, I run them twice concurrently.
Once on the commit I'm basing on and once on the HEAD of my patchset. I
then diff the two. So as long as the number of errors and warnings stay
the same or reduce, we're golden.
Perhaps the same method could be used with `kernel-doc`?
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 12:24 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:24 UTC (permalink / raw)
To: Hamza Mahfooz
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Mario Limonciello, Shashank Sharma, Michal Simek, amd-gfx,
Jonathan Hunter, Luben Tuikov, Danilo Krummrich, Ben Skeggs,
Stanley Yang, linux-media, Pengutronix Kernel Team, Sascha Hauer,
Maxime Ripard, linaro-mm-sig, linux-tegra, NXP Linux Team,
linux-arm-kernel, Hyun Kwon, Pan, Xinhui, linux-kernel,
Jerome Glisse, Thomas Zimmermann, Alex Deucher, Gourav Samaiya,
Shawn Guo, Christian König, Hawking Zhang
On Thu, 24 Aug 2023, Hamza Mahfooz wrote:
>
> On 8/24/23 08:07, Lee Jones wrote:
> > On Thu, 24 Aug 2023, Jani Nikula wrote:
> >
> > > On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> > > > This set is part of a larger effort attempting to clean-up W=1
> > > > kernel builds, which are currently overwhelmingly riddled with
> > > > niggly little warnings.
> > >
> > > The next question is, how do we keep it W=1 clean going forward?
> >
> > My plan was to fix them all, then move each warning to W=0.
> >
> > Arnd recently submitted a set doing just that for a bunch of them.
> >
> > https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
> >
> > I like to think a bunch of this is built on top of my previous efforts.
> >
> > GPU is a particularly tricky though - the warnings seem to come in faster
> > than I can squash them. Maybe the maintainers can find a way to test
> > new patches on merge?
>
> I guess on that note, do you know if there is a way to run
> `scripts/kernel-doc` on patches instead of whole files? That would make
> much easier to block new kernel-doc issues from appearing.
Not off hand.
When I run builds on patches I author, I run them twice concurrently.
Once on the commit I'm basing on and once on the HEAD of my patchset. I
then diff the two. So as long as the number of errors and warnings stay
the same or reduce, we're golden.
Perhaps the same method could be used with `kernel-doc`?
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 12:24 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:24 UTC (permalink / raw)
To: Hamza Mahfooz
Cc: Jani Nikula, Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Shashank Sharma, Michal Simek, amd-gfx, Jonathan Hunter,
Luben Tuikov, Danilo Krummrich, Ben Skeggs, Stanley Yang,
linux-media, Thomas Zimmermann, Sascha Hauer, Maxime Ripard,
linaro-mm-sig, linux-tegra, NXP Linux Team, linux-arm-kernel,
Hyun Kwon, Pan, Xinhui, linux-kernel, Hawking Zhang,
Jerome Glisse, Pengutronix Kernel Team, Alex Deucher,
Gourav Samaiya, Shawn Guo, Christian König,
Mario Limonciello
On Thu, 24 Aug 2023, Hamza Mahfooz wrote:
>
> On 8/24/23 08:07, Lee Jones wrote:
> > On Thu, 24 Aug 2023, Jani Nikula wrote:
> >
> > > On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> > > > This set is part of a larger effort attempting to clean-up W=1
> > > > kernel builds, which are currently overwhelmingly riddled with
> > > > niggly little warnings.
> > >
> > > The next question is, how do we keep it W=1 clean going forward?
> >
> > My plan was to fix them all, then move each warning to W=0.
> >
> > Arnd recently submitted a set doing just that for a bunch of them.
> >
> > https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
> >
> > I like to think a bunch of this is built on top of my previous efforts.
> >
> > GPU is a particularly tricky though - the warnings seem to come in faster
> > than I can squash them. Maybe the maintainers can find a way to test
> > new patches on merge?
>
> I guess on that note, do you know if there is a way to run
> `scripts/kernel-doc` on patches instead of whole files? That would make
> much easier to block new kernel-doc issues from appearing.
Not off hand.
When I run builds on patches I author, I run them twice concurrently.
Once on the commit I'm basing on and once on the HEAD of my patchset. I
then diff the two. So as long as the number of errors and warnings stay
the same or reduce, we're golden.
Perhaps the same method could be used with `kernel-doc`?
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 12:24 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:24 UTC (permalink / raw)
To: Hamza Mahfooz
Cc: nouveau, dri-devel, Mikko Perttunen, Maíra Canal,
Thierry Reding, Laurent Pinchart, Sumit Semwal, Mario Limonciello,
Shashank Sharma, Michal Simek, amd-gfx, Luben Tuikov, Ben Skeggs,
Stanley Yang, linux-media, Pengutronix Kernel Team, Sascha Hauer,
Maxime Ripard, linaro-mm-sig, Jani Nikula, linux-tegra,
NXP Linux Team, linux-arm-kernel, Hyun Kwon, Pan, Xinhui,
linux-kernel, Jerome Glisse, Alex Deucher, Gourav Samaiya,
Shawn Guo, Christian König, Hawking Zhang
On Thu, 24 Aug 2023, Hamza Mahfooz wrote:
>
> On 8/24/23 08:07, Lee Jones wrote:
> > On Thu, 24 Aug 2023, Jani Nikula wrote:
> >
> > > On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> > > > This set is part of a larger effort attempting to clean-up W=1
> > > > kernel builds, which are currently overwhelmingly riddled with
> > > > niggly little warnings.
> > >
> > > The next question is, how do we keep it W=1 clean going forward?
> >
> > My plan was to fix them all, then move each warning to W=0.
> >
> > Arnd recently submitted a set doing just that for a bunch of them.
> >
> > https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
> >
> > I like to think a bunch of this is built on top of my previous efforts.
> >
> > GPU is a particularly tricky though - the warnings seem to come in faster
> > than I can squash them. Maybe the maintainers can find a way to test
> > new patches on merge?
>
> I guess on that note, do you know if there is a way to run
> `scripts/kernel-doc` on patches instead of whole files? That would make
> much easier to block new kernel-doc issues from appearing.
Not off hand.
When I run builds on patches I author, I run them twice concurrently.
Once on the commit I'm basing on and once on the HEAD of my patchset. I
then diff the two. So as long as the number of errors and warnings stay
the same or reduce, we're golden.
Perhaps the same method could be used with `kernel-doc`?
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-24 12:24 ` Lee Jones
0 siblings, 0 replies; 159+ messages in thread
From: Lee Jones @ 2023-08-24 12:24 UTC (permalink / raw)
To: Hamza Mahfooz
Cc: Jani Nikula, Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Shashank Sharma, Michal Simek, amd-gfx, Jonathan Hunter,
Luben Tuikov, Danilo Krummrich, Ben Skeggs, Stanley Yang,
linux-media, Thomas Zimmermann, Sascha Hauer, Maxime Ripard,
linaro-mm-sig, linux-tegra, NXP Linux Team, linux-arm-kernel,
Hyun Kwon, Pan, Xinhui, linux-kernel, Hawking Zhang,
Jerome Glisse, Pengutronix Kernel Team, Alex Deucher,
Gourav Samaiya, Shawn Guo, Christian König,
Mario Limonciello
On Thu, 24 Aug 2023, Hamza Mahfooz wrote:
>
> On 8/24/23 08:07, Lee Jones wrote:
> > On Thu, 24 Aug 2023, Jani Nikula wrote:
> >
> > > On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
> > > > This set is part of a larger effort attempting to clean-up W=1
> > > > kernel builds, which are currently overwhelmingly riddled with
> > > > niggly little warnings.
> > >
> > > The next question is, how do we keep it W=1 clean going forward?
> >
> > My plan was to fix them all, then move each warning to W=0.
> >
> > Arnd recently submitted a set doing just that for a bunch of them.
> >
> > https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
> >
> > I like to think a bunch of this is built on top of my previous efforts.
> >
> > GPU is a particularly tricky though - the warnings seem to come in faster
> > than I can squash them. Maybe the maintainers can find a way to test
> > new patches on merge?
>
> I guess on that note, do you know if there is a way to run
> `scripts/kernel-doc` on patches instead of whole files? That would make
> much easier to block new kernel-doc issues from appearing.
Not off hand.
When I run builds on patches I author, I run them twice concurrently.
Once on the commit I'm basing on and once on the HEAD of my patchset. I
then diff the two. So as long as the number of errors and warnings stay
the same or reduce, we're golden.
Perhaps the same method could be used with `kernel-doc`?
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
2023-08-24 12:07 ` Lee Jones
(?)
(?)
@ 2023-08-28 16:11 ` Michel Dänzer
-1 siblings, 0 replies; 159+ messages in thread
From: Michel Dänzer @ 2023-08-28 16:11 UTC (permalink / raw)
To: Lee Jones, Jani Nikula
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Mario Limonciello, Shashank Sharma, Michal Simek, amd-gfx,
Jonathan Hunter, Luben Tuikov, Danilo Krummrich, Ben Skeggs,
Stanley Yang, linux-media, Pengutronix Kernel Team, Sascha Hauer,
Maxime Ripard, linaro-mm-sig, linux-tegra, NXP Linux Team,
linux-arm-kernel, Hyun Kwon, Pan, Xinhui, linux-kernel,
Jerome Glisse, Thomas Zimmermann, Alex Deucher, Gourav Samaiya,
Shawn Guo, Christian König, Hawking Zhang
On 8/24/23 14:07, Lee Jones wrote:
> On Thu, 24 Aug 2023, Jani Nikula wrote:
>> On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
>>> This set is part of a larger effort attempting to clean-up W=1
>>> kernel builds, which are currently overwhelmingly riddled with
>>> niggly little warnings.
>>
>> The next question is, how do we keep it W=1 clean going forward?
>
> My plan was to fix them all, then move each warning to W=0.
>
> Arnd recently submitted a set doing just that for a bunch of them.
>
> https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
>
> I like to think a bunch of this is built on top of my previous efforts.
>
> GPU is a particularly tricky though - the warnings seem to come in faster
> than I can squash them. Maybe the maintainers can find a way to test
> new patches on merge?
One approach for this which has proved effective in Mesa and other projects is to make warnings fatal in CI which must pass for any changes to be merged. There is ongoing work toward introducing this for the DRM subsystem, using gitlab.freedesktop.org CI.
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and Xwayland developer
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-28 16:11 ` Michel Dänzer
0 siblings, 0 replies; 159+ messages in thread
From: Michel Dänzer @ 2023-08-28 16:11 UTC (permalink / raw)
To: Lee Jones, Jani Nikula
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Shashank Sharma, Michal Simek, amd-gfx, Jonathan Hunter,
Luben Tuikov, Danilo Krummrich, Ben Skeggs, Stanley Yang,
linux-media, Thomas Zimmermann, Sascha Hauer, Maxime Ripard,
linaro-mm-sig, linux-tegra, NXP Linux Team, linux-arm-kernel,
Hyun Kwon, Pan, Xinhui, linux-kernel, Hawking Zhang,
Jerome Glisse, Pengutronix Kernel Team, Alex Deucher,
Gourav Samaiya, Shawn Guo, Christian König,
Mario Limonciello
On 8/24/23 14:07, Lee Jones wrote:
> On Thu, 24 Aug 2023, Jani Nikula wrote:
>> On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
>>> This set is part of a larger effort attempting to clean-up W=1
>>> kernel builds, which are currently overwhelmingly riddled with
>>> niggly little warnings.
>>
>> The next question is, how do we keep it W=1 clean going forward?
>
> My plan was to fix them all, then move each warning to W=0.
>
> Arnd recently submitted a set doing just that for a bunch of them.
>
> https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
>
> I like to think a bunch of this is built on top of my previous efforts.
>
> GPU is a particularly tricky though - the warnings seem to come in faster
> than I can squash them. Maybe the maintainers can find a way to test
> new patches on merge?
One approach for this which has proved effective in Mesa and other projects is to make warnings fatal in CI which must pass for any changes to be merged. There is ongoing work toward introducing this for the DRM subsystem, using gitlab.freedesktop.org CI.
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and Xwayland developer
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-28 16:11 ` Michel Dänzer
0 siblings, 0 replies; 159+ messages in thread
From: Michel Dänzer @ 2023-08-28 16:11 UTC (permalink / raw)
To: Lee Jones, Jani Nikula
Cc: nouveau, dri-devel, Mikko Perttunen, Maíra Canal,
Thierry Reding, Laurent Pinchart, Sumit Semwal, Mario Limonciello,
Shashank Sharma, Michal Simek, amd-gfx, Luben Tuikov, Ben Skeggs,
Stanley Yang, linux-media, Pengutronix Kernel Team, Sascha Hauer,
Maxime Ripard, linaro-mm-sig, linux-tegra, NXP Linux Team,
linux-arm-kernel, Hyun Kwon, Pan, Xinhui, linux-kernel,
Jerome Glisse, Alex Deucher, Gourav Samaiya, Shawn Guo,
Christian König, Hawking Zhang
On 8/24/23 14:07, Lee Jones wrote:
> On Thu, 24 Aug 2023, Jani Nikula wrote:
>> On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
>>> This set is part of a larger effort attempting to clean-up W=1
>>> kernel builds, which are currently overwhelmingly riddled with
>>> niggly little warnings.
>>
>> The next question is, how do we keep it W=1 clean going forward?
>
> My plan was to fix them all, then move each warning to W=0.
>
> Arnd recently submitted a set doing just that for a bunch of them.
>
> https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
>
> I like to think a bunch of this is built on top of my previous efforts.
>
> GPU is a particularly tricky though - the warnings seem to come in faster
> than I can squash them. Maybe the maintainers can find a way to test
> new patches on merge?
One approach for this which has proved effective in Mesa and other projects is to make warnings fatal in CI which must pass for any changes to be merged. There is ongoing work toward introducing this for the DRM subsystem, using gitlab.freedesktop.org CI.
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and Xwayland developer
^ permalink raw reply [flat|nested] 159+ messages in thread
* Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
@ 2023-08-28 16:11 ` Michel Dänzer
0 siblings, 0 replies; 159+ messages in thread
From: Michel Dänzer @ 2023-08-28 16:11 UTC (permalink / raw)
To: Lee Jones, Jani Nikula
Cc: Karol Herbst, nouveau, dri-devel, Mikko Perttunen,
Maíra Canal, Thierry Reding, Laurent Pinchart, Sumit Semwal,
Shashank Sharma, Michal Simek, amd-gfx, Jonathan Hunter,
Luben Tuikov, Danilo Krummrich, Ben Skeggs, Stanley Yang,
linux-media, Thomas Zimmermann, Sascha Hauer, Maxime Ripard,
linaro-mm-sig, linux-tegra, NXP Linux Team, linux-arm-kernel,
Hyun Kwon, Pan, Xinhui, linux-kernel, Hawking Zhang,
Jerome Glisse, Pengutronix Kernel Team, Alex Deucher,
Gourav Samaiya, Shawn Guo, Christian König,
Mario Limonciello
On 8/24/23 14:07, Lee Jones wrote:
> On Thu, 24 Aug 2023, Jani Nikula wrote:
>> On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
>>> This set is part of a larger effort attempting to clean-up W=1
>>> kernel builds, which are currently overwhelmingly riddled with
>>> niggly little warnings.
>>
>> The next question is, how do we keep it W=1 clean going forward?
>
> My plan was to fix them all, then move each warning to W=0.
>
> Arnd recently submitted a set doing just that for a bunch of them.
>
> https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
>
> I like to think a bunch of this is built on top of my previous efforts.
>
> GPU is a particularly tricky though - the warnings seem to come in faster
> than I can squash them. Maybe the maintainers can find a way to test
> new patches on merge?
One approach for this which has proved effective in Mesa and other projects is to make warnings fatal in CI which must pass for any changes to be merged. There is ongoing work toward introducing this for the DRM subsystem, using gitlab.freedesktop.org CI.
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and Xwayland developer
^ permalink raw reply [flat|nested] 159+ messages in thread