Re: [PATCH v7 01/13] dt-bindings: phy: Add zx297520v3 USB phy documentation

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The example uses an undocumented compatible string 'zte,zx297520v3-topcrm', which will break `make dt_binding_check` for this commit.
--

--- Patch [1]: [PATCH v7 01/13] dt-bindings: phy: Add zx297520v3 USB phy documentation ---
commit 4c69b2717ebf9691d299b4744633e7788d392913
Author: Stefan Dösinger <stefandoesinger@gmail.com>

dt-bindings: phy: Add zx297520v3 USB phy documentation

This commit adds device tree binding documentation for the ZTE zx297520v3 USB
and HSIC PHY. It defines the required properties for the PHY, which acts as
a child node to the topcrm controller.

> diff --git a/Documentation/devicetree/bindings/phy/zte,zx297520v3-usb-phy.yaml b/Documentation/devicetree/bindings/phy/zte,zx297520v3-usb-phy.yaml
> new file mode 100644
> index 0000000000000..8bad9365d5cc0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/zte,zx297520v3-usb-phy.yaml
[ ... ]
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/phy/phy-zte-zx297520v3-usb.h>
> +
> +    topcrm: clock-controller {
> +        compatible = "zte,zx297520v3-topcrm", "syscon";

[Severity: Low]
Will this undocumented compatible string cause a regression in
`make dt_binding_check` during bisection?

Since the "zte,zx297520v3-topcrm" binding is added in the next patch, evaluating
this commit on its own will result in validation failures because the string is
not documented in any schema and is not an allowed fallback in syscon.yaml.

Additionally, does the example node need a "reg" property since it includes
"syscon" in the compatible string? syscon.yaml requires it, which may lead to
further validation errors.

> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        #reset-cells = <1>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717-zx29clk-v7-0-408411cfcf36@gmail.com?part=1

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy