All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Carstens <hca@linux.ibm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: vladimir.murzin@arm.com, peterz@infradead.org, maz@kernel.org,
	ruanjinjie@huawei.com, linux-kernel@vger.kernel.org,
	yang@os.amperecomputing.com, catalin.marinas@arm.com,
	will@kernel.org, ardb@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 06/13] arm64: percpu: Add infrastructure for preemptible this_cpu_*() ops
Date: Wed, 29 Jul 2026 10:16:42 +0200	[thread overview]
Message-ID: <20260729081642.17504Be5-hca@linux.ibm.com> (raw)
In-Reply-To: <20260728165129.114152B00-hca@linux.ibm.com>

On Tue, Jul 28, 2026 at 06:51:29PM +0200, Heiko Carstens wrote:
> > If an exception is taken from within the critical section, the exception
> > return code will adjust <off> to be the current CPU's offset, and will
> > adjust <addr> to be (<pcp> + <off>). Distinct registers are used for
> > <pcp>, <off>, and <addr>, so that the fixup can be applied safely at any
> > point during the critical section.
> 
> This looks indeed better than that what I came up with for s390.
> 
> It works without comparing instruction pointers, also works out-of-the-box
> with kprobes, and hence the fixup is much simpler. I guess I'll try to change
> s390 to a similar mechanism and see what the result will look like. It will
> use one more instruction to the current version, as far as I can tell now, but
> the simplicity is probably worth it.

Hm.. unfortunately the required instructions (like an add that adds two
registers and puts the result in a third register), are not available on all
supported architecture levels on s390. But there are also other short comings
with the available instructions - so I don't think your approach will fly on
s390. Too bad.


WARNING: multiple messages have this Message-ID (diff)
From: Heiko Carstens <hca@linux.ibm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, ada.coupriediaz@arm.com,
	ardb@kernel.org, catalin.marinas@arm.com,
	linux-kernel@vger.kernel.org, maz@kernel.org,
	peterz@infradead.org, ruanjinjie@huawei.com,
	vladimir.murzin@arm.com, will@kernel.org,
	yang@os.amperecomputing.com
Subject: Re: [RFC PATCH 06/13] arm64: percpu: Add infrastructure for preemptible this_cpu_*() ops
Date: Wed, 29 Jul 2026 10:16:42 +0200	[thread overview]
Message-ID: <20260729081642.17504Be5-hca@linux.ibm.com> (raw)
In-Reply-To: <20260728165129.114152B00-hca@linux.ibm.com>

On Tue, Jul 28, 2026 at 06:51:29PM +0200, Heiko Carstens wrote:
> > If an exception is taken from within the critical section, the exception
> > return code will adjust <off> to be the current CPU's offset, and will
> > adjust <addr> to be (<pcp> + <off>). Distinct registers are used for
> > <pcp>, <off>, and <addr>, so that the fixup can be applied safely at any
> > point during the critical section.
> 
> This looks indeed better than that what I came up with for s390.
> 
> It works without comparing instruction pointers, also works out-of-the-box
> with kprobes, and hence the fixup is much simpler. I guess I'll try to change
> s390 to a similar mechanism and see what the result will look like. It will
> use one more instruction to the current version, as far as I can tell now, but
> the simplicity is probably worth it.

Hm.. unfortunately the required instructions (like an add that adds two
registers and puts the result in a third register), are not available on all
supported architecture levels on s390. But there are also other short comings
with the available instructions - so I don't think your approach will fly on
s390. Too bad.

  reply	other threads:[~2026-07-29  8:17 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28 12:38 [RFC PATCH 00/13] arm64: Preemptible this_cpu_*() operations Mark Rutland
2026-07-28 12:38 ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 01/13] arm64: preempt: Simplify and optimize __preempt_count_dec_and_test() Mark Rutland
2026-07-28 12:38   ` Mark Rutland
2026-07-29  3:56   ` Jinjie Ruan
2026-07-29  3:56     ` Jinjie Ruan
2026-07-28 12:38 ` [RFC PATCH 02/13] arm64: preempt: Treat should_resched() as unlikely Mark Rutland
2026-07-28 12:38   ` Mark Rutland
2026-07-29  4:00   ` Jinjie Ruan
2026-07-29  4:00     ` Jinjie Ruan
2026-07-28 12:38 ` [RFC PATCH 03/13] arm64: ptrace: Always inline pt_regs_[read,write}_reg() Mark Rutland
2026-07-28 12:38   ` Mark Rutland
2026-07-29  4:02   ` Jinjie Ruan
2026-07-29  4:02     ` Jinjie Ruan
2026-07-28 12:38 ` [RFC PATCH 04/13] arm64: percpu: Factor out percpu offset asm Mark Rutland
2026-07-28 12:38   ` Mark Rutland
2026-07-29  4:03   ` Jinjie Ruan
2026-07-29  4:03     ` Jinjie Ruan
2026-07-28 12:38 ` [RFC PATCH 05/13] arm64: gpr-num: Add wxN aliases for wN registers Mark Rutland
2026-07-28 12:38   ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 06/13] arm64: percpu: Add infrastructure for preemptible this_cpu_*() ops Mark Rutland
2026-07-28 12:38   ` Mark Rutland
2026-07-28 14:19   ` Peter Zijlstra
2026-07-28 14:19     ` Peter Zijlstra
2026-07-28 14:30     ` Peter Zijlstra
2026-07-28 14:30       ` Peter Zijlstra
2026-07-28 16:03       ` Mark Rutland
2026-07-28 16:03         ` Mark Rutland
2026-07-28 16:49         ` Peter Zijlstra
2026-07-28 16:49           ` Peter Zijlstra
2026-07-28 15:53     ` Mark Rutland
2026-07-28 15:53       ` Mark Rutland
2026-07-28 16:46       ` Peter Zijlstra
2026-07-28 16:46         ` Peter Zijlstra
2026-07-28 16:49       ` Peter Zijlstra
2026-07-28 16:49         ` Peter Zijlstra
2026-07-28 16:51   ` Heiko Carstens
2026-07-28 16:51     ` Heiko Carstens
2026-07-29  8:16     ` Heiko Carstens [this message]
2026-07-29  8:16       ` Heiko Carstens
2026-07-29 14:25   ` Vladimir Murzin
2026-07-29 14:25     ` Vladimir Murzin
2026-07-28 12:38 ` [RFC PATCH 07/13] arm64: percpu: Implement preemptible read/write ops Mark Rutland
2026-07-28 12:38   ` Mark Rutland
2026-07-28 21:47   ` David Laight
2026-07-28 21:47     ` David Laight
2026-07-28 22:05   ` David Laight
2026-07-28 22:05     ` David Laight
2026-07-28 12:38 ` [RFC PATCH 08/13] arm64: percpu: Implement preemptible void RMW ops Mark Rutland
2026-07-28 12:38   ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 09/13] arm64: percpu: Implement preemptible return " Mark Rutland
2026-07-28 12:38   ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 10/13] arm64: percpu: Implement preemptible XCHG ops Mark Rutland
2026-07-28 12:38   ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 11/13] arm64: percpu: Implement preemptible CMPXCHG ops Mark Rutland
2026-07-28 12:38   ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 12/13] arm64: percpu: Implement preemptible CMPXCHG128 ops Mark Rutland
2026-07-28 12:38   ` Mark Rutland
2026-07-28 12:38 ` [RFC PATCH 13/13] arm64: percpu: Remove _pcp_protect*() wrappers Mark Rutland
2026-07-28 12:38   ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260729081642.17504Be5-hca@linux.ibm.com \
    --to=hca@linux.ibm.com \
    --cc=ardb@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=peterz@infradead.org \
    --cc=ruanjinjie@huawei.com \
    --cc=vladimir.murzin@arm.com \
    --cc=will@kernel.org \
    --cc=yang@os.amperecomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.