All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	stable@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>,
	Sachin Saxena <sachin.saxena@nxp.com>
Subject: [PATCH 1/4] common/dpaax: fix unused variable warning in non-debug build
Date: Wed, 26 Aug 2026 16:43:01 -0700	[thread overview]
Message-ID: <20260826235933.194681-2-stephen@networkplumber.org> (raw)
In-Reply-To: <20260826235933.194681-1-stephen@networkplumber.org>

Fix compiler warning on clang-23.

  dpaa_of.c:14:12: warning: variable 'alive' set but not used
        [-Wunused-but-set-global]

The 'alive' flag is only read by DPAAX_HWWARN, which expands to an empty
statement and discards its condition unless RTE_LIBRTE_DPAAX_DEBUG is
defined. Make the empty expansion consume its argument so the condition
is still checked in a non-debug build.

Fixes: 8c83f28cc8a4 ("common/dpaax: move OF library from DPAA bus")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/common/dpaax/dpaax_logs.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/common/dpaax/dpaax_logs.h b/drivers/common/dpaax/dpaax_logs.h
index 90f0c98863..431a16f45a 100644
--- a/drivers/common/dpaax/dpaax_logs.h
+++ b/drivers/common/dpaax/dpaax_logs.h
@@ -5,6 +5,7 @@
 #ifndef _DPAAX_LOGS_H_
 #define _DPAAX_LOGS_H_
 
+#include <rte_common.h>
 #include <rte_log.h>
 
 extern int dpaax_logger;
@@ -17,7 +18,7 @@ extern int dpaax_logger;
 			DPAAX_LOG(DEBUG, "WARN: " fmt, ##__VA_ARGS__); \
 	} while (0)
 #else
-#define DPAAX_HWWARN(cond, fmt, ...) do { } while (0)
+#define DPAAX_HWWARN(cond, fmt, ...) do { RTE_SET_USED(cond); } while (0)
 #endif
 
 #define DPAAX_LOG(level, ...) \
-- 
2.53.0


  reply	other threads:[~2026-08-26 23:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 23:43 [PATCH 0/4] fix unused-but-set-global warnings Stephen Hemminger
2026-08-26 23:43 ` Stephen Hemminger [this message]
2026-08-27  9:07   ` [PATCH 1/4] common/dpaax: fix unused variable warning in non-debug build David Marchand
2026-08-27 14:57     ` Stephen Hemminger
2026-08-27 15:55       ` Hemant Agrawal
2026-08-26 23:43 ` [PATCH 2/4] bus/dpaa: remove unused qman_clk variable Stephen Hemminger
2026-08-27 15:57   ` Hemant Agrawal
2026-08-26 23:43 ` [PATCH 3/4] common/zsda: remove unused device counter Stephen Hemminger
2026-08-26 23:43 ` [PATCH 4/4] net/qede: remove unused app version variable Stephen Hemminger
2026-08-27  9:08   ` David Marchand
2026-08-27 14:59     ` Stephen Hemminger
2026-08-29 15:44 ` [PATCH v2 0/4] fix clang 23 unused but set warnings Stephen Hemminger
2026-08-29 15:44   ` [PATCH v2 1/4] common/dpaax: fix unused variable warning in non-debug build Stephen Hemminger
2026-08-29 15:44   ` [PATCH v2 2/4] bus/dpaa: remove unused qman_clk variable Stephen Hemminger
2026-08-29 15:44   ` [PATCH v2 3/4] common/zsda: remove unused device counter Stephen Hemminger
2026-08-29 15:44   ` [PATCH v2 4/4] net/qede: remove unused app version variable Stephen Hemminger
2026-08-31  8:27   ` [PATCH v2 0/4] fix clang 23 unused but set warnings David Marchand
2026-09-03 18:58   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260826235933.194681-2-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=sachin.saxena@nxp.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.