From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Subject: Re: [PATCH v2 0/4] fix clang 23 unused but set warnings
Date: Thu, 3 Sep 2026 11:58:35 -0700 [thread overview]
Message-ID: <20260903115826.15b675e5@phoenix.local> (raw)
In-Reply-To: <20260829154706.52169-1-stephen@networkplumber.org>
On Sat, 29 Aug 2026 08:44:44 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> Clang 23 adds -Wunused-but-set-global, which reports file scope
> variables that are assigned but never read. It is enabled by -Wall and
> does not appear with gcc or with clang 20 through 22.
>
> Three of these are dead variables and are simply removed. The fourth,
> 'alive' in dpaa_of.c, is a real debug aid: it is only read by
> DPAAX_HWWARN, which discards its condition when RTE_LIBRTE_DPAAX_DEBUG
> is not defined. That one is fixed by making the empty expansion consume
> its argument, which keeps the condition compiled in both builds and
> covers every other DPAAX_HWWARN user as well.
>
> v2 - remove more unused code as suggested.
>
> Stephen Hemminger (4):
> common/dpaax: fix unused variable warning in non-debug build
> bus/dpaa: remove unused qman_clk variable
> common/zsda: remove unused device counter
> net/qede: remove unused app version variable
>
> drivers/bus/dpaa/base/qbman/qman_driver.c | 4 ----
> drivers/common/dpaax/dpaax_logs.h | 3 ++-
> drivers/common/zsda/zsda_device.c | 5 -----
> drivers/net/qede/qede_debug.c | 20 --------------------
> 4 files changed, 2 insertions(+), 30 deletions(-)
>
Applied to next-net; so that clang 23 build tests can run across all drivers
prev parent reply other threads:[~2026-09-03 18:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 23:43 [PATCH 0/4] fix unused-but-set-global warnings Stephen Hemminger
2026-08-26 23:43 ` [PATCH 1/4] common/dpaax: fix unused variable warning in non-debug build Stephen Hemminger
2026-08-27 9:07 ` David Marchand
2026-08-27 14:57 ` Stephen Hemminger
2026-08-27 15:55 ` Hemant Agrawal
2026-08-26 23:43 ` [PATCH 2/4] bus/dpaa: remove unused qman_clk variable Stephen Hemminger
2026-08-27 15:57 ` Hemant Agrawal
2026-08-26 23:43 ` [PATCH 3/4] common/zsda: remove unused device counter Stephen Hemminger
2026-08-26 23:43 ` [PATCH 4/4] net/qede: remove unused app version variable Stephen Hemminger
2026-08-27 9:08 ` David Marchand
2026-08-27 14:59 ` Stephen Hemminger
2026-08-29 15:44 ` [PATCH v2 0/4] fix clang 23 unused but set warnings Stephen Hemminger
2026-08-29 15:44 ` [PATCH v2 1/4] common/dpaax: fix unused variable warning in non-debug build Stephen Hemminger
2026-08-29 15:44 ` [PATCH v2 2/4] bus/dpaa: remove unused qman_clk variable Stephen Hemminger
2026-08-29 15:44 ` [PATCH v2 3/4] common/zsda: remove unused device counter Stephen Hemminger
2026-08-29 15:44 ` [PATCH v2 4/4] net/qede: remove unused app version variable Stephen Hemminger
2026-08-31 8:27 ` [PATCH v2 0/4] fix clang 23 unused but set warnings David Marchand
2026-09-03 18:58 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903115826.15b675e5@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.