From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>, stable@dpdk.org
Subject: [PATCH v2 3/4] common/zsda: remove unused device counter
Date: Sat, 29 Aug 2026 08:44:47 -0700 [thread overview]
Message-ID: <20260829154706.52169-4-stephen@networkplumber.org> (raw)
In-Reply-To: <20260829154706.52169-1-stephen@networkplumber.org>
zsda_nb_pci_devices is incremented when a PCI device is allocated and
decremented when it is released, but the count is never read.
clang 23 reports:
zsda_device.c:10:12: warning: variable 'zsda_nb_pci_devices' set but
not used [-Wunused-but-set-global]
Remove the counter and the three sites that update it.
Fixes: 6592da5893d3 ("common/zsda: add base driver")
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
The CI AI review of this patch was hallucinating and
fabricated functions that don't exist.
drivers/common/zsda/zsda_device.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/common/zsda/zsda_device.c b/drivers/common/zsda/zsda_device.c
index 72f017c699..280a51f9b3 100644
--- a/drivers/common/zsda/zsda_device.c
+++ b/drivers/common/zsda/zsda_device.c
@@ -7,7 +7,6 @@
/* per-process array of device data */
struct zsda_device_info zsda_devs[RTE_PMD_ZSDA_MAX_PCI_DEVICES];
-static int zsda_nb_pci_devices;
/*
* The set of PCI devices this driver supports
@@ -85,7 +84,6 @@ zsda_pci_device_allocate(struct rte_pci_device *pci_dev)
zsda_pci_dev = mz->addr;
zsda_devs[zsda_pci_dev->zsda_dev_id].mz = mz;
zsda_devs[zsda_pci_dev->zsda_dev_id].pci_dev = pci_dev;
- zsda_nb_pci_devices++;
return zsda_pci_dev;
}
@@ -114,8 +112,6 @@ zsda_pci_device_allocate(struct rte_pci_device *pci_dev)
zsda_pci_dev->pci_dev = pci_dev;
zsda_devs[zsda_dev_id].pci_dev = pci_dev;
- zsda_nb_pci_devices++;
-
return zsda_pci_dev;
}
@@ -141,7 +137,6 @@ zsda_pci_device_release(const struct rte_pci_device *pci_dev)
rte_memzone_free(inst->mz);
memset(inst, 0, sizeof(struct zsda_device_info));
- zsda_nb_pci_devices--;
}
return 0;
}
--
2.53.0
next prev parent reply other threads:[~2026-08-29 15:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 23:43 [PATCH 0/4] fix unused-but-set-global warnings Stephen Hemminger
2026-08-26 23:43 ` [PATCH 1/4] common/dpaax: fix unused variable warning in non-debug build Stephen Hemminger
2026-08-27 9:07 ` David Marchand
2026-08-27 14:57 ` Stephen Hemminger
2026-08-27 15:55 ` Hemant Agrawal
2026-08-26 23:43 ` [PATCH 2/4] bus/dpaa: remove unused qman_clk variable Stephen Hemminger
2026-08-27 15:57 ` Hemant Agrawal
2026-08-26 23:43 ` [PATCH 3/4] common/zsda: remove unused device counter Stephen Hemminger
2026-08-26 23:43 ` [PATCH 4/4] net/qede: remove unused app version variable Stephen Hemminger
2026-08-27 9:08 ` David Marchand
2026-08-27 14:59 ` Stephen Hemminger
2026-08-29 15:44 ` [PATCH v2 0/4] fix clang 23 unused but set warnings Stephen Hemminger
2026-08-29 15:44 ` [PATCH v2 1/4] common/dpaax: fix unused variable warning in non-debug build Stephen Hemminger
2026-08-29 15:44 ` [PATCH v2 2/4] bus/dpaa: remove unused qman_clk variable Stephen Hemminger
2026-08-29 15:44 ` Stephen Hemminger [this message]
2026-08-29 15:44 ` [PATCH v2 4/4] net/qede: remove unused app version variable Stephen Hemminger
2026-08-31 8:27 ` [PATCH v2 0/4] fix clang 23 unused but set warnings David Marchand
2026-09-03 18:58 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260829154706.52169-4-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.