All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	stable@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>,
	Sachin Saxena <sachin.saxena@nxp.com>,
	Geoff Thorpe <geoff.thorpe@nxp.com>,
	Shreyansh Jain <shreyansh.jain@nxp.com>,
	Roy Pledge <roy.pledge@nxp.com>
Subject: [PATCH 2/4] bus/dpaa: remove unused qman_clk variable
Date: Wed, 26 Aug 2026 16:43:02 -0700	[thread overview]
Message-ID: <20260826235933.194681-3-stephen@networkplumber.org> (raw)
In-Reply-To: <20260826235933.194681-1-stephen@networkplumber.org>

The driver was recording the clock frequency and never using it.

clang 23 reports:

  qman_driver.c:27:12: warning: variable 'qman_clk' set but not used
        [-Wunused-but-set-global]

Remove the variable and the dead store.

Fixes: f6fadc3e6310 ("bus/dpaa: add QMAN interface driver")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/bus/dpaa/base/qbman/qman_driver.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/bus/dpaa/base/qbman/qman_driver.c b/drivers/bus/dpaa/base/qbman/qman_driver.c
index 45b094e0c6..bbe2640c52 100644
--- a/drivers/bus/dpaa/base/qbman/qman_driver.c
+++ b/drivers/bus/dpaa/base/qbman/qman_driver.c
@@ -23,8 +23,6 @@ u16 qm_channel_pme = QMAN_CHANNEL_PME;
 
 /* Ccsr map address to access ccsrbased register */
 static void *qman_ccsr_map;
-/* The qman clock frequency */
-static u32 qman_clk;
 
 static __thread int qmfd = -1;
 static __thread struct qm_portal_config qpcfg;
@@ -371,8 +369,6 @@ int qman_global_init(void)
 	clk = of_get_property(dt_node, "clock-frequency", NULL);
 	if (!clk)
 		pr_warn("Can't find Qman clock frequency\n");
-	else
-		qman_clk = be32_to_cpu(*clk);
 
 #ifdef CONFIG_FSL_QMAN_FQ_LOOKUP
 	return qman_setup_fq_lookup_table(CONFIG_FSL_QMAN_FQ_LOOKUP_MAX);
-- 
2.53.0


  parent reply	other threads:[~2026-08-27  0:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 23:43 [PATCH 0/4] fix unused-but-set-global warnings Stephen Hemminger
2026-08-26 23:43 ` [PATCH 1/4] common/dpaax: fix unused variable warning in non-debug build Stephen Hemminger
2026-08-27  9:07   ` David Marchand
2026-08-27 14:57     ` Stephen Hemminger
2026-08-27 15:55       ` Hemant Agrawal
2026-08-26 23:43 ` Stephen Hemminger [this message]
2026-08-27 15:57   ` [PATCH 2/4] bus/dpaa: remove unused qman_clk variable Hemant Agrawal
2026-08-26 23:43 ` [PATCH 3/4] common/zsda: remove unused device counter Stephen Hemminger
2026-08-26 23:43 ` [PATCH 4/4] net/qede: remove unused app version variable Stephen Hemminger
2026-08-27  9:08   ` David Marchand
2026-08-27 14:59     ` Stephen Hemminger
2026-08-29 15:44 ` [PATCH v2 0/4] fix clang 23 unused but set warnings Stephen Hemminger
2026-08-29 15:44   ` [PATCH v2 1/4] common/dpaax: fix unused variable warning in non-debug build Stephen Hemminger
2026-08-29 15:44   ` [PATCH v2 2/4] bus/dpaa: remove unused qman_clk variable Stephen Hemminger
2026-08-29 15:44   ` [PATCH v2 3/4] common/zsda: remove unused device counter Stephen Hemminger
2026-08-29 15:44   ` [PATCH v2 4/4] net/qede: remove unused app version variable Stephen Hemminger
2026-08-31  8:27   ` [PATCH v2 0/4] fix clang 23 unused but set warnings David Marchand
2026-09-03 18:58   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260826235933.194681-3-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=geoff.thorpe@nxp.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=roy.pledge@nxp.com \
    --cc=sachin.saxena@nxp.com \
    --cc=shreyansh.jain@nxp.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.