From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Devendra Singh Rawat <dsinghrawat@marvell.com>,
Alok Prasad <palok@marvell.com>, Rasesh Mody <rmody@marvell.com>,
Igor Russkikh <irusskikh@marvell.com>
Subject: Re: [PATCH 4/4] net/qede: remove unused app version variable
Date: Thu, 27 Aug 2026 07:59:40 -0700 [thread overview]
Message-ID: <20260827075940.5bafd493@phoenix.local> (raw)
In-Reply-To: <CAJFAV8xy6SKarAo6Vx3VA4Cnv5c3o=crOzvH3_u64XLH8GW7HQ@mail.gmail.com>
On Thu, 27 Aug 2026 11:08:07 +0200
David Marchand <david.marchand@redhat.com> wrote:
> On Thu, 27 Aug 2026 at 02:00, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > qed_dbg_set_app_ver() validates the caller's version and stores it.
> > But the variable s_app_ver is never used in DPDK driver.
> >
> > clang 23 reports:
> >
> > qede_debug.c:820:12: warning: variable 's_app_ver' set but not used
> > [-Wunused-but-set-global]
> >
> > Remove the variable and the dead store.
>
> Maybe go one step further?
> qed_dbg_set_app_ver() looks useless.
Yes it is useless code. Looks like inherited from Linux driver.
next prev parent reply other threads:[~2026-08-27 14:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 23:43 [PATCH 0/4] fix unused-but-set-global warnings Stephen Hemminger
2026-08-26 23:43 ` [PATCH 1/4] common/dpaax: fix unused variable warning in non-debug build Stephen Hemminger
2026-08-27 9:07 ` David Marchand
2026-08-27 14:57 ` Stephen Hemminger
2026-08-27 15:55 ` Hemant Agrawal
2026-08-26 23:43 ` [PATCH 2/4] bus/dpaa: remove unused qman_clk variable Stephen Hemminger
2026-08-27 15:57 ` Hemant Agrawal
2026-08-26 23:43 ` [PATCH 3/4] common/zsda: remove unused device counter Stephen Hemminger
2026-08-26 23:43 ` [PATCH 4/4] net/qede: remove unused app version variable Stephen Hemminger
2026-08-27 9:08 ` David Marchand
2026-08-27 14:59 ` Stephen Hemminger [this message]
2026-08-29 15:44 ` [PATCH v2 0/4] fix clang 23 unused but set warnings Stephen Hemminger
2026-08-29 15:44 ` [PATCH v2 1/4] common/dpaax: fix unused variable warning in non-debug build Stephen Hemminger
2026-08-29 15:44 ` [PATCH v2 2/4] bus/dpaa: remove unused qman_clk variable Stephen Hemminger
2026-08-29 15:44 ` [PATCH v2 3/4] common/zsda: remove unused device counter Stephen Hemminger
2026-08-29 15:44 ` [PATCH v2 4/4] net/qede: remove unused app version variable Stephen Hemminger
2026-08-31 8:27 ` [PATCH v2 0/4] fix clang 23 unused but set warnings David Marchand
2026-09-03 18:58 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827075940.5bafd493@phoenix.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=irusskikh@marvell.com \
--cc=palok@marvell.com \
--cc=rmody@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.