Re: [PATCH v8 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 4175 bytes --]

On Mon, Aug 31, 2026 at 04:32:04PM +0800, Zhentao Guo via B4 Relay wrote:
> From: Zhentao Guo <zhentao.guo@amlogic.com>
> 
> Describe the initial support for the V4L2 stateless video decoder
> driver used with the Amlogic S4 (S805X2) platform.
> 
> Signed-off-by: Zhentao Guo <zhentao.guo@amlogic.com>
> ---
>  .../devicetree/bindings/media/amlogic,s4-vdec.yaml | 106 +++++++++++++++++++++
>  1 file changed, 106 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml
> new file mode 100644
> index 000000000000..a93a2140801b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml
> @@ -0,0 +1,106 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2025 Amlogic, Inc. All rights reserved
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/amlogic,s4-vdec.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amlogic Video Decode Accelerator
> +
> +maintainers:
> +  - Zhentao Guo <zhentao.guo@amlogic.com>
> +
> +description:
> +  The Video Decoder Accelerator present on Amlogic SOCs.
> +  It supports stateless h264 decoding.
> +
> +properties:
> +  compatible:
> +    const: amlogic,s4-vdec
> +
> +  reg:
> +    maxItems: 2
> +
> +  reg-names:
> +    items:
> +      - const: dos
> +      - const: dmc
> +

> +  interrupts:
> +    maxItems: 2

What are these interrupts? All other properties convey the info via
mandatory -names, but interrupts don't.

I don't love the lack of items lists on !-names properties, but not a
big deal to not have them I don't think.

On account of the interrupts:
pw-bot: changes-requested

Cheers,
Conor.


> +
> +  clocks:
> +    maxItems: 3
> +
> +  clock-names:
> +    items:
> +      - const: dos
> +      - const: core_vdec
> +      - const: core_hvdec
> +
> +  power-domains:
> +    maxItems: 2
> +
> +  power-domain-names:
> +    items:
> +      - const: dos_vdec
> +      - const: dos_hvdec
> +
> +  resets:
> +    maxItems: 1
> +
> +  amlogic,canvas:
> +    description: Canvas maintains an index-to-physical-address
> +     mapping table that allows the 16-bit AMRISC decoder core
> +     to access 32-bit or 64-bit physical address.
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +
> +  amlogic,secure-monitor:
> +    description: Used to decrypt and load the signed decoder
> +     firmware through ARM SMC (Secure Monitor Call).
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +
> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +  - interrupts
> +  - clocks
> +  - clock-names
> +  - power-domains
> +  - power-domain-names
> +  - resets
> +  - amlogic,canvas
> +  - amlogic,secure-monitor
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/clock/amlogic,s4-pll-clkc.h>
> +    #include <dt-bindings/clock/amlogic,s4-peripherals-clkc.h>
> +    #include <dt-bindings/power/meson-s4-power.h>
> +    #include <dt-bindings/reset/amlogic,meson-s4-reset.h>
> +    video-codec@fe320000 {
> +      compatible = "amlogic,s4-vdec";
> +      reg = <0xfe320000 0x10000>,
> +            <0xfe036000 0x20>;
> +      reg-names = "dos",
> +                  "dmc";
> +      interrupts = <GIC_SPI 91 IRQ_TYPE_EDGE_RISING>,
> +                   <GIC_SPI 92 IRQ_TYPE_EDGE_RISING>;
> +      clocks = <&clkc_periphs CLKID_DOS>,
> +               <&clkc_periphs CLKID_VDEC_SEL>,
> +               <&clkc_periphs CLKID_HEVCF_SEL>;
> +      clock-names = "dos",
> +                    "core_vdec",
> +                    "core_hvdec";
> +      power-domains = <&pwrc PWRC_S4_DOS_VDEC_ID>,
> +                      <&pwrc PWRC_S4_DOS_HEVC_ID>;
> +      power-domain-names = "dos_vdec",
> +                           "dos_hvdec";
> +      resets = <&reset RESET_DOS>;
> +      amlogic,canvas = <&canvas>;
> +      amlogic,secure-monitor = <&sm>;
> +    };
> 
> -- 
> 2.42.0
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]