All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Zhentao Guo" <zhentao.guo@amlogic.com>
Cc: media-ci@linuxtv.org, neil.armstrong@linaro.org,
	linux-amlogic@lists.infradead.org, conor+dt@kernel.org,
	robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v8 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder
Date: Mon, 31 Aug 2026 08:42:44 +0000	[thread overview]
Message-ID: <20260831084245.7960A1F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260831-b4-s4-vdec-upstream-v8-3-830195b9bd91@amlogic.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The binding specifies up to 2 interrupts but lacks an 'items' list with descriptions or an 'interrupt-names' property to identify them.
--

commit 96c8a7f3d12fa5059564a56fdedd6a77c76d68cb
Author: Zhentao Guo <zhentao.guo@amlogic.com>

media: dt-bindings: Add Amlogic V4L2 video decoder

Describe the initial support for the V4L2 stateless video decoder driver used
with the Amlogic S4 (S805X2) platform.

> diff --git a/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml
> new file mode 100644
> index 0000000000000..a93a2140801b9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml
[ ... ]
> +  reg-names:
> +    items:
> +      - const: dos
> +      - const: dmc
> +
> +  interrupts:
> +    maxItems: 2

[Severity: Low]
Does this properties.interrupts binding allow up to 2 interrupts without
providing an 'items' list with descriptions or an 'interrupt-names' property to
identify them?

Since the driver uses platform_get_irq(pdev, IRQ_VDEC) (where IRQ_VDEC is 1),
it relies strictly on the index order. Could this make the bindings harder to
use correctly and lead to broken interrupts if a device tree author guesses the
wrong order when constructing a new board?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-b4-s4-vdec-upstream-v8-0-830195b9bd91@amlogic.com?part=3

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Zhentao Guo" <zhentao.guo@amlogic.com>
Cc: media-ci@linuxtv.org, neil.armstrong@linaro.org,
	linux-amlogic@lists.infradead.org, conor+dt@kernel.org,
	robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v8 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder
Date: Mon, 31 Aug 2026 08:42:44 +0000	[thread overview]
Message-ID: <20260831084245.7960A1F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260831-b4-s4-vdec-upstream-v8-3-830195b9bd91@amlogic.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The binding specifies up to 2 interrupts but lacks an 'items' list with descriptions or an 'interrupt-names' property to identify them.
--

commit 96c8a7f3d12fa5059564a56fdedd6a77c76d68cb
Author: Zhentao Guo <zhentao.guo@amlogic.com>

media: dt-bindings: Add Amlogic V4L2 video decoder

Describe the initial support for the V4L2 stateless video decoder driver used
with the Amlogic S4 (S805X2) platform.

> diff --git a/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml
> new file mode 100644
> index 0000000000000..a93a2140801b9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml
[ ... ]
> +  reg-names:
> +    items:
> +      - const: dos
> +      - const: dmc
> +
> +  interrupts:
> +    maxItems: 2

[Severity: Low]
Does this properties.interrupts binding allow up to 2 interrupts without
providing an 'items' list with descriptions or an 'interrupt-names' property to
identify them?

Since the driver uses platform_get_irq(pdev, IRQ_VDEC) (where IRQ_VDEC is 1),
it relies strictly on the index order. Could this make the bindings harder to
use correctly and lead to broken interrupts if a device tree author guesses the
wrong order when constructing a new board?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-b4-s4-vdec-upstream-v8-0-830195b9bd91@amlogic.com?part=3

  reply	other threads:[~2026-08-31  8:42 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31  8:32 [PATCH v8 0/6] Add Amlogic stateless H.264 video decoder for S4 Zhentao Guo via B4 Relay
2026-08-31  8:32 ` Zhentao Guo
2026-08-31  8:32 ` Zhentao Guo via B4 Relay
2026-08-31  8:32 ` [PATCH v8 1/6] firmware: meson: sm: video firmware loading via secure monitor Zhentao Guo via B4 Relay
2026-08-31  8:32   ` Zhentao Guo
2026-08-31  8:32   ` Zhentao Guo via B4 Relay
2026-08-31  8:43   ` sashiko-bot
2026-08-31  8:43     ` sashiko-bot
2026-08-31  8:32 ` [PATCH v8 2/6] firmware: meson: sm: Add video firmware loading SMC call Zhentao Guo via B4 Relay
2026-08-31  8:32   ` Zhentao Guo
2026-08-31  8:32   ` Zhentao Guo via B4 Relay
2026-08-31  8:45   ` sashiko-bot
2026-08-31  8:45     ` sashiko-bot
2026-08-31  8:32 ` [PATCH v8 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder Zhentao Guo via B4 Relay
2026-08-31  8:32   ` Zhentao Guo
2026-08-31  8:32   ` Zhentao Guo via B4 Relay
2026-08-31  8:42   ` sashiko-bot [this message]
2026-08-31  8:42     ` sashiko-bot
2026-08-31 16:04   ` Conor Dooley
2026-08-31 16:04     ` Conor Dooley
2026-09-01  2:16     ` Zhentao Guo
2026-09-01  2:16       ` Zhentao Guo
2026-08-31  8:32 ` [PATCH v8 4/6] decoder: Add V4L2 stateless H.264 decoder driver Zhentao Guo via B4 Relay
2026-08-31  8:32   ` Zhentao Guo
2026-08-31  8:32   ` Zhentao Guo via B4 Relay
2026-08-31  8:56   ` sashiko-bot
2026-08-31  8:56     ` sashiko-bot
2026-08-31  8:32 ` [PATCH v8 5/6] arm64: dts: amlogic: Add video decoder driver support for S4 SOCs Zhentao Guo via B4 Relay
2026-08-31  8:32   ` Zhentao Guo
2026-08-31  8:32   ` Zhentao Guo via B4 Relay
2026-08-31  8:32 ` [PATCH v8 6/6] arm64: defconfig: Enable CONFIG_VIDEO_AMLOGIC_VDEC Zhentao Guo via B4 Relay
2026-08-31  8:32   ` Zhentao Guo
2026-08-31  8:32   ` Zhentao Guo via B4 Relay
2026-08-31  8:58   ` sashiko-bot
2026-08-31  8:58     ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260831084245.7960A1F00A3D@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=media-ci@linuxtv.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=zhentao.guo@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.