All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Zhentao Guo" <zhentao.guo@amlogic.com>
Cc: media-ci@linuxtv.org, linux-amlogic@lists.infradead.org,
	robh@kernel.org, neil.armstrong@linaro.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v8 6/6] arm64: defconfig: Enable CONFIG_VIDEO_AMLOGIC_VDEC
Date: Mon, 31 Aug 2026 08:58:47 +0000	[thread overview]
Message-ID: <20260831085848.29FC51F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260831-b4-s4-vdec-upstream-v8-6-830195b9bd91@amlogic.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new defconfig entry CONFIG_VIDEO_AMLOGIC_VDEC is not placed in the correct order as it would be generated by `make savedefconfig`.
--

commit c64b548261f0711290a36c1bf013f8ce20bd9e1e
Author: Zhentao Guo <zhentao.guo@amlogic.com>

arm64: defconfig: Enable CONFIG_VIDEO_AMLOGIC_VDEC

This commit enables the Amlogic V4L2 stateless video decoder driver as a
module in the arm64 defconfig to support the Amlogic S4 platform.

> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 6ec8d3a69c98e..7be4e5a284bab 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -919,6 +919,7 @@ CONFIG_V4L_PLATFORM_DRIVERS=y
>  CONFIG_SDR_PLATFORM_DRIVERS=y
>  CONFIG_V4L_MEM2MEM_DRIVERS=y
>  CONFIG_VIDEO_AMPHION_VPU=m
> +CONFIG_VIDEO_AMLOGIC_VDEC=m

[Severity: Low]
Is this config placed out of order? In kernel development, defconfig files
must be updated using make savedefconfig to ensure entries are sorted
according to Kconfig parsing order.

In drivers/media/platform/Kconfig, amlogic/Kconfig is sourced before
amphion/Kconfig. Therefore, CONFIG_VIDEO_AMLOGIC_VDEC should appear before
CONFIG_VIDEO_AMPHION_VPU.

Could this be updated via make savedefconfig to avoid deviating from the
strict Kconfig tree order and prevent unnecessary churn or merge conflicts
in the future?

>  CONFIG_VIDEO_CADENCE_CSI2RX=m
>  CONFIG_VIDEO_WAVE_VPU=m
>  CONFIG_VIDEO_E5010_JPEG_ENC=m

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-b4-s4-vdec-upstream-v8-0-830195b9bd91@amlogic.com?part=6

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Zhentao Guo" <zhentao.guo@amlogic.com>
Cc: media-ci@linuxtv.org, linux-amlogic@lists.infradead.org,
	robh@kernel.org, neil.armstrong@linaro.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v8 6/6] arm64: defconfig: Enable CONFIG_VIDEO_AMLOGIC_VDEC
Date: Mon, 31 Aug 2026 08:58:47 +0000	[thread overview]
Message-ID: <20260831085848.29FC51F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260831-b4-s4-vdec-upstream-v8-6-830195b9bd91@amlogic.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new defconfig entry CONFIG_VIDEO_AMLOGIC_VDEC is not placed in the correct order as it would be generated by `make savedefconfig`.
--

commit c64b548261f0711290a36c1bf013f8ce20bd9e1e
Author: Zhentao Guo <zhentao.guo@amlogic.com>

arm64: defconfig: Enable CONFIG_VIDEO_AMLOGIC_VDEC

This commit enables the Amlogic V4L2 stateless video decoder driver as a
module in the arm64 defconfig to support the Amlogic S4 platform.

> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 6ec8d3a69c98e..7be4e5a284bab 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -919,6 +919,7 @@ CONFIG_V4L_PLATFORM_DRIVERS=y
>  CONFIG_SDR_PLATFORM_DRIVERS=y
>  CONFIG_V4L_MEM2MEM_DRIVERS=y
>  CONFIG_VIDEO_AMPHION_VPU=m
> +CONFIG_VIDEO_AMLOGIC_VDEC=m

[Severity: Low]
Is this config placed out of order? In kernel development, defconfig files
must be updated using make savedefconfig to ensure entries are sorted
according to Kconfig parsing order.

In drivers/media/platform/Kconfig, amlogic/Kconfig is sourced before
amphion/Kconfig. Therefore, CONFIG_VIDEO_AMLOGIC_VDEC should appear before
CONFIG_VIDEO_AMPHION_VPU.

Could this be updated via make savedefconfig to avoid deviating from the
strict Kconfig tree order and prevent unnecessary churn or merge conflicts
in the future?

>  CONFIG_VIDEO_CADENCE_CSI2RX=m
>  CONFIG_VIDEO_WAVE_VPU=m
>  CONFIG_VIDEO_E5010_JPEG_ENC=m

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-b4-s4-vdec-upstream-v8-0-830195b9bd91@amlogic.com?part=6

  reply	other threads:[~2026-08-31  8:58 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31  8:32 [PATCH v8 0/6] Add Amlogic stateless H.264 video decoder for S4 Zhentao Guo via B4 Relay
2026-08-31  8:32 ` Zhentao Guo
2026-08-31  8:32 ` Zhentao Guo via B4 Relay
2026-08-31  8:32 ` [PATCH v8 1/6] firmware: meson: sm: video firmware loading via secure monitor Zhentao Guo via B4 Relay
2026-08-31  8:32   ` Zhentao Guo
2026-08-31  8:32   ` Zhentao Guo via B4 Relay
2026-08-31  8:43   ` sashiko-bot
2026-08-31  8:43     ` sashiko-bot
2026-08-31  8:32 ` [PATCH v8 2/6] firmware: meson: sm: Add video firmware loading SMC call Zhentao Guo via B4 Relay
2026-08-31  8:32   ` Zhentao Guo
2026-08-31  8:32   ` Zhentao Guo via B4 Relay
2026-08-31  8:45   ` sashiko-bot
2026-08-31  8:45     ` sashiko-bot
2026-08-31  8:32 ` [PATCH v8 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder Zhentao Guo via B4 Relay
2026-08-31  8:32   ` Zhentao Guo
2026-08-31  8:32   ` Zhentao Guo via B4 Relay
2026-08-31  8:42   ` sashiko-bot
2026-08-31  8:42     ` sashiko-bot
2026-08-31 16:04   ` Conor Dooley
2026-08-31 16:04     ` Conor Dooley
2026-09-01  2:16     ` Zhentao Guo
2026-09-01  2:16       ` Zhentao Guo
2026-08-31  8:32 ` [PATCH v8 4/6] decoder: Add V4L2 stateless H.264 decoder driver Zhentao Guo via B4 Relay
2026-08-31  8:32   ` Zhentao Guo
2026-08-31  8:32   ` Zhentao Guo via B4 Relay
2026-08-31  8:56   ` sashiko-bot
2026-08-31  8:56     ` sashiko-bot
2026-08-31  8:32 ` [PATCH v8 5/6] arm64: dts: amlogic: Add video decoder driver support for S4 SOCs Zhentao Guo via B4 Relay
2026-08-31  8:32   ` Zhentao Guo
2026-08-31  8:32   ` Zhentao Guo via B4 Relay
2026-08-31  8:32 ` [PATCH v8 6/6] arm64: defconfig: Enable CONFIG_VIDEO_AMLOGIC_VDEC Zhentao Guo via B4 Relay
2026-08-31  8:32   ` Zhentao Guo
2026-08-31  8:32   ` Zhentao Guo via B4 Relay
2026-08-31  8:58   ` sashiko-bot [this message]
2026-08-31  8:58     ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260831085848.29FC51F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=media-ci@linuxtv.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=zhentao.guo@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.