Re: [PATCH v6 8/9] drm/xe/sysctrl: Log group and command ID on mailbox failure

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing xe_log.h header and xe_log_err definition causes a compilation failure.
--

commit 2afdd4e6d2ae348d6cec426e07181e76137fd2f6
Author: Mallesh Koujalagi <mallesh.koujalagi@intel.com>

drm/xe/sysctrl: Log group and command ID on mailbox failure

This commit updates the error logging for mailbox command preparation and
execution failures to include the group ID and command code.

> diff --git a/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c b/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c
> index 87e6568202795..d5e391c045c60 100644
> --- a/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c
> +++ b/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c
> @@ -353,7 +353,8 @@ int xe_sysctrl_send_command(struct xe_sysctrl *sc,
>  				      cmd->data_in, cmd->data_in_len,
>  				      &mbox_cmd, &cmd_size);
>  	if (ret) {
> -		xe_err(xe, "sysctrl: Failed to prepare command: %pe\n", ERR_PTR(ret));
> +		xe_log_err(xe, SYSCTRL, ret, "Failed to prepare command %#x.%#x\n",
> +			   group_id, command_code);

[Severity: Low]
Does this cause a build failure? 

The xe_log_err macro and the SYSCTRL log category appear to be undeclared in
this file. Is it possible that a required include header is missing here, or
perhaps a prerequisite patch that defines these logging facilities was dropped
from the series?

>  		return ret;
>  	}
>  

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831104456.1770605-11-mallesh.koujalagi@intel.com?part=8