Re: [PATCH v6 9/9] drm/xe/sysctrl: Report 'System Controller event' error using SIGID

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch relies on a missing header file 'xe_log.h' and undefined logging macros and identifiers.
--

commit 6685ffdeb0695b8ea21292cfaa83d3bea319ad7d
Author: Mallesh Koujalagi <mallesh.koujalagi@intel.com>

drm/xe/sysctrl: Report 'System Controller event' error using SIGID

This commit updates the System Controller event logging to use xe_log helpers
instead of the standard xe_err or xe_warn macros.

> diff --git a/drivers/gpu/drm/xe/xe_sysctrl_event.c b/drivers/gpu/drm/xe/xe_sysctrl_event.c
> index da395148ee9dc..5804d3649569c 100644
> --- a/drivers/gpu/drm/xe/xe_sysctrl_event.c
> +++ b/drivers/gpu/drm/xe/xe_sysctrl_event.c
> @@ -5,6 +5,7 @@
>  
>  #include "xe_device.h"
>  #include "xe_irq.h"
> +#include "xe_log.h"

[Severity: Low]
Is this header missing from the patch series? The xe_log.h file does not
appear to exist in the tree, which results in an immediate build failure
when applying this patch.

>  #include "xe_printk.h"
>  #include "xe_ras.h"
>  #include "xe_sysctrl.h"

[ ... ]

> @@ -25,23 +26,26 @@ static void get_pending_event(struct xe_sysctrl *sc, struct xe_sysctrl_mailbox_c
>  
>  		ret = xe_sysctrl_send_command(sc, command, &len);
>  		if (ret) {
> -			xe_err(xe, "sysctrl: failed to get pending event %d\n", ret);
> +			xe_log_err(xe, SYSCTRL, ret, "Failed to get pending event\n");

[Severity: Low]
Are xe_log_err and SYSCTRL defined in the missing xe_log.h header? Without
those definitions, the get_pending_event() function fails to compile due to
undefined identifiers.

>  			return;
>  		}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831104456.1770605-11-mallesh.koujalagi@intel.com?part=9