Re: [PATCH v6 7/9] drm/xe/sysctrl: Improve firmware response error logging

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

On 02-09-2026 09:52 pm, Michal Wajdeczko wrote:
>
> On 8/31/2026 12:45 PM, Mallesh Koujalagi wrote:
>> Use xe_log_err() helper and include additional details when a
>> response header mismatch occurs.
>>
>> Signed-off-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
>> ---
>> v5:
>> - Use %#x after REG_FIELD_GET change. (Michal)
>>
>> v6:
>> - Move REG_FIELD_GET to different patch. (Michal)
>> - Update response message.
>> ---
>>   drivers/gpu/drm/xe/xe_sysctrl_mailbox.c | 8 +++++---
>>   1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c b/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c
>> index 3aa868f60b38..87e656820279 100644
>> --- a/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c
>> +++ b/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c
>> @@ -233,13 +233,15 @@ static int sysctrl_receive_frames(struct xe_sysctrl *sc,
>>   	if (!XE_SYSCTRL_HDR_IS_RESPONSE(hdr) ||
>>   	    XE_SYSCTRL_HDR_GROUP_ID(hdr) != XE_SYSCTRL_HDR_GROUP_ID(req) ||
>>   	    XE_SYSCTRL_HDR_COMMAND(hdr) != XE_SYSCTRL_HDR_COMMAND(req)) {
>> -		xe_err(xe, "sysctrl: Response header mismatch\n");
>> +		xe_log_err(xe, SYSCTRL, -EPROTO,
>> +			   "Response header mismatch: %#x != %#x\n",
>> +			   le32_to_cpu(hdr->data), le32_to_cpu(req->data));
> nit: do we need this le32 conversions when we print both raw values?
Agreed!, if we do raw data comparison, it's make sense by removing le32.
>
>>   		return -EPROTO;
>>   	}
>>   
>>   	if (XE_SYSCTRL_HDR_RESULT(hdr) != 0) {
>> -		xe_err(xe, "sysctrl: Firmware error: 0x%02lx\n",
>> -		       XE_SYSCTRL_HDR_RESULT(hdr));
>> +		xe_log_err(xe, SYSCTRL, -EIO, "Firmware error: %#04x\n",
>> +			   XE_SYSCTRL_HDR_RESULT(hdr));
>>   		return -EIO;
>>   	}
>>   
> Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Thanks Michal !