Re: [PATCH v6 4/9] drm/xe/sysctrl: Make sysctrl_read_frame() void

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 8/31/2026 12:45 PM, Mallesh Koujalagi wrote:
> Convert it to return void and remove the unnecessary error
> handling in sysctrl_process_frame().

... as there are no places where this function can fail.

> 
> Signed-off-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

(a few tags Suggested-by: wouldn't hurt either ;)

> ---
>  drivers/gpu/drm/xe/xe_sysctrl_mailbox.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c b/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c
> index 3ef60067e226..4841dd7f2724 100644
> --- a/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c
> +++ b/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c
> @@ -68,8 +68,8 @@ static void sysctrl_write_frame(struct xe_sysctrl *sc, const void *frame,
>  		xe_mmio_write32(sc->mmio, regs[i], val[i]);
>  }
>  
> -static int sysctrl_read_frame(struct xe_sysctrl *sc, void *frame,
> -			      size_t len)
> +static void sysctrl_read_frame(struct xe_sysctrl *sc, void *frame,
> +			       size_t len)
>  {
>  	static const struct xe_reg regs[] = {
>  		SYSCTRL_MB_DATA0, SYSCTRL_MB_DATA1, SYSCTRL_MB_DATA2, SYSCTRL_MB_DATA3
> @@ -85,8 +85,6 @@ static int sysctrl_read_frame(struct xe_sysctrl *sc, void *frame,
>  		val[i] = xe_mmio_read32(sc->mmio, regs[i]);
>  
>  	memcpy(frame, val, len);
> -
> -	return 0;
>  }
>  
>  static void sysctrl_clear_response(struct xe_sysctrl *sc)
> @@ -194,10 +192,7 @@ static int sysctrl_process_frame(struct xe_sysctrl *sc, void *out,
>  	total_frames = FIELD_GET(SYSCTRL_FRAME_TOTAL_MASK, ctrl_reg);
>  	curr_frame = FIELD_GET(SYSCTRL_FRAME_CURRENT_MASK, ctrl_reg);
>  
> -	ret = sysctrl_read_frame(sc, out, frame_size);
> -	if (ret)
> -		return ret;
> -
> +	sysctrl_read_frame(sc, out, frame_size);
>  	sysctrl_clear_response(sc);
>  
>  	if (curr_frame == total_frames)