Re: [PATCH v6 7/9] drm/xe/sysctrl: Improve firmware response error logging

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces calls to an undefined function/macro `xe_log_err()` and relies on an undeclared identifier `SYSCTRL`. Furthermore, it depends on a header file (`xe_log.h`) that is missing from the repository tree, resulting in an immediate build failure.
--

commit d3ef42ba91500c22f5afaa468dbb619c680583f3
Author: Mallesh Koujalagi <mallesh.koujalagi@intel.com>

drm/xe/sysctrl: Improve firmware response error logging

This commit replaces xe_err() with xe_log_err() to include additional details 
when a response header mismatch occurs.

> diff --git a/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c b/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c
> index 3aa868f60b386..87e6568202795 100644
> --- a/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c
> +++ b/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c
> @@ -233,13 +233,15 @@ static int sysctrl_receive_frames(struct xe_sysctrl *sc,
>  	if (!XE_SYSCTRL_HDR_IS_RESPONSE(hdr) ||
>  	    XE_SYSCTRL_HDR_GROUP_ID(hdr) != XE_SYSCTRL_HDR_GROUP_ID(req) ||
>  	    XE_SYSCTRL_HDR_COMMAND(hdr) != XE_SYSCTRL_HDR_COMMAND(req)) {
> -		xe_err(xe, "sysctrl: Response header mismatch\n");
> +		xe_log_err(xe, SYSCTRL, -EPROTO,
> +			   "Response header mismatch: %#x != %#x\n",
> +			   le32_to_cpu(hdr->data), le32_to_cpu(req->data));

[Severity: Low]
Does this code cause a build failure? It appears that xe_log_err() and SYSCTRL
are not defined, and the requisite header (such as xe_log.h) is missing from
the source tree.

>  		return -EPROTO;
>  	}
>  
>  	if (XE_SYSCTRL_HDR_RESULT(hdr) != 0) {
> -		xe_err(xe, "sysctrl: Firmware error: 0x%02lx\n",
> -		       XE_SYSCTRL_HDR_RESULT(hdr));
> +		xe_log_err(xe, SYSCTRL, -EIO, "Firmware error: %#04x\n",
> +			   XE_SYSCTRL_HDR_RESULT(hdr));

[Severity: Low]
Is this another location where the undefined identifiers will break the build?

>  		return -EIO;
>  	}
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831104456.1770605-11-mallesh.koujalagi@intel.com?part=7