From: Rob Herring <robh@kernel.org>
To: Shawn Guo <shengchao.guo@oss.qualcomm.com>
Cc: Nabige Aala <nabige.aala@oss.qualcomm.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Ritesh Kumar <ritesh.kumar@oss.qualcomm.com>,
Mahadevan P <mahadevan.p@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org
Subject: Re: [PATCH v3 03/11] dt-bindings: display/msm: Document Nord MDSS
Date: Wed, 18 Nov 2026 15:23:05 -0600 [thread overview]
Message-ID: <20261118212305.GA1058901-robh@kernel.org> (raw)
In-Reply-To: <av0uy_Cq9iaTZn4c@QCOM-aGQu4IUr3Y.na.qualcomm.com>
On Wed, Nov 18, 2026 at 05:51:23AM +0100, Shawn Guo wrote:
> On Mon, Nov 16, 2026 at 06:46:42PM +0530, Nabige Aala wrote:
> > From: Mahadevan P <mahadevan.p@oss.qualcomm.com>
> >
> > Nord has a new MDSS 12.1 revision with DPU 1499A and two independent,
> > DP-only display interface controllers (no DSI), which no existing
> > schema describes. Add a dedicated qcom,nord-mdss binding to document.
> >
> > Assisted-by: LLM
> > Signed-off-by: Mahadevan P <mahadevan.p@oss.qualcomm.com>
> > Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
> > ---
> > .../bindings/display/msm/qcom,nord-mdss.yaml | 396 +++++++++++++++++++++
> > 1 file changed, 396 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml
> > new file mode 100644
> > index 000000000000..abd80dae4e7f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml
> > @@ -0,0 +1,396 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/msm/qcom,nord-mdss.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Nord display subsystem (MDSS)
> > +
> > +maintainers:
> > + - Mahadevan P <mahadevan.p@oss.qualcomm.com>
> > +
> > +description:
> > + Nord display subsystem consists of MDSS (display controller), DPU 1499A
> > + (display processing unit), and display interface controllers (DP only, no DSI).
> > + This is MDSS 12.1, DP-only, with 2 independent DP controllers.
> > +
> > +$ref: /schemas/display/msm/mdss-common.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: qcom,nord-mdss
> > +
> > + clocks:
> > + items:
> > + - description: Display AHB
> > + - description: Display hf AXI
> > + - description: Display core
> > +
> > + clock-names:
> > + items:
> > + - const: iface
> > + - const: bus
> > + - const: core
> > +
> > + iommus:
> > + maxItems: 1
> > +
> > + interconnects:
> > + items:
> > + - description: Interconnect path from mdp0 port to the data bus
> > + - description: Interconnect path from CPU to the reg bus
> > +
> > + interconnect-names:
> > + items:
> > + - const: mdp0-mem
> > + - const: cpu-cfg
> > +
> > +patternProperties:
> > + "^display-controller@[0-9a-f]+$":
> > + type: object
> > + additionalProperties: true
> > + properties:
> > + compatible:
> > + const: qcom,nord-dpu
> > +
> > + "^displayport-controller@[0-9a-f]+$":
> > + type: object
> > + additionalProperties: true
> > + properties:
> > + compatible:
> > + const: qcom,nord-dp
>
> This is now contradicting with the dp-controller bindings which documents
> "qcom,nord-dp" with a fallback on "qcom,sa8775p-dp".
The correct thing to do here is add 'contains'. We don't need to define
the exact value, but just have enough to ensure a schema is applied.
All these child nodes also need:
required:
- compatible
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Shawn Guo <shengchao.guo@oss.qualcomm.com>
Cc: Nabige Aala <nabige.aala@oss.qualcomm.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Ritesh Kumar <ritesh.kumar@oss.qualcomm.com>,
Mahadevan P <mahadevan.p@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org
Subject: Re: [PATCH v3 03/11] dt-bindings: display/msm: Document Nord MDSS
Date: Wed, 18 Nov 2026 15:23:05 -0600 [thread overview]
Message-ID: <20261118212305.GA1058901-robh@kernel.org> (raw)
In-Reply-To: <av0uy_Cq9iaTZn4c@QCOM-aGQu4IUr3Y.na.qualcomm.com>
On Wed, Nov 18, 2026 at 05:51:23AM +0100, Shawn Guo wrote:
> On Mon, Nov 16, 2026 at 06:46:42PM +0530, Nabige Aala wrote:
> > From: Mahadevan P <mahadevan.p@oss.qualcomm.com>
> >
> > Nord has a new MDSS 12.1 revision with DPU 1499A and two independent,
> > DP-only display interface controllers (no DSI), which no existing
> > schema describes. Add a dedicated qcom,nord-mdss binding to document.
> >
> > Assisted-by: LLM
> > Signed-off-by: Mahadevan P <mahadevan.p@oss.qualcomm.com>
> > Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
> > ---
> > .../bindings/display/msm/qcom,nord-mdss.yaml | 396 +++++++++++++++++++++
> > 1 file changed, 396 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml
> > new file mode 100644
> > index 000000000000..abd80dae4e7f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml
> > @@ -0,0 +1,396 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/msm/qcom,nord-mdss.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Nord display subsystem (MDSS)
> > +
> > +maintainers:
> > + - Mahadevan P <mahadevan.p@oss.qualcomm.com>
> > +
> > +description:
> > + Nord display subsystem consists of MDSS (display controller), DPU 1499A
> > + (display processing unit), and display interface controllers (DP only, no DSI).
> > + This is MDSS 12.1, DP-only, with 2 independent DP controllers.
> > +
> > +$ref: /schemas/display/msm/mdss-common.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: qcom,nord-mdss
> > +
> > + clocks:
> > + items:
> > + - description: Display AHB
> > + - description: Display hf AXI
> > + - description: Display core
> > +
> > + clock-names:
> > + items:
> > + - const: iface
> > + - const: bus
> > + - const: core
> > +
> > + iommus:
> > + maxItems: 1
> > +
> > + interconnects:
> > + items:
> > + - description: Interconnect path from mdp0 port to the data bus
> > + - description: Interconnect path from CPU to the reg bus
> > +
> > + interconnect-names:
> > + items:
> > + - const: mdp0-mem
> > + - const: cpu-cfg
> > +
> > +patternProperties:
> > + "^display-controller@[0-9a-f]+$":
> > + type: object
> > + additionalProperties: true
> > + properties:
> > + compatible:
> > + const: qcom,nord-dpu
> > +
> > + "^displayport-controller@[0-9a-f]+$":
> > + type: object
> > + additionalProperties: true
> > + properties:
> > + compatible:
> > + const: qcom,nord-dp
>
> This is now contradicting with the dp-controller bindings which documents
> "qcom,nord-dp" with a fallback on "qcom,sa8775p-dp".
The correct thing to do here is add 'contains'. We don't need to define
the exact value, but just have enough to ensure a schema is applied.
All these child nodes also need:
required:
- compatible
Rob
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-11-18 21:23 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 13:16 [PATCH v3 00/11] Add Qualcomm Nord display and eDP PHY support Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 01/11] dt-bindings: phy: qcom,edp-phy: Add DP PHY compatible for Nord Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 02/11] dt-bindings: display: msm: dp-controller: Document Nord DisplayPort Controller Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:31 ` sashiko-bot
2026-11-16 13:31 ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 03/11] dt-bindings: display/msm: Document Nord MDSS Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:38 ` sashiko-bot
2026-11-16 13:38 ` sashiko-bot
2026-11-17 15:23 ` Rob Herring (Arm)
2026-11-17 15:23 ` Rob Herring (Arm)
2026-11-18 4:51 ` Shawn Guo
2026-11-18 4:51 ` Shawn Guo
2026-11-18 21:23 ` Rob Herring [this message]
2026-11-18 21:23 ` Rob Herring
2026-11-16 13:16 ` [PATCH v3 04/11] dt-bindings: display/msm: qcom,sm8650-dpu: Add Qualcomm Nord Soc Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-18 21:24 ` Rob Herring (Arm)
2026-11-18 21:24 ` Rob Herring (Arm)
2026-11-16 13:16 ` [PATCH v3 05/11] drm/msm/dpu: Add support for DPU 12.1 on Nord Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:47 ` sashiko-bot
2026-11-16 13:47 ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 06/11] drm/msm/dpu: Fix DSI tear interrupts broken by adding INTF_9 and INTF_10 Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:29 ` sashiko-bot
2026-11-16 13:29 ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 07/11] drm/msm: mdss: Add support for MDSS on Nord Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 08/11] drm/msm/dp: Add support for DP controllers " Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 09/11] phy: qcom: edp: Generalize power-on path for per-SoC overrides Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 10/11] phy: qcom: edp: Add Nord-specific QSERDES COM register header Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:30 ` sashiko-bot
2026-11-16 13:30 ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 11/11] phy: qcom: edp: Add Nord eDP/DP PHY support Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:44 ` sashiko-bot
2026-11-16 13:44 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118212305.GA1058901-robh@kernel.org \
--to=robh@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mahadevan.p@oss.qualcomm.com \
--cc=mani@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=nabige.aala@oss.qualcomm.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_khsieh@quicinc.com \
--cc=ritesh.kumar@oss.qualcomm.com \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=shengchao.guo@oss.qualcomm.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.