From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 4/5] edac: Add APM X-Gene SoC EDAC driver
Date: Fri, 22 May 2015 10:59:28 +0200 [thread overview]
Message-ID: <2097631.G0OFDqxtEt@wuerfel> (raw)
In-Reply-To: <1431991481-25684-5-git-send-email-lho@apm.com>
On Monday 18 May 2015 17:24:40 Loc Ho wrote:
> + tmp_ctx.mcu_id = ((res.start >> 16) & 0xF) / 4;
>
Just found this line: you are effectively hardcoding the physical
register layout of the chip in the driver here, to get the index
of the memory controller. This is a very bad idea as it prevents
you from reusing this driver for another chip that puts the
same registers in a different place, don't do that.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Loc Ho <lho@apm.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
ijc+devicetree@hellion.org.uk, jcm@redhat.com,
mchehab@osg.samsung.com, patches@apm.com, robh+dt@kernel.org,
bp@alien8.de, dougthompson@xmission.com,
linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH v10 4/5] edac: Add APM X-Gene SoC EDAC driver
Date: Fri, 22 May 2015 10:59:28 +0200 [thread overview]
Message-ID: <2097631.G0OFDqxtEt@wuerfel> (raw)
In-Reply-To: <1431991481-25684-5-git-send-email-lho@apm.com>
On Monday 18 May 2015 17:24:40 Loc Ho wrote:
> + tmp_ctx.mcu_id = ((res.start >> 16) & 0xF) / 4;
>
Just found this line: you are effectively hardcoding the physical
register layout of the chip in the driver here, to get the index
of the memory controller. This is a very bad idea as it prevents
you from reusing this driver for another chip that puts the
same registers in a different place, don't do that.
Arnd
next prev parent reply other threads:[~2015-05-22 8:59 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 23:24 [PATCH v10 0/4] edac: Add APM X-Gene SoC EDAC driver Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-18 23:24 ` [PATCH v10 1/5] arm64: Enable EDAC on ARM64 Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-18 23:24 ` [PATCH v10 2/5] MAINTAINERS: Add entry for APM X-Gene SoC EDAC driver Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-18 23:24 ` [PATCH v10 3/5] Documentation: Add documentation for the APM X-Gene SoC EDAC DTS binding Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-18 23:24 ` [PATCH v10 4/5] edac: Add APM X-Gene SoC EDAC driver Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-18 23:24 ` [PATCH v10 5/5] arm64: Add APM X-Gene SoC EDAC DTS entries Loc Ho
2015-05-18 23:24 ` Loc Ho
2015-05-22 8:23 ` [PATCH v10 4/5] edac: Add APM X-Gene SoC EDAC driver Arnd Bergmann
2015-05-22 8:23 ` Arnd Bergmann
2015-05-22 8:46 ` Borislav Petkov
2015-05-22 8:46 ` Borislav Petkov
2015-05-22 8:55 ` Arnd Bergmann
2015-05-22 8:55 ` Arnd Bergmann
2015-05-22 18:28 ` Loc Ho
2015-05-22 18:28 ` Loc Ho
2015-05-22 18:25 ` Loc Ho
2015-05-22 18:25 ` Loc Ho
2015-05-22 8:59 ` Arnd Bergmann [this message]
2015-05-22 8:59 ` Arnd Bergmann
2015-05-22 8:02 ` [PATCH v10 3/5] Documentation: Add documentation for the APM X-Gene SoC EDAC DTS binding Arnd Bergmann
2015-05-22 8:02 ` Arnd Bergmann
2015-05-19 17:03 ` [PATCH v10 1/5] arm64: Enable EDAC on ARM64 Borislav Petkov
2015-05-19 17:03 ` Borislav Petkov
2015-05-19 19:57 ` Loc Ho
2015-05-19 19:57 ` Loc Ho
2015-05-19 20:33 ` Borislav Petkov
2015-05-19 20:33 ` Borislav Petkov
2015-05-21 18:07 ` Borislav Petkov
2015-05-21 18:07 ` Borislav Petkov
2015-05-21 18:11 ` [RFC PATCH] EDAC: Cleanup atomic_scrub mess Borislav Petkov
2015-05-21 18:11 ` Borislav Petkov
2015-05-22 20:13 ` Chris Metcalf
2015-05-22 20:13 ` Chris Metcalf
2015-05-27 15:52 ` Borislav Petkov
2015-05-27 15:52 ` Borislav Petkov
2015-05-28 2:27 ` Michael Ellerman
2015-05-28 2:27 ` Michael Ellerman
2015-05-28 12:34 ` Russell King - ARM Linux
2015-05-28 12:34 ` Russell King - ARM Linux
2015-05-28 13:37 ` Borislav Petkov
2015-05-28 13:37 ` Borislav Petkov
2015-05-22 8:24 ` [PATCH v10 0/4] edac: Add APM X-Gene SoC EDAC driver Arnd Bergmann
2015-05-22 8:24 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2097631.G0OFDqxtEt@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.