All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kumar, Udit" <u-kumar1@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: <linux-arm-kernel@lists.infradead.org>, <afd@ti.com>, <bb@ti.com>,
	<vaishnav.a@ti.com>, <j-choudhary@ti.com>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, J Keerthi <j-keerthy@ti.com>
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-j7200: Fix physical address of pin
Date: Sat, 15 Apr 2023 09:40:10 +0530	[thread overview]
Message-ID: <20bbb3f0-ac79-9d98-9c99-7062581b163f@ti.com> (raw)
In-Reply-To: <20230414182638.watc555ihi2hgkuv@slinging>

Hi Nishanth

On 4/14/2023 11:56 PM, Nishanth Menon wrote:
> On 23:44-20230414, Udit Kumar wrote:
>> Fixes: 9ae21ac445e9 ("arm64: dts: ti: k3-j7200: Fix wakeup pinmux range")
> In the wrong place.


will address in v2


>> wkup_pmx splits into multiple regions. Like
>>
>>      wkup_pmx0 -> 13 pins (WKUP_PADCONFIG 0 - 12)
>>      wkup_pmx1 -> 2 pins (WKUP_PADCONFIG 14 - 15)
>>      wkup_pmx2 -> 59 pins (WKUP_PADCONFIG 26 - 84)
>>      wkup_pmx3 -> 8 pins (WKUP_PADCONFIG 93 - 100)
>>
>> With this split, pin offset needs to be adjusted to
>> match with new pmx for all pins above wkup_pmx0.
>>
>> Example a pin under wkup_pmx1 should start from 0 instead of
>> old offset(0x38 WKUP_PADCONFIG 14 offset)
>>
>> J7200 Datasheet (Table 6-106, Section 6.4 Pin Multiplexing) :
>>              https://www.ti.com/lit/ds/symlink/dra821u.pdf
> Drop the preceding whitespace.

ok

>> Signed-off-by: J Keerthi <j-keerthy@ti.com>
> Spell check name please, I think he usually goes with:
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
>
> If this patch is from Keerthy, the patch should have a "From:"

ok.

git apply on original patch didn't worked , so i applied and committed.

will fix in patch itself before posting, Keerthi as author


>> Signed-off-by: Udit Kumar <u-kumar1@ti.com>
>> ---
>>   .../dts/ti/k3-j7200-common-proc-board.dts     | 28 +++++++++----------
>>   1 file changed, 14 insertions(+), 14 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> index 0d39d6b8cc0c..63633e4f6c59 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> @@ -83,25 +83,25 @@ vdd_sd_dv: gpio-regulator-TLV71033 {
>>   &wkup_pmx2 {
>>   	mcu_cpsw_pins_default: mcu-cpsw-pins-default {
>>   		pinctrl-single,pins = <
>> -			J721E_WKUP_IOPAD(0x0068, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */
>> -			J721E_WKUP_IOPAD(0x006c, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */
>> -			J721E_WKUP_IOPAD(0x0070, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */
>> -			J721E_WKUP_IOPAD(0x0074, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */
>> -			J721E_WKUP_IOPAD(0x0078, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */
>> -			J721E_WKUP_IOPAD(0x007c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */
>> -			J721E_WKUP_IOPAD(0x0088, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */
>> -			J721E_WKUP_IOPAD(0x008c, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */
>> -			J721E_WKUP_IOPAD(0x0090, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */
>> -			J721E_WKUP_IOPAD(0x0094, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */
>> -			J721E_WKUP_IOPAD(0x0080, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */
>> -			J721E_WKUP_IOPAD(0x0084, PIN_INPUT, 0) /* MCU_RGMII1_RXC */
>> +			J721E_WKUP_IOPAD(0x0000, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */
>> +			J721E_WKUP_IOPAD(0x0004, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */
>> +			J721E_WKUP_IOPAD(0x0008, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */
>> +			J721E_WKUP_IOPAD(0x000c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */
>> +			J721E_WKUP_IOPAD(0x0010, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */
>> +			J721E_WKUP_IOPAD(0x0014, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */
>> +			J721E_WKUP_IOPAD(0x0020, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */
>> +			J721E_WKUP_IOPAD(0x0024, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */
>> +			J721E_WKUP_IOPAD(0x0028, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */
>> +			J721E_WKUP_IOPAD(0x002c, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */
>> +			J721E_WKUP_IOPAD(0x0018, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */
>> +			J721E_WKUP_IOPAD(0x001c, PIN_INPUT, 0) /* MCU_RGMII1_RXC */
> nice catch.
>
>>   		>;
>>   	};
>>   
>>   	mcu_mdio_pins_default: mcu-mdio1-pins-default {
>>   		pinctrl-single,pins = <
>> -			J721E_WKUP_IOPAD(0x009c, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */
>> -			J721E_WKUP_IOPAD(0x0098, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */
>> +			J721E_WKUP_IOPAD(0x0034, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */
>> +			J721E_WKUP_IOPAD(0x0030, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */
>>   		>;
>>   	};
>>   };
>> -- 
>> 2.34.1
>>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Kumar, Udit" <u-kumar1@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: <linux-arm-kernel@lists.infradead.org>, <afd@ti.com>, <bb@ti.com>,
	<vaishnav.a@ti.com>, <j-choudhary@ti.com>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, J Keerthi <j-keerthy@ti.com>
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-j7200: Fix physical address of pin
Date: Sat, 15 Apr 2023 09:40:10 +0530	[thread overview]
Message-ID: <20bbb3f0-ac79-9d98-9c99-7062581b163f@ti.com> (raw)
In-Reply-To: <20230414182638.watc555ihi2hgkuv@slinging>

Hi Nishanth

On 4/14/2023 11:56 PM, Nishanth Menon wrote:
> On 23:44-20230414, Udit Kumar wrote:
>> Fixes: 9ae21ac445e9 ("arm64: dts: ti: k3-j7200: Fix wakeup pinmux range")
> In the wrong place.


will address in v2


>> wkup_pmx splits into multiple regions. Like
>>
>>      wkup_pmx0 -> 13 pins (WKUP_PADCONFIG 0 - 12)
>>      wkup_pmx1 -> 2 pins (WKUP_PADCONFIG 14 - 15)
>>      wkup_pmx2 -> 59 pins (WKUP_PADCONFIG 26 - 84)
>>      wkup_pmx3 -> 8 pins (WKUP_PADCONFIG 93 - 100)
>>
>> With this split, pin offset needs to be adjusted to
>> match with new pmx for all pins above wkup_pmx0.
>>
>> Example a pin under wkup_pmx1 should start from 0 instead of
>> old offset(0x38 WKUP_PADCONFIG 14 offset)
>>
>> J7200 Datasheet (Table 6-106, Section 6.4 Pin Multiplexing) :
>>              https://www.ti.com/lit/ds/symlink/dra821u.pdf
> Drop the preceding whitespace.

ok

>> Signed-off-by: J Keerthi <j-keerthy@ti.com>
> Spell check name please, I think he usually goes with:
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
>
> If this patch is from Keerthy, the patch should have a "From:"

ok.

git apply on original patch didn't worked , so i applied and committed.

will fix in patch itself before posting, Keerthi as author


>> Signed-off-by: Udit Kumar <u-kumar1@ti.com>
>> ---
>>   .../dts/ti/k3-j7200-common-proc-board.dts     | 28 +++++++++----------
>>   1 file changed, 14 insertions(+), 14 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> index 0d39d6b8cc0c..63633e4f6c59 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> @@ -83,25 +83,25 @@ vdd_sd_dv: gpio-regulator-TLV71033 {
>>   &wkup_pmx2 {
>>   	mcu_cpsw_pins_default: mcu-cpsw-pins-default {
>>   		pinctrl-single,pins = <
>> -			J721E_WKUP_IOPAD(0x0068, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */
>> -			J721E_WKUP_IOPAD(0x006c, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */
>> -			J721E_WKUP_IOPAD(0x0070, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */
>> -			J721E_WKUP_IOPAD(0x0074, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */
>> -			J721E_WKUP_IOPAD(0x0078, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */
>> -			J721E_WKUP_IOPAD(0x007c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */
>> -			J721E_WKUP_IOPAD(0x0088, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */
>> -			J721E_WKUP_IOPAD(0x008c, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */
>> -			J721E_WKUP_IOPAD(0x0090, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */
>> -			J721E_WKUP_IOPAD(0x0094, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */
>> -			J721E_WKUP_IOPAD(0x0080, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */
>> -			J721E_WKUP_IOPAD(0x0084, PIN_INPUT, 0) /* MCU_RGMII1_RXC */
>> +			J721E_WKUP_IOPAD(0x0000, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */
>> +			J721E_WKUP_IOPAD(0x0004, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */
>> +			J721E_WKUP_IOPAD(0x0008, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */
>> +			J721E_WKUP_IOPAD(0x000c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */
>> +			J721E_WKUP_IOPAD(0x0010, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */
>> +			J721E_WKUP_IOPAD(0x0014, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */
>> +			J721E_WKUP_IOPAD(0x0020, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */
>> +			J721E_WKUP_IOPAD(0x0024, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */
>> +			J721E_WKUP_IOPAD(0x0028, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */
>> +			J721E_WKUP_IOPAD(0x002c, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */
>> +			J721E_WKUP_IOPAD(0x0018, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */
>> +			J721E_WKUP_IOPAD(0x001c, PIN_INPUT, 0) /* MCU_RGMII1_RXC */
> nice catch.
>
>>   		>;
>>   	};
>>   
>>   	mcu_mdio_pins_default: mcu-mdio1-pins-default {
>>   		pinctrl-single,pins = <
>> -			J721E_WKUP_IOPAD(0x009c, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */
>> -			J721E_WKUP_IOPAD(0x0098, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */
>> +			J721E_WKUP_IOPAD(0x0034, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */
>> +			J721E_WKUP_IOPAD(0x0030, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */
>>   		>;
>>   	};
>>   };
>> -- 
>> 2.34.1
>>

  reply	other threads:[~2023-04-15  4:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14 18:14 [PATCH 0/2] arm64: dts: ti: k3-j7200-common-proc-board fixes Udit Kumar
2023-04-14 18:14 ` Udit Kumar
2023-04-14 18:14 ` [PATCH 1/2] arm64: dts: ti: k3-j7200: Fix physical address of pin Udit Kumar
2023-04-14 18:14   ` Udit Kumar
2023-04-14 18:26   ` Nishanth Menon
2023-04-14 18:26     ` Nishanth Menon
2023-04-15  4:10     ` Kumar, Udit [this message]
2023-04-15  4:10       ` Kumar, Udit
2023-04-15 12:47       ` Nishanth Menon
2023-04-15 12:47         ` Nishanth Menon
2023-04-14 18:14 ` [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Enable I2C Udit Kumar
2023-04-14 18:14   ` Udit Kumar
2023-04-14 18:24   ` Nishanth Menon
2023-04-14 18:24     ` Nishanth Menon
2023-04-15  4:06     ` Kumar, Udit
2023-04-15  4:06       ` Kumar, Udit
2023-04-15 12:47       ` Nishanth Menon
2023-04-15 12:47         ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20bbb3f0-ac79-9d98-9c99-7062581b163f@ti.com \
    --to=u-kumar1@ti.com \
    --cc=afd@ti.com \
    --cc=bb@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-choudhary@ti.com \
    --cc=j-keerthy@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vaishnav.a@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.