error compiling kvm-72 not there with kvm-69 - link kernel 2.6.26

error compiling kvm-72 not there with kvm-69 - link kernel 2.6.26

[jim miro]

1st - I don't peruse this mail list

error:
------------------
make -C kernel
make[1]: Entering directory `/usr/src/kvm-72/kernel'
make -C /lib/modules/2.6.26/build M=`pwd` \
        LINUXINCLUDE="-I`pwd`/include -Iinclude -I`pwd`/include-compat \
        -include include/linux/autoconf.h \
        -include `pwd`/external-module-compat.h"
make[2]: Entering directory `/usr/src/linux-2.6.26'
  LD      /usr/src/kvm-72/kernel/built-in.o
  CC [M]  /usr/src/kvm-72/kernel/svm.o
  CC [M]  /usr/src/kvm-72/kernel/external-module-compat.o
  CC [M]  /usr/src/kvm-72/kernel/vmx.o
  CC [M]  /usr/src/kvm-72/kernel/vmx-debug.o
  CC [M] 
 /usr/src/kvm-72/kernel/kvm_main.o
  CC [M]  /usr/src/kvm-72/kernel/x86.o
  CC [M]  /usr/src/kvm-72/kernel/mmu.o
  CC [M]  /usr/src/kvm-72/kernel/x86_emulate.o
  CC [M]  /usr/src/kvm-72/kernel/anon_inodes.o
/usr/src/kvm-72/kernel/anon_inodes.c: In function ‘kvm_anon_inode_getfd’:
/usr/src/kvm-72/kernel/anon_inodes.c:254: error: too many arguments to function ‘anon_inode_getfd’
make[3]: *** [/usr/src/kvm-72/kernel/anon_inodes.o] Error 1
make[2]: *** [_module_/usr/src/kvm-72/kernel] Error 2
make[2]: Leaving directory `/usr/src/linux-2.6.26'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/usr/src/kvm-72/kernel'
make: *** [kernel] Error 2
----------
kernel 2.6.26 built from linux.kernel.org image
It currently has kvm-69  external compiled modules made against this source and running.
I noted that --enable-alsa was not an option on kvm-72

kvm
 build with ./configure --prefix=/usr --enable-alsa  for kvm-69
for kvm-72 ./configure --prefix=/usr

cat config.mak
ARCH=x86_64
PREFIX=/usr
KERNELDIR=/lib/modules/2.6.26/build
LIBKVM_KERNELDIR=/usr/src/kvm-72/kernel
WANT_MODULE=1
CROSS_COMPILE=
CC=gcc
LD=ld
OBJCOPY=objcopy

OS is debian testing - last updated this date

CPU:
cat /proc/cpuinfo
processor    : 0
vendor_id    : AuthenticAMD
cpu family    : 15
model        : 75
model name    : AMD Athlon(tm) 64 X2 Dual Core Processor 3800+
stepping    : 2
cpu MHz        : 2009.262
cache size    : 512 KB
physical id    : 0
siblings    : 2
core id        : 0
cpu cores    :
 2
apicid        : 0
initial apicid    : 0
fpu        : yes
fpu_exception    : yes
cpuid level    : 1
wp        : yes
flags        : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt rdtscp lm 3dnowext 3dnow rep_good pni cx16 lahf_lm cmp_legacy svm extapic cr8_legacy
bogomips    : 4021.24
TLB size    : 1024 4K pages
clflush size    : 64
cache_alignment    : 64
address sizes    : 40 bits physical, 48 bits virtual
power management: ts fid vid ttp tm stc

processor    : 1
vendor_id    : AuthenticAMD
cpu family    : 15
model   
     : 75
model name    : AMD Athlon(tm) 64 X2 Dual Core Processor 3800+
stepping    : 2
cpu MHz        : 2009.262
cache size    : 512 KB
physical id    : 0
siblings    : 2
core id        : 1
cpu cores    : 2
apicid        : 1
initial apicid    : 1
fpu        : yes
fpu_exception    : yes
cpuid level    : 1
wp        : yes
flags        : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt rdtscp lm 3dnowext 3dnow rep_good pni cx16 lahf_lm cmp_legacy svm extapic cr8_legacy
bogomips    :
 4018.33
TLB size    : 1024 4K pages
clflush size    : 64
cache_alignment    : 64
address sizes    : 40 bits physical, 48 bits virtual
power management: ts fid vid ttp tm stc

Memory:
cat /proc/meminfo
MemTotal:      1994512 kB
MemFree:        619124 kB
Buffers:         64884 kB
Cached:         629192 kB
SwapCached:         16 kB
Active:         725200 kB
Inactive:       451964 kB
SwapTotal:     5984248 kB
SwapFree:      5984112 kB
Dirty:             180
 kB
Writeback:           0 kB
AnonPages:      483040 kB
Mapped:          67612 kB
Slab:           153472 kB
SReclaimable:   139308 kB
SUnreclaim:      14164 kB

PageTables:      13956 kB
NFS_Unstable:        0 kB
Bounce:              0 kB
WritebackTmp:        0 kB
CommitLimit:   6981504 kB
Committed_AS:   852184 kB
VmallocTotal: 34359738367 kB
VmallocUsed:    108376 kB
VmallocChunk: 34359625211 kB





      


      

Re: error compiling kvm-72 not there with kvm-69 - link kernel 2.6.26

[jim miro]

If I remove the "flags" parameter from the call to anon_inode_getfd in the function kvm_anon_inode_getfd 
It compiles but I get a warning.

 CC [M]  /usr/src/kvm-72/kernel/anon_inodes.o
/usr/src/kvm-72/kernel/anon_inodes.c: In function ‘kvm_anon_inode_getfd’:
/usr/src/kvm-72/kernel/anon_inodes.c:254: warning: passing argument 2 of ‘anon_inode_getfd’ from incompatible pointer type
  CC [M]  /usr/src/kvm-72/kernel/irq.o

So...
its late and I won't have time to try it tonight but there is a coding error there.

#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,26)

int kvm_anon_inode_getfd(const char *name,
			 const struct file_operations *fops,
			 void *priv, int flags)
{
	int r;
	int fd;
	struct inode *inode;
	struct file *file;

	r = anon_inode_getfd(&fd, &inode, &file, name, fops, priv);
	if (r < 0)
		return r;
	return fd;
}

#else

int kvm_anon_inode_getfd(const char *name,
			 const struct file_operations *fops,
			 void *priv, int flags)
{
	return anon_inode_getfd(name, &fops, priv, flags);
}                                                  ^^^error 

#endif



      

Re: error compiling kvm-72 not there with kvm-69 - link kernel 2.6.26

[jim miro]

the patch does not work...

watermod@miro:~/KVM$ sh run_c_kvm

Message from syslogd@miro at Thu Aug  7 01:58:37 2008 ...
miro kernel: Oops: 0011 [1] SMP 

Message from syslogd@miro at Thu Aug  7 01:58:37 2008 ...
miro kernel: Code: 00 00 00 00 00 00 00 00 00 00 00 20 5d ed 6e 00 81 ff ff 20 5d ed 6e 00 81 ff ff 00 00 00 00 00 00 00 00 40 5e 9f 68 00 81 ff ff <40> 5d ed 6e 00 81 ff ff 40 5d ed 6e 00 81 ff ff 80 e7 82 7b 00 

Message from syslogd@miro at Thu Aug  7 01:58:37 2008 ...
miro kernel: CR2: ffff81006eed5d40

Message from syslogd@miro at Thu Aug  7 01:58:37 2008 ...
miro kernel: Oops: 0000 [2] SMP 

Message from syslogd@miro at Thu Aug  7 01:58:37 2008 ...
miro kernel: Code: 5f e9 91 b4 11 00 41 57 4c 8d 7f 04 41 56 41 55 41 54 55 48 89 fd 4c 89 ff 4c 8d 75 08 53 48 83 ec 08 e8 6e b3 11 00 48 89 04 24 <48> 8b 4d 08 c7 45 00 00 00 00 00 4c 39 f1 0f 84 be 00 00 00 45 

Message from syslogd@miro at Thu Aug  7 01:58:37 2008 ...
miro kernel: CR2: 0000000000000009



--- On Thu, 8/7/08, jim miro <daliroot@yahoo.com> wrote:

> From: jim miro <daliroot@yahoo.com>
> Subject: Re: error compiling kvm-72 not there with kvm-69 - link kernel 2.6.26
> To: kvm@vger.kernel.org
> Date: Thursday, August 7, 2008, 1:46 AM
> If I remove the "flags" parameter from the call to
> anon_inode_getfd in the function kvm_anon_inode_getfd 
> It compiles but I get a warning.
> 
>  CC [M]  /usr/src/kvm-72/kernel/anon_inodes.o
> /usr/src/kvm-72/kernel/anon_inodes.c: In function
> ‘kvm_anon_inode_getfd’:
> /usr/src/kvm-72/kernel/anon_inodes.c:254: warning: passing
> argument 2 of ‘anon_inode_getfd’ from incompatible
> pointer type
>   CC [M]  /usr/src/kvm-72/kernel/irq.o
> 
> So...
> its late and I won't have time to try it tonight but
> there is a coding error there.
> 
> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,26)
> 
> int kvm_anon_inode_getfd(const char *name,
> 			 const struct file_operations *fops,
> 			 void *priv, int flags)
> {
> 	int r;
> 	int fd;
> 	struct inode *inode;
> 	struct file *file;
> 
> 	r = anon_inode_getfd(&fd, &inode, &file, name,
> fops, priv);
> 	if (r < 0)
> 		return r;
> 	return fd;
> }
> 
> #else
> 
> int kvm_anon_inode_getfd(const char *name,
> 			 const struct file_operations *fops,
> 			 void *priv, int flags)
> {
> 	return anon_inode_getfd(name, &fops, priv, flags);
> }                                                  ^^^error
> 
> 
> #endif