All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Neuling <mikey@neuling.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Helge Deller <deller@gmx.de>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Americo Wang <xiyou.wangcong@gmail.com>,
	Anton Blanchard <anton@samba.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] Create initial stack independent of PAGE_SIZE
Date: Fri, 12 Feb 2010 16:44:15 +1100	[thread overview]
Message-ID: <31586.1265953455@neuling.org> (raw)
In-Reply-To: <20100209132529.bfc455b7.akpm@linux-foundation.org>

Currently we create the initial stack based on the PAGE_SIZE.  This is
unnecessary.  

This creates this initial stack independent of the PAGE_SIZE.

It also bumps up the number of 4k pages allocated from 20 to 32, to
align with 64K page systems.

Signed-off-by: Michael Neuling <mikey@neuling.org>
---
This is the second half of my original patch. This can be targeted for
2.6.34 as it's just a cleanup.

Tested on PPC64 with 4k and 64k pages.

 fs/exec.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Index: linux-2.6-ozlabs/fs/exec.c
===================================================================
--- linux-2.6-ozlabs.orig/fs/exec.c
+++ linux-2.6-ozlabs/fs/exec.c
@@ -554,8 +554,6 @@ static int shift_arg_pages(struct vm_are
 	return 0;
 }
 
-#define EXTRA_STACK_VM_PAGES	20	/* random */
-
 /*
  * Finalizes the stack vm_area_struct. The flags and permissions are updated,
  * the stack is optionally relocated, and some extra space is added.
@@ -630,7 +628,7 @@ int setup_arg_pages(struct linux_binprm 
 			goto out_unlock;
 	}
 
-	stack_expand = EXTRA_STACK_VM_PAGES * PAGE_SIZE;
+	stack_expand = 131072UL; /* randomly 32*4k (or 2*64k) pages */
 	stack_size = vma->vm_end - vma->vm_start;
 	/*
 	 * Align this down to a page boundary as expand_stack

  parent reply	other threads:[~2010-02-12  5:44 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-06  0:43 Stack size protection broken on ppc64 Michael Neuling
2010-02-06  4:20 ` Anton Blanchard
2010-02-06  4:20   ` Anton Blanchard
2010-02-06 10:22   ` Michael Neuling
2010-02-06 10:22     ` Michael Neuling
2010-02-08  0:04     ` Anton Blanchard
2010-02-08  0:04       ` Anton Blanchard
2010-02-08  0:07     ` [PATCH] Restrict stack space reservation to rlimit Michael Neuling
2010-02-08  0:07       ` Michael Neuling
2010-02-08  0:28       ` Michael Neuling
2010-02-08  0:28         ` Michael Neuling
2010-02-08  5:06       ` KOSAKI Motohiro
2010-02-08  5:06         ` KOSAKI Motohiro
2010-02-08  5:11         ` Anton Blanchard
2010-02-08  5:11           ` Anton Blanchard
2010-02-08  5:22           ` KOSAKI Motohiro
2010-02-08  5:22             ` KOSAKI Motohiro
2010-02-08  5:31             ` Anton Blanchard
2010-02-08  5:31               ` Anton Blanchard
2010-02-08  6:11               ` KOSAKI Motohiro
2010-02-08  6:11                 ` KOSAKI Motohiro
2010-02-08  5:37             ` Michael Neuling
2010-02-08  5:37               ` Michael Neuling
2010-02-08  6:05               ` KOSAKI Motohiro
2010-02-08  6:05                 ` KOSAKI Motohiro
2010-02-08  7:07                 ` Américo Wang
2010-02-08  7:07                   ` Américo Wang
2010-02-08  7:07                   ` Américo Wang
2010-02-08  7:11                   ` KOSAKI Motohiro
2010-02-08  7:11                     ` KOSAKI Motohiro
2010-02-09  6:11                     ` [PATCH] Restrict initial stack space expansion " Michael Neuling
2010-02-09  6:11                       ` Michael Neuling
2010-02-09  6:46                       ` KOSAKI Motohiro
2010-02-09  6:46                         ` KOSAKI Motohiro
2010-02-09  8:59                         ` Michael Neuling
2010-02-09  8:59                           ` Michael Neuling
2010-02-09 21:25                           ` Andrew Morton
2010-02-09 21:25                             ` Andrew Morton
2010-02-09 21:51                             ` Michael Neuling
2010-02-09 21:51                               ` Michael Neuling
2010-02-09 22:27                               ` Helge Deller
2010-02-09 22:27                                 ` Helge Deller
2010-02-10  5:12                                 ` KOSAKI Motohiro
2010-02-10  5:12                                   ` KOSAKI Motohiro
2010-02-10  5:30                                   ` Michael Neuling
2010-02-10  5:30                                     ` Michael Neuling
2010-02-10  5:31                                   ` Michael Neuling
2010-02-10  5:31                                     ` Michael Neuling
2010-02-11 22:16                                     ` Helge Deller
2010-02-11 22:16                                       ` Helge Deller
2010-02-11 22:22                                       ` Michael Neuling
2010-02-11 22:22                                         ` Michael Neuling
2010-02-12  5:44                             ` Michael Neuling [this message]
2010-02-12  7:20                               ` [PATCH] Create initial stack independent of PAGE_SIZE KOSAKI Motohiro
2010-02-12  9:02                                 ` Michael Neuling
2010-02-12  9:51                                   ` KOSAKI Motohiro
2010-02-08 10:45                 ` [PATCH] Restrict stack space reservation to rlimit Michael Neuling
2010-02-08 10:45                   ` Michael Neuling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31586.1265953455@neuling.org \
    --to=mikey@neuling.org \
    --cc=akpm@linux-foundation.org \
    --cc=anton@samba.org \
    --cc=deller@gmx.de \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.