From: Anton Blanchard <anton@samba.org>
To: Michael Neuling <mikey@neuling.org>
Cc: aeb@cwi.nl, linux-kernel@vger.kernel.org, miltonm@bga.com,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
WANG Cong <xiyou.wangcong@gmail.com>,
Serge Hallyn <serue@us.ibm.com>,
stable@kernel.org
Subject: Re: Stack size protection broken on ppc64
Date: Mon, 8 Feb 2010 11:04:35 +1100 [thread overview]
Message-ID: <20100208000435.GJ32246@kryten> (raw)
In-Reply-To: <10125.1265451732@neuling.org>
Hi,
> Cool, thanks. The following is based on this and fixes the problem for
> me on PPC64 ie. the !CONFIG_STACK_GROWSUP case.
Thanks! Seeing the original setting of EXTRA_STACK_VM_PAGES is more or
less random, I wonder if we should round EXTRA_STACK_VM_SIZE up to 128kB
(or even down to 64kB) so it operates better with > 4kB pages.
But in the end its probably of little use for the default OVERCOMMIT_GUESS
setting, so the main thing is we dont terminate processes incorrectly.
Acked-by: Anton Blanchard <anton@samba.org>
Anton
WARNING: multiple messages have this Message-ID (diff)
From: Anton Blanchard <anton@samba.org>
To: Michael Neuling <mikey@neuling.org>
Cc: stable@kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, Serge Hallyn <serue@us.ibm.com>,
WANG Cong <xiyou.wangcong@gmail.com>,
Paul Mackerras <paulus@samba.org>,
benh@kernel.crashing.org, miltonm@bga.com, aeb@cwi.nl
Subject: Re: Stack size protection broken on ppc64
Date: Mon, 8 Feb 2010 11:04:35 +1100 [thread overview]
Message-ID: <20100208000435.GJ32246@kryten> (raw)
In-Reply-To: <10125.1265451732@neuling.org>
Hi,
> Cool, thanks. The following is based on this and fixes the problem for
> me on PPC64 ie. the !CONFIG_STACK_GROWSUP case.
Thanks! Seeing the original setting of EXTRA_STACK_VM_PAGES is more or
less random, I wonder if we should round EXTRA_STACK_VM_SIZE up to 128kB
(or even down to 64kB) so it operates better with > 4kB pages.
But in the end its probably of little use for the default OVERCOMMIT_GUESS
setting, so the main thing is we dont terminate processes incorrectly.
Acked-by: Anton Blanchard <anton@samba.org>
Anton
next prev parent reply other threads:[~2010-02-08 0:04 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-06 0:43 Stack size protection broken on ppc64 Michael Neuling
2010-02-06 4:20 ` Anton Blanchard
2010-02-06 4:20 ` Anton Blanchard
2010-02-06 10:22 ` Michael Neuling
2010-02-06 10:22 ` Michael Neuling
2010-02-08 0:04 ` Anton Blanchard [this message]
2010-02-08 0:04 ` Anton Blanchard
2010-02-08 0:07 ` [PATCH] Restrict stack space reservation to rlimit Michael Neuling
2010-02-08 0:07 ` Michael Neuling
2010-02-08 0:28 ` Michael Neuling
2010-02-08 0:28 ` Michael Neuling
2010-02-08 5:06 ` KOSAKI Motohiro
2010-02-08 5:06 ` KOSAKI Motohiro
2010-02-08 5:11 ` Anton Blanchard
2010-02-08 5:11 ` Anton Blanchard
2010-02-08 5:22 ` KOSAKI Motohiro
2010-02-08 5:22 ` KOSAKI Motohiro
2010-02-08 5:31 ` Anton Blanchard
2010-02-08 5:31 ` Anton Blanchard
2010-02-08 6:11 ` KOSAKI Motohiro
2010-02-08 6:11 ` KOSAKI Motohiro
2010-02-08 5:37 ` Michael Neuling
2010-02-08 5:37 ` Michael Neuling
2010-02-08 6:05 ` KOSAKI Motohiro
2010-02-08 6:05 ` KOSAKI Motohiro
2010-02-08 7:07 ` Américo Wang
2010-02-08 7:07 ` Américo Wang
2010-02-08 7:07 ` Américo Wang
2010-02-08 7:11 ` KOSAKI Motohiro
2010-02-08 7:11 ` KOSAKI Motohiro
2010-02-09 6:11 ` [PATCH] Restrict initial stack space expansion " Michael Neuling
2010-02-09 6:11 ` Michael Neuling
2010-02-09 6:46 ` KOSAKI Motohiro
2010-02-09 6:46 ` KOSAKI Motohiro
2010-02-09 8:59 ` Michael Neuling
2010-02-09 8:59 ` Michael Neuling
2010-02-09 21:25 ` Andrew Morton
2010-02-09 21:25 ` Andrew Morton
2010-02-09 21:51 ` Michael Neuling
2010-02-09 21:51 ` Michael Neuling
2010-02-09 22:27 ` Helge Deller
2010-02-09 22:27 ` Helge Deller
2010-02-10 5:12 ` KOSAKI Motohiro
2010-02-10 5:12 ` KOSAKI Motohiro
2010-02-10 5:30 ` Michael Neuling
2010-02-10 5:30 ` Michael Neuling
2010-02-10 5:31 ` Michael Neuling
2010-02-10 5:31 ` Michael Neuling
2010-02-11 22:16 ` Helge Deller
2010-02-11 22:16 ` Helge Deller
2010-02-11 22:22 ` Michael Neuling
2010-02-11 22:22 ` Michael Neuling
2010-02-12 5:44 ` [PATCH] Create initial stack independent of PAGE_SIZE Michael Neuling
2010-02-12 7:20 ` KOSAKI Motohiro
2010-02-12 9:02 ` Michael Neuling
2010-02-12 9:51 ` KOSAKI Motohiro
2010-02-08 10:45 ` [PATCH] Restrict stack space reservation to rlimit Michael Neuling
2010-02-08 10:45 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100208000435.GJ32246@kryten \
--to=anton@samba.org \
--cc=aeb@cwi.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=miltonm@bga.com \
--cc=paulus@samba.org \
--cc=serue@us.ibm.com \
--cc=stable@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.