All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Neuling <mikey@neuling.org>
To: anton@samba.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@ozlabs.org, Serge Hallyn <serue@us.ibm.com>,
	WANG Cong <xiyou.wangcong@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	benh@kernel.crashing.org
Cc: miltonm@bga.com
Subject: Stack size protection broken on ppc64
Date: Sat, 06 Feb 2010 11:43:13 +1100	[thread overview]
Message-ID: <3984.1265416993@neuling.org> (raw)

On recent ppc64 kernels, limiting the stack (using 'ulimit -s blah') is
now more restrictive than it was before.  On 2.6.31 with 4k pages I
could run 'ulimit -s 16; /usr/bin/test' without a problem.  Now with
mainline, even 'ulimit -s 64; /usr/bin/test' gets killed.

Using 64k pages is even worse.  I can't even run '/bin/ls' with a 1MB
stack (ulimit -s 1024; /bin/ls).  Hence, it seems new kernels are too
restrictive, rather than the old kernels being too liberal.

I've not tested with any other architectures.  

Bisecting, I found that this is the culprit (which is in 2.6.32)

  commit fc63cf237078c86214abcb2ee9926d8ad289da9b
  Author: Anton Blanchard <anton@samba.org>
  exec:   setup_arg_pages() fails to return errors

Looking at the patch, it's probably just unmasking a preexisting issue.
The error path for expand_stack() (and others) was modified to:
---
	ret = expand_stack(vma, stack_base);
	if (ret)
		ret = -EFAULT;

out_unlock:
	up_write(&mm->mmap_sem);
-       return 0;
+       return ret;
 }
 EXPORT_SYMBOL(setup_arg_pages);
---

So previously expand_stack errors were not returned correctly by
setup_arg_pages, but now they are.

Any clues how to fix this?

Mikey

             reply	other threads:[~2010-02-06  0:43 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-06  0:43 Michael Neuling [this message]
2010-02-06  4:20 ` Stack size protection broken on ppc64 Anton Blanchard
2010-02-06  4:20   ` Anton Blanchard
2010-02-06 10:22   ` Michael Neuling
2010-02-06 10:22     ` Michael Neuling
2010-02-08  0:04     ` Anton Blanchard
2010-02-08  0:04       ` Anton Blanchard
2010-02-08  0:07     ` [PATCH] Restrict stack space reservation to rlimit Michael Neuling
2010-02-08  0:07       ` Michael Neuling
2010-02-08  0:28       ` Michael Neuling
2010-02-08  0:28         ` Michael Neuling
2010-02-08  5:06       ` KOSAKI Motohiro
2010-02-08  5:06         ` KOSAKI Motohiro
2010-02-08  5:11         ` Anton Blanchard
2010-02-08  5:11           ` Anton Blanchard
2010-02-08  5:22           ` KOSAKI Motohiro
2010-02-08  5:22             ` KOSAKI Motohiro
2010-02-08  5:31             ` Anton Blanchard
2010-02-08  5:31               ` Anton Blanchard
2010-02-08  6:11               ` KOSAKI Motohiro
2010-02-08  6:11                 ` KOSAKI Motohiro
2010-02-08  5:37             ` Michael Neuling
2010-02-08  5:37               ` Michael Neuling
2010-02-08  6:05               ` KOSAKI Motohiro
2010-02-08  6:05                 ` KOSAKI Motohiro
2010-02-08  7:07                 ` Américo Wang
2010-02-08  7:07                   ` Américo Wang
2010-02-08  7:07                   ` Américo Wang
2010-02-08  7:11                   ` KOSAKI Motohiro
2010-02-08  7:11                     ` KOSAKI Motohiro
2010-02-09  6:11                     ` [PATCH] Restrict initial stack space expansion " Michael Neuling
2010-02-09  6:11                       ` Michael Neuling
2010-02-09  6:46                       ` KOSAKI Motohiro
2010-02-09  6:46                         ` KOSAKI Motohiro
2010-02-09  8:59                         ` Michael Neuling
2010-02-09  8:59                           ` Michael Neuling
2010-02-09 21:25                           ` Andrew Morton
2010-02-09 21:25                             ` Andrew Morton
2010-02-09 21:51                             ` Michael Neuling
2010-02-09 21:51                               ` Michael Neuling
2010-02-09 22:27                               ` Helge Deller
2010-02-09 22:27                                 ` Helge Deller
2010-02-10  5:12                                 ` KOSAKI Motohiro
2010-02-10  5:12                                   ` KOSAKI Motohiro
2010-02-10  5:30                                   ` Michael Neuling
2010-02-10  5:30                                     ` Michael Neuling
2010-02-10  5:31                                   ` Michael Neuling
2010-02-10  5:31                                     ` Michael Neuling
2010-02-11 22:16                                     ` Helge Deller
2010-02-11 22:16                                       ` Helge Deller
2010-02-11 22:22                                       ` Michael Neuling
2010-02-11 22:22                                         ` Michael Neuling
2010-02-12  5:44                             ` [PATCH] Create initial stack independent of PAGE_SIZE Michael Neuling
2010-02-12  7:20                               ` KOSAKI Motohiro
2010-02-12  9:02                                 ` Michael Neuling
2010-02-12  9:51                                   ` KOSAKI Motohiro
2010-02-08 10:45                 ` [PATCH] Restrict stack space reservation to rlimit Michael Neuling
2010-02-08 10:45                   ` Michael Neuling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3984.1265416993@neuling.org \
    --to=mikey@neuling.org \
    --cc=anton@samba.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=miltonm@bga.com \
    --cc=paulus@samba.org \
    --cc=serue@us.ibm.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.