All of lore.kernel.org
 help / color / mirror / Atom feed
From: "qinjian[覃健]" <qinjian@cqplus1.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Rob Herring <robh+dt@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <maz@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	"Russell King - ARM Linux" <linux@armlinux.org.uk>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	DTML <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>
Subject: RE: [PATCH v12 9/9] ARM: sp7021_defconfig: Add Sunplus SP7021 defconfig
Date: Fri, 1 Apr 2022 07:08:39 +0000	[thread overview]
Message-ID: <334463c7f78b4b25a62ddd01bba5fe06@cqplus1.com> (raw)
In-Reply-To: <CAK8P3a2SQCj8pqyJvS+TpgqQu51+YyB4SOi2cd_WU9ObgAjZOw@mail.gmail.com>

> On Thu, Mar 31, 2022 at 10:29 AM Qin Jian <qinjian@cqplus1.com> wrote:
> > Add generic Sunplus SP7021 based board defconfig
> 
> Here, you should explain why you need a custom defconfig for this SoC, as
> most platforms are fine just using the generic one. Are you too memory
> constrained,
> or are there other problems?
> 

For memory constrained board only.

> > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> > index 8863fa969..a3bd9dbd8 100644
> > --- a/arch/arm/configs/multi_v7_defconfig
> > +++ b/arch/arm/configs/multi_v7_defconfig
> > @@ -86,6 +86,7 @@ CONFIG_MACH_SPEAR1310=y
> >  CONFIG_MACH_SPEAR1340=y
> >  CONFIG_ARCH_STI=y
> >  CONFIG_ARCH_STM32=y
> > +CONFIG_ARCH_SUNPLUS=y
> >  CONFIG_ARCH_SUNXI=y
> >  CONFIG_ARCH_TEGRA=y
> >  CONFIG_ARCH_UNIPHIER=y
> 
> Don't you need any drivers here?
> 

Currently, all basic drivers auto enabled by mach-sunplus/Kconfig:
...
config SOC_SP7021
	bool "Sunplus SP7021 SoC support"
	depends on ARCH_SUNPLUS
	default ARCH_SUNPLUS
	select ARM_GIC
	select ARM_PSCI
	select PINCTRL
	select PINCTRL_SPPCTL
	select SERIAL_SUNPLUS
	select SERIAL_SUNPLUS_CONSOLE

and driver's Kconfig:
...
config RESET_SUNPLUS
        bool "Sunplus SoCs Reset Driver" if COMPILE_TEST
        default ARCH_SUNPLUS
...

> > diff --git a/arch/arm/configs/sp7021_defconfig b/arch/arm/configs/sp7021_defconfig
> > new file mode 100644
> > index 000000000..cda16d33a
> > --- /dev/null
> > +++ b/arch/arm/configs/sp7021_defconfig
> ...
> > +CONFIG_HAVE_ARM_ARCH_TIMER=y
> 
> I checked this one again, as most others don't enable it in the defconfig.
> 
> I don't remember if I recommended removing the 'select' from Kconfig
> in a previous round, but as that is where other platforms have it, I'd add
> it there as well.
> 

I'll move this to mach-sunplus/Kconfig.

> > +CONFIG_STAGING=y
> 
> Do you actually enable any staging drivers here? If not, I'd drop that bit.
> 

I’ll drop it.


Thanks all your comments.

WARNING: multiple messages have this Message-ID (diff)
From: "qinjian[覃健]" <qinjian@cqplus1.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Rob Herring <robh+dt@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <maz@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	"Russell King - ARM Linux" <linux@armlinux.org.uk>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	DTML <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>
Subject: RE: [PATCH v12 9/9] ARM: sp7021_defconfig: Add Sunplus SP7021 defconfig
Date: Fri, 1 Apr 2022 07:08:39 +0000	[thread overview]
Message-ID: <334463c7f78b4b25a62ddd01bba5fe06@cqplus1.com> (raw)
In-Reply-To: <CAK8P3a2SQCj8pqyJvS+TpgqQu51+YyB4SOi2cd_WU9ObgAjZOw@mail.gmail.com>

> On Thu, Mar 31, 2022 at 10:29 AM Qin Jian <qinjian@cqplus1.com> wrote:
> > Add generic Sunplus SP7021 based board defconfig
> 
> Here, you should explain why you need a custom defconfig for this SoC, as
> most platforms are fine just using the generic one. Are you too memory
> constrained,
> or are there other problems?
> 

For memory constrained board only.

> > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> > index 8863fa969..a3bd9dbd8 100644
> > --- a/arch/arm/configs/multi_v7_defconfig
> > +++ b/arch/arm/configs/multi_v7_defconfig
> > @@ -86,6 +86,7 @@ CONFIG_MACH_SPEAR1310=y
> >  CONFIG_MACH_SPEAR1340=y
> >  CONFIG_ARCH_STI=y
> >  CONFIG_ARCH_STM32=y
> > +CONFIG_ARCH_SUNPLUS=y
> >  CONFIG_ARCH_SUNXI=y
> >  CONFIG_ARCH_TEGRA=y
> >  CONFIG_ARCH_UNIPHIER=y
> 
> Don't you need any drivers here?
> 

Currently, all basic drivers auto enabled by mach-sunplus/Kconfig:
...
config SOC_SP7021
	bool "Sunplus SP7021 SoC support"
	depends on ARCH_SUNPLUS
	default ARCH_SUNPLUS
	select ARM_GIC
	select ARM_PSCI
	select PINCTRL
	select PINCTRL_SPPCTL
	select SERIAL_SUNPLUS
	select SERIAL_SUNPLUS_CONSOLE

and driver's Kconfig:
...
config RESET_SUNPLUS
        bool "Sunplus SoCs Reset Driver" if COMPILE_TEST
        default ARCH_SUNPLUS
...

> > diff --git a/arch/arm/configs/sp7021_defconfig b/arch/arm/configs/sp7021_defconfig
> > new file mode 100644
> > index 000000000..cda16d33a
> > --- /dev/null
> > +++ b/arch/arm/configs/sp7021_defconfig
> ...
> > +CONFIG_HAVE_ARM_ARCH_TIMER=y
> 
> I checked this one again, as most others don't enable it in the defconfig.
> 
> I don't remember if I recommended removing the 'select' from Kconfig
> in a previous round, but as that is where other platforms have it, I'd add
> it there as well.
> 

I'll move this to mach-sunplus/Kconfig.

> > +CONFIG_STAGING=y
> 
> Do you actually enable any staging drivers here? If not, I'd drop that bit.
> 

I’ll drop it.


Thanks all your comments.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-01  7:11 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31  8:29 [PATCH v12 0/9] Add Sunplus SP7021 SoC Support Qin Jian
2022-03-31  8:29 ` Qin Jian
2022-03-31  8:29 ` [PATCH v12 1/9] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31  8:29 ` [PATCH v12 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31  8:58   ` Arnd Bergmann
2022-03-31  8:58     ` Arnd Bergmann
2022-04-01  8:24     ` qinjian[覃健]
2022-04-01  8:24       ` qinjian[覃健]
2022-03-31  8:29 ` [PATCH v12 3/9] reset: Add Sunplus " Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31  8:59   ` Arnd Bergmann
2022-03-31  8:59     ` Arnd Bergmann
2022-03-31  8:29 ` [PATCH v12 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31 20:21   ` Krzysztof Kozlowski
2022-03-31 20:21     ` Krzysztof Kozlowski
2022-04-01  9:19     ` qinjian[覃健]
2022-04-01  9:19       ` qinjian[覃健]
2022-04-01  9:32       ` Krzysztof Kozlowski
2022-04-01  9:32         ` Krzysztof Kozlowski
2022-03-31  8:29 ` [PATCH v12 5/9] clk: Add Sunplus " Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31  9:22   ` Arnd Bergmann
2022-03-31  9:22     ` Arnd Bergmann
2022-04-01  9:47     ` qinjian[覃健]
2022-04-01  9:47       ` qinjian[覃健]
2022-04-01 10:09       ` Arnd Bergmann
2022-04-01 10:09         ` Arnd Bergmann
2022-04-02  3:37         ` qinjian[覃健]
2022-04-02  3:37           ` qinjian[覃健]
2022-03-31  8:29 ` [PATCH v12 6/9] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31 20:44   ` Rob Herring
2022-03-31 20:44     ` Rob Herring
2022-04-01  2:29     ` qinjian[覃健]
2022-04-01  2:29       ` qinjian[覃健]
2022-04-01 17:53       ` Rob Herring
2022-04-01 17:53         ` Rob Herring
2022-04-02  2:43         ` qinjian[覃健]
2022-04-02  2:43           ` qinjian[覃健]
2022-03-31  8:29 ` [PATCH v12 7/9] irqchip: Add Sunplus SP7021 interrupt controller driver Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31  9:17   ` Arnd Bergmann
2022-03-31  9:17     ` Arnd Bergmann
2022-04-01  7:17     ` qinjian[覃健]
2022-04-01  7:17       ` qinjian[覃健]
2022-03-31  8:29 ` [PATCH v12 8/9] ARM: sunplus: Add initial support for Sunplus SP7021 SoC Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31  9:03   ` Arnd Bergmann
2022-03-31  9:03     ` Arnd Bergmann
2022-03-31  8:29 ` [PATCH v12 9/9] ARM: sp7021_defconfig: Add Sunplus SP7021 defconfig Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31  9:09   ` Arnd Bergmann
2022-03-31  9:09     ` Arnd Bergmann
2022-04-01  7:08     ` qinjian[覃健] [this message]
2022-04-01  7:08       ` qinjian[覃健]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=334463c7f78b4b25a62ddd01bba5fe06@cqplus1.com \
    --to=qinjian@cqplus1.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maz@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.