All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "qinjian[覃健]" <qinjian@cqplus1.com>
Cc: "arnd@arndb.de" <arnd@arndb.de>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"maz@kernel.org" <maz@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>,
	"sboyd@kernel.org" <sboyd@kernel.org>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"krzysztof.kozlowski@canonical.com" 
	<krzysztof.kozlowski@canonical.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>
Subject: Re: [PATCH v12 6/9] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller
Date: Fri, 1 Apr 2022 12:53:14 -0500	[thread overview]
Message-ID: <Ykc8Cv/TbYlr9GxV@robh.at.kernel.org> (raw)
In-Reply-To: <3373b11528214394baae71198df3adff@cqplus1.com>

On Fri, Apr 01, 2022 at 02:29:58AM +0000, qinjian[覃健] wrote:
> > 
> > On Thu, 31 Mar 2022 16:29:53 +0800, Qin Jian wrote:
> > > Add documentation to describe Sunplus SP7021 interrupt controller bindings.
> > >
> > > Signed-off-by: Qin Jian <qinjian@cqplus1.com>
> > > ---
> > > Move 'reg' after 'compatible'
> > > ---
> > >  .../sunplus,sp7021-intc.yaml                  | 62 +++++++++++++++++++
> > >  MAINTAINERS                                   |  1 +
> > >  2 files changed, 63 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml
> > >
> > 
> > 
> > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> > there's no need to repost patches *only* to add the tags. The upstream
> > maintainer will do that for acks received on the version they apply.
> > 
> > If a tag was not added on purpose, please state why and what changed.
> 
> Changes: Move 'reg' after 'compatible'
> I did a modification based on comments from krzysztof.kozlowski@canonical.com [1]
> 
> [1] https://lore.kernel.org/all/6dbeda18-a11c-609d-7a8f-bf2e6f27aea7@kernel.org/

A trivial change like that can keep a tag especially if it came after 
the comment (not sure here).

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "qinjian[覃健]" <qinjian@cqplus1.com>
Cc: "arnd@arndb.de" <arnd@arndb.de>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"maz@kernel.org" <maz@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>,
	"sboyd@kernel.org" <sboyd@kernel.org>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"krzysztof.kozlowski@canonical.com"
	<krzysztof.kozlowski@canonical.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>
Subject: Re: [PATCH v12 6/9] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller
Date: Fri, 1 Apr 2022 12:53:14 -0500	[thread overview]
Message-ID: <Ykc8Cv/TbYlr9GxV@robh.at.kernel.org> (raw)
In-Reply-To: <3373b11528214394baae71198df3adff@cqplus1.com>

On Fri, Apr 01, 2022 at 02:29:58AM +0000, qinjian[覃健] wrote:
> > 
> > On Thu, 31 Mar 2022 16:29:53 +0800, Qin Jian wrote:
> > > Add documentation to describe Sunplus SP7021 interrupt controller bindings.
> > >
> > > Signed-off-by: Qin Jian <qinjian@cqplus1.com>
> > > ---
> > > Move 'reg' after 'compatible'
> > > ---
> > >  .../sunplus,sp7021-intc.yaml                  | 62 +++++++++++++++++++
> > >  MAINTAINERS                                   |  1 +
> > >  2 files changed, 63 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml
> > >
> > 
> > 
> > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> > there's no need to repost patches *only* to add the tags. The upstream
> > maintainer will do that for acks received on the version they apply.
> > 
> > If a tag was not added on purpose, please state why and what changed.
> 
> Changes: Move 'reg' after 'compatible'
> I did a modification based on comments from krzysztof.kozlowski@canonical.com [1]
> 
> [1] https://lore.kernel.org/all/6dbeda18-a11c-609d-7a8f-bf2e6f27aea7@kernel.org/

A trivial change like that can keep a tag especially if it came after 
the comment (not sure here).

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-01 17:53 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31  8:29 [PATCH v12 0/9] Add Sunplus SP7021 SoC Support Qin Jian
2022-03-31  8:29 ` Qin Jian
2022-03-31  8:29 ` [PATCH v12 1/9] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31  8:29 ` [PATCH v12 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31  8:58   ` Arnd Bergmann
2022-03-31  8:58     ` Arnd Bergmann
2022-04-01  8:24     ` qinjian[覃健]
2022-04-01  8:24       ` qinjian[覃健]
2022-03-31  8:29 ` [PATCH v12 3/9] reset: Add Sunplus " Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31  8:59   ` Arnd Bergmann
2022-03-31  8:59     ` Arnd Bergmann
2022-03-31  8:29 ` [PATCH v12 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31 20:21   ` Krzysztof Kozlowski
2022-03-31 20:21     ` Krzysztof Kozlowski
2022-04-01  9:19     ` qinjian[覃健]
2022-04-01  9:19       ` qinjian[覃健]
2022-04-01  9:32       ` Krzysztof Kozlowski
2022-04-01  9:32         ` Krzysztof Kozlowski
2022-03-31  8:29 ` [PATCH v12 5/9] clk: Add Sunplus " Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31  9:22   ` Arnd Bergmann
2022-03-31  9:22     ` Arnd Bergmann
2022-04-01  9:47     ` qinjian[覃健]
2022-04-01  9:47       ` qinjian[覃健]
2022-04-01 10:09       ` Arnd Bergmann
2022-04-01 10:09         ` Arnd Bergmann
2022-04-02  3:37         ` qinjian[覃健]
2022-04-02  3:37           ` qinjian[覃健]
2022-03-31  8:29 ` [PATCH v12 6/9] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31 20:44   ` Rob Herring
2022-03-31 20:44     ` Rob Herring
2022-04-01  2:29     ` qinjian[覃健]
2022-04-01  2:29       ` qinjian[覃健]
2022-04-01 17:53       ` Rob Herring [this message]
2022-04-01 17:53         ` Rob Herring
2022-04-02  2:43         ` qinjian[覃健]
2022-04-02  2:43           ` qinjian[覃健]
2022-03-31  8:29 ` [PATCH v12 7/9] irqchip: Add Sunplus SP7021 interrupt controller driver Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31  9:17   ` Arnd Bergmann
2022-03-31  9:17     ` Arnd Bergmann
2022-04-01  7:17     ` qinjian[覃健]
2022-04-01  7:17       ` qinjian[覃健]
2022-03-31  8:29 ` [PATCH v12 8/9] ARM: sunplus: Add initial support for Sunplus SP7021 SoC Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31  9:03   ` Arnd Bergmann
2022-03-31  9:03     ` Arnd Bergmann
2022-03-31  8:29 ` [PATCH v12 9/9] ARM: sp7021_defconfig: Add Sunplus SP7021 defconfig Qin Jian
2022-03-31  8:29   ` Qin Jian
2022-03-31  9:09   ` Arnd Bergmann
2022-03-31  9:09     ` Arnd Bergmann
2022-04-01  7:08     ` qinjian[覃健]
2022-04-01  7:08       ` qinjian[覃健]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ykc8Cv/TbYlr9GxV@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maz@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=qinjian@cqplus1.com \
    --cc=sboyd@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.