RE: [PATCH v12 7/9] irqchip: Add Sunplus SP7021 interrupt controller driver

From: "qinjian[覃健]" <qinjian@cqplus1.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Rob Herring <robh+dt@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <maz@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	"Russell King - ARM Linux" <linux@armlinux.org.uk>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	DTML <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>
Subject: RE: [PATCH v12 7/9] irqchip: Add Sunplus SP7021 interrupt controller driver
Date: Fri, 1 Apr 2022 07:17:52 +0000	[thread overview]
Message-ID: <49a391f2636d4bb193b80c301ce0832d@cqplus1.com> (raw)
In-Reply-To: <CAK8P3a16M3nv+TQWsC-0Pr5M2vcTttC2WWTzctMBaqdODMFX-A@mail.gmail.com>

> 
> On Thu, Mar 31, 2022 at 10:29 AM Qin Jian <qinjian@cqplus1.com> wrote:
> 
> > +#ifdef CONFIG_SMP
> > +static int sp_intc_set_affinity(struct irq_data *d, const struct cpumask *mask, bool force)
> > +{
> > +       return -EINVAL;
> > +}
> > +#endif
> > +
> > +static struct irq_chip sp_intc_chip = {
> > +       .name = "sp_intc",
> > +       .irq_ack = sp_intc_ack_irq,
> > +       .irq_mask = sp_intc_mask_irq,
> > +       .irq_unmask = sp_intc_unmask_irq,
> > +       .irq_set_type = sp_intc_set_type,
> > +#ifdef CONFIG_SMP
> > +       .irq_set_affinity = sp_intc_set_affinity,
> > +#endif
> > +};
> 
> I don't think you need to define an irq_set_affinity() callback at all if you
> just return -EINVAL, all the callers should have a check already. Even
> if you do need the function, I think you can remove the #ifdef, as long
> as the function itself can be built that way.
> 
>       Arnd

Thanks for your comments, I'll remove this empty function.