All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luis Miguel García" <ktech-39ZsbGIQGT7e5aOfsHch1g@public.gmane.org>
To: "Maciej W. Rozycki" <macro-8Y0ljV8xnLVscumT1wHf3A@public.gmane.org>
Cc: Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>,
	david+challenge-response-qokYbnrgTHEgsBAKwltoeQ@public.gmane.org,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	a.verweij-oe7qfRrRQfeEZXFvZSAUrfP6llvjuJOh@public.gmane.org
Subject: Re: acpi problem with nforce motherboards and ethernet
Date: Sat, 07 Feb 2004 07:29:20 +0100	[thread overview]
Message-ID: <402485C0.905@wanadoo.es> (raw)
In-Reply-To: <Pine.LNX.4.55.0402070021210.12260-rsPqkUlH4Vdx0R2ya2r/wqsMm+1xrEX8@public.gmane.org>

Maciej W. Rozycki wrote:

>On Thu, 5 Feb 2004, Andrew Morton wrote:
>
>  
>
>>>By the way, is anyone involved in solving the IO-APIC thing in nforce 
>>>motherboards? Anyone trying a different approach? Anyone contacting 
>>>nvidia about this problem?
>>>      
>>>
>>As far as I know, we're dead in the water on these problems.
>>    
>>
>
> Not necessarily. :-)
>
>  
>
>>Here's one:
>>
>>
>>[x86] do not wrongly override mp_ExtINT IRQ
>>
>>From: Mathieu <cheuche+lkml-GANU6spQydw@public.gmane.org>.
>>
>>With this patch timer IRQ0 is correctly set to IO-APIC-edge
>>(not XT-PIC) on nForce2 boards when using APIC and ACPI.
>>
>> arch/i386/kernel/mpparse.c |    3 ++-
>> 1 files changed, 2 insertions(+), 1 deletion(-)
>>
>>diff -puN arch/i386/kernel/mpparse.c~nforce2-apic arch/i386/kernel/mpparse.c
>>--- linux-2.6.0-test11/arch/i386/kernel/mpparse.c~nforce2-apic	2003-12-08 00:12:25.782597272 +0100
>>+++ linux-2.6.0-test11-root/arch/i386/kernel/mpparse.c	2003-12-08 00:12:25.786596664 +0100
>>@@ -962,7 +962,8 @@ void __init mp_override_legacy_irq (
>> 	 */
>> 	for (i = 0; i < mp_irq_entries; i++) {
>> 		if ((mp_irqs[i].mpc_dstapic == intsrc.mpc_dstapic) 
>>-			&& (mp_irqs[i].mpc_srcbusirq == intsrc.mpc_srcbusirq)) {
>>+			&& (mp_irqs[i].mpc_srcbusirq == intsrc.mpc_srcbusirq)
>>+			&& (mp_irqs[i].mpc_irqtype == intsrc.mpc_irqtype)) {
>> 			mp_irqs[i] = intsrc;
>> 			found = 1;
>> 			break;
>>    
>>
>
> That's not the right fix.  There's a bug in Linux's ACPI IRQ setup as
>I've discovered by comparing the code to the spec.  Here's a patch I sent
>in December both to the LKML and the ACPI maintainer.  The feedback from
>the list was positive, but the maintainer didn't bother to comment.
>
> I haven't pushed the patch more firmly, because the MIPS port is my
>priority and I don't even have any ACPI-aware equipment.
>
> Maciej
>
>  
>
Can you send us the specific patch or at least telling us if you're 
going to push it?

Thanks a lot for the fix ;)

LuisMi Garcia


-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn

WARNING: multiple messages have this Message-ID (diff)
From: "Luis Miguel García" <ktech@wanadoo.es>
To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Cc: Andrew Morton <akpm@osdl.org>,
	david+challenge-response@blue-labs.org,
	acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	a.verweij@student.tudelft.nl
Subject: Re: [ACPI] acpi problem with nforce motherboards and ethernet
Date: Sat, 07 Feb 2004 07:29:20 +0100	[thread overview]
Message-ID: <402485C0.905@wanadoo.es> (raw)
In-Reply-To: <Pine.LNX.4.55.0402070021210.12260@jurand.ds.pg.gda.pl>

Maciej W. Rozycki wrote:

>On Thu, 5 Feb 2004, Andrew Morton wrote:
>
>  
>
>>>By the way, is anyone involved in solving the IO-APIC thing in nforce 
>>>motherboards? Anyone trying a different approach? Anyone contacting 
>>>nvidia about this problem?
>>>      
>>>
>>As far as I know, we're dead in the water on these problems.
>>    
>>
>
> Not necessarily. :-)
>
>  
>
>>Here's one:
>>
>>
>>[x86] do not wrongly override mp_ExtINT IRQ
>>
>>From: Mathieu <cheuche+lkml@free.fr>.
>>
>>With this patch timer IRQ0 is correctly set to IO-APIC-edge
>>(not XT-PIC) on nForce2 boards when using APIC and ACPI.
>>
>> arch/i386/kernel/mpparse.c |    3 ++-
>> 1 files changed, 2 insertions(+), 1 deletion(-)
>>
>>diff -puN arch/i386/kernel/mpparse.c~nforce2-apic arch/i386/kernel/mpparse.c
>>--- linux-2.6.0-test11/arch/i386/kernel/mpparse.c~nforce2-apic	2003-12-08 00:12:25.782597272 +0100
>>+++ linux-2.6.0-test11-root/arch/i386/kernel/mpparse.c	2003-12-08 00:12:25.786596664 +0100
>>@@ -962,7 +962,8 @@ void __init mp_override_legacy_irq (
>> 	 */
>> 	for (i = 0; i < mp_irq_entries; i++) {
>> 		if ((mp_irqs[i].mpc_dstapic == intsrc.mpc_dstapic) 
>>-			&& (mp_irqs[i].mpc_srcbusirq == intsrc.mpc_srcbusirq)) {
>>+			&& (mp_irqs[i].mpc_srcbusirq == intsrc.mpc_srcbusirq)
>>+			&& (mp_irqs[i].mpc_irqtype == intsrc.mpc_irqtype)) {
>> 			mp_irqs[i] = intsrc;
>> 			found = 1;
>> 			break;
>>    
>>
>
> That's not the right fix.  There's a bug in Linux's ACPI IRQ setup as
>I've discovered by comparing the code to the spec.  Here's a patch I sent
>in December both to the LKML and the ACPI maintainer.  The feedback from
>the list was positive, but the maintainer didn't bother to comment.
>
> I haven't pushed the patch more firmly, because the MIPS port is my
>priority and I don't even have any ACPI-aware equipment.
>
> Maciej
>
>  
>
Can you send us the specific patch or at least telling us if you're 
going to push it?

Thanks a lot for the fix ;)

LuisMi Garcia

  parent reply	other threads:[~2004-02-07  6:29 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-05 19:25 acpi problem with nforce motherboards and ethernet Luis Miguel García
2004-02-05 19:25 ` [ACPI] " Luis Miguel García
     [not found] ` <402298C7.5050405-39ZsbGIQGT7e5aOfsHch1g@public.gmane.org>
2004-02-05 19:44   ` David Ford
2004-02-05 19:44     ` [ACPI] " David Ford
     [not found]     ` <40229D2C.20701-qokYbnrgTHEgsBAKwltoeQ@public.gmane.org>
2004-02-05 21:27       ` Luis Miguel García
2004-02-05 21:27         ` [ACPI] " Luis Miguel García
     [not found]         ` <4022B55B.1090309-39ZsbGIQGT7e5aOfsHch1g@public.gmane.org>
2004-02-05 23:40           ` Andrew Morton
2004-02-05 23:40             ` [ACPI] " Andrew Morton
     [not found]             ` <20040205154059.6649dd74.akpm-3NddpPZAyC0@public.gmane.org>
2004-02-06  0:08               ` Prakash K. Cheemplavam
2004-02-06  0:08                 ` [ACPI] " Prakash K. Cheemplavam
2004-02-06  0:14               ` Craig Bradney
2004-02-06  0:14                 ` [ACPI] " Craig Bradney
     [not found]                 ` <1076026496.16107.23.camel-V9bJ71E8C7qMuHbpHUh99CT4j+jCus6s@public.gmane.org>
2004-02-06  0:22                   ` Luis Miguel García
2004-02-06  0:22                     ` [ACPI] " Luis Miguel García
     [not found]                     ` <4022DE3C.1080905-39ZsbGIQGT7e5aOfsHch1g@public.gmane.org>
2004-02-06  0:38                       ` Prakash K. Cheemplavam
2004-02-06  0:38                         ` [ACPI] " Prakash K. Cheemplavam
2004-02-06  0:46                         ` Luis Miguel García
2004-02-06  0:58                           ` Prakash K. Cheemplavam
2004-02-06  1:01                             ` Craig Bradney
2004-02-06  1:09                               ` Luis Miguel García
2004-02-06  9:28                                 ` Prakash K. Cheemplavam
2004-02-06  9:26                               ` Prakash K. Cheemplavam
2004-02-06 10:07                                 ` Craig Bradney
2004-02-06 10:40                                   ` Prakash K. Cheemplavam
2004-02-06  9:44                                     ` Daniel Drake
2004-02-06 11:04                                       ` Prakash K. Cheemplavam
2004-02-06 11:15                                         ` Prakash K. Cheemplavam
2004-02-06 12:51                                           ` Craig Bradney
2004-02-06 13:10                                             ` Arjen Verweij
2004-02-06 13:20                                             ` Prakash K. Cheemplavam
2004-02-06 13:34                                             ` Arjen Verweij
2004-02-06 13:41                                               ` Prakash K. Cheemplavam
2004-02-06 13:43                                               ` Prakash K. Cheemplavam
2004-02-06 11:08                                   ` Craig Bradney
     [not found]                           ` <4022E3C8.4020704-39ZsbGIQGT7e5aOfsHch1g@public.gmane.org>
2004-02-06  0:59                             ` Craig Bradney
2004-02-06  0:59                               ` [ACPI] " Craig Bradney
2004-02-06  0:56                       ` Craig Bradney
2004-02-06  0:56                         ` [ACPI] " Craig Bradney
2004-02-06 23:33               ` Maciej W. Rozycki
2004-02-06 23:33                 ` [ACPI] " Maciej W. Rozycki
2004-02-07  2:50                 ` Andi Kleen
2004-02-07  6:39                   ` Josh McKinney
2004-02-07 10:04                     ` Maciej W. Rozycki
     [not found]                 ` <Pine.LNX.4.55.0402070021210.12260-rsPqkUlH4Vdx0R2ya2r/wqsMm+1xrEX8@public.gmane.org>
2004-02-07  6:29                   ` Luis Miguel García [this message]
2004-02-07  6:29                     ` Luis Miguel García
2004-02-06  9:47           ` Daniel Drake
2004-02-06  9:47             ` [ACPI] " Daniel Drake
  -- strict thread matches above, loose matches on Subject: below --
2004-02-05 17:41 Luis Miguel García
2004-02-05 17:41 ` Luis Miguel García

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=402485C0.905@wanadoo.es \
    --to=ktech-39zsbgiqgt7e5aofshch1g@public.gmane.org \
    --cc=a.verweij-oe7qfRrRQfeEZXFvZSAUrfP6llvjuJOh@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=akpm-3NddpPZAyC0@public.gmane.org \
    --cc=david+challenge-response-qokYbnrgTHEgsBAKwltoeQ@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=macro-8Y0ljV8xnLVscumT1wHf3A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.