sparc64 port

sparc64 port

[Vincent Pelletier]

[-- Attachment #1: Type: text/plain, Size: 2542 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I fixed the sparc64 port.
Current status is : rescue mode works, it can only be netbooted, no
module support, no utils (grub-emu, grub-install,...)

I separate the Changelog in 2 parts, one for the changes I made that
could interfere with the other ports (sparc_common.diff), and another
for the added files (sparc64_files.tar.bz2). It should add only needed
files & directories.

I added /* FIXME (sparc64).  */ in each file that contains hard-coded
values that might not be appropriate for sparc64 port. They come from
powerpc port but I don't know what to set instead. Could be in files I
don't use yet (like setjmp.h).

	2005-08-20  Vincent Pelletier  <subdino2004@yahoo.fr>
	
	* configure.ac: Add support for sparc64 host with ieee1275
	firmware.
	* configure: Generated from configure.ac.
	* disk/ieee1275/ofdisk.c (grub_ofdisk_open): use grub_ssize_t
	instead of int.
	(grub_ofdisk_read): Likewise.
	(grub_ofdisk_open): Use %p to print pointer values, and cast the
	pointers as (void *) to remove a warning.
	(grub_ofdisk_close): Likewise.
	(grub_ofdisk_read): Likewise.
	* kern/ieee1275/ieee1275.c (grub_ieee1275_exit): This never
	returns, so make it return void to remove a warning.
	* include/grub/ieee1275/ieee1275.h (grub_ieee1275_exit):
	Corresponding prototype change.
	* kern/mm.c (grub_mm_init_region): Use %p to print pointer
	values, and cast the pointers as (void *) to remove a warning.
	(grub_mm_dump): Likewise.

	2005-08-20  Vincent Pelletier  <subdino2004@yahoo.fr>
	
	* boot/sparc64: New directory.
	* boot/sparc64/ieee1275: New directory.
	* boot/sparc64/ieee1275/cmain.c: New file.
	* conf/sparc64-ieee1275.mk: New file.
	* conf/sparc64-ieee1275.rmk: New file.
	* include/grub/sparc64: New directory.
	* include/grub/sparc64/setjmp.h: New file.
	* include/grub/sparc64/types.h: New file.
	* include/grub/sparc64/ieee1275: New directory.
	* include/grub/sparc64/ieee1275/console.h: New file.
	* include/grub/sparc64/ieee1275/ieee1275.h: New file.
	* include/grub/sparc64/ieee1275/kernel.h: New file.
	* include/grub/sparc64/ieee1275/time.h: New file.
	* kern/sparc64: New directory.
	* kern/sparc64/cache.c: New file.
	* kern/sparc64/dl.c: New file.
	* kern/sparc64/ieee1275: New directory.
	* kern/sparc64/ieee1275/init.c: New file.
	* kern/sparc64/ieee1275/openfw.c: New file.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDBxa3FEQoKRQyjtURArmEAJ45AqBteOR4vSto4ssu/jl5NwosXQCgsio/
m9dBbZzRGeKT5mqEcr7/Zr4=
=mU/+
-----END PGP SIGNATURE-----

[-- Attachment #2: sparc64_common.diff --]
[-- Type: audio/x-mp3, Size: 5774 bytes --]

[-- Attachment #3: sparc64_files.tar.bz2 --]
[-- Type: application/x-bzip, Size: 9863 bytes --]

Re: sparc64 port

[Yoshinori K. Okuji]

On Saturday 20 August 2005 13:40, Vincent Pelletier wrote:
> 	* boot/sparc64/ieee1275/cmain.c: New file.

This is wrong. I guess you just followed the powerpc port, but it is also 
wrong. Instead, this file must be put in the kernel. The directory boot is 
used to organize files for the bootstrap of the kernel, which are not a part 
of the kernel.

In principle, the kernel should not be linked with a file in another 
directory. Unfortunately, this is not always true, in order to solve "chicken 
and egg" problems. Nevertheless, we should try to make the kernel as much 
independent of other directories as possible.

>       * kern/sparc64/cache.c: New file.

The contents of this file is strange. Why don't you simply include 
grub/cache.h?

About the ChangeLog:

Please do not mention new directories. They are not worth describing, because 
they don't cause bugs, and they are not related to copyright problems.

Please use simply "Likewise" when you repeat the same description. This is not 
obligatory, but often easier to read.

Okuji

Re: sparc64 port

[Vincent Pelletier]

[-- Attachment #1: Type: text/plain, Size: 1937 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Yoshinori K. Okuji wrote:
> On Saturday 20 August 2005 13:40, Vincent Pelletier wrote:
>>	* boot/sparc64/ieee1275/cmain.c: New file.
> This is wrong.

Corrected.

>>       * kern/sparc64/cache.c: New file.
> The contents of this file is strange. Why don't you simply include 
> grub/cache.h?

Done.

	2005-08-20  Vincent Pelletier  <subdino2004@yahoo.fr>

	* configure.ac: Add support for sparc64 host with ieee1275
	firmware.
	* configure: Generated from configure.ac.
	* disk/ieee1275/ofdisk.c (grub_ofdisk_open): use grub_ssize_t
	instead of int.
	(grub_ofdisk_read): Likewise.
	(grub_ofdisk_open): Use %p to print pointer values, and cast the
	pointers as (void *) to remove a warning.
	(grub_ofdisk_close): Likewise.
	(grub_ofdisk_read): Likewise.
	* kern/ieee1275/ieee1275.c (grub_ieee1275_exit): This never
	returns, so make it return void to remove a warning.
	* include/grub/ieee1275/ieee1275.h (grub_ieee1275_exit):
	Corresponding prototype change.
	* kern/mm.c (grub_mm_init_region): Use %p to print pointer
	values, and cast the pointers as (void *) to remove a warning.
	(grub_mm_dump): Likewise.

	2005-08-20  Vincent Pelletier  <subdino2004@yahoo.fr>

	* conf/sparc64-ieee1275.mk: New file.
	* conf/sparc64-ieee1275.rmk: Likewise.
	* include/grub/sparc64/setjmp.h: Likewise.
	* include/grub/sparc64/types.h: Likewise.
	* include/grub/sparc64/ieee1275/console.h: Likewise.
	* include/grub/sparc64/ieee1275/ieee1275.h: Likewise.
	* include/grub/sparc64/ieee1275/kernel.h: Likewise.
	* include/grub/sparc64/ieee1275/time.h: Likewise.
	* kern/sparc64/cache.c: Likewise.
	* kern/sparc64/dl.c: Likewise.
	* kern/sparc64/ieee1275/init.c: Likewise.
	* kern/sparc64/ieee1275/openfw.c: Likewise.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDBzdMFEQoKRQyjtURApAOAKCrh0SBed8sT+RdIxjSg4md23rkrACbBOTj
xya2F+fAkszTpaD9eieLgrk=
=6Cqh
-----END PGP SIGNATURE-----

[-- Attachment #2: sparc64_common.diff --]
[-- Type: audio/x-mp3, Size: 5774 bytes --]

[-- Attachment #3: sparc64_files.tar.bz2 --]
[-- Type: application/x-bzip, Size: 9654 bytes --]

Re: sparc64 port

[Yoshinori K. Okuji]

Go ahead. I don't see anything wrong any more.

Okuji

Re: sparc64 port

[Marco Gerards]

Vincent Pelletier <subdino2004@yahoo.fr> writes:

Hi Vincent,

This is really nice!  Thanks a lot.  You asked me on IRC if I can test
if it still builds on the PPC.  I will test that (and let you know on
IRC), after that you can commit the patch if you fix the things I
mention in my email and Okuji mentioned in his.


> 	* disk/ieee1275/ofdisk.c (grub_ofdisk_open): use grub_ssize_t
> 	instead of int.

Please start sentences with an uppercase letter, same for the other
entries.


Some files are not GPL'ed (cache.c, for example).  The copyright years
are not always correct, like that of ieee1275.h (you wrote it, so it
should be (C) 2005 only).

Can't openfw.c be shared?  I think it can be...

Thanks,
Marco

Re: sparc64 port

[Vincent Pelletier]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=us-ascii, Size: 1082 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Marco Gerards wrote:
> Please start sentences with an uppercase letter, same for the other
> entries.

Oops.

> Some files are not GPL'ed (cache.c, for example).  The copyright years
> are not always correct, like that of ieee1275.h (you wrote it, so it
> should be (C) 2005 only).

(bis repetita).

> Can't openfw.c be shared?  I think it can be...

I think too. The worse it that both powerpc and sparc versions are
conflicting : both have been modified since I originally extracted the
powerpc version. Going to resolve the problems, and I'll patch a common
version to be checked in before my port.

Vincent Pelletier
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDB0dHFEQoKRQyjtURAnYFAJ0e23MrnkEiDua5dsDuzcrF4DNKkQCfeMu1
vrwwuyXQ/rB1tOtJSNF2J+A=
=AZqu
-----END PGP SIGNATURE-----

	

	
		
___________________________________________________________________________ 
Appel audio GRATUIT partout dans le monde avec le nouveau Yahoo! Messenger 
Téléchargez cette version sur http://fr.messenger.yahoo.com