All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Willy Tarreau <willy@w.ods.org>
Cc: sfrost@snowman.net, gcoady.lk@gmail.com, laforge@netfilter.org,
	Jesper Juhl <jesper.juhl@gmail.com>,
	netfilter-devel@lists.netfilter.org,
	linux-kernel@vger.kernel.org, marcelo@kvack.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] fix mem-leak in netfilter
Date: Fri, 12 May 2006 14:49:31 +0200	[thread overview]
Message-ID: <4464845B.3010502@trash.net> (raw)
In-Reply-To: <20060512124041.GA31714@w.ods.org>

Willy Tarreau wrote:
> Please post it to the list, this coding style needs far more than two
> pairs of eyes to be fixed. It has already discouraged several people,
> the more we will be, the least pain we will feel :-)

:)

I actually just got to fed up with this garbage (once again) and started
rewriting it from scratch, which looks like a lot less pain. I'll look
into these loops again for 2.4 and 2.6.17 once I'm done doing that.

WARNING: multiple messages have this Message-ID (diff)
From: Patrick McHardy <kaber@trash.net>
To: Willy Tarreau <willy@w.ods.org>
Cc: Jesper Juhl <jesper.juhl@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	sfrost@snowman.net, gcoady.lk@gmail.com, laforge@netfilter.org,
	netfilter-devel@lists.netfilter.org,
	linux-kernel@vger.kernel.org, marcelo@kvack.org
Subject: Re: [PATCH] fix mem-leak in netfilter
Date: Fri, 12 May 2006 14:49:31 +0200	[thread overview]
Message-ID: <4464845B.3010502@trash.net> (raw)
In-Reply-To: <20060512124041.GA31714@w.ods.org>

Willy Tarreau wrote:
> Please post it to the list, this coding style needs far more than two
> pairs of eyes to be fixed. It has already discouraged several people,
> the more we will be, the least pain we will feel :-)

:)

I actually just got to fed up with this garbage (once again) and started
rewriting it from scratch, which looks like a lot less pain. I'll look
into these loops again for 2.4 and 2.6.17 once I'm done doing that.


  reply	other threads:[~2006-05-12 12:49 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-07  2:26 [PATCH] fix mem-leak in netfilter Jesper Juhl
2006-05-07  9:36 ` Willy Tarreau
2006-05-07  9:36   ` Willy Tarreau
2006-05-07 22:42   ` Grant Coady
2006-05-08  5:07     ` Willy Tarreau
2006-05-08  5:43       ` David S. Miller
2006-05-08  5:43         ` David S. Miller
2006-05-08  8:36         ` Amin Azez
2006-05-08  8:36           ` Amin Azez
2006-05-08  9:08           ` Juergen Kreileder
2006-05-08  9:08             ` Juergen Kreileder
2006-05-12  7:40         ` Patrick McHardy
2006-05-12  7:40           ` Patrick McHardy
2006-05-12 11:09           ` Jesper Juhl
2006-05-12 11:33             ` Patrick McHardy
2006-05-12 12:13               ` Jesper Juhl
2006-05-12 12:40                 ` Willy Tarreau
2006-05-12 12:40                   ` Willy Tarreau
2006-05-12 12:49                   ` Patrick McHardy [this message]
2006-05-12 12:49                     ` Patrick McHardy
2006-05-12 13:42               ` Amin Azez
2006-05-15  8:25                 ` Patrick McHardy
2006-05-15  8:25                   ` Patrick McHardy
2006-05-15 14:28                   ` Stephen Frost
2006-05-15 14:28                     ` Stephen Frost
2006-05-15 18:49                     ` Patrick McHardy
2006-05-15 18:49                       ` Patrick McHardy
2006-05-15 19:27                       ` Stephen Frost
2006-05-15 19:27                         ` Stephen Frost
2006-05-15 20:09                         ` Patrick McHardy
2006-05-15 20:09                           ` Patrick McHardy
2006-05-15 20:41                           ` Stephen Frost
2006-05-15 20:41                             ` Stephen Frost
2006-05-15 20:45                             ` Patrick McHardy
2006-05-15 20:45                               ` Patrick McHardy
2006-05-15 21:03                             ` Stephen Frost
2006-05-17  6:26                               ` Patrick McHardy
2006-05-17  6:59                                 ` David S. Miller
2006-05-17  6:59                                   ` David S. Miller
2006-05-17  7:19                                   ` Patrick McHardy
2006-05-17  7:19                                     ` Patrick McHardy
2006-05-17 10:55                                     ` Stephen Frost
2006-05-17  7:09                                 ` David S. Miller
2006-05-17  7:13                                   ` Roland Dreier
2006-05-17  7:19                                   ` Patrick McHardy
2006-05-17 13:14                                 ` Stephen Frost
2006-05-17 13:14                                   ` Stephen Frost
2006-06-01 13:43                                 ` Andrew James Wade
2006-06-01 14:53                                   ` Patrick McHardy
2006-06-02 21:32                                     ` Andrew James Wade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4464845B.3010502@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=gcoady.lk@gmail.com \
    --cc=jesper.juhl@gmail.com \
    --cc=laforge@netfilter.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@kvack.org \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=sfrost@snowman.net \
    --cc=willy@w.ods.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.