From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: sfrost@snowman.net, gcoady.lk@gmail.com, laforge@netfilter.org,
netfilter-devel@lists.netfilter.org,
linux-kernel@vger.kernel.org, marcelo@kvack.org, willy@w.ods.org,
azez@ufomechanic.net
Subject: Re: [PATCH] fix mem-leak in netfilter
Date: Wed, 17 May 2006 09:19:03 +0200 [thread overview]
Message-ID: <446ACE67.4030700@trash.net> (raw)
In-Reply-To: <20060516.235910.71774114.davem@davemloft.net>
David S. Miller wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Wed, 17 May 2006 08:26:03 +0200
>
>>OK, updated patch attached. The TTL is now always kept up-to-date.
>
>
> Looks nice.
>
> Is there any reasonable reason to allow ip_pkt_list_tot to ever be
> larger than say 255? If we can accept that limit, we can shrink
> the recent_entry considerably by packing the index and nstamps
> into a single word next to ttl.
My primary goal was full compatibility, I have no idea about real-life
usage though. Maybe Stephen can answer this.
WARNING: multiple messages have this Message-ID (diff)
From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: sfrost@snowman.net, azez@ufomechanic.net, willy@w.ods.org,
gcoady.lk@gmail.com, laforge@netfilter.org,
netfilter-devel@lists.netfilter.org,
linux-kernel@vger.kernel.org, marcelo@kvack.org
Subject: Re: [PATCH] fix mem-leak in netfilter
Date: Wed, 17 May 2006 09:19:03 +0200 [thread overview]
Message-ID: <446ACE67.4030700@trash.net> (raw)
In-Reply-To: <20060516.235910.71774114.davem@davemloft.net>
David S. Miller wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Wed, 17 May 2006 08:26:03 +0200
>
>>OK, updated patch attached. The TTL is now always kept up-to-date.
>
>
> Looks nice.
>
> Is there any reasonable reason to allow ip_pkt_list_tot to ever be
> larger than say 255? If we can accept that limit, we can shrink
> the recent_entry considerably by packing the index and nstamps
> into a single word next to ttl.
My primary goal was full compatibility, I have no idea about real-life
usage though. Maybe Stephen can answer this.
next prev parent reply other threads:[~2006-05-17 7:19 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-07 2:26 [PATCH] fix mem-leak in netfilter Jesper Juhl
2006-05-07 9:36 ` Willy Tarreau
2006-05-07 9:36 ` Willy Tarreau
2006-05-07 22:42 ` Grant Coady
2006-05-08 5:07 ` Willy Tarreau
2006-05-08 5:43 ` David S. Miller
2006-05-08 5:43 ` David S. Miller
2006-05-08 8:36 ` Amin Azez
2006-05-08 8:36 ` Amin Azez
2006-05-08 9:08 ` Juergen Kreileder
2006-05-08 9:08 ` Juergen Kreileder
2006-05-12 7:40 ` Patrick McHardy
2006-05-12 7:40 ` Patrick McHardy
2006-05-12 11:09 ` Jesper Juhl
2006-05-12 11:33 ` Patrick McHardy
2006-05-12 12:13 ` Jesper Juhl
2006-05-12 12:40 ` Willy Tarreau
2006-05-12 12:40 ` Willy Tarreau
2006-05-12 12:49 ` Patrick McHardy
2006-05-12 12:49 ` Patrick McHardy
2006-05-12 13:42 ` Amin Azez
2006-05-15 8:25 ` Patrick McHardy
2006-05-15 8:25 ` Patrick McHardy
2006-05-15 14:28 ` Stephen Frost
2006-05-15 14:28 ` Stephen Frost
2006-05-15 18:49 ` Patrick McHardy
2006-05-15 18:49 ` Patrick McHardy
2006-05-15 19:27 ` Stephen Frost
2006-05-15 19:27 ` Stephen Frost
2006-05-15 20:09 ` Patrick McHardy
2006-05-15 20:09 ` Patrick McHardy
2006-05-15 20:41 ` Stephen Frost
2006-05-15 20:41 ` Stephen Frost
2006-05-15 20:45 ` Patrick McHardy
2006-05-15 20:45 ` Patrick McHardy
2006-05-15 21:03 ` Stephen Frost
2006-05-17 6:26 ` Patrick McHardy
2006-05-17 6:59 ` David S. Miller
2006-05-17 6:59 ` David S. Miller
2006-05-17 7:19 ` Patrick McHardy [this message]
2006-05-17 7:19 ` Patrick McHardy
2006-05-17 10:55 ` Stephen Frost
2006-05-17 7:09 ` David S. Miller
2006-05-17 7:13 ` Roland Dreier
2006-05-17 7:19 ` Patrick McHardy
2006-05-17 13:14 ` Stephen Frost
2006-05-17 13:14 ` Stephen Frost
2006-06-01 13:43 ` Andrew James Wade
2006-06-01 14:53 ` Patrick McHardy
2006-06-02 21:32 ` Andrew James Wade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446ACE67.4030700@trash.net \
--to=kaber@trash.net \
--cc=azez@ufomechanic.net \
--cc=davem@davemloft.net \
--cc=gcoady.lk@gmail.com \
--cc=laforge@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@kvack.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=sfrost@snowman.net \
--cc=willy@w.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.