All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Gary Zambrano <zambrano@broadcom.com>
Cc: Michael Buesch <mb@bu3sch.de>,
	Maximilian Engelhardt <maxi@daemonizer.de>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Stephen Hemminger <shemminger@linux-foundation.org>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: b44: regression in 2.6.22 (resend)
Date: Tue, 29 May 2007 18:39:31 -0400	[thread overview]
Message-ID: <465CABA3.10003@pobox.com> (raw)
In-Reply-To: <1180472741.17711.19.camel@dhcp-10-12-136-115.broadcom.com>

Gary Zambrano wrote:
> The b44 interrupt status reg returns a value of 0 if no interrupts are
> pending. The b44 uses a mask to determine which bits (events) can
> generate device interrupts on the system. If the masked interrupt status
> register bits are not asserted, then the b44 will return to the system
> with handled = 0. 
> So, I think the way the b44 interrupt code is written should be ok and
> not a bug. 


This is normal.

We check for 0xffffffff because that is often how a fault is indicated, 
when the memory location is read during or immediately after hotplug (or 
if the PCI bus is truly faulty).  So for most hardware, you see

tmp = read(irq status)
if (!tmp)
	return irq-none		/* no irq events raised */
if (tmp == 0xffffffff)
	return irq-none		/* hot unplug or h/w fault */

and the method that determines no interrupt handling is needed.

Regards,

	Jeff



WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jgarzik-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
To: Gary Zambrano <zambrano-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Cc: Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>,
	Maximilian Engelhardt
	<maxi-OwNUvPV92VfddJNmlsFzeA@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-wireless
	<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Stephen Hemminger
	<shemminger-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	Arnaldo Carvalho de Melo
	<acme-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org>,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: b44: regression in 2.6.22 (resend)
Date: Tue, 29 May 2007 18:39:31 -0400	[thread overview]
Message-ID: <465CABA3.10003@pobox.com> (raw)
In-Reply-To: <1180472741.17711.19.camel-opBMJL+S1+nCw/J+WP9nZ0NK2P1VvzQgpWgKQ6/u3Fg@public.gmane.org>

Gary Zambrano wrote:
> The b44 interrupt status reg returns a value of 0 if no interrupts are
> pending. The b44 uses a mask to determine which bits (events) can
> generate device interrupts on the system. If the masked interrupt status
> register bits are not asserted, then the b44 will return to the system
> with handled = 0. 
> So, I think the way the b44 interrupt code is written should be ok and
> not a bug. 


This is normal.

We check for 0xffffffff because that is often how a fault is indicated, 
when the memory location is read during or immediately after hotplug (or 
if the PCI bus is truly faulty).  So for most hardware, you see

tmp = read(irq status)
if (!tmp)
	return irq-none		/* no irq events raised */
if (tmp == 0xffffffff)
	return irq-none		/* hot unplug or h/w fault */

and the method that determines no interrupt handling is needed.

Regards,

	Jeff

  reply	other threads:[~2007-05-29 22:39 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-26  0:24 b44: regression in 2.6.22 Stephen Hemminger
2007-05-26  3:51 ` Gary Zambrano
2007-05-26 17:01 ` Michael Buesch
2007-05-27 19:25   ` b44: regression in 2.6.22 (resend) Maximilian Engelhardt
2007-05-27 19:25     ` Maximilian Engelhardt
2007-05-27 19:45     ` Michael Buesch
2007-05-27 19:45       ` Michael Buesch
2007-05-27 20:36       ` Maximilian Engelhardt
2007-05-27 20:36         ` Maximilian Engelhardt
2007-05-27 20:46         ` Michael Buesch
2007-05-27 20:46           ` Michael Buesch
2007-05-27 21:46           ` Maximilian Engelhardt
2007-05-27 21:46             ` Maximilian Engelhardt
2007-05-27 21:13     ` Michael Buesch
2007-05-27 21:13       ` Michael Buesch
2007-05-27 21:16       ` Michael Buesch
2007-05-27 21:50         ` Maximilian Engelhardt
2007-05-27 21:50           ` Maximilian Engelhardt
2007-05-27 22:15       ` Maximilian Engelhardt
2007-05-27 22:15         ` Maximilian Engelhardt
2007-05-28  0:24         ` Michael Buesch
2007-05-28  0:40           ` Maximilian Engelhardt
2007-05-28  0:40             ` Maximilian Engelhardt
2007-05-28 10:16             ` Michael Buesch
2007-05-28 10:16               ` Michael Buesch
2007-05-28 14:09               ` Maximilian Engelhardt
2007-05-28 14:09                 ` Maximilian Engelhardt
2007-05-28 15:14                 ` Michael Buesch
2007-05-28 15:14                   ` Michael Buesch
2007-05-28 15:32                   ` Thomas Gleixner
2007-05-28 15:32                     ` Thomas Gleixner
2007-05-28 15:43                     ` Michael Buesch
2007-05-28 15:43                       ` Michael Buesch
2007-05-28 17:44                     ` Maximilian Engelhardt
2007-05-28 19:23                       ` Thomas Gleixner
2007-05-28 20:55                         ` Maximilian Engelhardt
2007-05-28 21:45                           ` Thomas Gleixner
2007-05-29 18:28                             ` Maximilian Engelhardt
2007-05-29 18:28                               ` Maximilian Engelhardt
2007-05-29 13:58                           ` Gary Zambrano
2007-05-29 13:58                             ` Gary Zambrano
2007-05-29 17:23                             ` Maximilian Engelhardt
2007-05-29 17:23                               ` Maximilian Engelhardt
2007-06-03 16:26                         ` Maximilian Engelhardt
2007-06-04  6:39                           ` Thomas Gleixner
2007-06-04  6:39                             ` Thomas Gleixner
2007-06-04 16:09                             ` Stephen Hemminger
2007-06-04 16:09                               ` Stephen Hemminger
2007-06-04 16:35                               ` Thomas Gleixner
2007-06-04 16:35                                 ` Thomas Gleixner
2007-06-04 16:59                                 ` iperf: performance regression (was b44 driver problem?) Stephen Hemminger
2007-06-04 17:32                                   ` Thomas Gleixner
2007-06-04 17:32                                     ` Thomas Gleixner
2007-06-04 17:51                                     ` Stephen Hemminger
2007-06-04 19:00                                       ` Thomas Gleixner
2007-06-04 19:26                                         ` Thomas Gleixner
2007-06-04 19:26                                           ` Thomas Gleixner
2007-06-04 19:32                                       ` Ingo Molnar
2007-06-04 19:47                                         ` Maximilian Engelhardt
2007-06-04 20:02                                           ` Stephen Hemminger
2007-06-04 20:52                                             ` Maximilian Engelhardt
2007-06-04 20:52                                               ` Maximilian Engelhardt
2007-05-28 10:49             ` b44: regression in 2.6.22 (resend) Michael Buesch
2007-05-28 14:12               ` Maximilian Engelhardt
2007-05-28 14:12                 ` Maximilian Engelhardt
2007-05-28 14:55                 ` Michael Buesch
2007-05-29 14:14                   ` Gary Zambrano
2007-05-29 20:45                     ` Michael Buesch
2007-05-29 20:45                       ` Michael Buesch
2007-05-29 21:01                       ` Stephen Hemminger
2007-05-29 21:01                         ` Stephen Hemminger
2007-05-29 21:05                       ` Gary Zambrano
2007-05-29 21:05                         ` Gary Zambrano
2007-05-29 22:39                         ` Jeff Garzik [this message]
2007-05-29 22:39                           ` Jeff Garzik
2007-05-29 21:36                           ` Gary Zambrano
2007-05-29 21:36                             ` Gary Zambrano
2007-05-30 10:45                             ` Michael Buesch
  -- strict thread matches above, loose matches on Subject: below --
2007-05-28 23:00 Uwe Bugla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=465CABA3.10003@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=acme@ghostprotocols.net \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=maxi@daemonizer.de \
    --cc=mb@bu3sch.de \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    --cc=zambrano@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.