* distclean failure
@ 2008-08-01 14:14 Christoph Egger
2008-08-01 14:18 ` [PATCH] " Samuel Thibault
0 siblings, 1 reply; 10+ messages in thread
From: Christoph Egger @ 2008-08-01 14:14 UTC (permalink / raw)
To: xen-devel
Hi,
cleaning the source tree fails.
gmake tries to enter a non-existing directory.
gmake[2]: Entering directory `xen-staging.hg/stubdom/c'
rm -f *.a *.o
gmake[2]: Leaving directory `xen-staging.hg/stubdom/c'
gmake -C grub clean
gmake[2]: Entering directory `xen-staging.hg/stubdom/grub'
rm -fr dirs *.a *.o stage2 netboot
gmake[2]: Leaving directory `xen-staging.hg/stubdom/grub'
gmake -C libxc clean
gmake: Entering an unknown directory
gmake: *** libxc: No such file or directory. Stop.
gmake: Leaving an unknown directory
gmake[1]: *** [clean] Error 2
gmake[1]: Leaving directory `xen-staging.hg/stubdom'
gmake: *** [distclean] Error 2
--
AMD Saxony, Dresden, Germany
Operating System Research Center
Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
Dr. Hans-R. Deppe, Thomas McCoy
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] Re: distclean failure
2008-08-01 14:14 distclean failure Christoph Egger
@ 2008-08-01 14:18 ` Samuel Thibault
2008-08-01 14:26 ` Christoph Egger
2008-08-01 20:27 ` Jeremy Fitzhardinge
0 siblings, 2 replies; 10+ messages in thread
From: Samuel Thibault @ 2008-08-01 14:18 UTC (permalink / raw)
To: Christoph Egger; +Cc: xen-devel
Christoph Egger, le Fri 01 Aug 2008 16:14:56 +0200, a écrit :
> gmake: *** libxc: No such file or directory. Stop.
Ah, right.
Samuel
stubdom: fix clean target after distclean
Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
diff -r 3dedb6209991 stubdom/Makefile
--- a/stubdom/Makefile Fri Aug 01 12:18:02 2008 +0100
+++ b/stubdom/Makefile Fri Aug 01 15:17:46 2008 +0100
@@ -321,8 +321,8 @@ clean:
$(MAKE) -C caml clean
$(MAKE) -C c clean
$(MAKE) -C grub clean
- $(MAKE) -C libxc clean
- $(MAKE) -C ioemu clean
+ [ ! -d libxc ] || $(MAKE) -C libxc clean
+ [ ! -d ioemu ] || $(MAKE) -C ioemu clean
# clean the cross-compilation result
.PHONY: crossclean
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Re: distclean failure
2008-08-01 14:18 ` [PATCH] " Samuel Thibault
@ 2008-08-01 14:26 ` Christoph Egger
2008-08-01 14:36 ` Christoph Egger
2008-08-01 20:27 ` Jeremy Fitzhardinge
1 sibling, 1 reply; 10+ messages in thread
From: Christoph Egger @ 2008-08-01 14:26 UTC (permalink / raw)
To: xen-devel; +Cc: Samuel Thibault
On Friday 01 August 2008 16:18:20 Samuel Thibault wrote:
> Christoph Egger, le Fri 01 Aug 2008 16:14:56 +0200, a écrit :
> > gmake: *** libxc: No such file or directory. Stop.
>
> Ah, right.
>
> Samuel
>
>
> stubdom: fix clean target after distclean
>
> Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
>
> diff -r 3dedb6209991 stubdom/Makefile
> --- a/stubdom/Makefile Fri Aug 01 12:18:02 2008 +0100
> +++ b/stubdom/Makefile Fri Aug 01 15:17:46 2008 +0100
> @@ -321,8 +321,8 @@ clean:
> $(MAKE) -C caml clean
> $(MAKE) -C c clean
> $(MAKE) -C grub clean
> - $(MAKE) -C libxc clean
> - $(MAKE) -C ioemu clean
> + [ ! -d libxc ] || $(MAKE) -C libxc clean
> + [ ! -d ioemu ] || $(MAKE) -C ioemu clean
>
> # clean the cross-compilation result
> .PHONY: crossclean
Yes, this patch works. Tnx.
Christoph
--
AMD Saxony, Dresden, Germany
Operating System Research Center
Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
Dr. Hans-R. Deppe, Thomas McCoy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Re: distclean failure
2008-08-01 14:26 ` Christoph Egger
@ 2008-08-01 14:36 ` Christoph Egger
2008-08-01 14:38 ` Keir Fraser
0 siblings, 1 reply; 10+ messages in thread
From: Christoph Egger @ 2008-08-01 14:36 UTC (permalink / raw)
To: xen-devel; +Cc: Keir Fraser, Samuel Thibault
Keir: In c/s 18211, why $$(MAKE) instead of $(MAKE) ?
Christoph
On Friday 01 August 2008 16:26:33 Christoph Egger wrote:
> On Friday 01 August 2008 16:18:20 Samuel Thibault wrote:
> > Christoph Egger, le Fri 01 Aug 2008 16:14:56 +0200, a écrit :
> > > gmake: *** libxc: No such file or directory. Stop.
> >
> > Ah, right.
> >
> > Samuel
> >
> >
> > stubdom: fix clean target after distclean
> >
> > Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
> >
> > diff -r 3dedb6209991 stubdom/Makefile
> > --- a/stubdom/Makefile Fri Aug 01 12:18:02 2008 +0100
> > +++ b/stubdom/Makefile Fri Aug 01 15:17:46 2008 +0100
> > @@ -321,8 +321,8 @@ clean:
> > $(MAKE) -C caml clean
> > $(MAKE) -C c clean
> > $(MAKE) -C grub clean
> > - $(MAKE) -C libxc clean
> > - $(MAKE) -C ioemu clean
> > + [ ! -d libxc ] || $(MAKE) -C libxc clean
> > + [ ! -d ioemu ] || $(MAKE) -C ioemu clean
> >
> > # clean the cross-compilation result
> > .PHONY: crossclean
>
> Yes, this patch works. Tnx.
>
> Christoph
--
AMD Saxony, Dresden, Germany
Operating System Research Center
Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
Dr. Hans-R. Deppe, Thomas McCoy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Re: distclean failure
2008-08-01 14:36 ` Christoph Egger
@ 2008-08-01 14:38 ` Keir Fraser
0 siblings, 0 replies; 10+ messages in thread
From: Keir Fraser @ 2008-08-01 14:38 UTC (permalink / raw)
To: Christoph Egger, xen-devel; +Cc: Keir Fraser, Samuel Thibault
Oops. Cut-n-paste error after the patch didn't apply straight from the email
text. Fixed.
-- Keir
On 1/8/08 15:36, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
>
> Keir: In c/s 18211, why $$(MAKE) instead of $(MAKE) ?
>
> Christoph
>
>
> On Friday 01 August 2008 16:26:33 Christoph Egger wrote:
>> On Friday 01 August 2008 16:18:20 Samuel Thibault wrote:
>>> Christoph Egger, le Fri 01 Aug 2008 16:14:56 +0200, a écrit :
>>>> gmake: *** libxc: No such file or directory. Stop.
>>>
>>> Ah, right.
>>>
>>> Samuel
>>>
>>>
>>> stubdom: fix clean target after distclean
>>>
>>> Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
>>>
>>> diff -r 3dedb6209991 stubdom/Makefile
>>> --- a/stubdom/Makefile Fri Aug 01 12:18:02 2008 +0100
>>> +++ b/stubdom/Makefile Fri Aug 01 15:17:46 2008 +0100
>>> @@ -321,8 +321,8 @@ clean:
>>> $(MAKE) -C caml clean
>>> $(MAKE) -C c clean
>>> $(MAKE) -C grub clean
>>> - $(MAKE) -C libxc clean
>>> - $(MAKE) -C ioemu clean
>>> + [ ! -d libxc ] || $(MAKE) -C libxc clean
>>> + [ ! -d ioemu ] || $(MAKE) -C ioemu clean
>>>
>>> # clean the cross-compilation result
>>> .PHONY: crossclean
>>
>> Yes, this patch works. Tnx.
>>
>> Christoph
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Re: distclean failure
2008-08-01 14:18 ` [PATCH] " Samuel Thibault
2008-08-01 14:26 ` Christoph Egger
@ 2008-08-01 20:27 ` Jeremy Fitzhardinge
2008-08-01 20:36 ` Samuel Thibault
1 sibling, 1 reply; 10+ messages in thread
From: Jeremy Fitzhardinge @ 2008-08-01 20:27 UTC (permalink / raw)
To: Samuel Thibault, Christoph Egger, xen-devel
Samuel Thibault wrote:
> Christoph Egger, le Fri 01 Aug 2008 16:14:56 +0200, a écrit :
>
>> gmake: *** libxc: No such file or directory. Stop.
>>
>
> Ah, right.
>
> Samuel
>
>
>
> stubdom: fix clean target after distclean
>
> Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
>
> diff -r 3dedb6209991 stubdom/Makefile
> --- a/stubdom/Makefile Fri Aug 01 12:18:02 2008 +0100
> +++ b/stubdom/Makefile Fri Aug 01 15:17:46 2008 +0100
> @@ -321,8 +321,8 @@ clean:
> $(MAKE) -C caml clean
> $(MAKE) -C c clean
> $(MAKE) -C grub clean
> - $(MAKE) -C libxc clean
> - $(MAKE) -C ioemu clean
> + [ ! -d libxc ] || $(MAKE) -C libxc clean
> + [ ! -d ioemu ] || $(MAKE) -C ioemu clean
>
Are you sure you don't not need a double negative there?
J
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] Re: distclean failure
2008-08-01 20:27 ` Jeremy Fitzhardinge
@ 2008-08-01 20:36 ` Samuel Thibault
2008-08-01 20:40 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 10+ messages in thread
From: Samuel Thibault @ 2008-08-01 20:36 UTC (permalink / raw)
To: Jeremy Fitzhardinge; +Cc: Christoph Egger, xen-devel
Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:27:29 -0700, a écrit :
> >+ [ ! -d libxc ] || $(MAKE) -C libxc clean
> >+ [ ! -d ioemu ] || $(MAKE) -C ioemu clean
>
> Are you sure you don't not need a double negative there?
Mmm, why? The clean target succeeds if either there is not even
libxc/ioemu directories, or the make clean there works.
Samuel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Re: distclean failure
2008-08-01 20:36 ` Samuel Thibault
@ 2008-08-01 20:40 ` Jeremy Fitzhardinge
2008-08-01 20:42 ` Samuel Thibault
0 siblings, 1 reply; 10+ messages in thread
From: Jeremy Fitzhardinge @ 2008-08-01 20:40 UTC (permalink / raw)
To: Samuel Thibault, Jeremy Fitzhardinge, Christoph Egger, xen-devel
Samuel Thibault wrote:
> Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:27:29 -0700, a écrit :
>
>>> + [ ! -d libxc ] || $(MAKE) -C libxc clean
>>> + [ ! -d ioemu ] || $(MAKE) -C ioemu clean
>>>
>> Are you sure you don't not need a double negative there?
>>
>
> Mmm, why? The clean target succeeds if either there is not even
> libxc/ioemu directories, or the make clean there works.
>
I'm just pointing out that
[ -d libxc ] && $(MAKE) -C libxc clean
is more straightforward.
J
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] Re: distclean failure
2008-08-01 20:40 ` Jeremy Fitzhardinge
@ 2008-08-01 20:42 ` Samuel Thibault
2008-08-01 20:55 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 10+ messages in thread
From: Samuel Thibault @ 2008-08-01 20:42 UTC (permalink / raw)
To: Jeremy Fitzhardinge; +Cc: Christoph Egger, xen-devel
Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:40:31 -0700, a écrit :
> Samuel Thibault wrote:
> >Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:27:29 -0700, a écrit :
> >
> >>>+ [ ! -d libxc ] || $(MAKE) -C libxc clean
> >>>+ [ ! -d ioemu ] || $(MAKE) -C ioemu clean
> >>>
> >>Are you sure you don't not need a double negative there?
> >>
> >
> >Mmm, why? The clean target succeeds if either there is not even
> >libxc/ioemu directories, or the make clean there works.
> >
>
> I'm just pointing out that
>
> [ -d libxc ] && $(MAKE) -C libxc clean
>
> is more straightforward.
But it makes the rule fail if the directory doesn't exist.
Samuel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Re: distclean failure
2008-08-01 20:42 ` Samuel Thibault
@ 2008-08-01 20:55 ` Jeremy Fitzhardinge
0 siblings, 0 replies; 10+ messages in thread
From: Jeremy Fitzhardinge @ 2008-08-01 20:55 UTC (permalink / raw)
To: Samuel Thibault, Jeremy Fitzhardinge, Christoph Egger, xen-devel
Samuel Thibault wrote:
> Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:40:31 -0700, a écrit :
>
>> Samuel Thibault wrote:
>>
>>> Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:27:29 -0700, a écrit :
>>>
>>>
>>>>> + [ ! -d libxc ] || $(MAKE) -C libxc clean
>>>>> + [ ! -d ioemu ] || $(MAKE) -C ioemu clean
>>>>>
>>>>>
>>>> Are you sure you don't not need a double negative there?
>>>>
>>>>
>>> Mmm, why? The clean target succeeds if either there is not even
>>> libxc/ioemu directories, or the make clean there works.
>>>
>>>
>> I'm just pointing out that
>>
>> [ -d libxc ] && $(MAKE) -C libxc clean
>>
>> is more straightforward.
>>
>
> But it makes the rule fail if the directory doesn't exist.
>
Blerk. OK.
J
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2008-08-01 20:55 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-01 14:14 distclean failure Christoph Egger
2008-08-01 14:18 ` [PATCH] " Samuel Thibault
2008-08-01 14:26 ` Christoph Egger
2008-08-01 14:36 ` Christoph Egger
2008-08-01 14:38 ` Keir Fraser
2008-08-01 20:27 ` Jeremy Fitzhardinge
2008-08-01 20:36 ` Samuel Thibault
2008-08-01 20:40 ` Jeremy Fitzhardinge
2008-08-01 20:42 ` Samuel Thibault
2008-08-01 20:55 ` Jeremy Fitzhardinge
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.