All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Starikovskiy <aystarik@gmail.com>
To: Nick Piggin <npiggin@suse.de>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	Linux Memory Management List <linux-mm@kvack.org>,
	linux-acpi@vger.kernel.org, lenb@kernel.org
Subject: Re: [patch][rfc] acpi: do not use kmem caches
Date: Mon, 01 Dec 2008 19:45:14 +0300	[thread overview]
Message-ID: <4934149A.4020604@gmail.com> (raw)
In-Reply-To: <20081201161404.GE10790@wotan.suse.de>

Nick Piggin wrote:
> On Mon, Dec 01, 2008 at 05:02:50PM +0300, Alexey Starikovskiy wrote:
>   
>> Because SLAB has standard memory wells of 2^x size. None of cached ACPI
>> objects has exactly this size, so bigger block will be used. Plus, 
>> internal ACPICA caching will add some overhead.
>>     
>
> That's an insane looking caching thing now that I come to closely read
> the code. There is so much stuff there that I thought it must have been
> doing something useful which is why I didn't replace the Linux functions
> with kmalloc/kfree directly.
>
> There is really some operating system you support that has such a poor
> allocator that you think ACPI can do better in 300 lines of code? Why
> not just rip that whole thing out?
>   
You would laugh, this is due to Windows userspace debug library -- it 
checks for
memory leaks by default, and it takes ages to do this.
And ACPICA maintainer is sitting on Windows, so he _cares_.
>> Do you have another interpreter in kernel space?
>>     
>
> So what makes it special?
>
>   
You don't know what size of program you will end up with.
DSDT could be almost empty, or you could have several thousand of SSDT 
tables.




WARNING: multiple messages have this Message-ID (diff)
From: Alexey Starikovskiy <aystarik@gmail.com>
To: Nick Piggin <npiggin@suse.de>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	Linux Memory Management List <linux-mm@kvack.org>,
	linux-acpi@vger.kernel.org, lenb@kernel.org
Subject: Re: [patch][rfc] acpi: do not use kmem caches
Date: Mon, 01 Dec 2008 19:45:14 +0300	[thread overview]
Message-ID: <4934149A.4020604@gmail.com> (raw)
In-Reply-To: <20081201161404.GE10790@wotan.suse.de>

Nick Piggin wrote:
> On Mon, Dec 01, 2008 at 05:02:50PM +0300, Alexey Starikovskiy wrote:
>   
>> Because SLAB has standard memory wells of 2^x size. None of cached ACPI
>> objects has exactly this size, so bigger block will be used. Plus, 
>> internal ACPICA caching will add some overhead.
>>     
>
> That's an insane looking caching thing now that I come to closely read
> the code. There is so much stuff there that I thought it must have been
> doing something useful which is why I didn't replace the Linux functions
> with kmalloc/kfree directly.
>
> There is really some operating system you support that has such a poor
> allocator that you think ACPI can do better in 300 lines of code? Why
> not just rip that whole thing out?
>   
You would laugh, this is due to Windows userspace debug library -- it 
checks for
memory leaks by default, and it takes ages to do this.
And ACPICA maintainer is sitting on Windows, so he _cares_.
>> Do you have another interpreter in kernel space?
>>     
>
> So what makes it special?
>
>   
You don't know what size of program you will end up with.
DSDT could be almost empty, or you could have several thousand of SSDT 
tables.



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-12-01 16:45 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-01  8:31 [patch][rfc] acpi: do not use kmem caches Nick Piggin
2008-12-01  8:31 ` Nick Piggin
2008-12-01 11:18 ` Pekka Enberg
2008-12-01 11:18   ` Pekka Enberg
2008-12-01 12:00   ` Nick Piggin
2008-12-01 12:00     ` Nick Piggin
2008-12-01 13:12     ` Alexey Starikovskiy
2008-12-01 13:12       ` Alexey Starikovskiy
2008-12-01 13:36       ` Nick Piggin
2008-12-01 13:36         ` Nick Piggin
2008-12-01 14:14         ` Alexey Starikovskiy
2008-12-01 14:14           ` Alexey Starikovskiy
2008-12-01 16:32           ` Nick Piggin
2008-12-01 16:32             ` Nick Piggin
2008-12-01 17:18           ` Christoph Hellwig
2008-12-01 17:18             ` Christoph Hellwig
2008-12-01 17:32             ` Alexey Starikovskiy
2008-12-01 17:32               ` Alexey Starikovskiy
2008-12-01 13:37       ` Pekka Enberg
2008-12-01 13:37         ` Pekka Enberg
2008-12-01 14:02         ` Alexey Starikovskiy
2008-12-01 14:02           ` Alexey Starikovskiy
2008-12-01 16:14           ` Nick Piggin
2008-12-01 16:14             ` Nick Piggin
2008-12-01 16:45             ` Alexey Starikovskiy [this message]
2008-12-01 16:45               ` Alexey Starikovskiy
2008-12-01 16:58               ` Nick Piggin
2008-12-01 16:58                 ` Nick Piggin
2008-12-01 17:20               ` Moore, Robert
2008-12-01 17:20                 ` Moore, Robert
2008-12-01 17:30                 ` Andi Kleen
2008-12-01 17:30                   ` Andi Kleen
2008-12-01 17:32                   ` Moore, Robert
2008-12-01 17:32                     ` Moore, Robert
2008-12-01 17:20               ` Christoph Hellwig
2008-12-01 17:20                 ` Christoph Hellwig
2008-12-01 17:49                 ` Alexey Starikovskiy
2008-12-01 17:49                   ` Alexey Starikovskiy
2008-12-01 17:53                 ` Len Brown
2008-12-01 17:53                   ` Len Brown
2008-12-01 18:10                   ` Nick Piggin
2008-12-01 18:10                     ` Nick Piggin
2008-12-31 22:04                     ` Len Brown
2008-12-31 22:04                       ` Len Brown
2009-01-05  4:14                       ` Nick Piggin
2009-01-05  4:14                         ` Nick Piggin
2009-01-05  5:43                         ` Skywing
2009-01-05  6:55                           ` Nick Piggin
2009-01-05  6:55                             ` Nick Piggin
2008-12-01 14:32         ` Christoph Lameter
2008-12-01 14:32           ` Christoph Lameter
2008-12-01 14:48           ` Alexey Starikovskiy
2008-12-01 14:48             ` Alexey Starikovskiy
2008-12-01 16:20             ` Nick Piggin
2008-12-01 16:20               ` Nick Piggin
2008-12-01 17:04               ` Alexey Starikovskiy
2008-12-01 17:04                 ` Alexey Starikovskiy
2008-12-01 17:12                 ` Nick Piggin
2008-12-01 17:12                   ` Nick Piggin
2008-12-01 17:25                   ` Pekka Enberg
2008-12-01 17:25                     ` Pekka Enberg
2008-12-01 17:32                     ` Pekka Enberg
2008-12-01 17:32                       ` Pekka Enberg
2008-12-01 17:36                       ` Alexey Starikovskiy
2008-12-01 17:36                         ` Alexey Starikovskiy
2008-12-01 17:48                         ` Pekka Enberg
2008-12-01 18:09                         ` Christoph Lameter
2008-12-01 18:09                           ` Christoph Lameter
2008-12-01 17:43                   ` Alexey Starikovskiy
2008-12-01 17:43                     ` Alexey Starikovskiy
2008-12-01 17:31 ` Len Brown
2008-12-01 17:31   ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4934149A.4020604@gmail.com \
    --to=aystarik@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.