From: Alexey Starikovskiy <aystarik@gmail.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Nick Piggin <npiggin@suse.de>,
Christoph Lameter <cl@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-acpi@vger.kernel.org, lenb@kernel.org
Subject: Re: [patch][rfc] acpi: do not use kmem caches
Date: Mon, 01 Dec 2008 20:36:50 +0300 [thread overview]
Message-ID: <493420B2.8050907@gmail.com> (raw)
In-Reply-To: <84144f020812010932l540b26dr57716d8abea2562@mail.gmail.com>
Pekka Enberg wrote:
> On Mon, Dec 1, 2008 at 7:25 PM, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
>
>> Though I suspect using kmem caches to combat the internal
>> fragmentation caused by kmalloc() rounding is not worth it in this
>> case.
>>
>
> Btw, just for the record, the ACPI objects are indeed a bad fit for
> kmalloc() as reported by SLUB statistics:
>
> [ The size of ACPI kmem caches with wasted bytes per object in parenthesis. ]
>
> 32-bit size 64-bit size
> Acpi-Namespace 24 (8) 32 (0)
> Acpi-Operand 40 (24) 72 (24)
> Acpi-Parse 32 (0) 48 (16)
> Acpi-ParseExt 44 (20) 72 (24)
> Acpi-State 44 (20) 80 (16)
>
> Though I suspect this situation could be improved by avoiding those
> fairly big unions ACPI does (like union acpi_operand_object).
>
No, last time I checked, operand may get down to 16 bytes in 32-bit case
-- save byte by having 3 types of operands... and making 2 more caches :)
WARNING: multiple messages have this Message-ID (diff)
From: Alexey Starikovskiy <aystarik@gmail.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Nick Piggin <npiggin@suse.de>,
Christoph Lameter <cl@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-acpi@vger.kernel.org, lenb@kernel.org
Subject: Re: [patch][rfc] acpi: do not use kmem caches
Date: Mon, 01 Dec 2008 20:36:50 +0300 [thread overview]
Message-ID: <493420B2.8050907@gmail.com> (raw)
In-Reply-To: <84144f020812010932l540b26dr57716d8abea2562@mail.gmail.com>
Pekka Enberg wrote:
> On Mon, Dec 1, 2008 at 7:25 PM, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
>
>> Though I suspect using kmem caches to combat the internal
>> fragmentation caused by kmalloc() rounding is not worth it in this
>> case.
>>
>
> Btw, just for the record, the ACPI objects are indeed a bad fit for
> kmalloc() as reported by SLUB statistics:
>
> [ The size of ACPI kmem caches with wasted bytes per object in parenthesis. ]
>
> 32-bit size 64-bit size
> Acpi-Namespace 24 (8) 32 (0)
> Acpi-Operand 40 (24) 72 (24)
> Acpi-Parse 32 (0) 48 (16)
> Acpi-ParseExt 44 (20) 72 (24)
> Acpi-State 44 (20) 80 (16)
>
> Though I suspect this situation could be improved by avoiding those
> fairly big unions ACPI does (like union acpi_operand_object).
>
No, last time I checked, operand may get down to 16 bytes in 32-bit case
-- save byte by having 3 types of operands... and making 2 more caches :)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-12-01 17:36 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 8:31 [patch][rfc] acpi: do not use kmem caches Nick Piggin
2008-12-01 8:31 ` Nick Piggin
2008-12-01 11:18 ` Pekka Enberg
2008-12-01 11:18 ` Pekka Enberg
2008-12-01 12:00 ` Nick Piggin
2008-12-01 12:00 ` Nick Piggin
2008-12-01 13:12 ` Alexey Starikovskiy
2008-12-01 13:12 ` Alexey Starikovskiy
2008-12-01 13:36 ` Nick Piggin
2008-12-01 13:36 ` Nick Piggin
2008-12-01 14:14 ` Alexey Starikovskiy
2008-12-01 14:14 ` Alexey Starikovskiy
2008-12-01 16:32 ` Nick Piggin
2008-12-01 16:32 ` Nick Piggin
2008-12-01 17:18 ` Christoph Hellwig
2008-12-01 17:18 ` Christoph Hellwig
2008-12-01 17:32 ` Alexey Starikovskiy
2008-12-01 17:32 ` Alexey Starikovskiy
2008-12-01 13:37 ` Pekka Enberg
2008-12-01 13:37 ` Pekka Enberg
2008-12-01 14:02 ` Alexey Starikovskiy
2008-12-01 14:02 ` Alexey Starikovskiy
2008-12-01 16:14 ` Nick Piggin
2008-12-01 16:14 ` Nick Piggin
2008-12-01 16:45 ` Alexey Starikovskiy
2008-12-01 16:45 ` Alexey Starikovskiy
2008-12-01 16:58 ` Nick Piggin
2008-12-01 16:58 ` Nick Piggin
2008-12-01 17:20 ` Moore, Robert
2008-12-01 17:20 ` Moore, Robert
2008-12-01 17:30 ` Andi Kleen
2008-12-01 17:30 ` Andi Kleen
2008-12-01 17:32 ` Moore, Robert
2008-12-01 17:32 ` Moore, Robert
2008-12-01 17:20 ` Christoph Hellwig
2008-12-01 17:20 ` Christoph Hellwig
2008-12-01 17:49 ` Alexey Starikovskiy
2008-12-01 17:49 ` Alexey Starikovskiy
2008-12-01 17:53 ` Len Brown
2008-12-01 17:53 ` Len Brown
2008-12-01 18:10 ` Nick Piggin
2008-12-01 18:10 ` Nick Piggin
2008-12-31 22:04 ` Len Brown
2008-12-31 22:04 ` Len Brown
2009-01-05 4:14 ` Nick Piggin
2009-01-05 4:14 ` Nick Piggin
2009-01-05 5:43 ` Skywing
2009-01-05 6:55 ` Nick Piggin
2009-01-05 6:55 ` Nick Piggin
2008-12-01 14:32 ` Christoph Lameter
2008-12-01 14:32 ` Christoph Lameter
2008-12-01 14:48 ` Alexey Starikovskiy
2008-12-01 14:48 ` Alexey Starikovskiy
2008-12-01 16:20 ` Nick Piggin
2008-12-01 16:20 ` Nick Piggin
2008-12-01 17:04 ` Alexey Starikovskiy
2008-12-01 17:04 ` Alexey Starikovskiy
2008-12-01 17:12 ` Nick Piggin
2008-12-01 17:12 ` Nick Piggin
2008-12-01 17:25 ` Pekka Enberg
2008-12-01 17:25 ` Pekka Enberg
2008-12-01 17:32 ` Pekka Enberg
2008-12-01 17:32 ` Pekka Enberg
2008-12-01 17:36 ` Alexey Starikovskiy [this message]
2008-12-01 17:36 ` Alexey Starikovskiy
2008-12-01 17:48 ` Pekka Enberg
2008-12-01 18:09 ` Christoph Lameter
2008-12-01 18:09 ` Christoph Lameter
2008-12-01 17:43 ` Alexey Starikovskiy
2008-12-01 17:43 ` Alexey Starikovskiy
2008-12-01 17:31 ` Len Brown
2008-12-01 17:31 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493420B2.8050907@gmail.com \
--to=aystarik@gmail.com \
--cc=cl@linux-foundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.