From: Mike Travis <travis@sgi.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>, Dave Jones <davej@redhat.com>,
cpufreq@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] work_on_cpu: Use our own workqueue.
Date: Wed, 28 Jan 2009 09:32:42 -0800 [thread overview]
Message-ID: <498096BA.2000301@sgi.com> (raw)
In-Reply-To: <4980939C.6010102@sgi.com>
Mike Travis wrote:
> Hi Rusty,
>
> I'm testing this now on x86_64 and one question comes up. The
> initialization of the woc_wq thread happens quite late. Might it
> be better to initialize it earlier?
Umm, definitely needed earlier... A bug catcher caught this. Work_on_cpu
is being called before it's initialized.
[ 16.541297] calling microcode_init+0x0/0x13a @ 1
[ 16.555989] ------------[ cut here ]------------
[ 16.556955] kernel BUG at .../kernel/work_on_cpu.c:67!
[ 16.556955] invalid opcode: 0000 [#1] SMP
[ 16.556955] last sysfs file:
[ 16.556955] CPU 5
[ 16.556955] Pid: 1, comm: swapper Tainted: G W 2.6.29-rc1-4k-defconfig.01280914-00263-g0ee2ad8-dirty #100
[ 16.556955] RIP: 0010:[<ffffffff810a69df>] [<ffffffff810a69df>] work_on_cpu+0x3d/0xeb
[ 16.556955] RSP: 0018:ffff88012fac9b60 EFLAGS: 00010202
[ 16.556955] RAX: 0000000000000000 RBX: 0000000000000001 RCX: 0000000000000000
[ 16.556955] RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
[ 16.556955] RBP: ffff88012fac9c00 R08: 0000000000000000 R09: ffff88012fac9b80
[ 16.556955] R10: ffffffff8187b778 R11: 0000000081049799 R12: 0000000000000000
[ 16.556955] R13: ffffffff81026313 R14: 0000000000000000 R15: 0000000000000000
[ 16.556955] FS: 0000000000000000(0000) GS:ffff88022ec3a000(0000) knlGS:0000000000000000
[ 16.556955] CS: 0010 DS: 0018 ES: 0018 CR0: 000000008005003b
[ 16.556955] CR2: 0000000000000000 CR3: 0000000000201000 CR4: 00000000000006a0
[ 16.556955] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 16.556955] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[ 16.556955] Process swapper (pid: 1, threadinfo ffff88012fac8000, task ffff88022faa8000)
[ 16.556955] Stack:
[ 16.556955] 000000002fac9bb0 ffffffff810260a6 000000002e0d75f0 0000000000000002
[ 16.556955] 2222222222222222 2222222222222222 2222222222222222 2222222222222222
[ 16.556955] 2222222222222222 0000000000000000 ffff88012fac9bd0 0000000000000000
[ 16.556955] Call Trace:
[ 16.556955] [<ffffffff810260a6>] ? microcode_init_cpu+0x1e/0x3e
[ 16.556955] [<ffffffff810260b6>] microcode_init_cpu+0x2e/0x3e
[ 16.556955] [<ffffffff8102620c>] mc_sysdev_add+0x67/0x71
[ 16.556955] [<ffffffff812ffde8>] sysdev_driver_register+0xcb/0x125
[ 16.556955] [<ffffffff81a5bc32>] microcode_init+0xb7/0x13a
[ 16.556955] [<ffffffff81a5bb7b>] ? microcode_init+0x0/0x13a
[ 16.556955] [<ffffffff81009075>] _stext+0x75/0x17f
[ 16.556955] [<ffffffff8106dc2c>] ? mark_lock+0x1c/0x369
[ 16.556955] [<ffffffff8106f0bc>] ? __lock_acquire+0xba0/0xbc1
[ 16.556955] [<ffffffff812444a1>] ? ida_get_new_above+0x171/0x18d
[ 16.556955] [<ffffffff8112d764>] ? proc_register+0x184/0x198
[ 16.556955] [<ffffffff8125b54e>] ? _raw_spin_unlock+0xc7/0xf6
[ 16.556955] [<ffffffff815ce60b>] ? _spin_unlock+0x2b/0x2f
[ 16.556955] [<ffffffff8112d764>] ? proc_register+0x184/0x198
[ 16.556955] [<ffffffff8112d895>] ? create_proc_entry+0x79/0x8f
[ 16.556955] [<ffffffff81094705>] ? register_irq_proc+0xb3/0xcf
[ 16.556955] [<ffffffff81120000>] ? load_elf_binary+0xc38/0x1aa8
[ 16.556955] [<ffffffff81a4a902>] kernel_init+0x14b/0x1a1
[ 16.556955] [<ffffffff8100d7ba>] child_rip+0xa/0x20
[ 16.556955] [<ffffffff8100d1bc>] ? restore_args+0x0/0x30
[ 16.556955] [<ffffffff81a4a7b7>] ? kernel_init+0x0/0x1a1
[ 16.556955] [<ffffffff8100d7b0>] ? child_rip+0x0/0x20
[ 16.556955] Code: 00 00 31 db 83 3d 75 24 50 01 00 41 89 fc 49 89 f5 49 89 d6 48 c7 c7 e8 d8 96 81 0f 94 c3 31 d2 89 de e8 8e f1 ff ff 85 db 74 04 <0f> 0b eb fe 48 8d 9d 60 ff ff ff 44 89 a5 60 ff ff ff 4c 89 ad
[ 16.556955] RIP [<ffffffff810a69df>] work_on_cpu+0x3d/0xeb
[ 16.556955] RSP <ffff88012fac9b60>
[ 17.493250] ---[ end trace 4eaa2a86a8e2da23 ]---
[ 17.507376] swapper used greatest stack depth: 3776 bytes left
[ 17.525131] Kernel panic - not syncing: Attempted to kill init!
next prev parent reply other threads:[~2009-01-28 17:32 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 19:11 [PATCH 0/3] cpu freq: fix problems with work_on_cpu usage in acpi-cpufreq Mike Travis
2009-01-16 19:11 ` [PATCH 1/3] work_on_cpu: dont try to get_online_cpus() in work_on_cpu Mike Travis
2009-01-16 19:11 ` [PATCH 2/3] work_on_cpu: Use our own workqueue Mike Travis
2009-01-24 8:15 ` Andrew Morton
[not found] ` <200901261711.43943.rusty@rustcorp.com.au>
2009-01-26 7:01 ` Andrew Morton
2009-01-26 17:16 ` Ingo Molnar
2009-01-26 18:35 ` Andrew Morton
2009-01-26 20:20 ` Ingo Molnar
2009-01-26 20:43 ` Mike Travis
2009-01-26 21:00 ` Andrew Morton
2009-01-26 21:27 ` Ingo Molnar
2009-01-26 21:35 ` Andrew Morton
2009-01-26 21:45 ` Ingo Molnar
2009-01-26 22:01 ` Andrew Morton
2009-01-26 22:05 ` Ingo Molnar
2009-01-26 22:16 ` Andrew Morton
2009-01-26 22:20 ` Ingo Molnar
2009-01-26 22:50 ` Andrew Morton
2009-01-26 22:59 ` Ingo Molnar
2009-01-26 23:42 ` Andrew Morton
2009-01-26 23:53 ` Ingo Molnar
2009-01-27 0:42 ` Andrew Morton
2009-01-26 22:31 ` Oleg Nesterov
2009-01-26 22:15 ` Oleg Nesterov
2009-01-26 22:24 ` Ingo Molnar
2009-01-26 22:37 ` Oleg Nesterov
2009-01-26 22:42 ` Ingo Molnar
2009-01-26 21:50 ` Oleg Nesterov
2009-01-26 22:17 ` Ingo Molnar
2009-01-26 23:01 ` Mike Travis
2009-01-27 0:09 ` Oleg Nesterov
2009-01-27 7:15 ` Rusty Russell
2009-01-27 17:55 ` Oleg Nesterov
2009-01-27 7:05 ` Rusty Russell
2009-01-27 7:25 ` Andrew Morton
2009-01-27 15:28 ` Ingo Molnar
2009-01-27 16:51 ` Andrew Morton
2009-01-28 13:02 ` Rusty Russell
2009-01-28 17:19 ` Mike Travis
2009-01-28 17:32 ` Mike Travis [this message]
2009-01-29 10:39 ` Rusty Russell
2009-01-28 19:44 ` Andrew Morton
2009-01-29 1:43 ` Rusty Russell
2009-01-29 2:12 ` Andrew Morton
2009-01-30 6:03 ` Rusty Russell
2009-01-30 6:30 ` Andrew Morton
2009-01-30 13:49 ` Ingo Molnar
2009-01-30 17:08 ` Andrew Morton
2009-01-30 21:59 ` Rusty Russell
2009-01-30 22:17 ` Andrew Morton
2009-02-02 12:35 ` Rusty Russell
2009-02-03 4:06 ` Andrew Morton
2009-02-04 2:44 ` Rusty Russell
2009-02-04 3:01 ` Andrew Morton
2009-02-04 10:41 ` Rusty Russell
2009-02-04 15:36 ` Andrew Morton
2009-02-04 21:35 ` Ingo Molnar
2009-02-04 21:48 ` Andrew Morton
2009-02-04 21:54 ` Ingo Molnar
2009-02-04 23:45 ` Rusty Russell
2009-02-05 12:19 ` Pavel Machek
2009-02-05 17:44 ` Dmitry Adamushko
2009-02-10 8:54 ` Rusty Russell
2009-02-10 9:35 ` Andrew Morton
2009-02-11 0:32 ` Rusty Russell
2009-01-16 19:11 ` [PATCH 3/3] cpufreq: use work_on_cpu in acpi-cpufreq.c for drv_read and drv_write Mike Travis
2009-01-16 23:38 ` [PATCH 0/3] cpu freq: fix problems with work_on_cpu usage in acpi-cpufreq [PULL request] Mike Travis
2009-01-17 22:08 ` Ingo Molnar
2009-01-19 17:11 ` Mike Travis
2009-01-19 17:26 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498096BA.2000301@sgi.com \
--to=travis@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.