All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: "Hilman, Kevin" <khilman@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Paul Walmsely <paul@pwsan.com>
Subject: Re: [PATCH 1/7] OMAP2+: hwmod: remove unused voltagedomain pointer
Date: Mon, 21 Mar 2011 14:08:25 +0100	[thread overview]
Message-ID: <4D874DC9.6020203@ti.com> (raw)
In-Reply-To: <1300493932-17362-2-git-send-email-khilman@ti.com>

Hi Kevin,

On 3/19/2011 1:18 AM, Hilman, Kevin wrote:
> The voltage domain pointer currently in struct omap_hwmod is not used
> and does not belong here.  Instead, voltage domains will be associated
> with powerdomains in forthcoming patches.

Technically speaking, an IP, and thus the hwmod does belong to a voltage 
domain, a power domain and a clock domain.

What is maybe important to add is that since clkdm < pwrdm < voltdm, we 
can potentially avoid providing the information for the each domain type.

At some point the hwmod will have to contain a clkdm instead of relying 
on the main_clk to get it... but that's another topic...

> Signed-off-by: Kevin Hilman<khilman@ti.com>
> ---
>   arch/arm/plat-omap/include/plat/omap_hwmod.h |    1 -
>   1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/plat/omap_hwmod.h b/arch/arm/plat-omap/include/plat/omap_hwmod.h
> index 1adea9c..a5fa7c1 100644
> --- a/arch/arm/plat-omap/include/plat/omap_hwmod.h
> +++ b/arch/arm/plat-omap/include/plat/omap_hwmod.h
> @@ -520,7 +520,6 @@ struct omap_hwmod {
>   	struct clk			*_clk;
>   	struct omap_hwmod_opt_clk	*opt_clks;
>   	char				*vdd_name;

And what about vdd_name? It should probably be removed as well.

Benoit


  reply	other threads:[~2011-03-21 13:08 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-19  0:18 [PATCH 0/7] OMAP2+: voltage layer cleanup and restructure Kevin Hilman
2011-03-19  0:18 ` [PATCH 1/7] OMAP2+: hwmod: remove unused voltagedomain pointer Kevin Hilman
2011-03-21 13:08   ` Cousson, Benoit [this message]
2011-03-21 15:32     ` Kevin Hilman
2011-03-24 13:03       ` Gulati, Shweta
2011-03-24 14:00         ` Kevin Hilman
2011-03-24 15:14           ` Cousson, Benoit
2011-03-25  5:00             ` Gulati, Shweta
2011-03-22 19:13   ` Paul Walmsley
2011-03-19  0:18 ` [PATCH 2/7] OMAP2+: voltage: move PRCM mod offets into VDD structure Kevin Hilman
2011-03-19  4:41   ` Santosh Shilimkar
2011-03-21 15:21     ` Kevin Hilman
2011-03-21 10:53   ` Premi, Sanjeev
2011-03-21 15:26     ` Kevin Hilman
2011-03-23 14:16     ` Kevin Hilman
2011-03-19  0:18 ` [PATCH 3/7] OMAP2+: voltage: start towards a new voltagedomain layer Kevin Hilman
2011-03-19  0:18 ` [PATCH 4/7] OMAP2+: powerdomain: add voltage domain lookup during register Kevin Hilman
2011-03-22 19:23   ` Paul Walmsley
2011-03-22 20:59     ` Cousson, Benoit
2011-03-22 22:08       ` Paul Walmsley
2011-03-22 23:04         ` Cousson, Benoit
2011-04-02  1:17           ` Paul Walmsley
2011-03-23  0:17     ` Kevin Hilman
2011-03-19  0:18 ` [PATCH 5/7] OMAP2+: voltage: keep track of powerdomains in each voltagedomain Kevin Hilman
2011-03-22 19:35   ` Paul Walmsley
2011-03-23  0:18     ` Kevin Hilman
2011-03-19  0:18 ` [PATCH 6/7] OMAP2+: voltage: move prm_irqst_reg from VP into voltage domain Kevin Hilman
2011-03-19  0:18 ` [PATCH 7/7] OMAP3: powerdomain data: add voltage domains Kevin Hilman
2011-03-22 19:30   ` Paul Walmsley
2011-03-22 21:09     ` Cousson, Benoit
2011-03-22 22:15       ` Paul Walmsley
2011-03-23  0:20         ` Kevin Hilman
2011-03-23  0:31 ` [PATCH 0/7] OMAP2+: voltage layer cleanup and restructure Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D874DC9.6020203@ti.com \
    --to=b-cousson@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.