From: Kevin Hilman <khilman@ti.com>
To: "Premi, Sanjeev" <premi@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Paul Walmsely <paul@pwsan.com>,
"Cousson, Benoit" <b-cousson@ti.com>
Subject: Re: [PATCH 2/7] OMAP2+: voltage: move PRCM mod offets into VDD structure
Date: Wed, 23 Mar 2011 07:16:27 -0700 [thread overview]
Message-ID: <87r59x9b2c.fsf@ti.com> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB593024C3B8CA7@dbde02.ent.ti.com> (Sanjeev Premi's message of "Mon, 21 Mar 2011 16:23:49 +0530")
"Premi, Sanjeev" <premi@ti.com> writes:
[...]
>
>> diff --git a/arch/arm/mach-omap2/voltage.h
>> b/arch/arm/mach-omap2/voltage.h
>> index e9f5408..44edc1e 100644
>> --- a/arch/arm/mach-omap2/voltage.h
>> +++ b/arch/arm/mach-omap2/voltage.h
>> @@ -133,6 +133,9 @@ struct omap_vdd_info {
>> struct dentry *debug_dir;
>> u32 curr_volt;
>> bool vp_enabled;
>> +
>> + s16 prm_mod;
>> + s16 prm_irqst_mod;
>
> [sp] Can we match the type with the functions these are eventually
> passed to?
Looking closer at this, the functions that these values are passed to
actually take s16 values, so I will leave them as s16.
For example, for OMAP2/3, see prm2xxx_3xxx.h:
extern u32 omap2_prm_read_mod_reg(s16 module, u16 idx);
extern void omap2_prm_write_mod_reg(u32 val, s16 module, u16 idx);
The reason this is important is that on 3430, these module offsets might
actually be negative (c.f. OMAP3430_IVA2_MOD in prcm-common.h)
Kevin
next prev parent reply other threads:[~2011-03-23 14:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-19 0:18 [PATCH 0/7] OMAP2+: voltage layer cleanup and restructure Kevin Hilman
2011-03-19 0:18 ` [PATCH 1/7] OMAP2+: hwmod: remove unused voltagedomain pointer Kevin Hilman
2011-03-21 13:08 ` Cousson, Benoit
2011-03-21 15:32 ` Kevin Hilman
2011-03-24 13:03 ` Gulati, Shweta
2011-03-24 14:00 ` Kevin Hilman
2011-03-24 15:14 ` Cousson, Benoit
2011-03-25 5:00 ` Gulati, Shweta
2011-03-22 19:13 ` Paul Walmsley
2011-03-19 0:18 ` [PATCH 2/7] OMAP2+: voltage: move PRCM mod offets into VDD structure Kevin Hilman
2011-03-19 4:41 ` Santosh Shilimkar
2011-03-21 15:21 ` Kevin Hilman
2011-03-21 10:53 ` Premi, Sanjeev
2011-03-21 15:26 ` Kevin Hilman
2011-03-23 14:16 ` Kevin Hilman [this message]
2011-03-19 0:18 ` [PATCH 3/7] OMAP2+: voltage: start towards a new voltagedomain layer Kevin Hilman
2011-03-19 0:18 ` [PATCH 4/7] OMAP2+: powerdomain: add voltage domain lookup during register Kevin Hilman
2011-03-22 19:23 ` Paul Walmsley
2011-03-22 20:59 ` Cousson, Benoit
2011-03-22 22:08 ` Paul Walmsley
2011-03-22 23:04 ` Cousson, Benoit
2011-04-02 1:17 ` Paul Walmsley
2011-03-23 0:17 ` Kevin Hilman
2011-03-19 0:18 ` [PATCH 5/7] OMAP2+: voltage: keep track of powerdomains in each voltagedomain Kevin Hilman
2011-03-22 19:35 ` Paul Walmsley
2011-03-23 0:18 ` Kevin Hilman
2011-03-19 0:18 ` [PATCH 6/7] OMAP2+: voltage: move prm_irqst_reg from VP into voltage domain Kevin Hilman
2011-03-19 0:18 ` [PATCH 7/7] OMAP3: powerdomain data: add voltage domains Kevin Hilman
2011-03-22 19:30 ` Paul Walmsley
2011-03-22 21:09 ` Cousson, Benoit
2011-03-22 22:15 ` Paul Walmsley
2011-03-23 0:20 ` Kevin Hilman
2011-03-23 0:31 ` [PATCH 0/7] OMAP2+: voltage layer cleanup and restructure Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r59x9b2c.fsf@ti.com \
--to=khilman@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.