Re: [PATCH 2/7] OMAP2+: voltage: move PRCM mod offets into VDD structure

[Kevin Hilman <khilman@ti.com>]

"Premi, Sanjeev" <premi@ti.com> writes:

>> -----Original Message-----
>> From: linux-omap-owner@vger.kernel.org 
>> [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Hilman, Kevin
>> Sent: Saturday, March 19, 2011 5:49 AM
>> To: linux-omap@vger.kernel.org
>> Cc: Paul Walmsely; Cousson, Benoit
>> Subject: [PATCH 2/7] OMAP2+: voltage: move PRCM mod offets 
>> into VDD structure
>> 
>> Eliminate need for global variables for the various PRM 
>> module offsets by
>> making them part of the VDD structure.
>> 
>> Eventually, these will likely be moved again, or more likely removed,
>> but for now just getting rid of them as global variabes so that the
>> voltage domain initialization can be cleaned up.
>> 
>> Signed-off-by: Kevin Hilman <khilman@ti.com>
>
> [sp] This is almost what I intended to do in the clean-up patches
>      posted earlier; but for few differences.
>
>      Putting them here as well.
>
> [snip...snip]
>
>> diff --git a/arch/arm/mach-omap2/voltage.h 
>> b/arch/arm/mach-omap2/voltage.h
>> index e9f5408..44edc1e 100644
>> --- a/arch/arm/mach-omap2/voltage.h
>> +++ b/arch/arm/mach-omap2/voltage.h
>> @@ -133,6 +133,9 @@ struct omap_vdd_info {
>>  	struct dentry *debug_dir;
>>  	u32 curr_volt;
>>  	bool vp_enabled;
>> +
>> +	s16 prm_mod;
>> +	s16 prm_irqst_mod;
>
> [sp] Can we match the type with the functions these are eventually
>      passed to?

Yes, will change them to u16.

>      Also, prm_mod is "comstant" for the silicon.
>
>      Shouldn't it be a local static instead. Else, same value is
>      repeated for each vdd.

Yes.  As the changelog says these will likely be moved (or likely
removed all together) with further VC/VP cleanups which will move this
code into a dedicated VC/VP layers.

Kevin