Re: [PATCH 7/7] OMAP3: powerdomain data: add voltage domains

[Kevin Hilman <khilman@ti.com>]

Paul Walmsley <paul@pwsan.com> writes:

> On Tue, 22 Mar 2011, Cousson, Benoit wrote:
>
>> On 3/22/2011 8:30 PM, Paul Walmsley wrote:
>> > On Fri, 18 Mar 2011, Kevin Hilman wrote:
>> > 
>> > > Add voltage domain name to indicate which voltagedomain each
>> > > powerdomain is in.  A missing voltage domain name means that that
>> > > powerdomain is not in one of the currently scalable voltage domains.
>> > 
>> > Before you add these, you might want to change the voltagedomain names for
>> > OMAP3.  I don't think it's correct to refer to the VDD1 voltagedomain as
>> > "mpu" since it includes both the MPU and IVA.  Probably best to use simply
>> > "vdd1" and "vdd2" since that is the historical usage.
>> 
>> Yes, but it was confusing, hence the change on OMAP4.
>> "core" is fine and better that vdd2, maybe "mpu_iva" will be better for vdd1.
>> Moreover, it will be consistent will all the OMAP4+ chips.
>
> Calling it "mpu_iva" is fine with me also.
>

OK, will use "mpu_iva" and "core".  I much prefer these to vdd1 & vdd2.

>> > >   static struct powerdomain dpll1_pwrdm = {
>> > 
>> > These DPLL powerdomains should have voltagedomains also.  DPLL1 is in
>> > VDD1, I believe.  I think the rest are in VDD2.
>> 
>> DPLL1 (MPU) & DPLL2 (IVA) are inside vdd1, DPLL3, 4 & 5 are inside the core
>> (vdd2)
>
> Indeed.
>

Thanks, will fix.

Kevin