Re: [PATCH 12/25] sony-laptop: input core improvements improvements

[Marco Chiappero <marco@absence.it>]

Il 06/06/2011 00:24, Mattia Dongili ha scritto:
>> Sure and I consider to be a good alternative, but it looks to me
>> like being another workaround, it is fine for particular exceptions
>> that need a few remappings, but it should not be the rule, the
>> driver extension. That's why I was asking about this change.
>
> what is a better solution? having keymaps for every different layout
> that Sony implemented throught the years

This is a wrong assumption: the layout never really changed "recently" 
(I mean, at least 4-5 years, or even more), is still the same since a 
long time (and it's very likely to stay the same), Sony is just adding 
keys. For example, there are models with the Zoom In key (Fn-F10), but 
no Zoom Out (Fn-F9), but on those models Fn-F9 do not generate 
"scancodes". The same goes, for example, for newer models where the 
Fn-F1 key (Touchpad toggle) is now present. The hotkeys layout is now 
stable enough to be used as the default one for every model, causing no 
problems at all (very old models will continue to work through the udev 
keymaps already in place - well, just one, because module-sony would no 
longer be necessary -).
To answer your question: to me, it looks much better having a single 
real input driver mapping the right keys for everybody instead of having 
a fake layout plus a userspace keymap (because just a single keymap is 
needed).