Re: [PATCH 4/25] sony-laptop: new SNC setup and cleanup functions

[Marco Chiappero <marco@absence.it>]

Il 13/06/2011 02:01, Marco Chiappero ha scritto:
> Il 13/06/2011 00:21, Mattia Dongili ha scritto:
>>> +static int sony_nc_snc_setup(struct platform_device *pd)
>>
>> To be honest these sony_nc_snc_* functions are a bit poorly named.
>> sony_nc_ was already supposed to be a partial expansion of SNC so this
>> whole thing is a bit redundant now. what about
>> sony_nc_setup/sony_nc_cleanup?
>
> Yes I know but in the hurry I forgot to think about that, I will use
> this new naming schema.

I've been rethinking about this, I was rather unhappy with the 
sony_nc_snc_setup_handles and sony_nc_handles_setup names. I think that 
the best solution is:
- to rename sony_nc_handles_setup to sony_nc_handles_list_setup
- to include the sony_nc_setup_handles code back to sony_nc_snc_setup 
and to rename this last one sony_nc_handles_setup, that should now deal 
with the sole handles (and handles events) setup. The same goes for the 
sony_nc_snc_resume and sony_nc_snc_cleanup functions.