From: Avi Kivity <avi@redhat.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Nakajima, Jun" <jun.nakajima@intel.com>,
"Dong, Eddie" <eddie.dong@intel.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] KVM: APIC: avoid instruction emulation for EOI writes
Date: Mon, 29 Aug 2011 11:51:20 +0300 [thread overview]
Message-ID: <4E5B5308.6010402@redhat.com> (raw)
In-Reply-To: <1314605756.29761.17.camel@sasha>
On 08/29/2011 11:15 AM, Sasha Levin wrote:
> >
> > +#define APIC_ACCESS_TYPE_W 1 /* Linear write access during inst execution */
> > static int handle_apic_access(struct kvm_vcpu *vcpu)
> > {
> > + unsigned long exit_qualification = vmcs_readl(EXIT_QUALIFICATION);
> > + int access_type, offset;
> > +
> > + access_type = (exit_qualification>> 12)& 0xf;
> > + offset = exit_qualification& 0xfff;
>
> Maybe it's worth moving that #define above, and '#define'ing all the
> magic that happens in these 2 lines in vmx.h along with all the other
> exit qualification parameters?
Sure, that's what vmx.h is for. And 0xfff is ~PAGE_MASK.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-08-29 8:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 6:09 [PATCH] KVM: APIC: avoid instruction emulation for EOI writes Tian, Kevin
2011-08-29 7:23 ` Avi Kivity
2011-08-29 7:35 ` Tian, Kevin
2011-08-29 8:15 ` Sasha Levin
2011-08-29 8:51 ` Avi Kivity [this message]
2011-08-29 10:24 ` Jan Kiszka
2011-08-29 10:59 ` Avi Kivity
2011-08-29 11:03 ` Jan Kiszka
2011-08-29 11:11 ` Avi Kivity
2011-08-29 13:55 ` Jan Kiszka
2011-08-29 14:14 ` Avi Kivity
2011-09-10 8:41 ` ya su
2011-09-11 7:11 ` Avi Kivity
2011-09-11 8:05 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5B5308.6010402@redhat.com \
--to=avi@redhat.com \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.