From: Scott Wood <scottwood@freescale.com>
To: Li Yang-R58472 <r58472@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"Artem.Bityutskiy@nokia.com" <Artem.Bityutskiy@nokia.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Liu Shuo-B35362 <B35362@freescale.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"dwmw2@infradead.org" <dwmw2@infradead.org>
Subject: Re: [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip
Date: Mon, 28 Nov 2011 11:20:34 -0600 [thread overview]
Message-ID: <4ED3C2E2.9040601@freescale.com> (raw)
In-Reply-To: <3F607A5180246847A760FD34122A1E052DC4CD@039-SN1MPN1-003.039d.mgd.msft.net>
On 11/24/2011 01:37 AM, Li Yang-R58472 wrote:
>> +static void io_to_buffer(struct mtd_info *mtd, int subpage, int oob)
>> +{
>> + struct nand_chip *chip = mtd->priv;
>> + struct fsl_elbc_mtd *priv = chip->priv;
>> + struct fsl_elbc_fcm_ctrl *elbc_fcm_ctrl = priv->ctrl->nand;
>> + void *src, *dst;
>> + int len = (oob ? 64 : 2048);
>> +
>> + if (oob)
>> + dst = elbc_fcm_ctrl->buffer + mtd->writesize + subpage * 64;
>> + else
>> + dst = elbc_fcm_ctrl->buffer + subpage * 2048;
>> +
>> + src = elbc_fcm_ctrl->addr + (oob ? 2048 : 0);
>> + memcpy_fromio(dst, src, len);
>
> Might be safer to use _memcpy_fromio()
How so?
memcpy_fromio() is the public interface that will end up calling
_memcpy_fromio() on powerpc.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Li Yang-R58472 <r58472@freescale.com>
Cc: Liu Shuo-B35362 <B35362@freescale.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"Artem.Bityutskiy@nokia.com" <Artem.Bityutskiy@nokia.com>,
Wood Scott-B07421 <B07421@freescale.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip
Date: Mon, 28 Nov 2011 11:20:34 -0600 [thread overview]
Message-ID: <4ED3C2E2.9040601@freescale.com> (raw)
In-Reply-To: <3F607A5180246847A760FD34122A1E052DC4CD@039-SN1MPN1-003.039d.mgd.msft.net>
On 11/24/2011 01:37 AM, Li Yang-R58472 wrote:
>> +static void io_to_buffer(struct mtd_info *mtd, int subpage, int oob)
>> +{
>> + struct nand_chip *chip = mtd->priv;
>> + struct fsl_elbc_mtd *priv = chip->priv;
>> + struct fsl_elbc_fcm_ctrl *elbc_fcm_ctrl = priv->ctrl->nand;
>> + void *src, *dst;
>> + int len = (oob ? 64 : 2048);
>> +
>> + if (oob)
>> + dst = elbc_fcm_ctrl->buffer + mtd->writesize + subpage * 64;
>> + else
>> + dst = elbc_fcm_ctrl->buffer + subpage * 2048;
>> +
>> + src = elbc_fcm_ctrl->addr + (oob ? 2048 : 0);
>> + memcpy_fromio(dst, src, len);
>
> Might be safer to use _memcpy_fromio()
How so?
memcpy_fromio() is the public interface that will end up calling
_memcpy_fromio() on powerpc.
-Scott
next prev parent reply other threads:[~2011-11-28 17:20 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 0:41 [PATCH 1/3] mtd/nand : use elbc_fcm_ctrl->oob to set FPAR_MS bit of FPAR b35362
2011-11-24 0:41 ` b35362
2011-11-24 0:41 ` b35362
2011-11-24 0:41 ` [PATCH 2/3] mtd/nand : set correct length to FBCR for a non-full-page write b35362
2011-11-24 0:41 ` b35362
2011-11-24 0:41 ` b35362
2011-11-24 0:41 ` [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip b35362
2011-11-24 0:41 ` b35362
2011-11-24 0:41 ` b35362
2011-11-24 7:37 ` Li Yang-R58472
2011-11-24 7:37 ` Li Yang-R58472
2011-11-24 7:37 ` Li Yang-R58472
2011-11-28 17:20 ` Scott Wood [this message]
2011-11-28 17:20 ` Scott Wood
2011-11-24 7:41 ` Artem Bityutskiy
2011-11-24 7:41 ` Artem Bityutskiy
2011-11-24 7:41 ` Artem Bityutskiy
2011-11-24 7:49 ` Li Yang-R58472
2011-11-24 7:49 ` Li Yang-R58472
2011-11-24 7:49 ` Li Yang-R58472
2011-11-24 8:16 ` Artem Bityutskiy
2011-11-24 8:16 ` Artem Bityutskiy
2011-11-24 10:02 ` LiuShuo
2011-11-24 10:02 ` LiuShuo
2011-11-24 10:02 ` LiuShuo
2011-11-24 11:07 ` Artem Bityutskiy
2011-11-24 11:07 ` Artem Bityutskiy
2011-11-28 21:48 ` Scott Wood
2011-11-28 21:48 ` Scott Wood
2011-11-28 21:48 ` Scott Wood
2011-11-28 21:49 ` Scott Wood
2011-11-28 21:49 ` Scott Wood
2011-11-28 21:49 ` Scott Wood
-- strict thread matches above, loose matches on Subject: below --
2011-12-04 4:31 [PATCH 1/3] mtd/nand : use elbc_fcm_ctrl->oob to set FPAR_MS bit of FPAR shuo.liu
2011-12-04 4:31 ` [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip shuo.liu
2011-12-04 4:31 ` shuo.liu
2011-12-04 4:31 ` shuo.liu
2011-12-05 6:47 ` Artem Bityutskiy
2011-12-05 6:47 ` Artem Bityutskiy
2011-12-05 6:47 ` Artem Bityutskiy
2011-12-05 19:46 ` Scott Wood
2011-12-05 19:46 ` Scott Wood
2011-12-06 11:49 ` Artem Bityutskiy
2011-12-06 11:49 ` Artem Bityutskiy
2011-12-06 11:49 ` Artem Bityutskiy
2011-12-06 11:49 ` Artem Bityutskiy
2011-12-06 11:49 ` Artem Bityutskiy
2011-12-07 0:09 ` Scott Wood
2011-12-07 0:09 ` Scott Wood
2011-12-07 0:09 ` Scott Wood
2011-12-07 3:55 ` LiuShuo
2011-12-07 3:55 ` LiuShuo
2011-12-07 3:55 ` LiuShuo
2011-12-07 19:11 ` Scott Wood
2011-12-07 19:11 ` Scott Wood
2011-12-07 19:11 ` Scott Wood
2011-12-08 10:44 ` LiuShuo
2011-12-08 10:44 ` LiuShuo
2011-12-08 10:44 ` LiuShuo
2011-12-08 18:43 ` Scott Wood
2011-12-08 18:43 ` Scott Wood
2011-12-08 18:43 ` Scott Wood
2011-12-12 21:09 ` Artem Bityutskiy
2011-12-12 21:09 ` Artem Bityutskiy
2011-12-12 21:09 ` Artem Bityutskiy
2011-12-12 21:15 ` Scott Wood
2011-12-12 21:15 ` Scott Wood
2011-12-12 21:15 ` Scott Wood
2011-12-12 21:19 ` Artem Bityutskiy
2011-12-12 21:19 ` Artem Bityutskiy
2011-12-12 21:19 ` Artem Bityutskiy
2011-12-12 21:30 ` Scott Wood
2011-12-12 21:30 ` Scott Wood
2011-12-12 21:30 ` Scott Wood
2011-12-13 2:46 ` LiuShuo
2011-12-13 2:46 ` LiuShuo
2011-12-13 2:46 ` LiuShuo
2011-12-14 8:41 ` LiuShuo
2011-12-14 8:41 ` LiuShuo
2011-12-14 8:41 ` LiuShuo
2011-12-14 20:15 ` Scott Wood
2011-12-14 20:15 ` Scott Wood
2011-12-14 20:15 ` Scott Wood
2011-12-15 4:59 ` Li Yang
2011-12-15 4:59 ` Li Yang
2011-12-15 4:59 ` Li Yang
2011-12-15 17:32 ` Scott Wood
2011-12-15 17:32 ` Scott Wood
2011-12-16 2:44 ` LiuShuo
2011-12-16 2:44 ` LiuShuo
2011-12-16 2:44 ` LiuShuo
2011-12-16 17:59 ` Scott Wood
2011-12-16 17:59 ` Scott Wood
2011-12-16 17:59 ` Scott Wood
2011-12-19 11:05 ` Li Yang
2011-12-19 11:05 ` Li Yang
2011-12-19 11:05 ` Li Yang
2011-12-19 16:47 ` Scott Wood
2011-12-19 16:47 ` Scott Wood
2011-12-20 9:08 ` Li Yang
2011-12-20 9:08 ` Li Yang
2011-12-20 9:08 ` Li Yang
2011-12-20 19:48 ` Scott Wood
2011-12-20 19:48 ` Scott Wood
2011-12-17 14:35 ` Artem Bityutskiy
2011-12-17 14:35 ` Artem Bityutskiy
2011-12-17 14:35 ` Artem Bityutskiy
2011-12-19 18:38 ` Scott Wood
2011-12-19 18:38 ` Scott Wood
2011-12-19 18:38 ` Scott Wood
2011-12-19 18:42 ` Scott Wood
2011-12-19 18:42 ` Scott Wood
2011-12-14 3:41 ` LiuShuo
2011-12-14 3:41 ` LiuShuo
2011-12-14 3:41 ` LiuShuo
2011-12-14 20:53 ` Scott Wood
2011-12-14 20:53 ` Scott Wood
2011-12-14 20:53 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED3C2E2.9040601@freescale.com \
--to=scottwood@freescale.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=B07421@freescale.com \
--cc=B35362@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r58472@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.