All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: LiuShuo <b35362@freescale.com>
Cc: Artem.Bityutskiy@nokia.com, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, shuo.liu@freescale.com,
	linux-mtd@lists.infradead.org, akpm@linux-foundation.org,
	leoli@freescale.com, dwmw2@infradead.org
Subject: Re: [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip
Date: Thu, 8 Dec 2011 12:43:52 -0600	[thread overview]
Message-ID: <4EE10568.9070002@freescale.com> (raw)
In-Reply-To: <4EE09526.5040705@freescale.com>

On 12/08/2011 04:44 AM, LiuShuo wrote:
> 于 2011年12月08日 03:11, Scott Wood 写道:
>> And if we do want to make such assumptions, we could rip out all usage
>> of index/column here, and just handle "oob" and "full page" cases.
> The function nand_do_write_ops() in nandbase.c is a Nand internal
> interface.
> It always is called when application write to nand flash. (e.g. dd)
> In this function, partial page write is dealt with by filling '0xff' to
> buffer before data copy.
> (nand_do_write_oob() is similar)
> So I don't think we need to do it in our controller driver again, it
> should be a job of upper layer.

If this is to be considered part of the interface contract, then perhaps
do a WARN_ON() if we see an unexpected index/column?  And after that,
only consider full-page or full-oob possibilities.

-Scott

WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: LiuShuo <b35362@freescale.com>
Cc: Artem.Bityutskiy@nokia.com, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, shuo.liu@freescale.com,
	linux-mtd@lists.infradead.org, akpm@linux-foundation.org,
	dwmw2@infradead.org
Subject: Re: [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip
Date: Thu, 8 Dec 2011 12:43:52 -0600	[thread overview]
Message-ID: <4EE10568.9070002@freescale.com> (raw)
In-Reply-To: <4EE09526.5040705@freescale.com>

On 12/08/2011 04:44 AM, LiuShuo wrote:
> =E4=BA=8E 2011=E5=B9=B412=E6=9C=8808=E6=97=A5 03:11, Scott Wood =E5=86=99=
=E9=81=93:
>> And if we do want to make such assumptions, we could rip out all usage
>> of index/column here, and just handle "oob" and "full page" cases.
> The function nand_do_write_ops() in nandbase.c is a Nand internal
> interface.
> It always is called when application write to nand flash. (e.g. dd)
> In this function, partial page write is dealt with by filling '0xff' to
> buffer before data copy.
> (nand_do_write_oob() is similar)
> So I don't think we need to do it in our controller driver again, it
> should be a job of upper layer.

If this is to be considered part of the interface contract, then perhaps
do a WARN_ON() if we see an unexpected index/column?  And after that,
only consider full-page or full-oob possibilities.

-Scott

WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: LiuShuo <b35362@freescale.com>
Cc: <shuo.liu@freescale.com>, <dwmw2@infradead.org>,
	<Artem.Bityutskiy@nokia.com>, <linux-mtd@lists.infradead.org>,
	<linuxppc-dev@lists.ozlabs.org>, <akpm@linux-foundation.org>,
	<linux-kernel@vger.kernel.org>, <leoli@freescale.com>
Subject: Re: [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip
Date: Thu, 8 Dec 2011 12:43:52 -0600	[thread overview]
Message-ID: <4EE10568.9070002@freescale.com> (raw)
In-Reply-To: <4EE09526.5040705@freescale.com>

On 12/08/2011 04:44 AM, LiuShuo wrote:
> 于 2011年12月08日 03:11, Scott Wood 写道:
>> And if we do want to make such assumptions, we could rip out all usage
>> of index/column here, and just handle "oob" and "full page" cases.
> The function nand_do_write_ops() in nandbase.c is a Nand internal
> interface.
> It always is called when application write to nand flash. (e.g. dd)
> In this function, partial page write is dealt with by filling '0xff' to
> buffer before data copy.
> (nand_do_write_oob() is similar)
> So I don't think we need to do it in our controller driver again, it
> should be a job of upper layer.

If this is to be considered part of the interface contract, then perhaps
do a WARN_ON() if we see an unexpected index/column?  And after that,
only consider full-page or full-oob possibilities.

-Scott


  reply	other threads:[~2011-12-08 18:43 UTC|newest]

Thread overview: 120+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-04  4:31 [PATCH 1/3] mtd/nand : use elbc_fcm_ctrl->oob to set FPAR_MS bit of FPAR shuo.liu
2011-12-04  4:31 ` shuo.liu
2011-12-04  4:31 ` shuo.liu
2011-12-04  4:31 ` [PATCH 2/3] mtd/nand : set correct length to FBCR for a non-full-page write shuo.liu
2011-12-04  4:31   ` shuo.liu
2011-12-04  4:31   ` shuo.liu
2011-12-04  4:31 ` [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip shuo.liu
2011-12-04  4:31   ` shuo.liu
2011-12-04  4:31   ` shuo.liu
2011-12-05  6:47   ` Artem Bityutskiy
2011-12-05  6:47     ` Artem Bityutskiy
2011-12-05  6:47     ` Artem Bityutskiy
2011-12-05 19:46     ` Scott Wood
2011-12-05 19:46       ` Scott Wood
2011-12-06 11:49       ` Artem Bityutskiy
2011-12-06 11:49         ` Artem Bityutskiy
2011-12-06 11:49   ` Artem Bityutskiy
2011-12-06 11:49     ` Artem Bityutskiy
2011-12-06 11:49     ` Artem Bityutskiy
2011-12-07  0:09   ` Scott Wood
2011-12-07  0:09     ` Scott Wood
2011-12-07  0:09     ` Scott Wood
2011-12-07  3:55     ` LiuShuo
2011-12-07  3:55       ` LiuShuo
2011-12-07  3:55       ` LiuShuo
2011-12-07 19:11       ` Scott Wood
2011-12-07 19:11         ` Scott Wood
2011-12-07 19:11         ` Scott Wood
2011-12-08 10:44         ` LiuShuo
2011-12-08 10:44           ` LiuShuo
2011-12-08 10:44           ` LiuShuo
2011-12-08 18:43           ` Scott Wood [this message]
2011-12-08 18:43             ` Scott Wood
2011-12-08 18:43             ` Scott Wood
2011-12-12 21:09     ` Artem Bityutskiy
2011-12-12 21:09       ` Artem Bityutskiy
2011-12-12 21:09       ` Artem Bityutskiy
2011-12-12 21:15       ` Scott Wood
2011-12-12 21:15         ` Scott Wood
2011-12-12 21:15         ` Scott Wood
2011-12-12 21:19         ` Artem Bityutskiy
2011-12-12 21:19           ` Artem Bityutskiy
2011-12-12 21:19           ` Artem Bityutskiy
2011-12-12 21:30           ` Scott Wood
2011-12-12 21:30             ` Scott Wood
2011-12-12 21:30             ` Scott Wood
2011-12-13  2:46             ` LiuShuo
2011-12-13  2:46               ` LiuShuo
2011-12-13  2:46               ` LiuShuo
2011-12-14  8:41               ` LiuShuo
2011-12-14  8:41                 ` LiuShuo
2011-12-14  8:41                 ` LiuShuo
2011-12-14 20:15                 ` Scott Wood
2011-12-14 20:15                   ` Scott Wood
2011-12-14 20:15                   ` Scott Wood
2011-12-15  4:59                   ` Li Yang
2011-12-15  4:59                     ` Li Yang
2011-12-15  4:59                     ` Li Yang
2011-12-15 17:32                     ` Scott Wood
2011-12-15 17:32                       ` Scott Wood
2011-12-16  2:44                   ` LiuShuo
2011-12-16  2:44                     ` LiuShuo
2011-12-16  2:44                     ` LiuShuo
2011-12-16 17:59                     ` Scott Wood
2011-12-16 17:59                       ` Scott Wood
2011-12-16 17:59                       ` Scott Wood
2011-12-19 11:05                       ` Li Yang
2011-12-19 11:05                         ` Li Yang
2011-12-19 11:05                         ` Li Yang
2011-12-19 16:47                         ` Scott Wood
2011-12-19 16:47                           ` Scott Wood
2011-12-20  9:08                           ` Li Yang
2011-12-20  9:08                             ` Li Yang
2011-12-20  9:08                             ` Li Yang
2011-12-20 19:48                             ` Scott Wood
2011-12-20 19:48                               ` Scott Wood
2011-12-17 14:35             ` Artem Bityutskiy
2011-12-17 14:35               ` Artem Bityutskiy
2011-12-17 14:35               ` Artem Bityutskiy
2011-12-19 18:38               ` Scott Wood
2011-12-19 18:38                 ` Scott Wood
2011-12-19 18:38                 ` Scott Wood
2011-12-19 18:42                 ` Scott Wood
2011-12-19 18:42                   ` Scott Wood
2011-12-14  3:41       ` LiuShuo
2011-12-14  3:41         ` LiuShuo
2011-12-14  3:41         ` LiuShuo
2011-12-14 20:53         ` Scott Wood
2011-12-14 20:53           ` Scott Wood
2011-12-14 20:53           ` Scott Wood
2011-12-05  6:50 ` [PATCH 1/3] mtd/nand : use elbc_fcm_ctrl->oob to set FPAR_MS bit of FPAR Artem Bityutskiy
2011-12-05  6:50   ` Artem Bityutskiy
2011-12-05  6:50   ` Artem Bityutskiy
  -- strict thread matches above, loose matches on Subject: below --
2011-11-24  0:41 b35362
2011-11-24  0:41 ` [PATCH 3/3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip b35362
2011-11-24  0:41   ` b35362
2011-11-24  0:41   ` b35362
2011-11-24  7:37   ` Li Yang-R58472
2011-11-24  7:37     ` Li Yang-R58472
2011-11-24  7:37     ` Li Yang-R58472
2011-11-28 17:20     ` Scott Wood
2011-11-28 17:20       ` Scott Wood
2011-11-24  7:41   ` Artem Bityutskiy
2011-11-24  7:41     ` Artem Bityutskiy
2011-11-24  7:41     ` Artem Bityutskiy
2011-11-24  7:49     ` Li Yang-R58472
2011-11-24  7:49       ` Li Yang-R58472
2011-11-24  7:49       ` Li Yang-R58472
2011-11-24  8:16       ` Artem Bityutskiy
2011-11-24  8:16         ` Artem Bityutskiy
2011-11-24 10:02         ` LiuShuo
2011-11-24 10:02           ` LiuShuo
2011-11-24 10:02           ` LiuShuo
2011-11-24 11:07           ` Artem Bityutskiy
2011-11-24 11:07             ` Artem Bityutskiy
2011-11-28 21:48   ` Scott Wood
2011-11-28 21:48     ` Scott Wood
2011-11-28 21:48     ` Scott Wood
2011-11-28 21:49     ` Scott Wood
2011-11-28 21:49       ` Scott Wood
2011-11-28 21:49       ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE10568.9070002@freescale.com \
    --to=scottwood@freescale.com \
    --cc=Artem.Bityutskiy@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=b35362@freescale.com \
    --cc=dwmw2@infradead.org \
    --cc=leoli@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=shuo.liu@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.