* [Qemu-devel] Broken realview
@ 2012-02-09 5:16 Evgeny Voevodin
2012-02-09 6:04 ` Peter Maydell
2012-02-09 6:13 ` Peter Maydell
0 siblings, 2 replies; 7+ messages in thread
From: Evgeny Voevodin @ 2012-02-09 5:16 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, aliguori, Dmitry Solodkiy
Since last QOM patch set landed into master, realview-pbx-a9,
realview-eb-mpcore (suppose that other too) abort with error:
qemu/hw/qdev-properties.c:1161: qdev_prop_set_uint32: Assertion `!errp'
failed.
Aborted
Bisect result:
9b170e60adc6dc01564128cf09f96ec923ed6526 is the first bad commit
commit 9b170e60adc6dc01564128cf09f96ec923ed6526
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: Thu Feb 2 12:51:44 2012 +0100
qdev: access properties via QOM
Do not poke anymore in the struct when accessing qdev properties.
Instead, ask the object to set the right value.
Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
--
Kind regards,
Evgeny Voevodin,
Leading Software Engineer,
ASWG, Moscow R&D center, Samsung Electronics
e-mail: e.voevodin@samsung.com
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Qemu-devel] Broken realview
2012-02-09 5:16 [Qemu-devel] Broken realview Evgeny Voevodin
@ 2012-02-09 6:04 ` Peter Maydell
2012-02-09 6:13 ` Evgeny Voevodin
2012-02-09 6:13 ` Peter Maydell
1 sibling, 1 reply; 7+ messages in thread
From: Peter Maydell @ 2012-02-09 6:04 UTC (permalink / raw)
To: Evgeny Voevodin; +Cc: pbonzini, aliguori, qemu-devel, Dmitry Solodkiy
On 9 February 2012 05:16, Evgeny Voevodin <e.voevodin@samsung.com> wrote:
> Since last QOM patch set landed into master, realview-pbx-a9,
> realview-eb-mpcore (suppose that other too) abort with error:
>
> qemu/hw/qdev-properties.c:1161: qdev_prop_set_uint32: Assertion `!errp'
> failed.
> Aborted
The realview etc board models were accidentally setting the proc_id
property on the sysctl register device after init rather than before.
This hasn't been detected as an error up til now. Patch coming up shortly...
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] Broken realview
2012-02-09 6:04 ` Peter Maydell
@ 2012-02-09 6:13 ` Evgeny Voevodin
2012-02-09 6:15 ` Peter Maydell
0 siblings, 1 reply; 7+ messages in thread
From: Evgeny Voevodin @ 2012-02-09 6:13 UTC (permalink / raw)
To: Peter Maydell; +Cc: pbonzini, aliguori, qemu-devel, Dmitry Solodkiy
On 02/09/2012 10:04 AM, Peter Maydell wrote:
> On 9 February 2012 05:16, Evgeny Voevodin<e.voevodin@samsung.com> wrote:
>> Since last QOM patch set landed into master, realview-pbx-a9,
>> realview-eb-mpcore (suppose that other too) abort with error:
>>
>> qemu/hw/qdev-properties.c:1161: qdev_prop_set_uint32: Assertion `!errp'
>> failed.
>> Aborted
>
> The realview etc board models were accidentally setting the proc_id
> property on the sysctl register device after init rather than before.
> This hasn't been detected as an error up til now. Patch coming up shortly...
>
> -- PMM
>
>
Hi, Peter.
It seems that we have to rebase our exynos boards again ). So, am I
right supposing that exynos will not be applied until all QOM patch sets
landed?
--
Kind regards,
Evgeny Voevodin,
Leading Software Engineer,
ASWG, Moscow R&D center, Samsung Electronics
e-mail: e.voevodin@samsung.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] Broken realview
2012-02-09 6:13 ` Evgeny Voevodin
@ 2012-02-09 6:15 ` Peter Maydell
2012-02-09 6:18 ` Evgeny Voevodin
0 siblings, 1 reply; 7+ messages in thread
From: Peter Maydell @ 2012-02-09 6:15 UTC (permalink / raw)
To: Evgeny Voevodin; +Cc: pbonzini, aliguori, qemu-devel, Dmitry Solodkiy
On 9 February 2012 06:13, Evgeny Voevodin <e.voevodin@samsung.com> wrote:
> It seems that we have to rebase our exynos boards again ). So, am I right
> supposing that exynos will not be applied until all QOM patch sets landed?
Anthony claims there aren't any more QOM patchsets which touch all the
files in the tree, so now is probably a good time to rebase and resubmit...
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] Broken realview
2012-02-09 6:15 ` Peter Maydell
@ 2012-02-09 6:18 ` Evgeny Voevodin
2012-02-09 7:08 ` Evgeny Voevodin
0 siblings, 1 reply; 7+ messages in thread
From: Evgeny Voevodin @ 2012-02-09 6:18 UTC (permalink / raw)
To: Peter Maydell; +Cc: pbonzini, aliguori, qemu-devel, Dmitry Solodkiy
On 02/09/2012 10:15 AM, Peter Maydell wrote:
> On 9 February 2012 06:13, Evgeny Voevodin<e.voevodin@samsung.com> wrote:
>> It seems that we have to rebase our exynos boards again ). So, am I right
>> supposing that exynos will not be applied until all QOM patch sets landed?
>
> Anthony claims there aren't any more QOM patchsets which touch all the
> files in the tree, so now is probably a good time to rebase and resubmit...
>
> -- PMM
>
>
Oh, good news :) Today be ready to receive v14 then.
--
Kind regards,
Evgeny Voevodin,
Leading Software Engineer,
ASWG, Moscow R&D center, Samsung Electronics
e-mail: e.voevodin@samsung.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] Broken realview
2012-02-09 6:18 ` Evgeny Voevodin
@ 2012-02-09 7:08 ` Evgeny Voevodin
0 siblings, 0 replies; 7+ messages in thread
From: Evgeny Voevodin @ 2012-02-09 7:08 UTC (permalink / raw)
Cc: Peter Maydell, qemu-devel, Dmitry Solodkiy
On 02/09/2012 10:18 AM, Evgeny Voevodin wrote:
> On 02/09/2012 10:15 AM, Peter Maydell wrote:
>> On 9 February 2012 06:13, Evgeny Voevodin<e.voevodin@samsung.com> wrote:
>>> It seems that we have to rebase our exynos boards again ). So, am I
>>> right
>>> supposing that exynos will not be applied until all QOM patch sets
>>> landed?
>>
>> Anthony claims there aren't any more QOM patchsets which touch all the
>> files in the tree, so now is probably a good time to rebase and
>> resubmit...
>>
>> -- PMM
>>
>>
>
> Oh, good news :) Today be ready to receive v14 then.
>
Offtopic:
Peter, what do you think is better for our Exynos platform since it runs
only on two CPUs:
- ignore smp_cpus (and throw a warning if "-smp" not equals to 2)
or
- rewrite smp_cpus and use it (and throw a warning if "-smp" not
equals to 2)
--
Kind regards,
Evgeny Voevodin,
Leading Software Engineer,
ASWG, Moscow R&D center, Samsung Electronics
e-mail: e.voevodin@samsung.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] Broken realview
2012-02-09 5:16 [Qemu-devel] Broken realview Evgeny Voevodin
2012-02-09 6:04 ` Peter Maydell
@ 2012-02-09 6:13 ` Peter Maydell
1 sibling, 0 replies; 7+ messages in thread
From: Peter Maydell @ 2012-02-09 6:13 UTC (permalink / raw)
To: Evgeny Voevodin; +Cc: pbonzini, aliguori, qemu-devel, Dmitry Solodkiy
On 9 February 2012 05:16, Evgeny Voevodin <e.voevodin@samsung.com> wrote:
> Since last QOM patch set landed into master, realview-pbx-a9,
> realview-eb-mpcore (suppose that other too) abort with error:
>
> qemu/hw/qdev-properties.c:1161: qdev_prop_set_uint32: Assertion `!errp'
> failed.
Incidentally, this is a rather unhelpful diagnostic for "attempt to
set a property after initialization"...
-- PMM
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-02-09 7:09 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-09 5:16 [Qemu-devel] Broken realview Evgeny Voevodin
2012-02-09 6:04 ` Peter Maydell
2012-02-09 6:13 ` Evgeny Voevodin
2012-02-09 6:15 ` Peter Maydell
2012-02-09 6:18 ` Evgeny Voevodin
2012-02-09 7:08 ` Evgeny Voevodin
2012-02-09 6:13 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.