[PATCH 0/5][KERNEL] add x/ehci-hcd and mei features

[PATCH 0/5][KERNEL] add x/ehci-hcd and mei features

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

This adds a few new features, one for xhci-hcd and another for
amt/mei, and refactors some existing config options into a new
echi-hcd, which is then used in crownbay.

If this looks like the way to go, I'll add similar USB features
for ohci and uhci and fix up all the meta-intel BSPs to use
them.

Please pull into linux-yocto-3.2.

Thanks,

Tom

The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
  Yang Shi (1):
        meta: Clean up BSPs kernel config

are available in the git repository at:

  git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
  http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features

Tom Zanussi (5):
  meta: add usb/host/base feature
  meta: add usb/xhci-hcd feature
  meta: add usb/ehci-hcd feature
  meta/crownbay: use ehci-hcd feature
  meta: add mei feature

 meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    4 ----
 meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    2 ++
 meta/cfg/kernel-cache/features/amt/mei/mei.cfg     |    3 +++
 meta/cfg/kernel-cache/features/amt/mei/mei.scc     |    4 ++++
 .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
 .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
 meta/cfg/kernel-cache/features/usb/host/base.cfg   |    3 +++
 meta/cfg/kernel-cache/features/usb/host/base.scc   |    4 ++++
 .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
 .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
 10 files changed, 30 insertions(+), 4 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
 create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
 create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc
 create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc
 create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc

[PATCH 1/5][KERNEL] meta: add usb/host/base feature

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Add a feature to enable 'base' support for USB, mainly to be included
by derived features such as ehch, xhci, etc.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/features/usb/host/base.cfg |    3 +++
 meta/cfg/kernel-cache/features/usb/host/base.scc |    4 ++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc

diff --git a/meta/cfg/kernel-cache/features/usb/host/base.cfg b/meta/cfg/kernel-cache/features/usb/host/base.cfg
new file mode 100644
index 0000000..dec6a47
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/usb/host/base.cfg
@@ -0,0 +1,3 @@
+CONFIG_USB_SUPPORT=y
+CONFIG_USB=y
+
diff --git a/meta/cfg/kernel-cache/features/usb/host/base.scc b/meta/cfg/kernel-cache/features/usb/host/base.scc
new file mode 100644
index 0000000..3c93475
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/usb/host/base.scc
@@ -0,0 +1,4 @@
+define KFEATURE_DESCRIPTION "Enable core options for USB support"
+define KFEATURE_COMPATIBILITY board
+
+kconf hardware base.cfg
-- 
1.7.0.4

Re: [PATCH 1/5][KERNEL] meta: add usb/host/base feature

[Darren Hart]

On 05/02/2012 08:35 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi <tom.zanussi@intel.com>
> 
> Add a feature to enable 'base' support for USB, mainly to be included
> by derived features such as ehch, xhci, etc.

This seems overly granular in my opinion. I think I would just include
the two required options in each of the *hci features.

--
Darren

> 
> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
> ---
>  meta/cfg/kernel-cache/features/usb/host/base.cfg |    3 +++
>  meta/cfg/kernel-cache/features/usb/host/base.scc |    4 ++++
>  2 files changed, 7 insertions(+), 0 deletions(-)
>  create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
>  create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc
> 
> diff --git a/meta/cfg/kernel-cache/features/usb/host/base.cfg b/meta/cfg/kernel-cache/features/usb/host/base.cfg
> new file mode 100644
> index 0000000..dec6a47
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/features/usb/host/base.cfg
> @@ -0,0 +1,3 @@
> +CONFIG_USB_SUPPORT=y
> +CONFIG_USB=y
> +
> diff --git a/meta/cfg/kernel-cache/features/usb/host/base.scc b/meta/cfg/kernel-cache/features/usb/host/base.scc
> new file mode 100644
> index 0000000..3c93475
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/features/usb/host/base.scc
> @@ -0,0 +1,4 @@
> +define KFEATURE_DESCRIPTION "Enable core options for USB support"
> +define KFEATURE_COMPATIBILITY board
> +
> +kconf hardware base.cfg

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 1/5][KERNEL] meta: add usb/host/base feature

[Tom Zanussi]

On Fri, 2012-05-04 at 09:16 -0700, Darren Hart wrote:
> 
> On 05/02/2012 08:35 PM, tom.zanussi@intel.com wrote:
> > From: Tom Zanussi <tom.zanussi@intel.com>
> > 
> > Add a feature to enable 'base' support for USB, mainly to be included
> > by derived features such as ehch, xhci, etc.
> 
> This seems overly granular in my opinion. I think I would just include
> the two required options in each of the *hci features.
> 

Really?  This seems to me a perfect use case for taking advantage of the
'reusibality' conf fragments offer.  There would be four of these, that
alone would seem to justify using a 'subroutine', but there could be
more in the future, and if so, this fragment would be readily available.

i.e. I don't see any reason to 'inline' these...

Tom

> --
> Darren
> 
> > 
> > Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
> > ---
> >  meta/cfg/kernel-cache/features/usb/host/base.cfg |    3 +++
> >  meta/cfg/kernel-cache/features/usb/host/base.scc |    4 ++++
> >  2 files changed, 7 insertions(+), 0 deletions(-)
> >  create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
> >  create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc
> > 
> > diff --git a/meta/cfg/kernel-cache/features/usb/host/base.cfg b/meta/cfg/kernel-cache/features/usb/host/base.cfg
> > new file mode 100644
> > index 0000000..dec6a47
> > --- /dev/null
> > +++ b/meta/cfg/kernel-cache/features/usb/host/base.cfg
> > @@ -0,0 +1,3 @@
> > +CONFIG_USB_SUPPORT=y
> > +CONFIG_USB=y
> > +
> > diff --git a/meta/cfg/kernel-cache/features/usb/host/base.scc b/meta/cfg/kernel-cache/features/usb/host/base.scc
> > new file mode 100644
> > index 0000000..3c93475
> > --- /dev/null
> > +++ b/meta/cfg/kernel-cache/features/usb/host/base.scc
> > @@ -0,0 +1,4 @@
> > +define KFEATURE_DESCRIPTION "Enable core options for USB support"
> > +define KFEATURE_COMPATIBILITY board
> > +
> > +kconf hardware base.cfg
> 

Re: [PATCH 1/5][KERNEL] meta: add usb/host/base feature

[Darren Hart]

On 05/04/2012 09:28 AM, Tom Zanussi wrote:
> On Fri, 2012-05-04 at 09:16 -0700, Darren Hart wrote:
>>
>> On 05/02/2012 08:35 PM, tom.zanussi@intel.com wrote:
>>> From: Tom Zanussi <tom.zanussi@intel.com>
>>>
>>> Add a feature to enable 'base' support for USB, mainly to be included
>>> by derived features such as ehch, xhci, etc.
>>
>> This seems overly granular in my opinion. I think I would just include
>> the two required options in each of the *hci features.
>>
> 
> Really?  This seems to me a perfect use case for taking advantage of the
> 'reusibality' conf fragments offer.  There would be four of these, that
> alone would seem to justify using a 'subroutine', but there could be
> more in the future, and if so, this fragment would be readily available.
> 

I agree in principle, but feel the two lines of obvious requirements
aren't worth it.

> i.e. I don't see any reason to 'inline' these...

I think "the line" is obviously a subjective one. And since you are the
one that put in the time to prepare the meta-data, I don't feel strongly
enough about it to argue the point. So I won't object to them going in
as is.

--
Darren

> 
> Tom
> 
>> --
>> Darren
>>
>>>
>>> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
>>> ---
>>>  meta/cfg/kernel-cache/features/usb/host/base.cfg |    3 +++
>>>  meta/cfg/kernel-cache/features/usb/host/base.scc |    4 ++++
>>>  2 files changed, 7 insertions(+), 0 deletions(-)
>>>  create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
>>>  create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc
>>>
>>> diff --git a/meta/cfg/kernel-cache/features/usb/host/base.cfg b/meta/cfg/kernel-cache/features/usb/host/base.cfg
>>> new file mode 100644
>>> index 0000000..dec6a47
>>> --- /dev/null
>>> +++ b/meta/cfg/kernel-cache/features/usb/host/base.cfg
>>> @@ -0,0 +1,3 @@
>>> +CONFIG_USB_SUPPORT=y
>>> +CONFIG_USB=y
>>> +
>>> diff --git a/meta/cfg/kernel-cache/features/usb/host/base.scc b/meta/cfg/kernel-cache/features/usb/host/base.scc
>>> new file mode 100644
>>> index 0000000..3c93475
>>> --- /dev/null
>>> +++ b/meta/cfg/kernel-cache/features/usb/host/base.scc
>>> @@ -0,0 +1,4 @@
>>> +define KFEATURE_DESCRIPTION "Enable core options for USB support"
>>> +define KFEATURE_COMPATIBILITY board
>>> +
>>> +kconf hardware base.cfg
>>
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

[PATCH 2/5][KERNEL] meta: add usb/xhci-hcd feature

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Add an 'xhci-hcd' feature that turns on the kernel options required to
support xhci (USB 3.0).

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
 .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc

diff --git a/meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg b/meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg
new file mode 100644
index 0000000..ae4294b
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg
@@ -0,0 +1 @@
+CONFIG_USB_XHCI_HCD=y
diff --git a/meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc b/meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc
new file mode 100644
index 0000000..e9251af
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc
@@ -0,0 +1,6 @@
+define KFEATURE_DESCRIPTION "Enable options for xhci (USB 3.0)"
+define KFEATURE_COMPATIBILITY board
+
+kconf hardware xhci-hcd.cfg
+
+include features/usb/host/base.scc
-- 
1.7.0.4

[PATCH 3/5][KERNEL] meta: add usb/ehci-hcd feature

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Add an 'ehci-hcd' feature that turns on the kernel options required to
support ehci (USB 2.0).

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
 .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc

diff --git a/meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg b/meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg
new file mode 100644
index 0000000..7322dc2
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg
@@ -0,0 +1 @@
+CONFIG_USB_EHCI_HCD=y
diff --git a/meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc b/meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc
new file mode 100644
index 0000000..6ed0944
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc
@@ -0,0 +1,6 @@
+define KFEATURE_DESCRIPTION "Enable options for ehci (USB 2.0)"
+define KFEATURE_COMPATIBILITY board
+
+kconf hardware ehci-hcd.cfg
+
+include features/usb/host/base.scc
-- 
1.7.0.4

[PATCH 4/5][KERNEL] meta/crownbay: use ehci-hcd feature

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Use the ehci-hcd feature and remove the associated config settings
from crownbay.cfg

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    4 ----
 meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc |    2 ++
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
index b101419..7a8b7ba 100644
--- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
+++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
@@ -10,13 +10,9 @@ CONFIG_ATA_SFF=y
 CONFIG_PCI=y
 CONFIG_MMC=y
 CONFIG_MMC_SDHCI=y
-CONFIG_USB_SUPPORT=y
-CONFIG_USB=y
-CONFIG_USB_ARCH_HAS_EHCI=y
 CONFIG_R8169=y
 CONFIG_PATA_SCH=y
 CONFIG_MMC_SDHCI_PCI=y
-CONFIG_USB_EHCI_HCD=y
 CONFIG_PCIEPORTBUS=y
 CONFIG_NET=y
 CONFIG_USB_UHCI_HCD=y
diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
index 0ff6ac6..968c648 100644
--- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
+++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
@@ -16,3 +16,5 @@ include features/logbuf/size-normal.scc
 
 include features/latencytop/latencytop.scc
 include features/profiling/profiling.scc
+
+include features/usb/ehci-hcd/ehci-hcd.scc
-- 
1.7.0.4

[PATCH 5/5][KERNEL] meta: add mei feature

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Add an 'mei' feature that turns on the kernel options required to
support the Intel Management Engine Interface.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/features/amt/mei/mei.cfg |    3 +++
 meta/cfg/kernel-cache/features/amt/mei/mei.scc |    4 ++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
 create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc

diff --git a/meta/cfg/kernel-cache/features/amt/mei/mei.cfg b/meta/cfg/kernel-cache/features/amt/mei/mei.cfg
new file mode 100644
index 0000000..c1c2ace
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/amt/mei/mei.cfg
@@ -0,0 +1,3 @@
+CONFIG_STAGING=y
+CONFIG_WATCHDOG_CORE=y
+CONFIG_INTEL_MEI=y
diff --git a/meta/cfg/kernel-cache/features/amt/mei/mei.scc b/meta/cfg/kernel-cache/features/amt/mei/mei.scc
new file mode 100644
index 0000000..c506a04
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/amt/mei/mei.scc
@@ -0,0 +1,4 @@
+define KFEATURE_DESCRIPTION "Enable options for the Intel Management Engine Interface"
+define KFEATURE_COMPATIBILITY board
+
+kconf hardware mei.cfg
-- 
1.7.0.4

Re: [PATCH 0/5][KERNEL] add x/ehci-hcd and mei features

[Bruce Ashfield]

On 12-05-02 11:35 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi<tom.zanussi@intel.com>
>
> This adds a few new features, one for xhci-hcd and another for
> amt/mei, and refactors some existing config options into a new
> echi-hcd, which is then used in crownbay.
>
> If this looks like the way to go, I'll add similar USB features
> for ohci and uhci and fix up all the meta-intel BSPs to use
> them.

I had a look, and while at first I thought it was perhaps an over
splitting and categorization. It does make things very clear, and
gets us a split that can be used to keep configs minimal and reusable.

I also wasn't sure about directory splitting, since we do end up
with the names both in .scc/.cfg and the directory name. We could
flatten the directory down to just 'usb' and keep the names of the
files as the differentiator. And if we don't think we'll have to
carry any patches, we could put it under cfg/usb/<Tom's stuff>.

I don't have a really strong opinion (but gave my preference) on this
split (several directories vs single), and I'd bet that you considered 
the same thing. Comments ?

But definitely, this is the way to go, just a minor question about the
organization of the files.

Bruce


>
> Please pull into linux-yocto-3.2.
>
> Thanks,
>
> Tom
>
> The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
>    Yang Shi (1):
>          meta: Clean up BSPs kernel config
>
> are available in the git repository at:
>
>    git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
>    http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
>
> Tom Zanussi (5):
>    meta: add usb/host/base feature
>    meta: add usb/xhci-hcd feature
>    meta: add usb/ehci-hcd feature
>    meta/crownbay: use ehci-hcd feature
>    meta: add mei feature
>
>   meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    4 ----
>   meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    2 ++
>   meta/cfg/kernel-cache/features/amt/mei/mei.cfg     |    3 +++
>   meta/cfg/kernel-cache/features/amt/mei/mei.scc     |    4 ++++
>   .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
>   .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
>   meta/cfg/kernel-cache/features/usb/host/base.cfg   |    3 +++
>   meta/cfg/kernel-cache/features/usb/host/base.scc   |    4 ++++
>   .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
>   .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
>   10 files changed, 30 insertions(+), 4 deletions(-)
>   create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
>   create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
>   create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg
>   create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc
>   create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
>   create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc
>   create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg
>   create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc
>

Re: [PATCH 0/5][KERNEL] add x/ehci-hcd and mei features

[Tom Zanussi]

On Thu, 2012-05-03 at 08:40 -0400, Bruce Ashfield wrote:
> On 12-05-02 11:35 PM, tom.zanussi@intel.com wrote:
> > From: Tom Zanussi<tom.zanussi@intel.com>
> >
> > This adds a few new features, one for xhci-hcd and another for
> > amt/mei, and refactors some existing config options into a new
> > echi-hcd, which is then used in crownbay.
> >
> > If this looks like the way to go, I'll add similar USB features
> > for ohci and uhci and fix up all the meta-intel BSPs to use
> > them.
> 
> I had a look, and while at first I thought it was perhaps an over
> splitting and categorization. It does make things very clear, and
> gets us a split that can be used to keep configs minimal and reusable.
> 
> I also wasn't sure about directory splitting, since we do end up
> with the names both in .scc/.cfg and the directory name. We could
> flatten the directory down to just 'usb' and keep the names of the
> files as the differentiator. And if we don't think we'll have to
> carry any patches, we could put it under cfg/usb/<Tom's stuff>.
> 
> I don't have a really strong opinion (but gave my preference) on this
> split (several directories vs single), and I'd bet that you considered 
> the same thing. Comments ?
> 

The directory splitting is definitely a result of personal preference on
my part i.e. directories are cheap and I hate having bunches of files in
a single directory.  This is actually the reason I tend to
avoid /cfg. ;-)

In this case and most others, I find the directory splitting maps more
cleanly 'at-a-glance' for me to the split in functionality, but as I
said it's a personal preference and if most people prefer a more
flattened tree, then I don't have a problem making that change...

Tom


> But definitely, this is the way to go, just a minor question about the
> organization of the files.
> 
> Bruce
> 
> 
> >
> > Please pull into linux-yocto-3.2.
> >
> > Thanks,
> >
> > Tom
> >
> > The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
> >    Yang Shi (1):
> >          meta: Clean up BSPs kernel config
> >
> > are available in the git repository at:
> >
> >    git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
> >    http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
> >
> > Tom Zanussi (5):
> >    meta: add usb/host/base feature
> >    meta: add usb/xhci-hcd feature
> >    meta: add usb/ehci-hcd feature
> >    meta/crownbay: use ehci-hcd feature
> >    meta: add mei feature
> >
> >   meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    4 ----
> >   meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    2 ++
> >   meta/cfg/kernel-cache/features/amt/mei/mei.cfg     |    3 +++
> >   meta/cfg/kernel-cache/features/amt/mei/mei.scc     |    4 ++++
> >   .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
> >   .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
> >   meta/cfg/kernel-cache/features/usb/host/base.cfg   |    3 +++
> >   meta/cfg/kernel-cache/features/usb/host/base.scc   |    4 ++++
> >   .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
> >   .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
> >   10 files changed, 30 insertions(+), 4 deletions(-)
> >   create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
> >   create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
> >   create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg
> >   create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc
> >   create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
> >   create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc
> >   create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg
> >   create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc
> >
> 

Re: [PATCH 0/5][KERNEL] add x/ehci-hcd and mei features

[Bruce Ashfield]

On 12-05-03 09:50 AM, Tom Zanussi wrote:
> On Thu, 2012-05-03 at 08:40 -0400, Bruce Ashfield wrote:
>> On 12-05-02 11:35 PM, tom.zanussi@intel.com wrote:
>>> From: Tom Zanussi<tom.zanussi@intel.com>
>>>
>>> This adds a few new features, one for xhci-hcd and another for
>>> amt/mei, and refactors some existing config options into a new
>>> echi-hcd, which is then used in crownbay.
>>>
>>> If this looks like the way to go, I'll add similar USB features
>>> for ohci and uhci and fix up all the meta-intel BSPs to use
>>> them.
>>
>> I had a look, and while at first I thought it was perhaps an over
>> splitting and categorization. It does make things very clear, and
>> gets us a split that can be used to keep configs minimal and reusable.
>>
>> I also wasn't sure about directory splitting, since we do end up
>> with the names both in .scc/.cfg and the directory name. We could
>> flatten the directory down to just 'usb' and keep the names of the
>> files as the differentiator. And if we don't think we'll have to
>> carry any patches, we could put it under cfg/usb/<Tom's stuff>.
>>
>> I don't have a really strong opinion (but gave my preference) on this
>> split (several directories vs single), and I'd bet that you considered
>> the same thing. Comments ?
>>
>
> The directory splitting is definitely a result of personal preference on
> my part i.e. directories are cheap and I hate having bunches of files in
> a single directory.  This is actually the reason I tend to
> avoid /cfg. ;-)

Aha! A valid point :)

>
> In this case and most others, I find the directory splitting maps more
> cleanly 'at-a-glance' for me to the split in functionality, but as I
> said it's a personal preference and if most people prefer a more
> flattened tree, then I don't have a problem making that change...

Nope. I'd rather not have you re-do it for just that minor change, when
there's a valid reason on both sides.

I tossed the email .. and something has happened to my IMAP connection,
so I can't find them now. Can you resend just the pull request ? or
just the patches to me.

We can wait to see if Darren has a strong opinion one way or the other
as well.

Bruce

>
> Tom
>
>
>> But definitely, this is the way to go, just a minor question about the
>> organization of the files.
>>
>> Bruce
>>
>>
>>>
>>> Please pull into linux-yocto-3.2.
>>>
>>> Thanks,
>>>
>>> Tom
>>>
>>> The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
>>>     Yang Shi (1):
>>>           meta: Clean up BSPs kernel config
>>>
>>> are available in the git repository at:
>>>
>>>     git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
>>>     http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
>>>
>>> Tom Zanussi (5):
>>>     meta: add usb/host/base feature
>>>     meta: add usb/xhci-hcd feature
>>>     meta: add usb/ehci-hcd feature
>>>     meta/crownbay: use ehci-hcd feature
>>>     meta: add mei feature
>>>
>>>    meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    4 ----
>>>    meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    2 ++
>>>    meta/cfg/kernel-cache/features/amt/mei/mei.cfg     |    3 +++
>>>    meta/cfg/kernel-cache/features/amt/mei/mei.scc     |    4 ++++
>>>    .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
>>>    .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
>>>    meta/cfg/kernel-cache/features/usb/host/base.cfg   |    3 +++
>>>    meta/cfg/kernel-cache/features/usb/host/base.scc   |    4 ++++
>>>    .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
>>>    .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
>>>    10 files changed, 30 insertions(+), 4 deletions(-)
>>>    create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
>>>    create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg
>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc
>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc
>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg
>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc
>>>
>>
>
>

Re: [PATCH 0/5][KERNEL] add x/ehci-hcd and mei features

[Darren Hart]

On 05/03/2012 06:57 AM, Bruce Ashfield wrote:
> On 12-05-03 09:50 AM, Tom Zanussi wrote:
>> On Thu, 2012-05-03 at 08:40 -0400, Bruce Ashfield wrote:
>>> On 12-05-02 11:35 PM, tom.zanussi@intel.com wrote:
>>>> From: Tom Zanussi<tom.zanussi@intel.com>
>>>>
>>>> This adds a few new features, one for xhci-hcd and another for
>>>> amt/mei, and refactors some existing config options into a new
>>>> echi-hcd, which is then used in crownbay.
>>>>
>>>> If this looks like the way to go, I'll add similar USB features
>>>> for ohci and uhci and fix up all the meta-intel BSPs to use
>>>> them.
>>>
>>> I had a look, and while at first I thought it was perhaps an over
>>> splitting and categorization. It does make things very clear, and
>>> gets us a split that can be used to keep configs minimal and reusable.
>>>
>>> I also wasn't sure about directory splitting, since we do end up
>>> with the names both in .scc/.cfg and the directory name. We could
>>> flatten the directory down to just 'usb' and keep the names of the
>>> files as the differentiator. And if we don't think we'll have to
>>> carry any patches, we could put it under cfg/usb/<Tom's stuff>.
>>>
>>> I don't have a really strong opinion (but gave my preference) on this
>>> split (several directories vs single), and I'd bet that you considered
>>> the same thing. Comments ?
>>>
>>
>> The directory splitting is definitely a result of personal preference on
>> my part i.e. directories are cheap and I hate having bunches of files in
>> a single directory.  This is actually the reason I tend to
>> avoid /cfg. ;-)
> 
> Aha! A valid point :)
> 
>>
>> In this case and most others, I find the directory splitting maps more
>> cleanly 'at-a-glance' for me to the split in functionality, but as I
>> said it's a personal preference and if most people prefer a more
>> flattened tree, then I don't have a problem making that change...
> 
> Nope. I'd rather not have you re-do it for just that minor change, when
> there's a valid reason on both sides.
> 
> I tossed the email .. and something has happened to my IMAP connection,
> so I can't find them now. Can you resend just the pull request ? or
> just the patches to me.
> 
> We can wait to see if Darren has a strong opinion one way or the other
> as well.

Personally I prefer to keep directories minimal until such time as there
is a need for more. As it is we're only talking about a handful of files
which are still easily filtered. Still, this isn't a huge deal. I care
more about the granularity of the setup. I feel having the usb/base bit
adds unnecessarily to the file count.

Otherwise I'm content-ish.

--
Darren

> 
> Bruce
> 
>>
>> Tom
>>
>>
>>> But definitely, this is the way to go, just a minor question about the
>>> organization of the files.
>>>
>>> Bruce
>>>
>>>
>>>>
>>>> Please pull into linux-yocto-3.2.
>>>>
>>>> Thanks,
>>>>
>>>> Tom
>>>>
>>>> The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
>>>>     Yang Shi (1):
>>>>           meta: Clean up BSPs kernel config
>>>>
>>>> are available in the git repository at:
>>>>
>>>>     git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
>>>>     http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
>>>>
>>>> Tom Zanussi (5):
>>>>     meta: add usb/host/base feature
>>>>     meta: add usb/xhci-hcd feature
>>>>     meta: add usb/ehci-hcd feature
>>>>     meta/crownbay: use ehci-hcd feature
>>>>     meta: add mei feature
>>>>
>>>>    meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    4 ----
>>>>    meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    2 ++
>>>>    meta/cfg/kernel-cache/features/amt/mei/mei.cfg     |    3 +++
>>>>    meta/cfg/kernel-cache/features/amt/mei/mei.scc     |    4 ++++
>>>>    .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
>>>>    .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
>>>>    meta/cfg/kernel-cache/features/usb/host/base.cfg   |    3 +++
>>>>    meta/cfg/kernel-cache/features/usb/host/base.scc   |    4 ++++
>>>>    .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
>>>>    .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
>>>>    10 files changed, 30 insertions(+), 4 deletions(-)
>>>>    create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
>>>>    create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg
>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc
>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc
>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg
>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc
>>>>
>>>
>>
>>
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 0/5][KERNEL] add x/ehci-hcd and mei features

[Tom Zanussi]

On Fri, 2012-05-04 at 09:24 -0700, Darren Hart wrote:
> 
> On 05/03/2012 06:57 AM, Bruce Ashfield wrote:
> > On 12-05-03 09:50 AM, Tom Zanussi wrote:
> >> On Thu, 2012-05-03 at 08:40 -0400, Bruce Ashfield wrote:
> >>> On 12-05-02 11:35 PM, tom.zanussi@intel.com wrote:
> >>>> From: Tom Zanussi<tom.zanussi@intel.com>
> >>>>
> >>>> This adds a few new features, one for xhci-hcd and another for
> >>>> amt/mei, and refactors some existing config options into a new
> >>>> echi-hcd, which is then used in crownbay.
> >>>>
> >>>> If this looks like the way to go, I'll add similar USB features
> >>>> for ohci and uhci and fix up all the meta-intel BSPs to use
> >>>> them.
> >>>
> >>> I had a look, and while at first I thought it was perhaps an over
> >>> splitting and categorization. It does make things very clear, and
> >>> gets us a split that can be used to keep configs minimal and reusable.
> >>>
> >>> I also wasn't sure about directory splitting, since we do end up
> >>> with the names both in .scc/.cfg and the directory name. We could
> >>> flatten the directory down to just 'usb' and keep the names of the
> >>> files as the differentiator. And if we don't think we'll have to
> >>> carry any patches, we could put it under cfg/usb/<Tom's stuff>.
> >>>
> >>> I don't have a really strong opinion (but gave my preference) on this
> >>> split (several directories vs single), and I'd bet that you considered
> >>> the same thing. Comments ?
> >>>
> >>
> >> The directory splitting is definitely a result of personal preference on
> >> my part i.e. directories are cheap and I hate having bunches of files in
> >> a single directory.  This is actually the reason I tend to
> >> avoid /cfg. ;-)
> > 
> > Aha! A valid point :)
> > 
> >>
> >> In this case and most others, I find the directory splitting maps more
> >> cleanly 'at-a-glance' for me to the split in functionality, but as I
> >> said it's a personal preference and if most people prefer a more
> >> flattened tree, then I don't have a problem making that change...
> > 
> > Nope. I'd rather not have you re-do it for just that minor change, when
> > there's a valid reason on both sides.
> > 
> > I tossed the email .. and something has happened to my IMAP connection,
> > so I can't find them now. Can you resend just the pull request ? or
> > just the patches to me.
> > 
> > We can wait to see if Darren has a strong opinion one way or the other
> > as well.
> 
> Personally I prefer to keep directories minimal until such time as there
> is a need for more. As it is we're only talking about a handful of files
> which are still easily filtered. Still, this isn't a huge deal. I care
> more about the granularity of the setup. I feel having the usb/base bit
> adds unnecessarily to the file count.
> 

OK, sounds like people like flat directories.

Actually, the other option would be to just put the options into the
top-level feature like everything else.  Was trying to clean that
current situation up a bit, but maybe it's not really needed and I'll
just continue with that, will have to think on it....

Tom

> Otherwise I'm content-ish.
> 
> --
> Darren
> 
> > 
> > Bruce
> > 
> >>
> >> Tom
> >>
> >>
> >>> But definitely, this is the way to go, just a minor question about the
> >>> organization of the files.
> >>>
> >>> Bruce
> >>>
> >>>
> >>>>
> >>>> Please pull into linux-yocto-3.2.
> >>>>
> >>>> Thanks,
> >>>>
> >>>> Tom
> >>>>
> >>>> The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
> >>>>     Yang Shi (1):
> >>>>           meta: Clean up BSPs kernel config
> >>>>
> >>>> are available in the git repository at:
> >>>>
> >>>>     git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
> >>>>     http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
> >>>>
> >>>> Tom Zanussi (5):
> >>>>     meta: add usb/host/base feature
> >>>>     meta: add usb/xhci-hcd feature
> >>>>     meta: add usb/ehci-hcd feature
> >>>>     meta/crownbay: use ehci-hcd feature
> >>>>     meta: add mei feature
> >>>>
> >>>>    meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    4 ----
> >>>>    meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    2 ++
> >>>>    meta/cfg/kernel-cache/features/amt/mei/mei.cfg     |    3 +++
> >>>>    meta/cfg/kernel-cache/features/amt/mei/mei.scc     |    4 ++++
> >>>>    .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
> >>>>    .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
> >>>>    meta/cfg/kernel-cache/features/usb/host/base.cfg   |    3 +++
> >>>>    meta/cfg/kernel-cache/features/usb/host/base.scc   |    4 ++++
> >>>>    .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
> >>>>    .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
> >>>>    10 files changed, 30 insertions(+), 4 deletions(-)
> >>>>    create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
> >>>>    create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
> >>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg
> >>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc
> >>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
> >>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc
> >>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg
> >>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc
> >>>>
> >>>
> >>
> >>
> > 
> 

Re: [PATCH 0/5][KERNEL] add x/ehci-hcd and mei features

[Darren Hart]

On 05/04/2012 09:35 AM, Tom Zanussi wrote:
> On Fri, 2012-05-04 at 09:24 -0700, Darren Hart wrote:
>>
>> On 05/03/2012 06:57 AM, Bruce Ashfield wrote:
>>> On 12-05-03 09:50 AM, Tom Zanussi wrote:
>>>> On Thu, 2012-05-03 at 08:40 -0400, Bruce Ashfield wrote:
>>>>> On 12-05-02 11:35 PM, tom.zanussi@intel.com wrote:
>>>>>> From: Tom Zanussi<tom.zanussi@intel.com>
>>>>>>
>>>>>> This adds a few new features, one for xhci-hcd and another for
>>>>>> amt/mei, and refactors some existing config options into a new
>>>>>> echi-hcd, which is then used in crownbay.
>>>>>>
>>>>>> If this looks like the way to go, I'll add similar USB features
>>>>>> for ohci and uhci and fix up all the meta-intel BSPs to use
>>>>>> them.
>>>>>
>>>>> I had a look, and while at first I thought it was perhaps an over
>>>>> splitting and categorization. It does make things very clear, and
>>>>> gets us a split that can be used to keep configs minimal and reusable.
>>>>>
>>>>> I also wasn't sure about directory splitting, since we do end up
>>>>> with the names both in .scc/.cfg and the directory name. We could
>>>>> flatten the directory down to just 'usb' and keep the names of the
>>>>> files as the differentiator. And if we don't think we'll have to
>>>>> carry any patches, we could put it under cfg/usb/<Tom's stuff>.
>>>>>
>>>>> I don't have a really strong opinion (but gave my preference) on this
>>>>> split (several directories vs single), and I'd bet that you considered
>>>>> the same thing. Comments ?
>>>>>
>>>>
>>>> The directory splitting is definitely a result of personal preference on
>>>> my part i.e. directories are cheap and I hate having bunches of files in
>>>> a single directory.  This is actually the reason I tend to
>>>> avoid /cfg. ;-)
>>>
>>> Aha! A valid point :)
>>>
>>>>
>>>> In this case and most others, I find the directory splitting maps more
>>>> cleanly 'at-a-glance' for me to the split in functionality, but as I
>>>> said it's a personal preference and if most people prefer a more
>>>> flattened tree, then I don't have a problem making that change...
>>>
>>> Nope. I'd rather not have you re-do it for just that minor change, when
>>> there's a valid reason on both sides.
>>>
>>> I tossed the email .. and something has happened to my IMAP connection,
>>> so I can't find them now. Can you resend just the pull request ? or
>>> just the patches to me.
>>>
>>> We can wait to see if Darren has a strong opinion one way or the other
>>> as well.
>>
>> Personally I prefer to keep directories minimal until such time as there
>> is a need for more. As it is we're only talking about a handful of files
>> which are still easily filtered. Still, this isn't a huge deal. I care
>> more about the granularity of the setup. I feel having the usb/base bit
>> adds unnecessarily to the file count.
>>
> 
> OK, sounds like people like flat directories.
> 
> Actually, the other option would be to just put the options into the
> top-level feature like everything else.  Was trying to clean that
> current situation up a bit, but maybe it's not really needed and I'll
> just continue with that, will have to think on it....


I think at least a usb/ dir is worth while. My rule of thumb is that a
new dir needs at least 3 things (I'd group cfg and scc as 1 thing).
Again, highly subjective.

--
Darren

> 
> Tom
> 
>> Otherwise I'm content-ish.
>>
>> --
>> Darren
>>
>>>
>>> Bruce
>>>
>>>>
>>>> Tom
>>>>
>>>>
>>>>> But definitely, this is the way to go, just a minor question about the
>>>>> organization of the files.
>>>>>
>>>>> Bruce
>>>>>
>>>>>
>>>>>>
>>>>>> Please pull into linux-yocto-3.2.
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Tom
>>>>>>
>>>>>> The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
>>>>>>     Yang Shi (1):
>>>>>>           meta: Clean up BSPs kernel config
>>>>>>
>>>>>> are available in the git repository at:
>>>>>>
>>>>>>     git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
>>>>>>     http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
>>>>>>
>>>>>> Tom Zanussi (5):
>>>>>>     meta: add usb/host/base feature
>>>>>>     meta: add usb/xhci-hcd feature
>>>>>>     meta: add usb/ehci-hcd feature
>>>>>>     meta/crownbay: use ehci-hcd feature
>>>>>>     meta: add mei feature
>>>>>>
>>>>>>    meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    4 ----
>>>>>>    meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    2 ++
>>>>>>    meta/cfg/kernel-cache/features/amt/mei/mei.cfg     |    3 +++
>>>>>>    meta/cfg/kernel-cache/features/amt/mei/mei.scc     |    4 ++++
>>>>>>    .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
>>>>>>    .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
>>>>>>    meta/cfg/kernel-cache/features/usb/host/base.cfg   |    3 +++
>>>>>>    meta/cfg/kernel-cache/features/usb/host/base.scc   |    4 ++++
>>>>>>    .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
>>>>>>    .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
>>>>>>    10 files changed, 30 insertions(+), 4 deletions(-)
>>>>>>    create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
>>>>>>    create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
>>>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg
>>>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc
>>>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
>>>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc
>>>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg
>>>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 0/5][KERNEL] add x/ehci-hcd and mei features

[Tom Zanussi]

On Fri, 2012-05-04 at 09:39 -0700, Darren Hart wrote:
> 
> On 05/04/2012 09:35 AM, Tom Zanussi wrote:
> > On Fri, 2012-05-04 at 09:24 -0700, Darren Hart wrote:
> >>
> >> On 05/03/2012 06:57 AM, Bruce Ashfield wrote:
> >>> On 12-05-03 09:50 AM, Tom Zanussi wrote:
> >>>> On Thu, 2012-05-03 at 08:40 -0400, Bruce Ashfield wrote:
> >>>>> On 12-05-02 11:35 PM, tom.zanussi@intel.com wrote:
> >>>>>> From: Tom Zanussi<tom.zanussi@intel.com>
> >>>>>>
> >>>>>> This adds a few new features, one for xhci-hcd and another for
> >>>>>> amt/mei, and refactors some existing config options into a new
> >>>>>> echi-hcd, which is then used in crownbay.
> >>>>>>
> >>>>>> If this looks like the way to go, I'll add similar USB features
> >>>>>> for ohci and uhci and fix up all the meta-intel BSPs to use
> >>>>>> them.
> >>>>>
> >>>>> I had a look, and while at first I thought it was perhaps an over
> >>>>> splitting and categorization. It does make things very clear, and
> >>>>> gets us a split that can be used to keep configs minimal and reusable.
> >>>>>
> >>>>> I also wasn't sure about directory splitting, since we do end up
> >>>>> with the names both in .scc/.cfg and the directory name. We could
> >>>>> flatten the directory down to just 'usb' and keep the names of the
> >>>>> files as the differentiator. And if we don't think we'll have to
> >>>>> carry any patches, we could put it under cfg/usb/<Tom's stuff>.
> >>>>>
> >>>>> I don't have a really strong opinion (but gave my preference) on this
> >>>>> split (several directories vs single), and I'd bet that you considered
> >>>>> the same thing. Comments ?
> >>>>>
> >>>>
> >>>> The directory splitting is definitely a result of personal preference on
> >>>> my part i.e. directories are cheap and I hate having bunches of files in
> >>>> a single directory.  This is actually the reason I tend to
> >>>> avoid /cfg. ;-)
> >>>
> >>> Aha! A valid point :)
> >>>
> >>>>
> >>>> In this case and most others, I find the directory splitting maps more
> >>>> cleanly 'at-a-glance' for me to the split in functionality, but as I
> >>>> said it's a personal preference and if most people prefer a more
> >>>> flattened tree, then I don't have a problem making that change...
> >>>
> >>> Nope. I'd rather not have you re-do it for just that minor change, when
> >>> there's a valid reason on both sides.
> >>>
> >>> I tossed the email .. and something has happened to my IMAP connection,
> >>> so I can't find them now. Can you resend just the pull request ? or
> >>> just the patches to me.
> >>>
> >>> We can wait to see if Darren has a strong opinion one way or the other
> >>> as well.
> >>
> >> Personally I prefer to keep directories minimal until such time as there
> >> is a need for more. As it is we're only talking about a handful of files
> >> which are still easily filtered. Still, this isn't a huge deal. I care
> >> more about the granularity of the setup. I feel having the usb/base bit
> >> adds unnecessarily to the file count.
> >>
> > 
> > OK, sounds like people like flat directories.
> > 
> > Actually, the other option would be to just put the options into the
> > top-level feature like everything else.  Was trying to clean that
> > current situation up a bit, but maybe it's not really needed and I'll
> > just continue with that, will have to think on it....
> 
> 
> I think at least a usb/ dir is worth while. My rule of thumb is that a
> new dir needs at least 3 things (I'd group cfg and scc as 1 thing).
> Again, highly subjective.
> 

OK, this is what I'll go with, then, four features in /usb
(ehci/xhci/uhch/ohci, etc), with no 'base' feature (inline those options
in each individual feature).

So Bruce, don't bother pulling in the current patchset, I'll resubmit a
new patchset later.

Tom

> --
> Darren
> 
> > 
> > Tom
> > 
> >> Otherwise I'm content-ish.
> >>
> >> --
> >> Darren
> >>
> >>>
> >>> Bruce
> >>>
> >>>>
> >>>> Tom
> >>>>
> >>>>
> >>>>> But definitely, this is the way to go, just a minor question about the
> >>>>> organization of the files.
> >>>>>
> >>>>> Bruce
> >>>>>
> >>>>>
> >>>>>>
> >>>>>> Please pull into linux-yocto-3.2.
> >>>>>>
> >>>>>> Thanks,
> >>>>>>
> >>>>>> Tom
> >>>>>>
> >>>>>> The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
> >>>>>>     Yang Shi (1):
> >>>>>>           meta: Clean up BSPs kernel config
> >>>>>>
> >>>>>> are available in the git repository at:
> >>>>>>
> >>>>>>     git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
> >>>>>>     http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
> >>>>>>
> >>>>>> Tom Zanussi (5):
> >>>>>>     meta: add usb/host/base feature
> >>>>>>     meta: add usb/xhci-hcd feature
> >>>>>>     meta: add usb/ehci-hcd feature
> >>>>>>     meta/crownbay: use ehci-hcd feature
> >>>>>>     meta: add mei feature
> >>>>>>
> >>>>>>    meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    4 ----
> >>>>>>    meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    2 ++
> >>>>>>    meta/cfg/kernel-cache/features/amt/mei/mei.cfg     |    3 +++
> >>>>>>    meta/cfg/kernel-cache/features/amt/mei/mei.scc     |    4 ++++
> >>>>>>    .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
> >>>>>>    .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
> >>>>>>    meta/cfg/kernel-cache/features/usb/host/base.cfg   |    3 +++
> >>>>>>    meta/cfg/kernel-cache/features/usb/host/base.scc   |    4 ++++
> >>>>>>    .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
> >>>>>>    .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
> >>>>>>    10 files changed, 30 insertions(+), 4 deletions(-)
> >>>>>>    create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
> >>>>>>    create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
> >>>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg
> >>>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc
> >>>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
> >>>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc
> >>>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg
> >>>>>>    create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc
> >>>>>>
> >>>>>
> >>>>
> >>>>
> >>>
> >>
> > 
> > 
> 

Re: [PATCH 0/5][KERNEL] add x/ehci-hcd and mei features

[Bruce Ashfield]

On 12-05-04 12:43 PM, Tom Zanussi wrote:
> On Fri, 2012-05-04 at 09:39 -0700, Darren Hart wrote:
>>
>> On 05/04/2012 09:35 AM, Tom Zanussi wrote:
>>> On Fri, 2012-05-04 at 09:24 -0700, Darren Hart wrote:
>>>>
>>>> On 05/03/2012 06:57 AM, Bruce Ashfield wrote:
>>>>> On 12-05-03 09:50 AM, Tom Zanussi wrote:
>>>>>> On Thu, 2012-05-03 at 08:40 -0400, Bruce Ashfield wrote:
>>>>>>> On 12-05-02 11:35 PM, tom.zanussi@intel.com wrote:
>>>>>>>> From: Tom Zanussi<tom.zanussi@intel.com>
>>>>>>>>
>>>>>>>> This adds a few new features, one for xhci-hcd and another for
>>>>>>>> amt/mei, and refactors some existing config options into a new
>>>>>>>> echi-hcd, which is then used in crownbay.
>>>>>>>>
>>>>>>>> If this looks like the way to go, I'll add similar USB features
>>>>>>>> for ohci and uhci and fix up all the meta-intel BSPs to use
>>>>>>>> them.
>>>>>>>
>>>>>>> I had a look, and while at first I thought it was perhaps an over
>>>>>>> splitting and categorization. It does make things very clear, and
>>>>>>> gets us a split that can be used to keep configs minimal and reusable.
>>>>>>>
>>>>>>> I also wasn't sure about directory splitting, since we do end up
>>>>>>> with the names both in .scc/.cfg and the directory name. We could
>>>>>>> flatten the directory down to just 'usb' and keep the names of the
>>>>>>> files as the differentiator. And if we don't think we'll have to
>>>>>>> carry any patches, we could put it under cfg/usb/<Tom's stuff>.
>>>>>>>
>>>>>>> I don't have a really strong opinion (but gave my preference) on this
>>>>>>> split (several directories vs single), and I'd bet that you considered
>>>>>>> the same thing. Comments ?
>>>>>>>
>>>>>>
>>>>>> The directory splitting is definitely a result of personal preference on
>>>>>> my part i.e. directories are cheap and I hate having bunches of files in
>>>>>> a single directory.  This is actually the reason I tend to
>>>>>> avoid /cfg. ;-)
>>>>>
>>>>> Aha! A valid point :)
>>>>>
>>>>>>
>>>>>> In this case and most others, I find the directory splitting maps more
>>>>>> cleanly 'at-a-glance' for me to the split in functionality, but as I
>>>>>> said it's a personal preference and if most people prefer a more
>>>>>> flattened tree, then I don't have a problem making that change...
>>>>>
>>>>> Nope. I'd rather not have you re-do it for just that minor change, when
>>>>> there's a valid reason on both sides.
>>>>>
>>>>> I tossed the email .. and something has happened to my IMAP connection,
>>>>> so I can't find them now. Can you resend just the pull request ? or
>>>>> just the patches to me.
>>>>>
>>>>> We can wait to see if Darren has a strong opinion one way or the other
>>>>> as well.
>>>>
>>>> Personally I prefer to keep directories minimal until such time as there
>>>> is a need for more. As it is we're only talking about a handful of files
>>>> which are still easily filtered. Still, this isn't a huge deal. I care
>>>> more about the granularity of the setup. I feel having the usb/base bit
>>>> adds unnecessarily to the file count.
>>>>
>>>
>>> OK, sounds like people like flat directories.
>>>
>>> Actually, the other option would be to just put the options into the
>>> top-level feature like everything else.  Was trying to clean that
>>> current situation up a bit, but maybe it's not really needed and I'll
>>> just continue with that, will have to think on it....
>>
>>
>> I think at least a usb/ dir is worth while. My rule of thumb is that a
>> new dir needs at least 3 things (I'd group cfg and scc as 1 thing).
>> Again, highly subjective.
>>
>
> OK, this is what I'll go with, then, four features in /usb
> (ehci/xhci/uhch/ohci, etc), with no 'base' feature (inline those options
> in each individual feature).
>
> So Bruce, don't bother pulling in the current patchset, I'll resubmit a
> new patchset later.

ooops. I merged it on the plane, but haven't pushed it. I'll reset
it out of my branches here.

Bruce

>
> Tom
>
>> --
>> Darren
>>
>>>
>>> Tom
>>>
>>>> Otherwise I'm content-ish.
>>>>
>>>> --
>>>> Darren
>>>>
>>>>>
>>>>> Bruce
>>>>>
>>>>>>
>>>>>> Tom
>>>>>>
>>>>>>
>>>>>>> But definitely, this is the way to go, just a minor question about the
>>>>>>> organization of the files.
>>>>>>>
>>>>>>> Bruce
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>> Please pull into linux-yocto-3.2.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>>
>>>>>>>> Tom
>>>>>>>>
>>>>>>>> The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
>>>>>>>>      Yang Shi (1):
>>>>>>>>            meta: Clean up BSPs kernel config
>>>>>>>>
>>>>>>>> are available in the git repository at:
>>>>>>>>
>>>>>>>>      git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
>>>>>>>>      http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
>>>>>>>>
>>>>>>>> Tom Zanussi (5):
>>>>>>>>      meta: add usb/host/base feature
>>>>>>>>      meta: add usb/xhci-hcd feature
>>>>>>>>      meta: add usb/ehci-hcd feature
>>>>>>>>      meta/crownbay: use ehci-hcd feature
>>>>>>>>      meta: add mei feature
>>>>>>>>
>>>>>>>>     meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    4 ----
>>>>>>>>     meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    2 ++
>>>>>>>>     meta/cfg/kernel-cache/features/amt/mei/mei.cfg     |    3 +++
>>>>>>>>     meta/cfg/kernel-cache/features/amt/mei/mei.scc     |    4 ++++
>>>>>>>>     .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
>>>>>>>>     .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
>>>>>>>>     meta/cfg/kernel-cache/features/usb/host/base.cfg   |    3 +++
>>>>>>>>     meta/cfg/kernel-cache/features/usb/host/base.scc   |    4 ++++
>>>>>>>>     .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
>>>>>>>>     .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
>>>>>>>>     10 files changed, 30 insertions(+), 4 deletions(-)
>>>>>>>>     create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
>>>>>>>>     create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
>>>>>>>>     create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg
>>>>>>>>     create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc
>>>>>>>>     create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
>>>>>>>>     create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc
>>>>>>>>     create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg
>>>>>>>>     create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>>
>>
>
>