All of lore.kernel.org
 help / color / mirror / Atom feed
From: srinivas.kandagatla@st.com (srinivas kandagatla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: STi: add stid127 soc support
Date: Wed, 5 Feb 2014 11:48:24 +0000	[thread overview]
Message-ID: <52F22508.7080706@st.com> (raw)
In-Reply-To: <201401312115.33731.arnd@arndb.de>

Hi Arnd,
On 31/01/14 20:15, Arnd Bergmann wrote:
> On Friday 31 January 2014, srinivas kandagatla wrote:
> 
>>> Sorry if I missed the initial review, but can you explain
>>> why this is needed to start with?
>>
>> On ST SoCs the default value for L2 AUX_CTRL register is 0x0, so we  set
>> the way-size explicit here.
> 
> Unfortunately, we keep going back and forth on the L2 cache controller
> setup between "it should work automatically" and "we don't want to
> have configuration data in DT", where my personal opinion is that
> the first one is more important here.
> 
> Now, there are a couple of properties that are defined in
> Documentation/devicetree/bindings/arm/l2cc.txt to let some of the
> things get set up automatically already. Can you check which bits
> are missing there, if any? Are they better described as "configuration"
> or "hardware" settings?

Currently l2cc bindings has few optional properties like.

- arm,data-latency
- arm,tag-latency
- arm,dirty-latency
- arm,filter-ranges
- interrupts :
- cache-id-part:
- wt-override:

These does not include properties to set "way-size", "associativity",
"enabling prefetching", "Prefetch drop enable", "prefetch offset",
"Double linefill" and few more in prefect control register and
aux-control register.

This is not just a issue with STi SOCs, having a quick look, I can see
that few more SOCs have similar requirements to set these properties.

We could do two things to get l2 setup automatically on STi SOCS.

1> Either define these properties case-by-case basic, which might be
useful for other SOCs too.

2> Or Add new compatible string for STi SoCs so that they can
automatically setup these values in cache-l2x0.c

Am Ok with either approaches.


Thanks,
srini


> 
> 	Arnd
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: srinivas kandagatla <srinivas.kandagatla@st.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Russell King <linux@arm.linux.org.uk>,
	kernel@stlinux.com, Linus Walleij <linus.walleij@linaro.org>,
	Patrice CHOTARD <patrice.chotard@st.com>,
	linux-kernel@vger.kernel.org,
	Stuart Menefy <stuart.menefy@st.com>,
	Rob Herring <robh+dt@kernel.org>,
	Grant Likely <grant.likely@linaro.org>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	maxime.coquelin@st.com, alexandre.torgue@st.com
Subject: Re: [PATCH 1/4] ARM: STi: add stid127 soc support
Date: Wed, 5 Feb 2014 11:48:24 +0000	[thread overview]
Message-ID: <52F22508.7080706@st.com> (raw)
In-Reply-To: <201401312115.33731.arnd@arndb.de>

Hi Arnd,
On 31/01/14 20:15, Arnd Bergmann wrote:
> On Friday 31 January 2014, srinivas kandagatla wrote:
> 
>>> Sorry if I missed the initial review, but can you explain
>>> why this is needed to start with?
>>
>> On ST SoCs the default value for L2 AUX_CTRL register is 0x0, so we  set
>> the way-size explicit here.
> 
> Unfortunately, we keep going back and forth on the L2 cache controller
> setup between "it should work automatically" and "we don't want to
> have configuration data in DT", where my personal opinion is that
> the first one is more important here.
> 
> Now, there are a couple of properties that are defined in
> Documentation/devicetree/bindings/arm/l2cc.txt to let some of the
> things get set up automatically already. Can you check which bits
> are missing there, if any? Are they better described as "configuration"
> or "hardware" settings?

Currently l2cc bindings has few optional properties like.

- arm,data-latency
- arm,tag-latency
- arm,dirty-latency
- arm,filter-ranges
- interrupts :
- cache-id-part:
- wt-override:

These does not include properties to set "way-size", "associativity",
"enabling prefetching", "Prefetch drop enable", "prefetch offset",
"Double linefill" and few more in prefect control register and
aux-control register.

This is not just a issue with STi SOCs, having a quick look, I can see
that few more SOCs have similar requirements to set these properties.

We could do two things to get l2 setup automatically on STi SOCS.

1> Either define these properties case-by-case basic, which might be
useful for other SOCs too.

2> Or Add new compatible string for STi SoCs so that they can
automatically setup these values in cache-l2x0.c

Am Ok with either approaches.


Thanks,
srini


> 
> 	Arnd
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: srinivas kandagatla <srinivas.kandagatla@st.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>,
	Russell King <linux@arm.linux.org.uk>, <kernel@stlinux.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Patrice CHOTARD <patrice.chotard@st.com>,
	<linux-kernel@vger.kernel.org>,
	Stuart Menefy <stuart.menefy@st.com>,
	Rob Herring <robh+dt@kernel.org>,
	Grant Likely <grant.likely@linaro.org>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	<maxime.coquelin@st.com>, <alexandre.torgue@st.com>
Subject: Re: [PATCH 1/4] ARM: STi: add stid127 soc support
Date: Wed, 5 Feb 2014 11:48:24 +0000	[thread overview]
Message-ID: <52F22508.7080706@st.com> (raw)
In-Reply-To: <201401312115.33731.arnd@arndb.de>

Hi Arnd,
On 31/01/14 20:15, Arnd Bergmann wrote:
> On Friday 31 January 2014, srinivas kandagatla wrote:
> 
>>> Sorry if I missed the initial review, but can you explain
>>> why this is needed to start with?
>>
>> On ST SoCs the default value for L2 AUX_CTRL register is 0x0, so we  set
>> the way-size explicit here.
> 
> Unfortunately, we keep going back and forth on the L2 cache controller
> setup between "it should work automatically" and "we don't want to
> have configuration data in DT", where my personal opinion is that
> the first one is more important here.
> 
> Now, there are a couple of properties that are defined in
> Documentation/devicetree/bindings/arm/l2cc.txt to let some of the
> things get set up automatically already. Can you check which bits
> are missing there, if any? Are they better described as "configuration"
> or "hardware" settings?

Currently l2cc bindings has few optional properties like.

- arm,data-latency
- arm,tag-latency
- arm,dirty-latency
- arm,filter-ranges
- interrupts :
- cache-id-part:
- wt-override:

These does not include properties to set "way-size", "associativity",
"enabling prefetching", "Prefetch drop enable", "prefetch offset",
"Double linefill" and few more in prefect control register and
aux-control register.

This is not just a issue with STi SOCs, having a quick look, I can see
that few more SOCs have similar requirements to set these properties.

We could do two things to get l2 setup automatically on STi SOCS.

1> Either define these properties case-by-case basic, which might be
useful for other SOCs too.

2> Or Add new compatible string for STi SoCs so that they can
automatically setup these values in cache-l2x0.c

Am Ok with either approaches.


Thanks,
srini


> 
> 	Arnd
> 
> 


  parent reply	other threads:[~2014-02-05 11:48 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30 14:55 [PATCH 0/4] ARM:sti: Add STiD127 platform and board support Patrice CHOTARD
2014-01-30 14:55 ` Patrice CHOTARD
2014-01-30 14:55 ` Patrice CHOTARD
2014-01-30 14:55 ` [PATCH 1/4] ARM: STi: add stid127 soc support Patrice CHOTARD
2014-01-30 14:55   ` Patrice CHOTARD
2014-01-30 14:55   ` Patrice CHOTARD
2014-01-30 18:35   ` Arnd Bergmann
2014-01-30 18:35     ` Arnd Bergmann
2014-01-30 18:35     ` Arnd Bergmann
2014-01-30 18:39     ` Arnd Bergmann
2014-01-30 18:39       ` Arnd Bergmann
2014-01-30 18:39       ` Arnd Bergmann
2014-01-31 12:27       ` srinivas kandagatla
2014-01-31 12:27         ` srinivas kandagatla
2014-01-31 12:27         ` srinivas kandagatla
2014-01-31 20:15         ` Arnd Bergmann
2014-01-31 20:15           ` Arnd Bergmann
2014-01-31 20:15           ` Arnd Bergmann
2014-02-03  8:33           ` Alexandre Torgue
2014-02-03  8:33             ` Alexandre Torgue
2014-02-03  8:33             ` Alexandre Torgue
2014-02-05 11:48           ` srinivas kandagatla [this message]
2014-02-05 11:48             ` srinivas kandagatla
2014-02-05 11:48             ` srinivas kandagatla
2014-02-06 16:46             ` Arnd Bergmann
2014-02-06 16:46               ` Arnd Bergmann
2014-02-06 16:46               ` Arnd Bergmann
2014-02-07  8:08               ` srinivas kandagatla
2014-02-07  8:08                 ` srinivas kandagatla
2014-02-07  8:08                 ` srinivas kandagatla
2014-02-27 12:23   ` Maxime Coquelin
2014-02-27 12:23     ` Maxime Coquelin
2014-02-27 12:23     ` Maxime Coquelin
2014-02-27 12:27     ` Patrice Chotard
2014-02-27 12:27       ` Patrice Chotard
2014-02-27 12:27       ` Patrice Chotard
2014-01-30 14:55 ` [PATCH 2/4] pinctrl: st: add stid127 support Patrice CHOTARD
2014-01-30 14:55   ` Patrice CHOTARD
2014-01-30 14:55   ` Patrice CHOTARD
2014-01-31 12:30   ` srinivas kandagatla
2014-01-31 12:30     ` srinivas kandagatla
2014-01-31 12:30     ` srinivas kandagatla
2014-02-04 20:54   ` Linus Walleij
2014-02-04 20:54     ` Linus Walleij
2014-01-30 14:55 ` [PATCH 3/4] ARM: dts: Add support of STid127 Soc Patrice CHOTARD
2014-01-30 14:55   ` Patrice CHOTARD
2014-01-30 14:55   ` Patrice CHOTARD
2014-01-31 12:50   ` srinivas kandagatla
2014-01-31 12:50     ` srinivas kandagatla
2014-01-31 12:50     ` srinivas kandagatla
2014-02-05 10:27     ` Patrice Chotard
2014-02-05 10:27       ` Patrice Chotard
2014-02-05 10:27       ` Patrice Chotard
2014-01-30 14:55 ` [PATCH 4/4] ARM: dts: add B2112 board support Patrice CHOTARD
2014-01-30 14:55   ` Patrice CHOTARD
2014-01-31 12:51   ` srinivas kandagatla
2014-01-31 12:51     ` srinivas kandagatla
2014-01-31 12:51     ` srinivas kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F22508.7080706@st.com \
    --to=srinivas.kandagatla@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.