All of lore.kernel.org
 help / color / mirror / Atom feed
From: patrice.chotard@st.com (Patrice Chotard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: dts: Add support of STid127 Soc.
Date: Wed, 5 Feb 2014 11:27:54 +0100	[thread overview]
Message-ID: <52F2122A.9080603@st.com> (raw)
In-Reply-To: <52EB9C03.70009@st.com>

Hi Srinivas

Thanks for reviewing, a V2 serie will be pushed with all required fixes.

Patrice

On 01/31/2014 01:50 PM, srinivas kandagatla wrote:
> Hi Patrice,
>
> On 30/01/14 14:55, Patrice CHOTARD wrote:
>> From: Alexandre TORGUE <alexandre.torgue@st.com>
>>
>> The STid127 integrates all harware components to function as a cable modem
> s/harware/hardware/
>
> s/STid127/STiD127
>
> Please fix other instances too.
>
>> or, in combination with a back end device, as a Gateway set top boxe.
> s/boxe/box/
>> Supported devices:
>> 	-UART0
>> 	-UART2
>>
>> Signed-off-by: alexandre torgue <alexandre.torgue@st.com>
>> ---
>>   arch/arm/boot/dts/stid127-clock.dtsi   |   31 ++++
>>   arch/arm/boot/dts/stid127-pinctrl.dtsi |  245 ++++++++++++++++++++++++++++++++
>>   arch/arm/boot/dts/stid127.dtsi         |  130 +++++++++++++++++
>>   3 files changed, 406 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/stid127-clock.dtsi
>>   create mode 100644 arch/arm/boot/dts/stid127-pinctrl.dtsi
>>   create mode 100644 arch/arm/boot/dts/stid127.dtsi
>>
>> diff --git a/arch/arm/boot/dts/stid127-clock.dtsi b/arch/arm/boot/dts/stid127-clock.dtsi
>> new file mode 100644
>> index 0000000..c6cafa9
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/stid127-clock.dtsi
>> @@ -0,0 +1,31 @@
>> +/*
>> + * Copyright (C) 2013 STMicroelectronics (R&D) Limited
> 2014
>
>> + * Author(s): Giuseppe Cavallaro <peppe.cavallaro@st.com>
>> + *	      Alexandre Torgue <alexandre.torgue@st.com>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +/ {Acked-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>> +	clocks {
>> +		/*
>> +		 * ARM Peripheral clock for timers
>> +		 */
>> +		arm_periph_clk: arm_periph_clk {
>> +			#clock-cells = <0>;
>> +			compatible = "fixed-clock";
>> +			clock-frequency = <100000000>;
>> +		};
>> +		/*
>> +		 * Bootloader initialized system infrastructure clock for
>> +		 * serial devices.
>> +		 */
>> +		CLK_IC_LP_HD: clockgenA0 at 29 {
>> +			#clock-cells = <0>;
>> +			compatible = "fixed-clock";
>> +			clock-frequency = <100000000>;
>> +			clock-output-names = "CLK_IC_LP_HD";
>> +		};
>> +	};
>> +};
>> diff --git a/arch/arm/boot/dts/stid127-pinctrl.dtsi b/arch/arm/boot/dts/stid127-pinctrl.dtsi
>> new file mode 100644
>> index 0000000..3fa66f3
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/stid127-pinctrl.dtsi
>> @@ -0,0 +1,245 @@
>> +/*
>> + * Copyright (C) 2012 STMicroelectronics Limited.
> 2014
>
>> + * Author(s): Giuseppe Cavallaro <peppe.cavallaro@st.com>
>> + *	      Alexandre Torgue <alexandre.torgue@st.com>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * publishhed by the Free Software Foundation.
> s/publishhed/published/
>
>> + */
>> +#include "st-pincfg.h"
>> +/ {
>> +	aliases {
>> +		gpio0	= &PIO0;
>> +		gpio1	= &PIO1;
>> +		gpio2	= &PIO2;
>> +		gpio3	= &PIO3;
>> +		gpio4	= &PIO4;
>> +		gpio5	= &PIO5;
>> +		gpio6	= &PIO6;
>> +		gpio7	= &PIO7;
>> +		gpio8	= &PIO8;
>> +		gpio9	= &PIO9;
>> +		gpio10	= &PIO10;
>> +		gpio11	= &PIO11;
>> +		gpio12	= &PIO12;
>> +		gpio13	= &PIO13;
>> +		gpio14	= &PIO14;
>> +		gpio15	= &PIO15;
>> +		gpio16	= &PIO16;
>> +		gpio17	= &PIO17;
>> +		gpio18	= &PIO18;
>> +		gpio19	= &PIO19;
>> +		gpio20	= &PIO20;
>> +		gpio21	= &PIO21;
>> +		gpio22	= &PIO22;
>> +
>> +	};
>> +
>> +	soc {
>> +		pin-controller-pwest {
>> +			#address-cells	= <1>;
>> +			#size-cells	= <1>;
>> +			compatible	= "st,stid127-pwest-pinctrl";
>> +			st,syscfg	= <&syscfg_pwest>;
>> +			ranges		= <0 0xfebe0000 0x8000>;
> Can you add interrupt controller support to the pin controller.
>
> Patches are in : https://lkml.org/lkml/2014/1/16/342
> All these patches are due to be in v3.15.
>
>> +
>> +			PIO0: gpio at febe0000 {
>> +				gpio-controller;
>> +				#gpio-cells = <1>;
>> +				reg = <0 0x100>;
>> +				interrupts =  <0 149 0>;
>> +				st,bank-name  = "PIO0";
>> +			};
>> +						rx	= <&PIO3 0 ALT2	IN>;
>> +					};
>> +				};
>> +			};
>> +
>> +		};
> unnecessary empty line  here.
>
>> diff --git a/arch/arm/boot/dts/stid127.dtsi b/arch/arm/boot/dts/stid127.dtsi
>> new file mode 100644
>> index 0000000..a6f0b8fe
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/stid127.dtsi
>> @@ -0,0 +1,130 @@
>> +/*
>> + * Copyright (C) 2013 STMicroelectronics Limited.
> 2014
>> + * Author(s): Giuseppe Cavallaro <peppe.cavallaro@st.com>
>> + *	      Alexandre Torgue <alexandre.torgue@st.com>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * publishhed by the Free Software Foundation.
> s/publishhed/published/
>
>> + */
>> +#include "stid127-pinctrl.dtsi"
>> +#include "stid127-clock.dtsi"
>> +/ {
>> +	#address-cells = <1>;
>> +	#size-cells = <1>;
>> +
>> +	cpus {
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +
>> +		cpu at 0 {
>> +			device_type = "cpu";
>> +			compatible = "arm,cortex-a9";
>> +			reg = <0>;
>> +		};
>> +		cpu at 1 {
>> +			device_type = "cpu";
>> +			compatible = "arm,cortex-a9";
>> +			reg = <1>;
>> +		};
>> +	};
>> +
>> +	intc: interrupt-controller at fffe1000 {
>> +		compatible = "arm,cortex-a9-gic";
>> +		#interrupt-cells = <3>;
>> +		interrupt-controller;
>> +		reg = <0xfffe1000 0x1000>,
>> +		      <0xfffe0100 0x100>;
>> +	};
>> +
>> +	scu at fffe0000 {
>> +		compatible = "arm,cortex-a9-scu";
>> +		reg = <0xfffe0000 0x1000>;
>> +	};
>> +
>> +	timer at fffe0200 {
>> +			interrupt-parent = <&intc>;
>> +			compatible = "arm,cortex-a9-global-timer";
>> +			reg = <0xfffe0200 0x100>;
>> +			interrupts = <1 11 0x04>;
>> +			clocks = <&arm_periph_clk>;
> Fix the tab spacing here.
>
> Thanks,
> srini

WARNING: multiple messages have this Message-ID (diff)
From: Patrice Chotard <patrice.chotard-qxv4g6HH51o@public.gmane.org>
To: srinivas kandagatla
	<srinivas.kandagatla-qxv4g6HH51o@public.gmane.org>,
	Stuart Menefy <stuart.menefy-qxv4g6HH51o@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Linus Walleij
	<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Grant Likely
	<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: maxime.coquelin-qxv4g6HH51o@public.gmane.org,
	alexandre.torgue-qxv4g6HH51o@public.gmane.org,
	Giuseppe Cavallaro <peppe.cavallaro-qxv4g6HH51o@public.gmane.org>
Subject: Re: [PATCH 3/4] ARM: dts: Add support of STid127 Soc.
Date: Wed, 5 Feb 2014 11:27:54 +0100	[thread overview]
Message-ID: <52F2122A.9080603@st.com> (raw)
In-Reply-To: <52EB9C03.70009-qxv4g6HH51o@public.gmane.org>

Hi Srinivas

Thanks for reviewing, a V2 serie will be pushed with all required fixes.

Patrice

On 01/31/2014 01:50 PM, srinivas kandagatla wrote:
> Hi Patrice,
>
> On 30/01/14 14:55, Patrice CHOTARD wrote:
>> From: Alexandre TORGUE <alexandre.torgue-qxv4g6HH51o@public.gmane.org>
>>
>> The STid127 integrates all harware components to function as a cable modem
> s/harware/hardware/
>
> s/STid127/STiD127
>
> Please fix other instances too.
>
>> or, in combination with a back end device, as a Gateway set top boxe.
> s/boxe/box/
>> Supported devices:
>> 	-UART0
>> 	-UART2
>>
>> Signed-off-by: alexandre torgue <alexandre.torgue-qxv4g6HH51o@public.gmane.org>
>> ---
>>   arch/arm/boot/dts/stid127-clock.dtsi   |   31 ++++
>>   arch/arm/boot/dts/stid127-pinctrl.dtsi |  245 ++++++++++++++++++++++++++++++++
>>   arch/arm/boot/dts/stid127.dtsi         |  130 +++++++++++++++++
>>   3 files changed, 406 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/stid127-clock.dtsi
>>   create mode 100644 arch/arm/boot/dts/stid127-pinctrl.dtsi
>>   create mode 100644 arch/arm/boot/dts/stid127.dtsi
>>
>> diff --git a/arch/arm/boot/dts/stid127-clock.dtsi b/arch/arm/boot/dts/stid127-clock.dtsi
>> new file mode 100644
>> index 0000000..c6cafa9
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/stid127-clock.dtsi
>> @@ -0,0 +1,31 @@
>> +/*
>> + * Copyright (C) 2013 STMicroelectronics (R&D) Limited
> 2014
>
>> + * Author(s): Giuseppe Cavallaro <peppe.cavallaro-qxv4g6HH51o@public.gmane.org>
>> + *	      Alexandre Torgue <alexandre.torgue-qxv4g6HH51o@public.gmane.org>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +/ {Acked-by: Srinivas Kandagatla <srinivas.kandagatla-qxv4g6HH51o@public.gmane.org>
>> +	clocks {
>> +		/*
>> +		 * ARM Peripheral clock for timers
>> +		 */
>> +		arm_periph_clk: arm_periph_clk {
>> +			#clock-cells = <0>;
>> +			compatible = "fixed-clock";
>> +			clock-frequency = <100000000>;
>> +		};
>> +		/*
>> +		 * Bootloader initialized system infrastructure clock for
>> +		 * serial devices.
>> +		 */
>> +		CLK_IC_LP_HD: clockgenA0@29 {
>> +			#clock-cells = <0>;
>> +			compatible = "fixed-clock";
>> +			clock-frequency = <100000000>;
>> +			clock-output-names = "CLK_IC_LP_HD";
>> +		};
>> +	};
>> +};
>> diff --git a/arch/arm/boot/dts/stid127-pinctrl.dtsi b/arch/arm/boot/dts/stid127-pinctrl.dtsi
>> new file mode 100644
>> index 0000000..3fa66f3
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/stid127-pinctrl.dtsi
>> @@ -0,0 +1,245 @@
>> +/*
>> + * Copyright (C) 2012 STMicroelectronics Limited.
> 2014
>
>> + * Author(s): Giuseppe Cavallaro <peppe.cavallaro-qxv4g6HH51o@public.gmane.org>
>> + *	      Alexandre Torgue <alexandre.torgue-qxv4g6HH51o@public.gmane.org>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * publishhed by the Free Software Foundation.
> s/publishhed/published/
>
>> + */
>> +#include "st-pincfg.h"
>> +/ {
>> +	aliases {
>> +		gpio0	= &PIO0;
>> +		gpio1	= &PIO1;
>> +		gpio2	= &PIO2;
>> +		gpio3	= &PIO3;
>> +		gpio4	= &PIO4;
>> +		gpio5	= &PIO5;
>> +		gpio6	= &PIO6;
>> +		gpio7	= &PIO7;
>> +		gpio8	= &PIO8;
>> +		gpio9	= &PIO9;
>> +		gpio10	= &PIO10;
>> +		gpio11	= &PIO11;
>> +		gpio12	= &PIO12;
>> +		gpio13	= &PIO13;
>> +		gpio14	= &PIO14;
>> +		gpio15	= &PIO15;
>> +		gpio16	= &PIO16;
>> +		gpio17	= &PIO17;
>> +		gpio18	= &PIO18;
>> +		gpio19	= &PIO19;
>> +		gpio20	= &PIO20;
>> +		gpio21	= &PIO21;
>> +		gpio22	= &PIO22;
>> +
>> +	};
>> +
>> +	soc {
>> +		pin-controller-pwest {
>> +			#address-cells	= <1>;
>> +			#size-cells	= <1>;
>> +			compatible	= "st,stid127-pwest-pinctrl";
>> +			st,syscfg	= <&syscfg_pwest>;
>> +			ranges		= <0 0xfebe0000 0x8000>;
> Can you add interrupt controller support to the pin controller.
>
> Patches are in : https://lkml.org/lkml/2014/1/16/342
> All these patches are due to be in v3.15.
>
>> +
>> +			PIO0: gpio@febe0000 {
>> +				gpio-controller;
>> +				#gpio-cells = <1>;
>> +				reg = <0 0x100>;
>> +				interrupts =  <0 149 0>;
>> +				st,bank-name  = "PIO0";
>> +			};
>> +						rx	= <&PIO3 0 ALT2	IN>;
>> +					};
>> +				};
>> +			};
>> +
>> +		};
> unnecessary empty line  here.
>
>> diff --git a/arch/arm/boot/dts/stid127.dtsi b/arch/arm/boot/dts/stid127.dtsi
>> new file mode 100644
>> index 0000000..a6f0b8fe
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/stid127.dtsi
>> @@ -0,0 +1,130 @@
>> +/*
>> + * Copyright (C) 2013 STMicroelectronics Limited.
> 2014
>> + * Author(s): Giuseppe Cavallaro <peppe.cavallaro-qxv4g6HH51o@public.gmane.org>
>> + *	      Alexandre Torgue <alexandre.torgue-qxv4g6HH51o@public.gmane.org>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * publishhed by the Free Software Foundation.
> s/publishhed/published/
>
>> + */
>> +#include "stid127-pinctrl.dtsi"
>> +#include "stid127-clock.dtsi"
>> +/ {
>> +	#address-cells = <1>;
>> +	#size-cells = <1>;
>> +
>> +	cpus {
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +
>> +		cpu@0 {
>> +			device_type = "cpu";
>> +			compatible = "arm,cortex-a9";
>> +			reg = <0>;
>> +		};
>> +		cpu@1 {
>> +			device_type = "cpu";
>> +			compatible = "arm,cortex-a9";
>> +			reg = <1>;
>> +		};
>> +	};
>> +
>> +	intc: interrupt-controller@fffe1000 {
>> +		compatible = "arm,cortex-a9-gic";
>> +		#interrupt-cells = <3>;
>> +		interrupt-controller;
>> +		reg = <0xfffe1000 0x1000>,
>> +		      <0xfffe0100 0x100>;
>> +	};
>> +
>> +	scu@fffe0000 {
>> +		compatible = "arm,cortex-a9-scu";
>> +		reg = <0xfffe0000 0x1000>;
>> +	};
>> +
>> +	timer@fffe0200 {
>> +			interrupt-parent = <&intc>;
>> +			compatible = "arm,cortex-a9-global-timer";
>> +			reg = <0xfffe0200 0x100>;
>> +			interrupts = <1 11 0x04>;
>> +			clocks = <&arm_periph_clk>;
> Fix the tab spacing here.
>
> Thanks,
> srini

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Patrice Chotard <patrice.chotard@st.com>
To: srinivas kandagatla <srinivas.kandagatla@st.com>,
	Stuart Menefy <stuart.menefy@st.com>,
	Russell King <linux@arm.linux.org.uk>,
	<linux-arm-kernel@lists.infradead.org>, <kernel@stlinux.com>,
	<linux-kernel@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>
Cc: <maxime.coquelin@st.com>, <alexandre.torgue@st.com>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>
Subject: Re: [PATCH 3/4] ARM: dts: Add support of STid127 Soc.
Date: Wed, 5 Feb 2014 11:27:54 +0100	[thread overview]
Message-ID: <52F2122A.9080603@st.com> (raw)
In-Reply-To: <52EB9C03.70009@st.com>

Hi Srinivas

Thanks for reviewing, a V2 serie will be pushed with all required fixes.

Patrice

On 01/31/2014 01:50 PM, srinivas kandagatla wrote:
> Hi Patrice,
>
> On 30/01/14 14:55, Patrice CHOTARD wrote:
>> From: Alexandre TORGUE <alexandre.torgue@st.com>
>>
>> The STid127 integrates all harware components to function as a cable modem
> s/harware/hardware/
>
> s/STid127/STiD127
>
> Please fix other instances too.
>
>> or, in combination with a back end device, as a Gateway set top boxe.
> s/boxe/box/
>> Supported devices:
>> 	-UART0
>> 	-UART2
>>
>> Signed-off-by: alexandre torgue <alexandre.torgue@st.com>
>> ---
>>   arch/arm/boot/dts/stid127-clock.dtsi   |   31 ++++
>>   arch/arm/boot/dts/stid127-pinctrl.dtsi |  245 ++++++++++++++++++++++++++++++++
>>   arch/arm/boot/dts/stid127.dtsi         |  130 +++++++++++++++++
>>   3 files changed, 406 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/stid127-clock.dtsi
>>   create mode 100644 arch/arm/boot/dts/stid127-pinctrl.dtsi
>>   create mode 100644 arch/arm/boot/dts/stid127.dtsi
>>
>> diff --git a/arch/arm/boot/dts/stid127-clock.dtsi b/arch/arm/boot/dts/stid127-clock.dtsi
>> new file mode 100644
>> index 0000000..c6cafa9
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/stid127-clock.dtsi
>> @@ -0,0 +1,31 @@
>> +/*
>> + * Copyright (C) 2013 STMicroelectronics (R&D) Limited
> 2014
>
>> + * Author(s): Giuseppe Cavallaro <peppe.cavallaro@st.com>
>> + *	      Alexandre Torgue <alexandre.torgue@st.com>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +/ {Acked-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>> +	clocks {
>> +		/*
>> +		 * ARM Peripheral clock for timers
>> +		 */
>> +		arm_periph_clk: arm_periph_clk {
>> +			#clock-cells = <0>;
>> +			compatible = "fixed-clock";
>> +			clock-frequency = <100000000>;
>> +		};
>> +		/*
>> +		 * Bootloader initialized system infrastructure clock for
>> +		 * serial devices.
>> +		 */
>> +		CLK_IC_LP_HD: clockgenA0@29 {
>> +			#clock-cells = <0>;
>> +			compatible = "fixed-clock";
>> +			clock-frequency = <100000000>;
>> +			clock-output-names = "CLK_IC_LP_HD";
>> +		};
>> +	};
>> +};
>> diff --git a/arch/arm/boot/dts/stid127-pinctrl.dtsi b/arch/arm/boot/dts/stid127-pinctrl.dtsi
>> new file mode 100644
>> index 0000000..3fa66f3
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/stid127-pinctrl.dtsi
>> @@ -0,0 +1,245 @@
>> +/*
>> + * Copyright (C) 2012 STMicroelectronics Limited.
> 2014
>
>> + * Author(s): Giuseppe Cavallaro <peppe.cavallaro@st.com>
>> + *	      Alexandre Torgue <alexandre.torgue@st.com>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * publishhed by the Free Software Foundation.
> s/publishhed/published/
>
>> + */
>> +#include "st-pincfg.h"
>> +/ {
>> +	aliases {
>> +		gpio0	= &PIO0;
>> +		gpio1	= &PIO1;
>> +		gpio2	= &PIO2;
>> +		gpio3	= &PIO3;
>> +		gpio4	= &PIO4;
>> +		gpio5	= &PIO5;
>> +		gpio6	= &PIO6;
>> +		gpio7	= &PIO7;
>> +		gpio8	= &PIO8;
>> +		gpio9	= &PIO9;
>> +		gpio10	= &PIO10;
>> +		gpio11	= &PIO11;
>> +		gpio12	= &PIO12;
>> +		gpio13	= &PIO13;
>> +		gpio14	= &PIO14;
>> +		gpio15	= &PIO15;
>> +		gpio16	= &PIO16;
>> +		gpio17	= &PIO17;
>> +		gpio18	= &PIO18;
>> +		gpio19	= &PIO19;
>> +		gpio20	= &PIO20;
>> +		gpio21	= &PIO21;
>> +		gpio22	= &PIO22;
>> +
>> +	};
>> +
>> +	soc {
>> +		pin-controller-pwest {
>> +			#address-cells	= <1>;
>> +			#size-cells	= <1>;
>> +			compatible	= "st,stid127-pwest-pinctrl";
>> +			st,syscfg	= <&syscfg_pwest>;
>> +			ranges		= <0 0xfebe0000 0x8000>;
> Can you add interrupt controller support to the pin controller.
>
> Patches are in : https://lkml.org/lkml/2014/1/16/342
> All these patches are due to be in v3.15.
>
>> +
>> +			PIO0: gpio@febe0000 {
>> +				gpio-controller;
>> +				#gpio-cells = <1>;
>> +				reg = <0 0x100>;
>> +				interrupts =  <0 149 0>;
>> +				st,bank-name  = "PIO0";
>> +			};
>> +						rx	= <&PIO3 0 ALT2	IN>;
>> +					};
>> +				};
>> +			};
>> +
>> +		};
> unnecessary empty line  here.
>
>> diff --git a/arch/arm/boot/dts/stid127.dtsi b/arch/arm/boot/dts/stid127.dtsi
>> new file mode 100644
>> index 0000000..a6f0b8fe
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/stid127.dtsi
>> @@ -0,0 +1,130 @@
>> +/*
>> + * Copyright (C) 2013 STMicroelectronics Limited.
> 2014
>> + * Author(s): Giuseppe Cavallaro <peppe.cavallaro@st.com>
>> + *	      Alexandre Torgue <alexandre.torgue@st.com>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * publishhed by the Free Software Foundation.
> s/publishhed/published/
>
>> + */
>> +#include "stid127-pinctrl.dtsi"
>> +#include "stid127-clock.dtsi"
>> +/ {
>> +	#address-cells = <1>;
>> +	#size-cells = <1>;
>> +
>> +	cpus {
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +
>> +		cpu@0 {
>> +			device_type = "cpu";
>> +			compatible = "arm,cortex-a9";
>> +			reg = <0>;
>> +		};
>> +		cpu@1 {
>> +			device_type = "cpu";
>> +			compatible = "arm,cortex-a9";
>> +			reg = <1>;
>> +		};
>> +	};
>> +
>> +	intc: interrupt-controller@fffe1000 {
>> +		compatible = "arm,cortex-a9-gic";
>> +		#interrupt-cells = <3>;
>> +		interrupt-controller;
>> +		reg = <0xfffe1000 0x1000>,
>> +		      <0xfffe0100 0x100>;
>> +	};
>> +
>> +	scu@fffe0000 {
>> +		compatible = "arm,cortex-a9-scu";
>> +		reg = <0xfffe0000 0x1000>;
>> +	};
>> +
>> +	timer@fffe0200 {
>> +			interrupt-parent = <&intc>;
>> +			compatible = "arm,cortex-a9-global-timer";
>> +			reg = <0xfffe0200 0x100>;
>> +			interrupts = <1 11 0x04>;
>> +			clocks = <&arm_periph_clk>;
> Fix the tab spacing here.
>
> Thanks,
> srini


  reply	other threads:[~2014-02-05 10:27 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30 14:55 [PATCH 0/4] ARM:sti: Add STiD127 platform and board support Patrice CHOTARD
2014-01-30 14:55 ` Patrice CHOTARD
2014-01-30 14:55 ` Patrice CHOTARD
2014-01-30 14:55 ` [PATCH 1/4] ARM: STi: add stid127 soc support Patrice CHOTARD
2014-01-30 14:55   ` Patrice CHOTARD
2014-01-30 14:55   ` Patrice CHOTARD
2014-01-30 18:35   ` Arnd Bergmann
2014-01-30 18:35     ` Arnd Bergmann
2014-01-30 18:35     ` Arnd Bergmann
2014-01-30 18:39     ` Arnd Bergmann
2014-01-30 18:39       ` Arnd Bergmann
2014-01-30 18:39       ` Arnd Bergmann
2014-01-31 12:27       ` srinivas kandagatla
2014-01-31 12:27         ` srinivas kandagatla
2014-01-31 12:27         ` srinivas kandagatla
2014-01-31 20:15         ` Arnd Bergmann
2014-01-31 20:15           ` Arnd Bergmann
2014-01-31 20:15           ` Arnd Bergmann
2014-02-03  8:33           ` Alexandre Torgue
2014-02-03  8:33             ` Alexandre Torgue
2014-02-03  8:33             ` Alexandre Torgue
2014-02-05 11:48           ` srinivas kandagatla
2014-02-05 11:48             ` srinivas kandagatla
2014-02-05 11:48             ` srinivas kandagatla
2014-02-06 16:46             ` Arnd Bergmann
2014-02-06 16:46               ` Arnd Bergmann
2014-02-06 16:46               ` Arnd Bergmann
2014-02-07  8:08               ` srinivas kandagatla
2014-02-07  8:08                 ` srinivas kandagatla
2014-02-07  8:08                 ` srinivas kandagatla
2014-02-27 12:23   ` Maxime Coquelin
2014-02-27 12:23     ` Maxime Coquelin
2014-02-27 12:23     ` Maxime Coquelin
2014-02-27 12:27     ` Patrice Chotard
2014-02-27 12:27       ` Patrice Chotard
2014-02-27 12:27       ` Patrice Chotard
2014-01-30 14:55 ` [PATCH 2/4] pinctrl: st: add stid127 support Patrice CHOTARD
2014-01-30 14:55   ` Patrice CHOTARD
2014-01-30 14:55   ` Patrice CHOTARD
2014-01-31 12:30   ` srinivas kandagatla
2014-01-31 12:30     ` srinivas kandagatla
2014-01-31 12:30     ` srinivas kandagatla
2014-02-04 20:54   ` Linus Walleij
2014-02-04 20:54     ` Linus Walleij
2014-01-30 14:55 ` [PATCH 3/4] ARM: dts: Add support of STid127 Soc Patrice CHOTARD
2014-01-30 14:55   ` Patrice CHOTARD
2014-01-30 14:55   ` Patrice CHOTARD
2014-01-31 12:50   ` srinivas kandagatla
2014-01-31 12:50     ` srinivas kandagatla
2014-01-31 12:50     ` srinivas kandagatla
2014-02-05 10:27     ` Patrice Chotard [this message]
2014-02-05 10:27       ` Patrice Chotard
2014-02-05 10:27       ` Patrice Chotard
2014-01-30 14:55 ` [PATCH 4/4] ARM: dts: add B2112 board support Patrice CHOTARD
2014-01-30 14:55   ` Patrice CHOTARD
2014-01-31 12:51   ` srinivas kandagatla
2014-01-31 12:51     ` srinivas kandagatla
2014-01-31 12:51     ` srinivas kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F2122A.9080603@st.com \
    --to=patrice.chotard@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.