From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 12/12] imx: ventana: switch to SPL
Date: Wed, 7 May 2014 09:14:05 -0700 [thread overview]
Message-ID: <536A5BCD.9070406@freescale.com> (raw)
In-Reply-To: <CAJ+vNU10DmbZUSb_gm5KWCcdQewa=dSK15n6bV6y_-aW43G-Sw@mail.gmail.com>
On 05/06/2014 04:35 PM, Tim Harvey wrote:
> On Tue, May 6, 2014 at 12:11 PM, Jeroen Hofstee <dasuboot@myspectrum.nl> wrote:
>> Hello Tim,
>>
<snip>
>>
>> Since Crt0.S already created gd on the stack before calling
>> board_init_f, can't the assignment of gd not simply be removed?
>> Is there anything special about gdata?
>>
>> Regards,
>> Jeroen
>>
>>
>
> Jeroen,
>
> That does make sense, but what I find is that York's ocmmit
> dec1861be90c948ea9fb771927d3d26a994d2e20 requires that gd be blanked
> and its not. This causes bus_i2c_init to skip its initialization
> because p->base is not zero.
>
> York, does this make sense? Your patch creates a dependence on
> gd->srdata being blank which isn't the case with the SRAM when booting
> from the IMX6 boot rom.
>
GD should be cleared (zeroed). Then we don't have this problem. Whoever sets up
gd (board_int_f, cpu_init_f, or others) should make sure gd is cleared. Why
isn't it the case for IMX6 boot rom?
York
next prev parent reply other threads:[~2014-05-07 16:14 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 20:17 [U-Boot] [PATCH 00/12] MX6: SPL NAND support Tim Harvey
2014-04-28 20:17 ` [U-Boot] [PATCH 01/12] SPL: NAND: remove CONFIG_SYS_NAND_PAGE_SIZE Tim Harvey
2014-04-28 20:17 ` [U-Boot] [PATCH 02/12] SPL: NAND: add support for mxs nand Tim Harvey
2014-05-02 20:56 ` Scott Wood
2014-05-06 4:08 ` Tim Harvey
2014-04-28 20:17 ` [U-Boot] [PATCH 03/12] MX6: add common SPL configuration Tim Harvey
2014-04-29 4:14 ` Eric Nelson
2014-04-29 6:37 ` Igor Grinberg
2014-04-29 11:55 ` Tim Harvey
2014-05-05 9:05 ` Stefano Babic
2014-05-07 17:01 ` Nikita Kiryanov
2014-04-28 20:17 ` [U-Boot] [PATCH 04/12] spl: consolidate arch/arm/include/asm/arch-*/spl.h Tim Harvey
2014-04-30 5:39 ` Masahiro Yamada
2014-05-05 9:08 ` Stefano Babic
2014-04-28 20:17 ` [U-Boot] [PATCH 05/12] MX6: add boot device support for SPL Tim Harvey
2014-04-29 4:28 ` Eric Nelson
2014-05-05 9:14 ` Stefano Babic
2014-05-05 15:46 ` Tim Harvey
2014-05-05 18:30 ` Stefano Babic
2014-05-06 6:36 ` Tapani Utriainen
2014-05-06 7:55 ` Stefano Babic
2014-05-06 15:42 ` Tim Harvey
2014-04-28 20:17 ` [U-Boot] [PATCH 06/12] IMX: add comments and remove unused struct fields Tim Harvey
2014-05-05 10:28 ` Stefano Babic
2014-04-28 20:17 ` [U-Boot] [PATCH 07/12] MX6: add structs for mmdc and ddr iomux registers Tim Harvey
2014-04-29 14:20 ` Eric Nelson
2014-05-05 10:34 ` Stefano Babic
2014-05-05 15:52 ` Tim Harvey
2014-04-28 20:17 ` [U-Boot] [PATCH 08/12] MX6: add mmdc configuration for MX6Q/MX6DL Tim Harvey
2014-04-29 15:15 ` Eric Nelson
2014-04-29 18:19 ` Tim Harvey
2014-04-29 18:26 ` Eric Nelson
2014-04-29 18:35 ` Otavio Salvador
2014-04-28 20:17 ` [U-Boot] [PATCH 09/12] IMX: add additional function for pinmux using an array Tim Harvey
2014-04-29 15:22 ` Eric Nelson
2014-05-06 4:35 ` Tim Harvey
2014-05-07 16:59 ` Nikita Kiryanov
2014-05-08 4:11 ` Tim Harvey
2014-04-28 20:17 ` [U-Boot] [PATCH 10/12] imx: ventana: split read_eeprom into standalone file Tim Harvey
2014-04-28 20:17 ` [U-Boot] [PATCH 11/12] imx: ventana: auto-configure for IMX6Q vs IMX6DL Tim Harvey
2014-04-28 20:17 ` [U-Boot] [PATCH 12/12] imx: ventana: switch to SPL Tim Harvey
2014-05-06 18:18 ` Tim Harvey
2014-05-06 18:45 ` York Sun
2014-05-06 19:11 ` Jeroen Hofstee
2014-05-06 23:35 ` Tim Harvey
2014-05-07 16:14 ` York Sun [this message]
2014-05-07 18:43 ` Jeroen Hofstee
2014-05-07 20:27 ` Tim Harvey
2014-05-07 20:29 ` York Sun
2014-05-07 20:35 ` Tim Harvey
2014-05-07 20:36 ` York Sun
2014-05-07 9:29 ` Stefano Babic
2014-05-14 4:58 ` Tim Harvey
2014-05-14 5:03 ` Tim Harvey
2014-05-14 22:32 ` Tim Harvey
2014-05-15 9:20 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536A5BCD.9070406@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.